6 |
|
* Pat Fisher, Mike Judd. |
7 |
|
*/ |
8 |
|
|
9 |
< |
import junit.framework.*; |
9 |
> |
import static java.util.concurrent.TimeUnit.MILLISECONDS; |
10 |
> |
|
11 |
> |
import java.util.Arrays; |
12 |
> |
import java.util.Collection; |
13 |
> |
import java.util.HashSet; |
14 |
> |
import java.util.concurrent.CountDownLatch; |
15 |
|
import java.util.concurrent.atomic.AtomicBoolean; |
16 |
|
import java.util.concurrent.locks.Condition; |
17 |
|
import java.util.concurrent.locks.Lock; |
18 |
|
import java.util.concurrent.locks.ReentrantReadWriteLock; |
19 |
< |
import java.util.concurrent.CountDownLatch; |
20 |
< |
import static java.util.concurrent.TimeUnit.MILLISECONDS; |
21 |
< |
import java.util.*; |
19 |
> |
|
20 |
> |
import junit.framework.AssertionFailedError; |
21 |
> |
import junit.framework.Test; |
22 |
> |
import junit.framework.TestSuite; |
23 |
|
|
24 |
|
public class ReentrantReadWriteLockTest extends JSR166TestCase { |
25 |
|
public static void main(String[] args) { |
26 |
< |
junit.textui.TestRunner.run(suite()); |
26 |
> |
main(suite(), args); |
27 |
|
} |
28 |
|
public static Test suite() { |
29 |
|
return new TestSuite(ReentrantReadWriteLockTest.class); |
155 |
|
enum AwaitMethod { await, awaitTimed, awaitNanos, awaitUntil } |
156 |
|
|
157 |
|
/** |
158 |
< |
* Awaits condition using the specified AwaitMethod. |
158 |
> |
* Awaits condition "indefinitely" using the specified AwaitMethod. |
159 |
|
*/ |
160 |
|
void await(Condition c, AwaitMethod awaitMethod) |
161 |
|
throws InterruptedException { |
162 |
+ |
long timeoutMillis = 2 * LONG_DELAY_MS; |
163 |
|
switch (awaitMethod) { |
164 |
|
case await: |
165 |
|
c.await(); |
166 |
|
break; |
167 |
|
case awaitTimed: |
168 |
< |
assertTrue(c.await(2 * LONG_DELAY_MS, MILLISECONDS)); |
168 |
> |
assertTrue(c.await(timeoutMillis, MILLISECONDS)); |
169 |
|
break; |
170 |
|
case awaitNanos: |
171 |
< |
long nanosRemaining = c.awaitNanos(MILLISECONDS.toNanos(2 * LONG_DELAY_MS)); |
172 |
< |
assertTrue(nanosRemaining > 0); |
171 |
> |
long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis); |
172 |
> |
long nanosRemaining = c.awaitNanos(timeoutNanos); |
173 |
> |
assertTrue(nanosRemaining > timeoutNanos / 2); |
174 |
> |
assertTrue(nanosRemaining <= timeoutNanos); |
175 |
|
break; |
176 |
|
case awaitUntil: |
177 |
< |
java.util.Date d = new java.util.Date(); |
169 |
< |
assertTrue(c.awaitUntil(new java.util.Date(d.getTime() + 2 * LONG_DELAY_MS))); |
177 |
> |
assertTrue(c.awaitUntil(delayedDate(timeoutMillis))); |
178 |
|
break; |
179 |
+ |
default: |
180 |
+ |
throw new AssertionError(); |
181 |
|
} |
182 |
|
} |
183 |
|
|
231 |
|
public void testGetWriteHoldCount() { testGetWriteHoldCount(false); } |
232 |
|
public void testGetWriteHoldCount_fair() { testGetWriteHoldCount(true); } |
233 |
|
public void testGetWriteHoldCount(boolean fair) { |
234 |
< |
ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
234 |
> |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
235 |
|
for (int i = 1; i <= SIZE; i++) { |
236 |
|
lock.writeLock().lock(); |
237 |
|
assertEquals(i,lock.getWriteHoldCount()); |
238 |
|
} |
239 |
|
for (int i = SIZE; i > 0; i--) { |
240 |
|
lock.writeLock().unlock(); |
241 |
< |
assertEquals(i-1,lock.getWriteHoldCount()); |
241 |
> |
assertEquals(i - 1,lock.getWriteHoldCount()); |
242 |
|
} |
243 |
|
} |
244 |
|
|
248 |
|
public void testGetHoldCount() { testGetHoldCount(false); } |
249 |
|
public void testGetHoldCount_fair() { testGetHoldCount(true); } |
250 |
|
public void testGetHoldCount(boolean fair) { |
251 |
< |
ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
251 |
> |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
252 |
|
for (int i = 1; i <= SIZE; i++) { |
253 |
|
lock.writeLock().lock(); |
254 |
|
assertEquals(i,lock.writeLock().getHoldCount()); |
255 |
|
} |
256 |
|
for (int i = SIZE; i > 0; i--) { |
257 |
|
lock.writeLock().unlock(); |
258 |
< |
assertEquals(i-1,lock.writeLock().getHoldCount()); |
258 |
> |
assertEquals(i - 1,lock.writeLock().getHoldCount()); |
259 |
|
} |
260 |
|
} |
261 |
|
|
265 |
|
public void testGetReadHoldCount() { testGetReadHoldCount(false); } |
266 |
|
public void testGetReadHoldCount_fair() { testGetReadHoldCount(true); } |
267 |
|
public void testGetReadHoldCount(boolean fair) { |
268 |
< |
ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
268 |
> |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
269 |
|
for (int i = 1; i <= SIZE; i++) { |
270 |
|
lock.readLock().lock(); |
271 |
|
assertEquals(i,lock.getReadHoldCount()); |
272 |
|
} |
273 |
|
for (int i = SIZE; i > 0; i--) { |
274 |
|
lock.readLock().unlock(); |
275 |
< |
assertEquals(i-1,lock.getReadHoldCount()); |
275 |
> |
assertEquals(i - 1,lock.getReadHoldCount()); |
276 |
|
} |
277 |
|
} |
278 |
|
|
282 |
|
public void testWriteUnlock_IMSE() { testWriteUnlock_IMSE(false); } |
283 |
|
public void testWriteUnlock_IMSE_fair() { testWriteUnlock_IMSE(true); } |
284 |
|
public void testWriteUnlock_IMSE(boolean fair) { |
285 |
< |
ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
285 |
> |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
286 |
|
try { |
287 |
|
lock.writeLock().unlock(); |
288 |
|
shouldThrow(); |
295 |
|
public void testReadUnlock_IMSE() { testReadUnlock_IMSE(false); } |
296 |
|
public void testReadUnlock_IMSE_fair() { testReadUnlock_IMSE(true); } |
297 |
|
public void testReadUnlock_IMSE(boolean fair) { |
298 |
< |
ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
298 |
> |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
299 |
|
try { |
300 |
|
lock.readLock().unlock(); |
301 |
|
shouldThrow(); |
788 |
|
public void testWriteTryLock_Timeout(boolean fair) { |
789 |
|
final PublicReentrantReadWriteLock lock = |
790 |
|
new PublicReentrantReadWriteLock(fair); |
791 |
+ |
final long timeoutMillis = timeoutMillis(); |
792 |
|
lock.writeLock().lock(); |
793 |
|
Thread t = newStartedThread(new CheckedRunnable() { |
794 |
|
public void realRun() throws InterruptedException { |
795 |
|
long startTime = System.nanoTime(); |
785 |
– |
long timeoutMillis = 10; |
796 |
|
assertFalse(lock.writeLock().tryLock(timeoutMillis, MILLISECONDS)); |
797 |
|
assertTrue(millisElapsedSince(startTime) >= timeoutMillis); |
798 |
|
}}); |
812 |
|
Thread t = newStartedThread(new CheckedRunnable() { |
813 |
|
public void realRun() throws InterruptedException { |
814 |
|
long startTime = System.nanoTime(); |
815 |
< |
long timeoutMillis = 10; |
815 |
> |
long timeoutMillis = timeoutMillis(); |
816 |
|
assertFalse(lock.readLock().tryLock(timeoutMillis, MILLISECONDS)); |
817 |
|
assertTrue(millisElapsedSince(startTime) >= timeoutMillis); |
818 |
|
}}); |
832 |
|
new PublicReentrantReadWriteLock(fair); |
833 |
|
try { |
834 |
|
lock.writeLock().lockInterruptibly(); |
835 |
< |
} catch (InterruptedException ie) { |
826 |
< |
threadUnexpectedException(ie); |
827 |
< |
} |
835 |
> |
} catch (InterruptedException fail) { threadUnexpectedException(fail); } |
836 |
|
Thread t = newStartedThread(new CheckedInterruptedRunnable() { |
837 |
|
public void realRun() throws InterruptedException { |
838 |
|
lock.writeLock().lockInterruptibly(); |
857 |
|
lock.readLock().lockInterruptibly(); |
858 |
|
lock.readLock().unlock(); |
859 |
|
lock.writeLock().lockInterruptibly(); |
860 |
< |
} catch (InterruptedException ie) { |
853 |
< |
threadUnexpectedException(ie); |
854 |
< |
} |
860 |
> |
} catch (InterruptedException fail) { threadUnexpectedException(fail); } |
861 |
|
Thread t = newStartedThread(new CheckedInterruptedRunnable() { |
862 |
|
public void realRun() throws InterruptedException { |
863 |
|
lock.readLock().lockInterruptibly(); |
883 |
|
await(c, awaitMethod); |
884 |
|
shouldThrow(); |
885 |
|
} catch (IllegalMonitorStateException success) { |
886 |
< |
} catch (InterruptedException e) { threadUnexpectedException(e); } |
886 |
> |
} catch (InterruptedException fail) { |
887 |
> |
threadUnexpectedException(fail); |
888 |
> |
} |
889 |
|
assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS); |
890 |
|
} |
891 |
|
} |
924 |
|
public void testAwaitNanos_Timeout() { testAwaitNanos_Timeout(false); } |
925 |
|
public void testAwaitNanos_Timeout_fair() { testAwaitNanos_Timeout(true); } |
926 |
|
public void testAwaitNanos_Timeout(boolean fair) { |
927 |
+ |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
928 |
+ |
final Condition c = lock.writeLock().newCondition(); |
929 |
+ |
final long timeoutMillis = timeoutMillis(); |
930 |
+ |
lock.writeLock().lock(); |
931 |
+ |
final long startTime = System.nanoTime(); |
932 |
+ |
final long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis); |
933 |
|
try { |
920 |
– |
final ReentrantReadWriteLock lock = |
921 |
– |
new ReentrantReadWriteLock(fair); |
922 |
– |
final Condition c = lock.writeLock().newCondition(); |
923 |
– |
lock.writeLock().lock(); |
924 |
– |
long startTime = System.nanoTime(); |
925 |
– |
long timeoutMillis = 10; |
926 |
– |
long timeoutNanos = MILLISECONDS.toNanos(timeoutMillis); |
934 |
|
long nanosRemaining = c.awaitNanos(timeoutNanos); |
935 |
|
assertTrue(nanosRemaining <= 0); |
936 |
< |
assertTrue(millisElapsedSince(startTime) >= timeoutMillis); |
937 |
< |
lock.writeLock().unlock(); |
938 |
< |
} catch (InterruptedException e) { |
932 |
< |
threadUnexpectedException(e); |
933 |
< |
} |
936 |
> |
} catch (InterruptedException fail) { threadUnexpectedException(fail); } |
937 |
> |
assertTrue(millisElapsedSince(startTime) >= timeoutMillis); |
938 |
> |
lock.writeLock().unlock(); |
939 |
|
} |
940 |
|
|
941 |
|
/** |
944 |
|
public void testAwait_Timeout() { testAwait_Timeout(false); } |
945 |
|
public void testAwait_Timeout_fair() { testAwait_Timeout(true); } |
946 |
|
public void testAwait_Timeout(boolean fair) { |
947 |
+ |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
948 |
+ |
final Condition c = lock.writeLock().newCondition(); |
949 |
+ |
final long timeoutMillis = timeoutMillis(); |
950 |
+ |
lock.writeLock().lock(); |
951 |
+ |
final long startTime = System.nanoTime(); |
952 |
|
try { |
943 |
– |
final ReentrantReadWriteLock lock = |
944 |
– |
new ReentrantReadWriteLock(fair); |
945 |
– |
final Condition c = lock.writeLock().newCondition(); |
946 |
– |
lock.writeLock().lock(); |
947 |
– |
long startTime = System.nanoTime(); |
948 |
– |
long timeoutMillis = 10; |
953 |
|
assertFalse(c.await(timeoutMillis, MILLISECONDS)); |
954 |
< |
assertTrue(millisElapsedSince(startTime) >= timeoutMillis); |
955 |
< |
lock.writeLock().unlock(); |
956 |
< |
} catch (InterruptedException e) { |
953 |
< |
threadUnexpectedException(e); |
954 |
< |
} |
954 |
> |
} catch (InterruptedException fail) { threadUnexpectedException(fail); } |
955 |
> |
assertTrue(millisElapsedSince(startTime) >= timeoutMillis); |
956 |
> |
lock.writeLock().unlock(); |
957 |
|
} |
958 |
|
|
959 |
|
/** |
962 |
|
public void testAwaitUntil_Timeout() { testAwaitUntil_Timeout(false); } |
963 |
|
public void testAwaitUntil_Timeout_fair() { testAwaitUntil_Timeout(true); } |
964 |
|
public void testAwaitUntil_Timeout(boolean fair) { |
965 |
+ |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
966 |
+ |
final Condition c = lock.writeLock().newCondition(); |
967 |
+ |
lock.writeLock().lock(); |
968 |
+ |
// We shouldn't assume that nanoTime and currentTimeMillis |
969 |
+ |
// use the same time source, so don't use nanoTime here. |
970 |
+ |
final java.util.Date delayedDate = delayedDate(timeoutMillis()); |
971 |
|
try { |
972 |
< |
final ReentrantReadWriteLock lock = |
973 |
< |
new ReentrantReadWriteLock(fair); |
974 |
< |
final Condition c = lock.writeLock().newCondition(); |
975 |
< |
lock.writeLock().lock(); |
968 |
< |
long startTime = System.nanoTime(); |
969 |
< |
long timeoutMillis = 10; |
970 |
< |
java.util.Date d = new java.util.Date(); |
971 |
< |
assertFalse(c.awaitUntil(new java.util.Date(d.getTime() + timeoutMillis))); |
972 |
< |
assertTrue(millisElapsedSince(startTime) >= timeoutMillis); |
973 |
< |
lock.writeLock().unlock(); |
974 |
< |
} catch (InterruptedException e) { |
975 |
< |
threadUnexpectedException(e); |
976 |
< |
} |
972 |
> |
assertFalse(c.awaitUntil(delayedDate)); |
973 |
> |
} catch (InterruptedException fail) { threadUnexpectedException(fail); } |
974 |
> |
assertTrue(new java.util.Date().getTime() >= delayedDate.getTime()); |
975 |
> |
lock.writeLock().unlock(); |
976 |
|
} |
977 |
|
|
978 |
|
/** |
1228 |
|
public void testSerialization() { testSerialization(false); } |
1229 |
|
public void testSerialization_fair() { testSerialization(true); } |
1230 |
|
public void testSerialization(boolean fair) { |
1231 |
< |
ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
1231 |
> |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
1232 |
|
lock.writeLock().lock(); |
1233 |
|
lock.readLock().lock(); |
1234 |
|
|
1630 |
|
public void testToString() { testToString(false); } |
1631 |
|
public void testToString_fair() { testToString(true); } |
1632 |
|
public void testToString(boolean fair) { |
1633 |
< |
ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
1633 |
> |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
1634 |
|
assertTrue(lock.toString().contains("Write locks = 0")); |
1635 |
|
assertTrue(lock.toString().contains("Read locks = 0")); |
1636 |
|
lock.writeLock().lock(); |
1637 |
|
assertTrue(lock.toString().contains("Write locks = 1")); |
1638 |
|
assertTrue(lock.toString().contains("Read locks = 0")); |
1639 |
+ |
lock.writeLock().lock(); |
1640 |
+ |
assertTrue(lock.toString().contains("Write locks = 2")); |
1641 |
+ |
assertTrue(lock.toString().contains("Read locks = 0")); |
1642 |
+ |
lock.writeLock().unlock(); |
1643 |
|
lock.writeLock().unlock(); |
1644 |
|
lock.readLock().lock(); |
1645 |
+ |
assertTrue(lock.toString().contains("Write locks = 0")); |
1646 |
+ |
assertTrue(lock.toString().contains("Read locks = 1")); |
1647 |
|
lock.readLock().lock(); |
1648 |
|
assertTrue(lock.toString().contains("Write locks = 0")); |
1649 |
|
assertTrue(lock.toString().contains("Read locks = 2")); |
1655 |
|
public void testReadLockToString() { testReadLockToString(false); } |
1656 |
|
public void testReadLockToString_fair() { testReadLockToString(true); } |
1657 |
|
public void testReadLockToString(boolean fair) { |
1658 |
< |
ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
1658 |
> |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
1659 |
|
assertTrue(lock.readLock().toString().contains("Read locks = 0")); |
1660 |
|
lock.readLock().lock(); |
1661 |
+ |
assertTrue(lock.readLock().toString().contains("Read locks = 1")); |
1662 |
|
lock.readLock().lock(); |
1663 |
|
assertTrue(lock.readLock().toString().contains("Read locks = 2")); |
1664 |
+ |
lock.readLock().unlock(); |
1665 |
+ |
assertTrue(lock.readLock().toString().contains("Read locks = 1")); |
1666 |
+ |
lock.readLock().unlock(); |
1667 |
+ |
assertTrue(lock.readLock().toString().contains("Read locks = 0")); |
1668 |
|
} |
1669 |
|
|
1670 |
|
/** |
1673 |
|
public void testWriteLockToString() { testWriteLockToString(false); } |
1674 |
|
public void testWriteLockToString_fair() { testWriteLockToString(true); } |
1675 |
|
public void testWriteLockToString(boolean fair) { |
1676 |
< |
ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
1676 |
> |
final ReentrantReadWriteLock lock = new ReentrantReadWriteLock(fair); |
1677 |
|
assertTrue(lock.writeLock().toString().contains("Unlocked")); |
1678 |
|
lock.writeLock().lock(); |
1679 |
< |
assertTrue(lock.writeLock().toString().contains("Locked")); |
1679 |
> |
assertTrue(lock.writeLock().toString().contains("Locked by")); |
1680 |
|
lock.writeLock().unlock(); |
1681 |
|
assertTrue(lock.writeLock().toString().contains("Unlocked")); |
1682 |
|
} |