ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ScheduledExecutorSubclassTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ScheduledExecutorSubclassTest.java (file contents):
Revision 1.67 by jsr166, Mon May 29 19:15:02 2017 UTC vs.
Revision 1.73 by dl, Tue Jan 26 13:33:06 2021 UTC

# Line 9 | Line 9 | import static java.util.concurrent.TimeU
9   import static java.util.concurrent.TimeUnit.SECONDS;
10  
11   import java.util.ArrayList;
12 + import java.util.Collection;
13 + import java.util.Collections;
14   import java.util.HashSet;
15   import java.util.List;
16   import java.util.concurrent.BlockingQueue;
# Line 121 | Line 123 | public class ScheduledExecutorSubclassTe
123          final CustomExecutor p = new CustomExecutor(1);
124          try (PoolCleaner cleaner = cleaner(p, done)) {
125              final long startTime = System.nanoTime();
126 <            Callable task = new CheckedCallable<Boolean>() {
126 >            Callable<Boolean> task = new CheckedCallable<Boolean>() {
127                  public Boolean realCall() {
128                      done.countDown();
129                      assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
130                      return Boolean.TRUE;
131                  }};
132 <            Future f = p.schedule(task, timeoutMillis(), MILLISECONDS);
132 >            Future<Boolean> f = p.schedule(task, timeoutMillis(), MILLISECONDS);
133              assertSame(Boolean.TRUE, f.get());
134              assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
135          }
# Line 146 | Line 148 | public class ScheduledExecutorSubclassTe
148                      done.countDown();
149                      assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
150                  }};
151 <            Future f = p.schedule(task, timeoutMillis(), MILLISECONDS);
151 >            Future<?> f = p.schedule(task, timeoutMillis(), MILLISECONDS);
152              await(done);
153              assertNull(f.get(LONG_DELAY_MS, MILLISECONDS));
154              assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
# Line 166 | Line 168 | public class ScheduledExecutorSubclassTe
168                      done.countDown();
169                      assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
170                  }};
171 <            ScheduledFuture f =
171 >            ScheduledFuture<?> f =
172                  p.scheduleAtFixedRate(task, timeoutMillis(),
173                                        LONG_DELAY_MS, MILLISECONDS);
174              await(done);
# Line 188 | Line 190 | public class ScheduledExecutorSubclassTe
190                      done.countDown();
191                      assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
192                  }};
193 <            ScheduledFuture f =
193 >            ScheduledFuture<?> f =
194                  p.scheduleWithFixedDelay(task, timeoutMillis(),
195                                           LONG_DELAY_MS, MILLISECONDS);
196              await(done);
# Line 216 | Line 218 | public class ScheduledExecutorSubclassTe
218                  final CountDownLatch done = new CountDownLatch(cycles);
219                  final Runnable task = new CheckedRunnable() {
220                      public void realRun() { done.countDown(); }};
221 <                final ScheduledFuture periodicTask =
221 >                final ScheduledFuture<?> periodicTask =
222                      p.scheduleAtFixedRate(task, 0, delay, MILLISECONDS);
223                  final int totalDelayMillis = (cycles - 1) * delay;
224                  await(done, totalDelayMillis + LONG_DELAY_MS);
# Line 262 | Line 264 | public class ScheduledExecutorSubclassTe
264                          previous.set(now);
265                          done.countDown();
266                      }};
267 <                final ScheduledFuture periodicTask =
267 >                final ScheduledFuture<?> periodicTask =
268                      p.scheduleWithFixedDelay(task, 0, delay, MILLISECONDS);
269                  final int totalDelayMillis = (cycles - 1) * delay;
270                  await(done, totalDelayMillis + cycles * LONG_DELAY_MS);
# Line 278 | Line 280 | public class ScheduledExecutorSubclassTe
280      }
281  
282      /**
283 <     * execute(null) throws NPE
283 >     * Submitting null tasks throws NullPointerException
284       */
285 <    public void testExecuteNull() throws InterruptedException {
285 >    public void testNullTaskSubmission() {
286          final CustomExecutor p = new CustomExecutor(1);
287          try (PoolCleaner cleaner = cleaner(p)) {
288 <            try {
287 <                p.execute(null);
288 <                shouldThrow();
289 <            } catch (NullPointerException success) {}
288 >            assertNullTaskSubmissionThrowsNullPointerException(p);
289          }
290      }
291  
292      /**
293 <     * schedule(null) throws NPE
293 >     * Submitted tasks are rejected when shutdown
294       */
295 <    public void testScheduleNull() throws InterruptedException {
296 <        final CustomExecutor p = new CustomExecutor(1);
297 <        try (PoolCleaner cleaner = cleaner(p)) {
298 <            try {
299 <                Future f = p.schedule((Callable)null,
300 <                                      randomTimeout(), randomTimeUnit());
301 <                shouldThrow();
302 <            } catch (NullPointerException success) {}
303 <        }
304 <    }
295 >    public void testSubmittedTasksRejectedWhenShutdown() throws InterruptedException {
296 >        final CustomExecutor p = new CustomExecutor(2);
297 >        final ThreadLocalRandom rnd = ThreadLocalRandom.current();
298 >        final CountDownLatch threadsStarted = new CountDownLatch(p.getCorePoolSize());
299 >        final CountDownLatch done = new CountDownLatch(1);
300 >        final Runnable r = () -> {
301 >            threadsStarted.countDown();
302 >            for (;;) {
303 >                try {
304 >                    done.await();
305 >                    return;
306 >                } catch (InterruptedException shutdownNowDeliberatelyIgnored) {}
307 >            }};
308 >        final Callable<Boolean> c = () -> {
309 >            threadsStarted.countDown();
310 >            for (;;) {
311 >                try {
312 >                    done.await();
313 >                    return Boolean.TRUE;
314 >                } catch (InterruptedException shutdownNowDeliberatelyIgnored) {}
315 >            }};
316  
317 <    /**
318 <     * execute throws RejectedExecutionException if shutdown
319 <     */
320 <    public void testSchedule1_RejectedExecutionException() {
321 <        final CustomExecutor p = new CustomExecutor(1);
322 <        try (PoolCleaner cleaner = cleaner(p)) {
323 <            try {
324 <                p.shutdown();
325 <                p.schedule(new NoOpRunnable(),
316 <                           MEDIUM_DELAY_MS, MILLISECONDS);
317 <                shouldThrow();
318 <            } catch (RejectedExecutionException success) {
319 <            } catch (SecurityException ok) {}
320 <        }
321 <    }
317 >        try (PoolCleaner cleaner = cleaner(p, done)) {
318 >            for (int i = p.getCorePoolSize(); i--> 0; ) {
319 >                switch (rnd.nextInt(4)) {
320 >                case 0: p.execute(r); break;
321 >                case 1: assertFalse(p.submit(r).isDone()); break;
322 >                case 2: assertFalse(p.submit(r, Boolean.TRUE).isDone()); break;
323 >                case 3: assertFalse(p.submit(c).isDone()); break;
324 >                }
325 >            }
326  
327 <    /**
328 <     * schedule throws RejectedExecutionException if shutdown
325 <     */
326 <    public void testSchedule2_RejectedExecutionException() {
327 <        final CustomExecutor p = new CustomExecutor(1);
328 <        try (PoolCleaner cleaner = cleaner(p)) {
329 <            try {
330 <                p.shutdown();
331 <                p.schedule(new NoOpCallable(),
332 <                           MEDIUM_DELAY_MS, MILLISECONDS);
333 <                shouldThrow();
334 <            } catch (RejectedExecutionException success) {
335 <            } catch (SecurityException ok) {}
336 <        }
337 <    }
327 >            // ScheduledThreadPoolExecutor has an unbounded queue, so never saturated.
328 >            await(threadsStarted);
329  
330 <    /**
331 <     * schedule callable throws RejectedExecutionException if shutdown
332 <     */
342 <    public void testSchedule3_RejectedExecutionException() {
343 <        final CustomExecutor p = new CustomExecutor(1);
344 <        try (PoolCleaner cleaner = cleaner(p)) {
345 <            try {
330 >            if (rnd.nextBoolean())
331 >                p.shutdownNow();
332 >            else
333                  p.shutdown();
334 <                p.schedule(new NoOpCallable(),
335 <                           MEDIUM_DELAY_MS, MILLISECONDS);
336 <                shouldThrow();
350 <            } catch (RejectedExecutionException success) {
351 <            } catch (SecurityException ok) {}
352 <        }
353 <    }
334 >            // Pool is shutdown, but not yet terminated
335 >            assertTaskSubmissionsAreRejected(p);
336 >            assertFalse(p.isTerminated());
337  
338 <    /**
339 <     * scheduleAtFixedRate throws RejectedExecutionException if shutdown
357 <     */
358 <    public void testScheduleAtFixedRate1_RejectedExecutionException() {
359 <        final CustomExecutor p = new CustomExecutor(1);
360 <        try (PoolCleaner cleaner = cleaner(p)) {
361 <            try {
362 <                p.shutdown();
363 <                p.scheduleAtFixedRate(new NoOpRunnable(),
364 <                                      MEDIUM_DELAY_MS, MEDIUM_DELAY_MS, MILLISECONDS);
365 <                shouldThrow();
366 <            } catch (RejectedExecutionException success) {
367 <            } catch (SecurityException ok) {}
368 <        }
369 <    }
338 >            done.countDown();   // release blocking tasks
339 >            assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
340  
341 <    /**
372 <     * scheduleWithFixedDelay throws RejectedExecutionException if shutdown
373 <     */
374 <    public void testScheduleWithFixedDelay1_RejectedExecutionException() {
375 <        final CustomExecutor p = new CustomExecutor(1);
376 <        try (PoolCleaner cleaner = cleaner(p)) {
377 <            try {
378 <                p.shutdown();
379 <                p.scheduleWithFixedDelay(new NoOpRunnable(),
380 <                                         MEDIUM_DELAY_MS, MEDIUM_DELAY_MS, MILLISECONDS);
381 <                shouldThrow();
382 <            } catch (RejectedExecutionException success) {
383 <            } catch (SecurityException ok) {}
341 >            assertTaskSubmissionsAreRejected(p);
342          }
343 +        assertEquals(p.getCorePoolSize(), p.getCompletedTaskCount());
344      }
345  
346      /**
# Line 632 | Line 591 | public class ScheduledExecutorSubclassTe
591          final ScheduledThreadPoolExecutor p = new CustomExecutor(1);
592          try (PoolCleaner cleaner = cleaner(p, done)) {
593              final CountDownLatch threadStarted = new CountDownLatch(1);
594 <            ScheduledFuture[] tasks = new ScheduledFuture[5];
594 >            @SuppressWarnings("unchecked")
595 >            ScheduledFuture<?>[] tasks = (ScheduledFuture<?>[])new ScheduledFuture[5];
596              for (int i = 0; i < tasks.length; i++) {
597                  Runnable r = new CheckedRunnable() {
598                      public void realRun() throws InterruptedException {
# Line 655 | Line 615 | public class ScheduledExecutorSubclassTe
615          final CountDownLatch done = new CountDownLatch(1);
616          final ScheduledThreadPoolExecutor p = new CustomExecutor(1);
617          try (PoolCleaner cleaner = cleaner(p, done)) {
618 <            ScheduledFuture[] tasks = new ScheduledFuture[5];
618 >            @SuppressWarnings("unchecked")
619 >            ScheduledFuture<?>[] tasks = (ScheduledFuture<?>[])new ScheduledFuture[5];
620              final CountDownLatch threadStarted = new CountDownLatch(1);
621              for (int i = 0; i < tasks.length; i++) {
622                  Runnable r = new CheckedRunnable() {
# Line 683 | Line 644 | public class ScheduledExecutorSubclassTe
644       * purge removes cancelled tasks from the queue
645       */
646      public void testPurge() throws InterruptedException {
647 <        final ScheduledFuture[] tasks = new ScheduledFuture[5];
647 >        @SuppressWarnings("unchecked")
648 >        ScheduledFuture<?>[] tasks = (ScheduledFuture<?>[])new ScheduledFuture[5];
649          final Runnable releaser = new Runnable() { public void run() {
650 <            for (ScheduledFuture task : tasks)
650 >            for (ScheduledFuture<?> task : tasks)
651                  if (task != null) task.cancel(true); }};
652          final CustomExecutor p = new CustomExecutor(1);
653          try (PoolCleaner cleaner = cleaner(p, releaser)) {
654              for (int i = 0; i < tasks.length; i++)
655 <                tasks[i] = p.schedule(new SmallPossiblyInterruptedRunnable(),
655 >                tasks[i] = p.schedule(possiblyInterruptedRunnable(SMALL_DELAY_MS),
656                                        LONG_DELAY_MS, MILLISECONDS);
657              int max = tasks.length;
658              if (tasks[4].cancel(true)) --max;
# Line 721 | Line 683 | public class ScheduledExecutorSubclassTe
683          Runnable waiter = new CheckedRunnable() { public void realRun() {
684              threadsStarted.countDown();
685              try {
686 <                MILLISECONDS.sleep(2 * LONG_DELAY_MS);
686 >                MILLISECONDS.sleep(LONGER_DELAY_MS);
687              } catch (InterruptedException success) {}
688              ran.getAndIncrement();
689          }};
# Line 751 | Line 713 | public class ScheduledExecutorSubclassTe
713       */
714      public void testShutdownNow_delayedTasks() throws InterruptedException {
715          final CustomExecutor p = new CustomExecutor(1);
716 <        List<ScheduledFuture> tasks = new ArrayList<>();
716 >        List<ScheduledFuture<?>> tasks = new ArrayList<>();
717          for (int i = 0; i < 3; i++) {
718              Runnable r = new NoOpRunnable();
719              tasks.add(p.schedule(r, 9, SECONDS));
# Line 759 | Line 721 | public class ScheduledExecutorSubclassTe
721              tasks.add(p.scheduleWithFixedDelay(r, 9, 9, SECONDS));
722          }
723          if (testImplementationDetails)
724 <            assertEquals(new HashSet(tasks), new HashSet(p.getQueue()));
724 >            assertEquals(new HashSet<Object>(tasks), new HashSet<Object>(p.getQueue()));
725          final List<Runnable> queuedTasks;
726          try {
727              queuedTasks = p.shutdownNow();
# Line 769 | Line 731 | public class ScheduledExecutorSubclassTe
731          assertTrue(p.isShutdown());
732          assertTrue(p.getQueue().isEmpty());
733          if (testImplementationDetails)
734 <            assertEquals(new HashSet(tasks), new HashSet(queuedTasks));
734 >            assertEquals(new HashSet<Object>(tasks), new HashSet<Object>(queuedTasks));
735          assertEquals(tasks.size(), queuedTasks.size());
736 <        for (ScheduledFuture task : tasks) {
736 >        for (ScheduledFuture<?> task : tasks) {
737              assertFalse(((CustomTask)task).ran);
738              assertFalse(task.isDone());
739              assertFalse(task.isCancelled());
# Line 787 | Line 749 | public class ScheduledExecutorSubclassTe
749       * - setExecuteExistingDelayedTasksAfterShutdownPolicy
750       * - setContinueExistingPeriodicTasksAfterShutdownPolicy
751       */
752 +    @SuppressWarnings("FutureReturnValueIgnored")
753      public void testShutdown_cancellation() throws Exception {
754          final int poolSize = 4;
755          final CustomExecutor p = new CustomExecutor(poolSize);
# Line 885 | Line 848 | public class ScheduledExecutorSubclassTe
848          immediates.forEach(
849              f -> assertTrue(((ScheduledFuture)f).getDelay(NANOSECONDS) <= 0L));
850  
851 <        Stream.of(immediates, delayeds, periodics).flatMap(c -> c.stream())
851 >        Stream.of(immediates, delayeds, periodics).flatMap(Collection::stream)
852              .forEach(f -> assertFalse(f.isDone()));
853  
854          try { p.shutdown(); } catch (SecurityException ok) { return; }
# Line 939 | Line 902 | public class ScheduledExecutorSubclassTe
902  
903          assertTrue(q.isEmpty());
904  
905 <        Stream.of(immediates, delayeds, periodics).flatMap(c -> c.stream())
905 >        Stream.of(immediates, delayeds, periodics).flatMap(Collection::stream)
906              .forEach(f -> assertTrue(f.isDone()));
907  
908          for (Future<?> f : immediates) assertNull(f.get());
# Line 1018 | Line 981 | public class ScheduledExecutorSubclassTe
981      }
982  
983      /**
984 <     * invokeAny(empty collection) throws IAE
984 >     * invokeAny(empty collection) throws IllegalArgumentException
985       */
986      public void testInvokeAny2() throws Exception {
987          final ExecutorService e = new CustomExecutor(2);
# Line 1093 | Line 1056 | public class ScheduledExecutorSubclassTe
1056      }
1057  
1058      /**
1059 <     * invokeAll(empty collection) returns empty collection
1059 >     * invokeAll(empty collection) returns empty list
1060       */
1061      public void testInvokeAll2() throws Exception {
1062          final ExecutorService e = new CustomExecutor(2);
1063 +        final Collection<Callable<String>> emptyCollection
1064 +            = Collections.emptyList();
1065          try (PoolCleaner cleaner = cleaner(e)) {
1066 <            List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>());
1066 >            List<Future<String>> r = e.invokeAll(emptyCollection);
1067              assertTrue(r.isEmpty());
1068          }
1069      }
# Line 1161 | Line 1126 | public class ScheduledExecutorSubclassTe
1126          final ExecutorService e = new CustomExecutor(2);
1127          try (PoolCleaner cleaner = cleaner(e)) {
1128              try {
1129 <                e.invokeAny(null, MEDIUM_DELAY_MS, MILLISECONDS);
1129 >                e.invokeAny(null, randomTimeout(), randomTimeUnit());
1130                  shouldThrow();
1131              } catch (NullPointerException success) {}
1132          }
# Line 1176 | Line 1141 | public class ScheduledExecutorSubclassTe
1141              List<Callable<String>> l = new ArrayList<>();
1142              l.add(new StringTask());
1143              try {
1144 <                e.invokeAny(l, MEDIUM_DELAY_MS, null);
1144 >                e.invokeAny(l, randomTimeout(), null);
1145                  shouldThrow();
1146              } catch (NullPointerException success) {}
1147          }
1148      }
1149  
1150      /**
1151 <     * timed invokeAny(empty collection) throws IAE
1151 >     * timed invokeAny(empty collection) throws IllegalArgumentException
1152       */
1153      public void testTimedInvokeAny2() throws Exception {
1154          final ExecutorService e = new CustomExecutor(2);
1155 +        final Collection<Callable<String>> emptyCollection
1156 +            = Collections.emptyList();
1157          try (PoolCleaner cleaner = cleaner(e)) {
1158              try {
1159 <                e.invokeAny(new ArrayList<Callable<String>>(), MEDIUM_DELAY_MS, MILLISECONDS);
1159 >                e.invokeAny(emptyCollection, randomTimeout(), randomTimeUnit());
1160                  shouldThrow();
1161              } catch (IllegalArgumentException success) {}
1162          }
# Line 1206 | Line 1173 | public class ScheduledExecutorSubclassTe
1173              l.add(latchAwaitingStringTask(latch));
1174              l.add(null);
1175              try {
1176 <                e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1176 >                e.invokeAny(l, randomTimeout(), randomTimeUnit());
1177                  shouldThrow();
1178              } catch (NullPointerException success) {}
1179              latch.countDown();
# Line 1249 | Line 1216 | public class ScheduledExecutorSubclassTe
1216      }
1217  
1218      /**
1219 <     * timed invokeAll(null) throws NPE
1219 >     * timed invokeAll(null) throws NullPointerException
1220       */
1221      public void testTimedInvokeAll1() throws Exception {
1222          final ExecutorService e = new CustomExecutor(2);
1223          try (PoolCleaner cleaner = cleaner(e)) {
1224              try {
1225 <                e.invokeAll(null, MEDIUM_DELAY_MS, MILLISECONDS);
1225 >                e.invokeAll(null, randomTimeout(), randomTimeUnit());
1226                  shouldThrow();
1227              } catch (NullPointerException success) {}
1228          }
1229      }
1230  
1231      /**
1232 <     * timed invokeAll(,,null) throws NPE
1232 >     * timed invokeAll(,,null) throws NullPointerException
1233       */
1234      public void testTimedInvokeAllNullTimeUnit() throws Exception {
1235          final ExecutorService e = new CustomExecutor(2);
# Line 1270 | Line 1237 | public class ScheduledExecutorSubclassTe
1237              List<Callable<String>> l = new ArrayList<>();
1238              l.add(new StringTask());
1239              try {
1240 <                e.invokeAll(l, MEDIUM_DELAY_MS, null);
1240 >                e.invokeAll(l, randomTimeout(), null);
1241                  shouldThrow();
1242              } catch (NullPointerException success) {}
1243          }
1244      }
1245  
1246      /**
1247 <     * timed invokeAll(empty collection) returns empty collection
1247 >     * timed invokeAll(empty collection) returns empty list
1248       */
1249      public void testTimedInvokeAll2() throws Exception {
1250          final ExecutorService e = new CustomExecutor(2);
1251 +        final Collection<Callable<String>> emptyCollection
1252 +            = Collections.emptyList();
1253          try (PoolCleaner cleaner = cleaner(e)) {
1254 <            List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>(), MEDIUM_DELAY_MS, MILLISECONDS);
1254 >            List<Future<String>> r =
1255 >                e.invokeAll(emptyCollection, randomTimeout(), randomTimeUnit());
1256              assertTrue(r.isEmpty());
1257          }
1258      }
# Line 1297 | Line 1267 | public class ScheduledExecutorSubclassTe
1267              l.add(new StringTask());
1268              l.add(null);
1269              try {
1270 <                e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1270 >                e.invokeAll(l, randomTimeout(), randomTimeUnit());
1271                  shouldThrow();
1272              } catch (NullPointerException success) {}
1273          }
# Line 1308 | Line 1278 | public class ScheduledExecutorSubclassTe
1278       */
1279      public void testTimedInvokeAll4() throws Exception {
1280          final ExecutorService e = new CustomExecutor(2);
1281 +        final Collection<Callable<String>> c = new ArrayList<>();
1282 +        c.add(new NPETask());
1283          try (PoolCleaner cleaner = cleaner(e)) {
1312            List<Callable<String>> l = new ArrayList<>();
1313            l.add(new NPETask());
1284              List<Future<String>> futures =
1285 <                e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1285 >                e.invokeAll(c, LONG_DELAY_MS, MILLISECONDS);
1286              assertEquals(1, futures.size());
1287              try {
1288                  futures.get(0).get();
# Line 1362 | Line 1332 | public class ScheduledExecutorSubclassTe
1332                      p.invokeAll(tasks, timeout, MILLISECONDS);
1333                  assertEquals(tasks.size(), futures.size());
1334                  assertTrue(millisElapsedSince(startTime) >= timeout);
1335 <                for (Future future : futures)
1335 >                for (Future<?> future : futures)
1336                      assertTrue(future.isDone());
1337                  assertTrue(futures.get(1).isCancelled());
1338                  try {

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines