ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/SemaphoreTest.java
(Generate patch)

Comparing jsr166/src/test/tck/SemaphoreTest.java (file contents):
Revision 1.17 by jsr166, Mon Nov 16 05:30:08 2009 UTC vs.
Revision 1.39 by jsr166, Sun May 14 03:31:53 2017 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include Andrew Wright, Jeffrey Hayes,
6   * Pat Fisher, Mike Judd.
7   */
8  
9 < import junit.framework.*;
10 < import java.util.*;
11 < import java.util.concurrent.*;
12 < import java.io.*;
9 > import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 >
11 > import java.util.Collection;
12 > import java.util.concurrent.CountDownLatch;
13 > import java.util.concurrent.Semaphore;
14 > import java.util.concurrent.ThreadLocalRandom;
15 >
16 > import junit.framework.AssertionFailedError;
17 > import junit.framework.Test;
18 > import junit.framework.TestSuite;
19  
20   public class SemaphoreTest extends JSR166TestCase {
21      public static void main(String[] args) {
22 <        junit.textui.TestRunner.run (suite());
22 >        main(suite(), args);
23      }
24      public static Test suite() {
25 <        return new TestSuite(SemaphoreTest.class);
25 >        return new TestSuite(SemaphoreTest.class);
26      }
27  
28      /**
29       * Subclass to expose protected methods
30       */
31      static class PublicSemaphore extends Semaphore {
32 <        PublicSemaphore(int p, boolean f) { super(p, f); }
32 >        PublicSemaphore(int permits) { super(permits); }
33 >        PublicSemaphore(int permits, boolean fair) { super(permits, fair); }
34          public Collection<Thread> getQueuedThreads() {
35              return super.getQueuedThreads();
36          }
37 <        public void reducePermits(int p) {
38 <            super.reducePermits(p);
37 >        public boolean hasQueuedThread(Thread t) {
38 >            return super.getQueuedThreads().contains(t);
39 >        }
40 >        public void reducePermits(int reduction) {
41 >            super.reducePermits(reduction);
42          }
43      }
44  
45      /**
46       * A runnable calling acquire
47       */
48 <    class InterruptibleLockRunnable implements Runnable {
48 >    class InterruptibleLockRunnable extends CheckedRunnable {
49          final Semaphore lock;
50 <        InterruptibleLockRunnable(Semaphore l) { lock = l; }
51 <        public void run() {
50 >        InterruptibleLockRunnable(Semaphore s) { lock = s; }
51 >        public void realRun() {
52              try {
53                  lock.acquire();
54 <            } catch (InterruptedException success) {}
54 >            }
55 >            catch (InterruptedException ignored) {}
56          }
57      }
58  
48
59      /**
60 <     * A runnable calling acquire that expects to be
51 <     * interrupted
60 >     * A runnable calling acquire that expects to be interrupted
61       */
62 <    class InterruptedLockRunnable implements Runnable {
62 >    class InterruptedLockRunnable extends CheckedInterruptedRunnable {
63          final Semaphore lock;
64 <        InterruptedLockRunnable(Semaphore l) { lock = l; }
65 <        public void run() {
66 <            try {
67 <                lock.acquire();
68 <                threadShouldThrow();
69 <            } catch (InterruptedException success) {}
64 >        InterruptedLockRunnable(Semaphore s) { lock = s; }
65 >        public void realRun() throws InterruptedException {
66 >            lock.acquire();
67 >        }
68 >    }
69 >
70 >    /**
71 >     * Spin-waits until s.hasQueuedThread(t) becomes true.
72 >     */
73 >    void waitForQueuedThread(PublicSemaphore s, Thread t) {
74 >        long startTime = System.nanoTime();
75 >        while (!s.hasQueuedThread(t)) {
76 >            if (millisElapsedSince(startTime) > LONG_DELAY_MS)
77 >                throw new AssertionFailedError("timed out");
78 >            Thread.yield();
79 >        }
80 >        assertTrue(s.hasQueuedThreads());
81 >        assertTrue(t.isAlive());
82 >    }
83 >
84 >    /**
85 >     * Spin-waits until s.hasQueuedThreads() becomes true.
86 >     */
87 >    void waitForQueuedThreads(Semaphore s) {
88 >        long startTime = System.nanoTime();
89 >        while (!s.hasQueuedThreads()) {
90 >            if (millisElapsedSince(startTime) > LONG_DELAY_MS)
91 >                throw new AssertionFailedError("timed out");
92 >            Thread.yield();
93 >        }
94 >    }
95 >
96 >    enum AcquireMethod {
97 >        acquire() {
98 >            void acquire(Semaphore s) throws InterruptedException {
99 >                s.acquire();
100 >            }
101 >        },
102 >        acquireN() {
103 >            void acquire(Semaphore s, int permits) throws InterruptedException {
104 >                s.acquire(permits);
105 >            }
106 >        },
107 >        acquireUninterruptibly() {
108 >            void acquire(Semaphore s) {
109 >                s.acquireUninterruptibly();
110 >            }
111 >        },
112 >        acquireUninterruptiblyN() {
113 >            void acquire(Semaphore s, int permits) {
114 >                s.acquireUninterruptibly(permits);
115 >            }
116 >        },
117 >        tryAcquire() {
118 >            void acquire(Semaphore s) {
119 >                assertTrue(s.tryAcquire());
120 >            }
121 >        },
122 >        tryAcquireN() {
123 >            void acquire(Semaphore s, int permits) {
124 >                assertTrue(s.tryAcquire(permits));
125 >            }
126 >        },
127 >        tryAcquireTimed() {
128 >            void acquire(Semaphore s) throws InterruptedException {
129 >                assertTrue(s.tryAcquire(2 * LONG_DELAY_MS, MILLISECONDS));
130 >            }
131 >            Thread.State parkedState() { return Thread.State.TIMED_WAITING; }
132 >        },
133 >        tryAcquireTimedN {
134 >            void acquire(Semaphore s, int permits) throws InterruptedException {
135 >                assertTrue(s.tryAcquire(permits, 2 * LONG_DELAY_MS, MILLISECONDS));
136 >            }
137 >            Thread.State parkedState() { return Thread.State.TIMED_WAITING; }
138 >        };
139 >
140 >        // Intentionally meta-circular
141 >
142 >        /** Acquires 1 permit. */
143 >        void acquire(Semaphore s) throws InterruptedException {
144 >            acquire(s, 1);
145 >        }
146 >        /** Acquires the given number of permits. */
147 >        void acquire(Semaphore s, int permits) throws InterruptedException {
148 >            for (int i = 0; i < permits; i++)
149 >                acquire(s);
150          }
151 +        Thread.State parkedState() { return Thread.State.WAITING; }
152      }
153  
154      /**
155       * Zero, negative, and positive initial values are allowed in constructor
156       */
157 <    public void testConstructor() {
158 <        Semaphore s0 = new Semaphore(0, false);
159 <        assertEquals(0, s0.availablePermits());
160 <        assertFalse(s0.isFair());
161 <        Semaphore s1 = new Semaphore(-1, false);
162 <        assertEquals(-1, s1.availablePermits());
163 <        assertFalse(s1.isFair());
164 <        Semaphore s2 = new Semaphore(-1, false);
75 <        assertEquals(-1, s2.availablePermits());
76 <        assertFalse(s2.isFair());
157 >    public void testConstructor()      { testConstructor(false); }
158 >    public void testConstructor_fair() { testConstructor(true); }
159 >    public void testConstructor(boolean fair) {
160 >        for (int permits : new int[] { -42, -1, 0, 1, 42 }) {
161 >            Semaphore s = new Semaphore(permits, fair);
162 >            assertEquals(permits, s.availablePermits());
163 >            assertEquals(fair, s.isFair());
164 >        }
165      }
166  
167      /**
168       * Constructor without fairness argument behaves as nonfair
169       */
170 <    public void testConstructor2() {
171 <        Semaphore s0 = new Semaphore(0);
172 <        assertEquals(0, s0.availablePermits());
173 <        assertFalse(s0.isFair());
174 <        Semaphore s1 = new Semaphore(-1);
175 <        assertEquals(-1, s1.availablePermits());
88 <        assertFalse(s1.isFair());
89 <        Semaphore s2 = new Semaphore(-1);
90 <        assertEquals(-1, s2.availablePermits());
91 <        assertFalse(s2.isFair());
170 >    public void testConstructorDefaultsToNonFair() {
171 >        for (int permits : new int[] { -42, -1, 0, 1, 42 }) {
172 >            Semaphore s = new Semaphore(permits);
173 >            assertEquals(permits, s.availablePermits());
174 >            assertFalse(s.isFair());
175 >        }
176      }
177  
178      /**
179       * tryAcquire succeeds when sufficient permits, else fails
180       */
181 <    public void testTryAcquireInSameThread() {
182 <        Semaphore s = new Semaphore(2, false);
181 >    public void testTryAcquireInSameThread()      { testTryAcquireInSameThread(false); }
182 >    public void testTryAcquireInSameThread_fair() { testTryAcquireInSameThread(true); }
183 >    public void testTryAcquireInSameThread(boolean fair) {
184 >        Semaphore s = new Semaphore(2, fair);
185          assertEquals(2, s.availablePermits());
186          assertTrue(s.tryAcquire());
187          assertTrue(s.tryAcquire());
188          assertEquals(0, s.availablePermits());
189          assertFalse(s.tryAcquire());
190 +        assertFalse(s.tryAcquire());
191 +        assertEquals(0, s.availablePermits());
192      }
193  
194      /**
195 <     * Acquire and release of semaphore succeed if initially available
108 <     */
109 <    public void testAcquireReleaseInSameThread() {
110 <        Semaphore s = new Semaphore(1, false);
111 <        try {
112 <            s.acquire();
113 <            s.release();
114 <            s.acquire();
115 <            s.release();
116 <            s.acquire();
117 <            s.release();
118 <            s.acquire();
119 <            s.release();
120 <            s.acquire();
121 <            s.release();
122 <            assertEquals(1, s.availablePermits());
123 <        } catch ( InterruptedException e) {
124 <            unexpectedException();
125 <        }
126 <    }
127 <
128 <    /**
129 <     * Uninterruptible acquire and release of semaphore succeed if
130 <     * initially available
131 <     */
132 <    public void testAcquireUninterruptiblyReleaseInSameThread() {
133 <        Semaphore s = new Semaphore(1, false);
134 <        try {
135 <            s.acquireUninterruptibly();
136 <            s.release();
137 <            s.acquireUninterruptibly();
138 <            s.release();
139 <            s.acquireUninterruptibly();
140 <            s.release();
141 <            s.acquireUninterruptibly();
142 <            s.release();
143 <            s.acquireUninterruptibly();
144 <            s.release();
145 <            assertEquals(1, s.availablePermits());
146 <        } finally {
147 <        }
148 <    }
149 <
150 <    /**
151 <     * Timed Acquire and release of semaphore succeed if
152 <     * initially available
153 <     */
154 <    public void testTimedAcquireReleaseInSameThread() {
155 <        Semaphore s = new Semaphore(1, false);
156 <        try {
157 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
158 <            s.release();
159 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
160 <            s.release();
161 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
162 <            s.release();
163 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
164 <            s.release();
165 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
166 <            s.release();
167 <            assertEquals(1, s.availablePermits());
168 <        } catch ( InterruptedException e) {
169 <            unexpectedException();
170 <        }
171 <    }
172 <
173 <    /**
174 <     * A release in one thread enables an acquire in another thread
175 <     */
176 <    public void testAcquireReleaseInDifferentThreads() {
177 <        final Semaphore s = new Semaphore(0, false);
178 <        Thread t = new Thread(new Runnable() {
179 <                public void run() {
180 <                    try {
181 <                        s.acquire();
182 <                        s.release();
183 <                        s.release();
184 <                        s.acquire();
185 <                    } catch (InterruptedException ie) {
186 <                        threadUnexpectedException();
187 <                    }
188 <                }
189 <            });
190 <        try {
191 <            t.start();
192 <            Thread.sleep(SHORT_DELAY_MS);
193 <            s.release();
194 <            s.release();
195 <            s.acquire();
196 <            s.acquire();
197 <            s.release();
198 <            t.join();
199 <        } catch ( InterruptedException e) {
200 <            unexpectedException();
201 <        }
202 <    }
203 <
204 <    /**
205 <     * A release in one thread enables an uninterruptible acquire in another thread
195 >     * timed tryAcquire times out
196       */
197 <    public void testUninterruptibleAcquireReleaseInDifferentThreads() {
198 <        final Semaphore s = new Semaphore(0, false);
199 <        Thread t = new Thread(new Runnable() {
200 <                public void run() {
201 <                    s.acquireUninterruptibly();
202 <                    s.release();
203 <                    s.release();
204 <                    s.acquireUninterruptibly();
205 <                }
206 <            });
207 <        try {
208 <            t.start();
209 <            Thread.sleep(SHORT_DELAY_MS);
210 <            s.release();
211 <            s.release();
212 <            s.acquireUninterruptibly();
213 <            s.acquireUninterruptibly();
214 <            s.release();
215 <            t.join();
216 <        } catch ( InterruptedException e) {
217 <            unexpectedException();
197 >    public void testTryAcquire_timeout() {
198 >        final ThreadLocalRandom rnd = ThreadLocalRandom.current();
199 >        final boolean fair = rnd.nextBoolean();
200 >        final Semaphore s = new Semaphore(0, fair);
201 >        final long startTime = System.nanoTime();
202 >        try { assertFalse(s.tryAcquire(timeoutMillis(), MILLISECONDS)); }
203 >        catch (InterruptedException e) { threadUnexpectedException(e); }
204 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
205 >    }
206 >
207 >    /**
208 >     * timed tryAcquire(N) times out
209 >     */
210 >    public void testTryAcquireN_timeout() {
211 >        final ThreadLocalRandom rnd = ThreadLocalRandom.current();
212 >        final boolean fair = rnd.nextBoolean();
213 >        final Semaphore s = new Semaphore(2, fair);
214 >        final long startTime = System.nanoTime();
215 >        try { assertFalse(s.tryAcquire(3, timeoutMillis(), MILLISECONDS)); }
216 >        catch (InterruptedException e) { threadUnexpectedException(e); }
217 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
218 >    }
219 >
220 >    /**
221 >     * acquire(), acquire(N), timed tryAcquired, timed tryAcquire(N)
222 >     * are interruptible
223 >     */
224 >    public void testInterruptible_acquire()               { testInterruptible(false, AcquireMethod.acquire); }
225 >    public void testInterruptible_acquire_fair()          { testInterruptible(true,  AcquireMethod.acquire); }
226 >    public void testInterruptible_acquireN()              { testInterruptible(false, AcquireMethod.acquireN); }
227 >    public void testInterruptible_acquireN_fair()         { testInterruptible(true,  AcquireMethod.acquireN); }
228 >    public void testInterruptible_tryAcquireTimed()       { testInterruptible(false, AcquireMethod.tryAcquireTimed); }
229 >    public void testInterruptible_tryAcquireTimed_fair()  { testInterruptible(true,  AcquireMethod.tryAcquireTimed); }
230 >    public void testInterruptible_tryAcquireTimedN()      { testInterruptible(false, AcquireMethod.tryAcquireTimedN); }
231 >    public void testInterruptible_tryAcquireTimedN_fair() { testInterruptible(true,  AcquireMethod.tryAcquireTimedN); }
232 >    public void testInterruptible(boolean fair, final AcquireMethod acquirer) {
233 >        final PublicSemaphore s = new PublicSemaphore(0, fair);
234 >        final java.util.concurrent.CyclicBarrier pleaseInterrupt
235 >            = new java.util.concurrent.CyclicBarrier(2);
236 >        Thread t = newStartedThread(new CheckedRunnable() {
237 >            public void realRun() {
238 >                // Interrupt before acquire
239 >                Thread.currentThread().interrupt();
240 >                try {
241 >                    acquirer.acquire(s);
242 >                    shouldThrow();
243 >                } catch (InterruptedException success) {}
244 >                assertFalse(Thread.interrupted());
245 >
246 >                // Interrupt before acquire(N)
247 >                Thread.currentThread().interrupt();
248 >                try {
249 >                    acquirer.acquire(s, 3);
250 >                    shouldThrow();
251 >                } catch (InterruptedException success) {}
252 >                assertFalse(Thread.interrupted());
253 >
254 >                // Interrupt during acquire
255 >                await(pleaseInterrupt);
256 >                try {
257 >                    acquirer.acquire(s);
258 >                    shouldThrow();
259 >                } catch (InterruptedException success) {}
260 >                assertFalse(Thread.interrupted());
261 >
262 >                // Interrupt during acquire(N)
263 >                await(pleaseInterrupt);
264 >                try {
265 >                    acquirer.acquire(s, 3);
266 >                    shouldThrow();
267 >                } catch (InterruptedException success) {}
268 >                assertFalse(Thread.interrupted());
269 >            }});
270 >
271 >        for (int n = 2; n-->0; ) {
272 >            await(pleaseInterrupt);
273 >            assertThreadBlocks(t, acquirer.parkedState());
274 >            t.interrupt();
275          }
276 +        
277 +        awaitTermination(t);
278      }
279  
231
280      /**
281 <     *  A release in one thread enables a timed acquire in another thread
281 >     * acquireUninterruptibly(), acquireUninterruptibly(N) are
282 >     * uninterruptible
283       */
284 <    public void testTimedAcquireReleaseInDifferentThreads() {
285 <        final Semaphore s = new Semaphore(1, false);
286 <        Thread t = new Thread(new Runnable() {
287 <                public void run() {
288 <                    try {
289 <                        s.release();
290 <                        threadAssertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
291 <                        s.release();
292 <                        threadAssertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
284 >    public void testUninterruptible_acquireUninterruptibly()       { testUninterruptible(false, AcquireMethod.acquireUninterruptibly); }
285 >    public void testUninterruptible_acquireUninterruptibly_fair()  { testUninterruptible(true,  AcquireMethod.acquireUninterruptibly); }
286 >    public void testUninterruptible_acquireUninterruptiblyN()      { testUninterruptible(false, AcquireMethod.acquireUninterruptiblyN); }
287 >    public void testUninterruptible_acquireUninterruptiblyN_fair() { testUninterruptible(true,  AcquireMethod.acquireUninterruptiblyN); }
288 >    public void testUninterruptible(boolean fair, final AcquireMethod acquirer) {
289 >        final PublicSemaphore s = new PublicSemaphore(0, fair);
290 >        final Semaphore pleaseInterrupt = new Semaphore(-1, fair);
291 >
292 >        Thread t1 = newStartedThread(new CheckedRunnable() {
293 >            public void realRun() throws InterruptedException {
294 >                // Interrupt before acquire
295 >                pleaseInterrupt.release();
296 >                Thread.currentThread().interrupt();
297 >                acquirer.acquire(s);
298 >                assertTrue(Thread.interrupted());
299 >            }});
300 >
301 >        Thread t2 = newStartedThread(new CheckedRunnable() {
302 >            public void realRun() throws InterruptedException {
303 >                // Interrupt during acquire
304 >                pleaseInterrupt.release();
305 >                acquirer.acquire(s);
306 >                assertTrue(Thread.interrupted());
307 >            }});
308 >
309 >        await(pleaseInterrupt);
310 >        waitForQueuedThread(s, t1);
311 >        waitForQueuedThread(s, t2);
312 >        t2.interrupt();
313  
314 <                    } catch (InterruptedException ie) {
315 <                        threadUnexpectedException();
247 <                    }
248 <                }
249 <            });
250 <        try {
251 <            t.start();
252 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
253 <            s.release();
254 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
255 <            s.release();
256 <            s.release();
257 <            t.join();
258 <        } catch ( InterruptedException e) {
259 <            unexpectedException();
260 <        }
261 <    }
314 >        assertThreadBlocks(t1, Thread.State.WAITING);
315 >        assertThreadBlocks(t2, Thread.State.WAITING);
316  
317 <    /**
264 <     * A waiting acquire blocks interruptibly
265 <     */
266 <    public void testAcquire_InterruptedException() {
267 <        final Semaphore s = new Semaphore(0, false);
268 <        Thread t = new Thread(new Runnable() {
269 <                public void run() {
270 <                    try {
271 <                        s.acquire();
272 <                        threadShouldThrow();
273 <                    } catch (InterruptedException success) {}
274 <                }
275 <            });
276 <        t.start();
277 <        try {
278 <            Thread.sleep(SHORT_DELAY_MS);
279 <            t.interrupt();
280 <            t.join();
281 <        } catch (InterruptedException e) {
282 <            unexpectedException();
283 <        }
284 <    }
317 >        s.release(2);
318  
319 <    /**
320 <     *  A waiting timed acquire blocks interruptibly
288 <     */
289 <    public void testTryAcquire_InterruptedException() {
290 <        final Semaphore s = new Semaphore(0, false);
291 <        Thread t = new Thread(new Runnable() {
292 <                public void run() {
293 <                    try {
294 <                        s.tryAcquire(MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
295 <                        threadShouldThrow();
296 <                    } catch (InterruptedException success) {
297 <                    }
298 <                }
299 <            });
300 <        t.start();
301 <        try {
302 <            Thread.sleep(SHORT_DELAY_MS);
303 <            t.interrupt();
304 <            t.join();
305 <        } catch (InterruptedException e) {
306 <            unexpectedException();
307 <        }
319 >        awaitTermination(t1);
320 >        awaitTermination(t2);
321      }
322  
323      /**
324       * hasQueuedThreads reports whether there are waiting threads
325       */
326 <    public void testHasQueuedThreads() {
327 <        final Semaphore lock = new Semaphore(1, false);
328 <        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
329 <        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
330 <        try {
331 <            assertFalse(lock.hasQueuedThreads());
332 <            lock.acquireUninterruptibly();
333 <            t1.start();
334 <            Thread.sleep(SHORT_DELAY_MS);
335 <            assertTrue(lock.hasQueuedThreads());
336 <            t2.start();
337 <            Thread.sleep(SHORT_DELAY_MS);
338 <            assertTrue(lock.hasQueuedThreads());
339 <            t1.interrupt();
340 <            Thread.sleep(SHORT_DELAY_MS);
341 <            assertTrue(lock.hasQueuedThreads());
342 <            lock.release();
343 <            Thread.sleep(SHORT_DELAY_MS);
331 <            assertFalse(lock.hasQueuedThreads());
332 <            t1.join();
333 <            t2.join();
334 <        } catch (Exception e) {
335 <            unexpectedException();
336 <        }
326 >    public void testHasQueuedThreads()      { testHasQueuedThreads(false); }
327 >    public void testHasQueuedThreads_fair() { testHasQueuedThreads(true); }
328 >    public void testHasQueuedThreads(boolean fair) {
329 >        final PublicSemaphore lock = new PublicSemaphore(1, fair);
330 >        assertFalse(lock.hasQueuedThreads());
331 >        lock.acquireUninterruptibly();
332 >        Thread t1 = newStartedThread(new InterruptedLockRunnable(lock));
333 >        waitForQueuedThread(lock, t1);
334 >        assertTrue(lock.hasQueuedThreads());
335 >        Thread t2 = newStartedThread(new InterruptibleLockRunnable(lock));
336 >        waitForQueuedThread(lock, t2);
337 >        assertTrue(lock.hasQueuedThreads());
338 >        t1.interrupt();
339 >        awaitTermination(t1);
340 >        assertTrue(lock.hasQueuedThreads());
341 >        lock.release();
342 >        awaitTermination(t2);
343 >        assertFalse(lock.hasQueuedThreads());
344      }
345  
346      /**
347       * getQueueLength reports number of waiting threads
348       */
349 <    public void testGetQueueLength() {
350 <        final Semaphore lock = new Semaphore(1, false);
351 <        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
352 <        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
353 <        try {
354 <            assertEquals(0, lock.getQueueLength());
355 <            lock.acquireUninterruptibly();
356 <            t1.start();
357 <            Thread.sleep(SHORT_DELAY_MS);
358 <            assertEquals(1, lock.getQueueLength());
359 <            t2.start();
360 <            Thread.sleep(SHORT_DELAY_MS);
361 <            assertEquals(2, lock.getQueueLength());
362 <            t1.interrupt();
363 <            Thread.sleep(SHORT_DELAY_MS);
364 <            assertEquals(1, lock.getQueueLength());
365 <            lock.release();
366 <            Thread.sleep(SHORT_DELAY_MS);
360 <            assertEquals(0, lock.getQueueLength());
361 <            t1.join();
362 <            t2.join();
363 <        } catch (Exception e) {
364 <            unexpectedException();
365 <        }
349 >    public void testGetQueueLength()      { testGetQueueLength(false); }
350 >    public void testGetQueueLength_fair() { testGetQueueLength(true); }
351 >    public void testGetQueueLength(boolean fair) {
352 >        final PublicSemaphore lock = new PublicSemaphore(1, fair);
353 >        assertEquals(0, lock.getQueueLength());
354 >        lock.acquireUninterruptibly();
355 >        Thread t1 = newStartedThread(new InterruptedLockRunnable(lock));
356 >        waitForQueuedThread(lock, t1);
357 >        assertEquals(1, lock.getQueueLength());
358 >        Thread t2 = newStartedThread(new InterruptibleLockRunnable(lock));
359 >        waitForQueuedThread(lock, t2);
360 >        assertEquals(2, lock.getQueueLength());
361 >        t1.interrupt();
362 >        awaitTermination(t1);
363 >        assertEquals(1, lock.getQueueLength());
364 >        lock.release();
365 >        awaitTermination(t2);
366 >        assertEquals(0, lock.getQueueLength());
367      }
368  
369      /**
370       * getQueuedThreads includes waiting threads
371       */
372 <    public void testGetQueuedThreads() {
373 <        final PublicSemaphore lock = new PublicSemaphore(1, false);
374 <        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
375 <        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
376 <        try {
377 <            assertTrue(lock.getQueuedThreads().isEmpty());
378 <            lock.acquireUninterruptibly();
379 <            assertTrue(lock.getQueuedThreads().isEmpty());
380 <            t1.start();
381 <            Thread.sleep(SHORT_DELAY_MS);
382 <            assertTrue(lock.getQueuedThreads().contains(t1));
383 <            t2.start();
384 <            Thread.sleep(SHORT_DELAY_MS);
385 <            assertTrue(lock.getQueuedThreads().contains(t1));
386 <            assertTrue(lock.getQueuedThreads().contains(t2));
387 <            t1.interrupt();
388 <            Thread.sleep(SHORT_DELAY_MS);
389 <            assertFalse(lock.getQueuedThreads().contains(t1));
390 <            assertTrue(lock.getQueuedThreads().contains(t2));
391 <            lock.release();
392 <            Thread.sleep(SHORT_DELAY_MS);
392 <            assertTrue(lock.getQueuedThreads().isEmpty());
393 <            t1.join();
394 <            t2.join();
395 <        } catch (Exception e) {
396 <            unexpectedException();
397 <        }
372 >    public void testGetQueuedThreads()      { testGetQueuedThreads(false); }
373 >    public void testGetQueuedThreads_fair() { testGetQueuedThreads(true); }
374 >    public void testGetQueuedThreads(boolean fair) {
375 >        final PublicSemaphore lock = new PublicSemaphore(1, fair);
376 >        assertTrue(lock.getQueuedThreads().isEmpty());
377 >        lock.acquireUninterruptibly();
378 >        assertTrue(lock.getQueuedThreads().isEmpty());
379 >        Thread t1 = newStartedThread(new InterruptedLockRunnable(lock));
380 >        waitForQueuedThread(lock, t1);
381 >        assertTrue(lock.getQueuedThreads().contains(t1));
382 >        Thread t2 = newStartedThread(new InterruptibleLockRunnable(lock));
383 >        waitForQueuedThread(lock, t2);
384 >        assertTrue(lock.getQueuedThreads().contains(t1));
385 >        assertTrue(lock.getQueuedThreads().contains(t2));
386 >        t1.interrupt();
387 >        awaitTermination(t1);
388 >        assertFalse(lock.getQueuedThreads().contains(t1));
389 >        assertTrue(lock.getQueuedThreads().contains(t2));
390 >        lock.release();
391 >        awaitTermination(t2);
392 >        assertTrue(lock.getQueuedThreads().isEmpty());
393      }
394  
395      /**
396       * drainPermits reports and removes given number of permits
397       */
398 <    public void testDrainPermits() {
399 <        Semaphore s = new Semaphore(0, false);
398 >    public void testDrainPermits()      { testDrainPermits(false); }
399 >    public void testDrainPermits_fair() { testDrainPermits(true); }
400 >    public void testDrainPermits(boolean fair) {
401 >        Semaphore s = new Semaphore(0, fair);
402          assertEquals(0, s.availablePermits());
403          assertEquals(0, s.drainPermits());
404          s.release(10);
# Line 412 | Line 409 | public class SemaphoreTest extends JSR16
409      }
410  
411      /**
412 <     * reducePermits reduces number of permits
412 >     * release(-N) throws IllegalArgumentException
413       */
414 <    public void testReducePermits() {
415 <        PublicSemaphore s = new PublicSemaphore(10, false);
416 <        assertEquals(10, s.availablePermits());
417 <        s.reducePermits(1);
421 <        assertEquals(9, s.availablePermits());
422 <        s.reducePermits(10);
423 <        assertEquals(-1, s.availablePermits());
424 <    }
425 <
426 <    /**
427 <     * a deserialized serialized semaphore has same number of permits
428 <     */
429 <    public void testSerialization() {
430 <        Semaphore l = new Semaphore(3, false);
414 >    public void testReleaseIAE()      { testReleaseIAE(false); }
415 >    public void testReleaseIAE_fair() { testReleaseIAE(true); }
416 >    public void testReleaseIAE(boolean fair) {
417 >        Semaphore s = new Semaphore(10, fair);
418          try {
419 <            l.acquire();
420 <            l.release();
421 <            ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
435 <            ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
436 <            out.writeObject(l);
437 <            out.close();
438 <
439 <            ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
440 <            ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
441 <            Semaphore r = (Semaphore) in.readObject();
442 <            assertEquals(3, r.availablePermits());
443 <            assertFalse(r.isFair());
444 <            r.acquire();
445 <            r.release();
446 <        } catch (Exception e) {
447 <            unexpectedException();
448 <        }
419 >            s.release(-1);
420 >            shouldThrow();
421 >        } catch (IllegalArgumentException success) {}
422      }
423  
451
424      /**
425 <     * Zero, negative, and positive initial values are allowed in constructor
454 <     */
455 <    public void testConstructor_fair() {
456 <        Semaphore s0 = new Semaphore(0, true);
457 <        assertEquals(0, s0.availablePermits());
458 <        assertTrue(s0.isFair());
459 <        Semaphore s1 = new Semaphore(-1, true);
460 <        assertEquals(-1, s1.availablePermits());
461 <        Semaphore s2 = new Semaphore(-1, true);
462 <        assertEquals(-1, s2.availablePermits());
463 <    }
464 <
465 <    /**
466 <     * tryAcquire succeeds when sufficient permits, else fails
425 >     * reducePermits(-N) throws IllegalArgumentException
426       */
427 <    public void testTryAcquireInSameThread_fair() {
428 <        Semaphore s = new Semaphore(2, true);
429 <        assertEquals(2, s.availablePermits());
430 <        assertTrue(s.tryAcquire());
431 <        assertTrue(s.tryAcquire());
432 <        assertEquals(0, s.availablePermits());
433 <        assertFalse(s.tryAcquire());
427 >    public void testReducePermitsIAE()      { testReducePermitsIAE(false); }
428 >    public void testReducePermitsIAE_fair() { testReducePermitsIAE(true); }
429 >    public void testReducePermitsIAE(boolean fair) {
430 >        PublicSemaphore s = new PublicSemaphore(10, fair);
431 >        try {
432 >            s.reducePermits(-1);
433 >            shouldThrow();
434 >        } catch (IllegalArgumentException success) {}
435      }
436  
437      /**
438 <     * tryAcquire(n) succeeds when sufficient permits, else fails
438 >     * reducePermits reduces number of permits
439       */
440 <    public void testTryAcquireNInSameThread_fair() {
441 <        Semaphore s = new Semaphore(2, true);
442 <        assertEquals(2, s.availablePermits());
443 <        assertTrue(s.tryAcquire(2));
444 <        assertEquals(0, s.availablePermits());
445 <        assertFalse(s.tryAcquire());
440 >    public void testReducePermits()      { testReducePermits(false); }
441 >    public void testReducePermits_fair() { testReducePermits(true); }
442 >    public void testReducePermits(boolean fair) {
443 >        PublicSemaphore s = new PublicSemaphore(10, fair);
444 >        assertEquals(10, s.availablePermits());
445 >        s.reducePermits(0);
446 >        assertEquals(10, s.availablePermits());
447 >        s.reducePermits(1);
448 >        assertEquals(9, s.availablePermits());
449 >        s.reducePermits(10);
450 >        assertEquals(-1, s.availablePermits());
451 >        s.reducePermits(10);
452 >        assertEquals(-11, s.availablePermits());
453 >        s.reducePermits(0);
454 >        assertEquals(-11, s.availablePermits());
455      }
456  
457      /**
458 <     * Acquire and release of semaphore succeed if initially available
458 >     * a reserialized semaphore has same number of permits and
459 >     * fairness, but no queued threads
460       */
461 <    public void testAcquireReleaseInSameThread_fair() {
462 <        Semaphore s = new Semaphore(1, true);
461 >    public void testSerialization()      { testSerialization(false); }
462 >    public void testSerialization_fair() { testSerialization(true); }
463 >    public void testSerialization(boolean fair) {
464          try {
465 +            Semaphore s = new Semaphore(3, fair);
466              s.acquire();
495            s.release();
496            s.acquire();
497            s.release();
467              s.acquire();
468              s.release();
500            s.acquire();
501            s.release();
502            s.acquire();
503            s.release();
504            assertEquals(1, s.availablePermits());
505        } catch (InterruptedException e) {
506            unexpectedException();
507        }
508    }
469  
470 <    /**
471 <     * Acquire(n) and release(n) of semaphore succeed if initially available
472 <     */
473 <    public void testAcquireReleaseNInSameThread_fair() {
474 <        Semaphore s = new Semaphore(1, true);
475 <        try {
476 <            s.release(1);
477 <            s.acquire(1);
518 <            s.release(2);
519 <            s.acquire(2);
520 <            s.release(3);
521 <            s.acquire(3);
522 <            s.release(4);
523 <            s.acquire(4);
524 <            s.release(5);
525 <            s.acquire(5);
526 <            assertEquals(1, s.availablePermits());
527 <        } catch ( InterruptedException e) {
528 <            unexpectedException();
529 <        }
530 <    }
531 <
532 <    /**
533 <     * Acquire(n) and release(n) of semaphore succeed if initially available
534 <     */
535 <    public void testAcquireUninterruptiblyReleaseNInSameThread_fair() {
536 <        Semaphore s = new Semaphore(1, true);
537 <        try {
538 <            s.release(1);
539 <            s.acquireUninterruptibly(1);
540 <            s.release(2);
541 <            s.acquireUninterruptibly(2);
542 <            s.release(3);
543 <            s.acquireUninterruptibly(3);
544 <            s.release(4);
545 <            s.acquireUninterruptibly(4);
546 <            s.release(5);
547 <            s.acquireUninterruptibly(5);
548 <            assertEquals(1, s.availablePermits());
549 <        } finally {
550 <        }
551 <    }
552 <
553 <    /**
554 <     * release(n) in one thread enables timed acquire(n) in another thread
555 <     */
556 <    public void testTimedAcquireReleaseNInSameThread_fair() {
557 <        Semaphore s = new Semaphore(1, true);
558 <        try {
559 <            s.release(1);
560 <            assertTrue(s.tryAcquire(1, SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
561 <            s.release(2);
562 <            assertTrue(s.tryAcquire(2, SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
563 <            s.release(3);
564 <            assertTrue(s.tryAcquire(3, SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
565 <            s.release(4);
566 <            assertTrue(s.tryAcquire(4, SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
567 <            s.release(5);
568 <            assertTrue(s.tryAcquire(5, SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
569 <            assertEquals(1, s.availablePermits());
570 <        } catch ( InterruptedException e) {
571 <            unexpectedException();
572 <        }
573 <    }
574 <
575 <    /**
576 <     * release in one thread enables timed acquire in another thread
577 <     */
578 <    public void testTimedAcquireReleaseInSameThread_fair() {
579 <        Semaphore s = new Semaphore(1, true);
580 <        try {
581 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
582 <            s.release();
583 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
584 <            s.release();
585 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
586 <            s.release();
587 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
588 <            s.release();
589 <            assertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
590 <            s.release();
591 <            assertEquals(1, s.availablePermits());
592 <        } catch ( InterruptedException e) {
593 <            unexpectedException();
594 <        }
595 <    }
596 <
597 <    /**
598 <     * A release in one thread enables an acquire in another thread
599 <     */
600 <    public void testAcquireReleaseInDifferentThreads_fair() {
601 <        final Semaphore s = new Semaphore(0, true);
602 <        Thread t = new Thread(new Runnable() {
603 <                public void run() {
604 <                    try {
605 <                        s.acquire();
606 <                        s.acquire();
607 <                        s.acquire();
608 <                        s.acquire();
609 <                    } catch (InterruptedException ie) {
610 <                        threadUnexpectedException();
611 <                    }
612 <                }
613 <            });
614 <        try {
615 <            t.start();
616 <            Thread.sleep(SHORT_DELAY_MS);
617 <            s.release();
618 <            s.release();
619 <            s.release();
620 <            s.release();
621 <            s.release();
622 <            s.release();
623 <            t.join();
470 >            Semaphore clone = serialClone(s);
471 >            assertEquals(fair, s.isFair());
472 >            assertEquals(fair, clone.isFair());
473 >            assertEquals(2, s.availablePermits());
474 >            assertEquals(2, clone.availablePermits());
475 >            clone.acquire();
476 >            clone.acquire();
477 >            clone.release();
478              assertEquals(2, s.availablePermits());
479 <        } catch ( InterruptedException e) {
480 <            unexpectedException();
479 >            assertEquals(1, clone.availablePermits());
480 >            assertFalse(s.hasQueuedThreads());
481 >            assertFalse(clone.hasQueuedThreads());
482 >        } catch (InterruptedException e) { threadUnexpectedException(e); }
483 >
484 >        {
485 >            PublicSemaphore s = new PublicSemaphore(0, fair);
486 >            Thread t = newStartedThread(new InterruptibleLockRunnable(s));
487 >            // waitForQueuedThreads(s); // suffers from "flicker", so ...
488 >            waitForQueuedThread(s, t);  // ... we use this instead
489 >            PublicSemaphore clone = serialClone(s);
490 >            assertEquals(fair, s.isFair());
491 >            assertEquals(fair, clone.isFair());
492 >            assertEquals(0, s.availablePermits());
493 >            assertEquals(0, clone.availablePermits());
494 >            assertTrue(s.hasQueuedThreads());
495 >            assertFalse(clone.hasQueuedThreads());
496 >            s.release();
497 >            awaitTermination(t);
498 >            assertFalse(s.hasQueuedThreads());
499 >            assertFalse(clone.hasQueuedThreads());
500          }
501      }
502  
503      /**
504 <     * release(n) in one thread enables acquire(n) in another thread
504 >     * tryAcquire(n) succeeds when sufficient permits, else fails
505       */
506 <    public void testAcquireReleaseNInDifferentThreads_fair() {
507 <        final Semaphore s = new Semaphore(0, true);
508 <        Thread t = new Thread(new Runnable() {
509 <                public void run() {
510 <                    try {
511 <                        s.acquire();
512 <                        s.release(2);
513 <                        s.acquire();
514 <                    } catch (InterruptedException ie) {
515 <                        threadUnexpectedException();
516 <                    }
517 <                }
645 <            });
646 <        try {
647 <            t.start();
648 <            Thread.sleep(SHORT_DELAY_MS);
649 <            s.release(2);
650 <            s.acquire(2);
651 <            s.release(1);
652 <            t.join();
653 <        } catch ( InterruptedException e) {
654 <            unexpectedException();
655 <        }
656 <    }
657 <
658 <    /**
659 <     * release(n) in one thread enables acquire(n) in another thread
660 <     */
661 <    public void testAcquireReleaseNInDifferentThreads_fair2() {
662 <        final Semaphore s = new Semaphore(0, true);
663 <        Thread t = new Thread(new Runnable() {
664 <                public void run() {
665 <                    try {
666 <                        s.acquire(2);
667 <                        s.acquire(2);
668 <                        s.release(4);
669 <                    } catch (InterruptedException ie) {
670 <                        threadUnexpectedException();
671 <                    }
672 <                }
673 <            });
674 <        try {
675 <            t.start();
676 <            Thread.sleep(SHORT_DELAY_MS);
677 <            s.release(6);
678 <            s.acquire(2);
679 <            s.acquire(2);
680 <            s.release(2);
681 <            t.join();
682 <        } catch ( InterruptedException e) {
683 <            unexpectedException();
684 <        }
506 >    public void testTryAcquireNInSameThread()      { testTryAcquireNInSameThread(false); }
507 >    public void testTryAcquireNInSameThread_fair() { testTryAcquireNInSameThread(true); }
508 >    public void testTryAcquireNInSameThread(boolean fair) {
509 >        Semaphore s = new Semaphore(2, fair);
510 >        assertEquals(2, s.availablePermits());
511 >        assertFalse(s.tryAcquire(3));
512 >        assertEquals(2, s.availablePermits());
513 >        assertTrue(s.tryAcquire(2));
514 >        assertEquals(0, s.availablePermits());
515 >        assertFalse(s.tryAcquire(1));
516 >        assertFalse(s.tryAcquire(2));
517 >        assertEquals(0, s.availablePermits());
518      }
519  
687
688
689
690
520      /**
521 <     * release in one thread enables timed acquire in another thread
521 >     * acquire succeeds if permits available
522       */
523 <    public void testTimedAcquireReleaseInDifferentThreads_fair() {
524 <        final Semaphore s = new Semaphore(1, true);
525 <        Thread t = new Thread(new Runnable() {
526 <                public void run() {
527 <                    try {
528 <                        threadAssertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
529 <                        threadAssertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
530 <                        threadAssertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
531 <                        threadAssertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
532 <                        threadAssertTrue(s.tryAcquire(SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
533 <
534 <                    } catch (InterruptedException ie) {
535 <                        threadUnexpectedException();
536 <                    }
537 <                }
538 <            });
539 <        t.start();
540 <        try {
541 <            s.release();
542 <            s.release();
543 <            s.release();
544 <            s.release();
545 <            s.release();
546 <            t.join();
547 <        } catch ( InterruptedException e) {
548 <            unexpectedException();
720 <        }
721 <    }
722 <
723 <    /**
724 <     * release(n) in one thread enables timed acquire(n) in another thread
725 <     */
726 <    public void testTimedAcquireReleaseNInDifferentThreads_fair() {
727 <        final Semaphore s = new Semaphore(2, true);
728 <        Thread t = new Thread(new Runnable() {
729 <                public void run() {
730 <                    try {
731 <                        threadAssertTrue(s.tryAcquire(2, SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
732 <                        s.release(2);
733 <                        threadAssertTrue(s.tryAcquire(2, SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
734 <                        s.release(2);
735 <                    } catch (InterruptedException ie) {
736 <                        threadUnexpectedException();
737 <                    }
738 <                }
739 <            });
740 <        t.start();
741 <        try {
742 <            assertTrue(s.tryAcquire(2, SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
743 <            s.release(2);
744 <            assertTrue(s.tryAcquire(2, SHORT_DELAY_MS, TimeUnit.MILLISECONDS));
745 <            s.release(2);
746 <            t.join();
747 <        } catch ( InterruptedException e) {
748 <            unexpectedException();
749 <        }
750 <    }
751 <
752 <    /**
753 <     * A waiting acquire blocks interruptibly
754 <     */
755 <    public void testAcquire_InterruptedException_fair() {
756 <        final Semaphore s = new Semaphore(0, true);
757 <        Thread t = new Thread(new Runnable() {
758 <                public void run() {
759 <                    try {
760 <                        s.acquire();
761 <                        threadShouldThrow();
762 <                    } catch (InterruptedException success) {}
763 <                }
764 <            });
765 <        t.start();
766 <        try {
767 <            Thread.sleep(SHORT_DELAY_MS);
768 <            t.interrupt();
769 <            t.join();
770 <        } catch (InterruptedException e) {
771 <            unexpectedException();
772 <        }
773 <    }
774 <
775 <    /**
776 <     * A waiting acquire(n) blocks interruptibly
777 <     */
778 <    public void testAcquireN_InterruptedException_fair() {
779 <        final Semaphore s = new Semaphore(2, true);
780 <        Thread t = new Thread(new Runnable() {
781 <                public void run() {
782 <                    try {
783 <                        s.acquire(3);
784 <                        threadShouldThrow();
785 <                    } catch (InterruptedException success) {}
786 <                }
787 <            });
788 <        t.start();
789 <        try {
790 <            Thread.sleep(SHORT_DELAY_MS);
791 <            t.interrupt();
792 <            t.join();
793 <        } catch (InterruptedException e) {
794 <            unexpectedException();
795 <        }
796 <    }
797 <
798 <    /**
799 <     *  A waiting tryAcquire blocks interruptibly
800 <     */
801 <    public void testTryAcquire_InterruptedException_fair() {
802 <        final Semaphore s = new Semaphore(0, true);
803 <        Thread t = new Thread(new Runnable() {
804 <                public void run() {
805 <                    try {
806 <                        s.tryAcquire(MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
807 <                        threadShouldThrow();
808 <                    } catch (InterruptedException success) {
809 <                    }
810 <                }
811 <            });
812 <        t.start();
813 <        try {
814 <            Thread.sleep(SHORT_DELAY_MS);
815 <            t.interrupt();
816 <            t.join();
817 <        } catch (InterruptedException e) {
818 <            unexpectedException();
819 <        }
820 <    }
821 <
822 <    /**
823 <     *  A waiting tryAcquire(n) blocks interruptibly
824 <     */
825 <    public void testTryAcquireN_InterruptedException_fair() {
826 <        final Semaphore s = new Semaphore(1, true);
827 <        Thread t = new Thread(new Runnable() {
828 <                public void run() {
829 <                    try {
830 <                        s.tryAcquire(4, MEDIUM_DELAY_MS, TimeUnit.MILLISECONDS);
831 <                        threadShouldThrow();
832 <                    } catch (InterruptedException success) {
833 <                    }
834 <                }
835 <            });
836 <        t.start();
837 <        try {
838 <            Thread.sleep(SHORT_DELAY_MS);
839 <            t.interrupt();
840 <            t.join();
841 <        } catch (InterruptedException e) {
842 <            unexpectedException();
523 >    public void testReleaseAcquireSameThread_acquire()       { testReleaseAcquireSameThread(false, AcquireMethod.acquire); }
524 >    public void testReleaseAcquireSameThread_acquire_fair()  { testReleaseAcquireSameThread(true, AcquireMethod.acquire); }
525 >    public void testReleaseAcquireSameThread_acquireN()      { testReleaseAcquireSameThread(false, AcquireMethod.acquireN); }
526 >    public void testReleaseAcquireSameThread_acquireN_fair() { testReleaseAcquireSameThread(true, AcquireMethod.acquireN); }
527 >    public void testReleaseAcquireSameThread_acquireUninterruptibly()       { testReleaseAcquireSameThread(false, AcquireMethod.acquireUninterruptibly); }
528 >    public void testReleaseAcquireSameThread_acquireUninterruptibly_fair()  { testReleaseAcquireSameThread(true, AcquireMethod.acquireUninterruptibly); }
529 >    public void testReleaseAcquireSameThread_acquireUninterruptiblyN()      { testReleaseAcquireSameThread(false, AcquireMethod.acquireUninterruptibly); }
530 >    public void testReleaseAcquireSameThread_acquireUninterruptiblyN_fair() { testReleaseAcquireSameThread(true, AcquireMethod.acquireUninterruptibly); }
531 >    public void testReleaseAcquireSameThread_tryAcquire()       { testReleaseAcquireSameThread(false, AcquireMethod.tryAcquire); }
532 >    public void testReleaseAcquireSameThread_tryAcquire_fair()  { testReleaseAcquireSameThread(true, AcquireMethod.tryAcquire); }
533 >    public void testReleaseAcquireSameThread_tryAcquireN()      { testReleaseAcquireSameThread(false, AcquireMethod.tryAcquireN); }
534 >    public void testReleaseAcquireSameThread_tryAcquireN_fair() { testReleaseAcquireSameThread(true, AcquireMethod.tryAcquireN); }
535 >    public void testReleaseAcquireSameThread_tryAcquireTimed()       { testReleaseAcquireSameThread(false, AcquireMethod.tryAcquireTimed); }
536 >    public void testReleaseAcquireSameThread_tryAcquireTimed_fair()  { testReleaseAcquireSameThread(true, AcquireMethod.tryAcquireTimed); }
537 >    public void testReleaseAcquireSameThread_tryAcquireTimedN()      { testReleaseAcquireSameThread(false, AcquireMethod.tryAcquireTimedN); }
538 >    public void testReleaseAcquireSameThread_tryAcquireTimedN_fair() { testReleaseAcquireSameThread(true, AcquireMethod.tryAcquireTimedN); }
539 >    public void testReleaseAcquireSameThread(boolean fair,
540 >                                             final AcquireMethod acquirer) {
541 >        Semaphore s = new Semaphore(1, fair);
542 >        for (int i = 1; i < 6; i++) {
543 >            s.release(i);
544 >            assertEquals(1 + i, s.availablePermits());
545 >            try {
546 >                acquirer.acquire(s, i);
547 >            } catch (InterruptedException e) { threadUnexpectedException(e); }
548 >            assertEquals(1, s.availablePermits());
549          }
550      }
551  
552      /**
553 <     * getQueueLength reports number of waiting threads
553 >     * release in one thread enables acquire in another thread
554       */
555 <    public void testGetQueueLength_fair() {
556 <        final Semaphore lock = new Semaphore(1, true);
557 <        Thread t1 = new Thread(new InterruptedLockRunnable(lock));
558 <        Thread t2 = new Thread(new InterruptibleLockRunnable(lock));
559 <        try {
560 <            assertEquals(0, lock.getQueueLength());
561 <            lock.acquireUninterruptibly();
562 <            t1.start();
563 <            Thread.sleep(SHORT_DELAY_MS);
564 <            assertEquals(1, lock.getQueueLength());
565 <            t2.start();
566 <            Thread.sleep(SHORT_DELAY_MS);
567 <            assertEquals(2, lock.getQueueLength());
568 <            t1.interrupt();
569 <            Thread.sleep(SHORT_DELAY_MS);
570 <            assertEquals(1, lock.getQueueLength());
571 <            lock.release();
572 <            Thread.sleep(SHORT_DELAY_MS);
573 <            assertEquals(0, lock.getQueueLength());
574 <            t1.join();
575 <            t2.join();
576 <        } catch (Exception e) {
577 <            unexpectedException();
555 >    public void testReleaseAcquireDifferentThreads_acquire()       { testReleaseAcquireDifferentThreads(false, AcquireMethod.acquire); }
556 >    public void testReleaseAcquireDifferentThreads_acquire_fair()  { testReleaseAcquireDifferentThreads(true, AcquireMethod.acquire); }
557 >    public void testReleaseAcquireDifferentThreads_acquireN()      { testReleaseAcquireDifferentThreads(false, AcquireMethod.acquireN); }
558 >    public void testReleaseAcquireDifferentThreads_acquireN_fair() { testReleaseAcquireDifferentThreads(true, AcquireMethod.acquireN); }
559 >    public void testReleaseAcquireDifferentThreads_acquireUninterruptibly()       { testReleaseAcquireDifferentThreads(false, AcquireMethod.acquireUninterruptibly); }
560 >    public void testReleaseAcquireDifferentThreads_acquireUninterruptibly_fair()  { testReleaseAcquireDifferentThreads(true, AcquireMethod.acquireUninterruptibly); }
561 >    public void testReleaseAcquireDifferentThreads_acquireUninterruptiblyN()      { testReleaseAcquireDifferentThreads(false, AcquireMethod.acquireUninterruptibly); }
562 >    public void testReleaseAcquireDifferentThreads_acquireUninterruptiblyN_fair() { testReleaseAcquireDifferentThreads(true, AcquireMethod.acquireUninterruptibly); }
563 >    public void testReleaseAcquireDifferentThreads_tryAcquireTimed()       { testReleaseAcquireDifferentThreads(false, AcquireMethod.tryAcquireTimed); }
564 >    public void testReleaseAcquireDifferentThreads_tryAcquireTimed_fair()  { testReleaseAcquireDifferentThreads(true, AcquireMethod.tryAcquireTimed); }
565 >    public void testReleaseAcquireDifferentThreads_tryAcquireTimedN()      { testReleaseAcquireDifferentThreads(false, AcquireMethod.tryAcquireTimedN); }
566 >    public void testReleaseAcquireDifferentThreads_tryAcquireTimedN_fair() { testReleaseAcquireDifferentThreads(true, AcquireMethod.tryAcquireTimedN); }
567 >    public void testReleaseAcquireDifferentThreads(boolean fair,
568 >                                                   final AcquireMethod acquirer) {
569 >        final Semaphore s = new Semaphore(0, fair);
570 >        final int rounds = 4;
571 >        long startTime = System.nanoTime();
572 >        Thread t = newStartedThread(new CheckedRunnable() {
573 >            public void realRun() throws InterruptedException {
574 >                for (int i = 0; i < rounds; i++) {
575 >                    assertFalse(s.hasQueuedThreads());
576 >                    if (i % 2 == 0)
577 >                        acquirer.acquire(s);
578 >                    else
579 >                        acquirer.acquire(s, 3);
580 >                }}});
581 >
582 >        for (int i = 0; i < rounds; i++) {
583 >            while (! (s.availablePermits() == 0 && s.hasQueuedThreads()))
584 >                Thread.yield();
585 >            assertTrue(t.isAlive());
586 >            if (i % 2 == 0)
587 >                s.release();
588 >            else
589 >                s.release(3);
590          }
591 +        awaitTermination(t);
592 +        assertEquals(0, s.availablePermits());
593 +        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
594      }
595  
875
596      /**
597 <     * a deserialized serialized semaphore has same number of permits
597 >     * fair locks are strictly FIFO
598       */
599 <    public void testSerialization_fair() {
600 <        Semaphore l = new Semaphore(3, true);
601 <
602 <        try {
603 <            l.acquire();
604 <            l.release();
605 <            ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
606 <            ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
607 <            out.writeObject(l);
608 <            out.close();
609 <
610 <            ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
611 <            ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
612 <            Semaphore r = (Semaphore) in.readObject();
613 <            assertEquals(3, r.availablePermits());
614 <            assertTrue(r.isFair());
615 <            r.acquire();
616 <            r.release();
617 <        } catch (Exception e) {
618 <            unexpectedException();
619 <        }
599 >    public void testFairLocksFifo() {
600 >        final PublicSemaphore s = new PublicSemaphore(1, true);
601 >        final CountDownLatch pleaseRelease = new CountDownLatch(1);
602 >        Thread t1 = newStartedThread(new CheckedRunnable() {
603 >            public void realRun() throws InterruptedException {
604 >                // Will block; permits are available, but not three
605 >                s.acquire(3);
606 >            }});
607 >
608 >        waitForQueuedThread(s, t1);
609 >
610 >        Thread t2 = newStartedThread(new CheckedRunnable() {
611 >            public void realRun() throws InterruptedException {
612 >                // Will fail, even though 1 permit is available
613 >                assertFalse(s.tryAcquire(0L, MILLISECONDS));
614 >                assertFalse(s.tryAcquire(1, 0L, MILLISECONDS));
615 >
616 >                // untimed tryAcquire will barge and succeed
617 >                assertTrue(s.tryAcquire());
618 >                s.release(2);
619 >                assertTrue(s.tryAcquire(2));
620 >                s.release();
621 >
622 >                pleaseRelease.countDown();
623 >                // Will queue up behind t1, even though 1 permit is available
624 >                s.acquire();
625 >            }});
626 >
627 >        await(pleaseRelease);
628 >        waitForQueuedThread(s, t2);
629 >        s.release(2);
630 >        awaitTermination(t1);
631 >        assertTrue(t2.isAlive());
632 >        s.release();
633 >        awaitTermination(t2);
634      }
635  
636      /**
637       * toString indicates current number of permits
638       */
639 <    public void testToString() {
640 <        Semaphore s = new Semaphore(0);
641 <        String us = s.toString();
642 <        assertTrue(us.indexOf("Permits = 0") >= 0);
643 <        s.release();
910 <        String s1 = s.toString();
911 <        assertTrue(s1.indexOf("Permits = 1") >= 0);
639 >    public void testToString()      { testToString(false); }
640 >    public void testToString_fair() { testToString(true); }
641 >    public void testToString(boolean fair) {
642 >        PublicSemaphore s = new PublicSemaphore(0, fair);
643 >        assertTrue(s.toString().contains("Permits = 0"));
644          s.release();
645 <        String s2 = s.toString();
646 <        assertTrue(s2.indexOf("Permits = 2") >= 0);
645 >        assertTrue(s.toString().contains("Permits = 1"));
646 >        s.release(2);
647 >        assertTrue(s.toString().contains("Permits = 3"));
648 >        s.reducePermits(5);
649 >        assertTrue(s.toString().contains("Permits = -2"));
650      }
651  
652   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines