ViewVC Help

View File | Revision Log | Show Annotations | Download File | Root Listing

root/jsr166/jsr166/src/test/tck/SplittableRandomTest.java

Comparing jsr166/src/test/tck/SplittableRandomTest.java (file contents):
Revision 1.11 by jsr166, Tue Sep 24 16:39:38 2013 UTC vs.
Revision 1.26 by jsr166, Mon Dec 16 22:55:54 2019 UTC

#	Line 3 | Line 3
3		* Expert Group and released to the public domain, as explained at
4		* http://creativecommons.org/publicdomain/zero/1.0/
5		*/
6	<	import junit.framework.*;
7	<	import java.util.*;
6	>
7	>	import java.util.Arrays;
8	>	import java.util.List;
9		import java.util.SplittableRandom;
10		import java.util.concurrent.atomic.AtomicInteger;
10	–	import java.util.concurrent.atomic.AtomicLong;
11		import java.util.concurrent.atomic.LongAdder;
12	+	import java.lang.reflect.Method;
13	+	import java.util.function.Predicate;
14	+	import java.util.stream.Collectors;
15	+	import java.util.stream.DoubleStream;
16	+	import java.util.stream.IntStream;
17	+	import java.util.stream.LongStream;
18	+
19	+	import junit.framework.Test;
20	+	import junit.framework.TestSuite;
21
22		public class SplittableRandomTest extends JSR166TestCase {
23
24		public static void main(String[] args) {
25	<	junit.textui.TestRunner.run(suite());
25	>	main(suite(), args);
26		}
27		public static Test suite() {
28		return new TestSuite(SplittableRandomTest.class);
#	Line 42 | Line 51 | public class SplittableRandomTest extend
51		static final int MAX_INT_BOUND = (1 << 26);
52
53		// max sampled long bound
54	<	static final long MAX_LONG_BOUND = (1L << 42);
54	>	static final long MAX_LONG_BOUND = (1L << 40);
55
56		// Number of replications for other checks
57		static final int REPS =
#	Line 89 | Line 98 | public class SplittableRandomTest extend
98		* same values for nextLong.
99		*/
100		public void testSeedConstructor() {
101	<	for (long seed = 2; seed < MAX_LONG_BOUND; seed += 15485863)  {
101	>	for (long seed = 2; seed < MAX_LONG_BOUND; seed += 15485863) {
102		SplittableRandom sr1 = new SplittableRandom(seed);
103		SplittableRandom sr2 = new SplittableRandom(seed);
104		for (int i = 0; i < REPS; ++i)
#	Line 130 | Line 139 | public class SplittableRandomTest extend
139		/**
140		* nextInt(non-positive) throws IllegalArgumentException
141		*/
142	<	public void testNextIntNonPositive() {
142	>	public void testNextIntBoundNonPositive() {
143		SplittableRandom sr = new SplittableRandom();
144	<	Runnable[] throwingActions = {
144	>	assertThrows(
145	>	IllegalArgumentException.class,
146		() -> sr.nextInt(-17),
147		() -> sr.nextInt(0),
148	<	() -> sr.nextInt(Integer.MIN_VALUE),
139	<	};
140	<	assertThrows(IllegalArgumentException.class, throwingActions);
148	>	() -> sr.nextInt(Integer.MIN_VALUE));
149		}
150
151		/**
#	Line 145 | Line 153 | public class SplittableRandomTest extend
153		*/
154		public void testNextIntBadBounds() {
155		SplittableRandom sr = new SplittableRandom();
156	<	Runnable[] throwingActions = {
156	>	assertThrows(
157	>	IllegalArgumentException.class,
158		() -> sr.nextInt(17, 2),
159		() -> sr.nextInt(-42, -42),
160	<	() -> sr.nextInt(Integer.MAX_VALUE, Integer.MIN_VALUE),
152	<	};
153	<	assertThrows(IllegalArgumentException.class, throwingActions);
160	>	() -> sr.nextInt(Integer.MAX_VALUE, Integer.MIN_VALUE));
161		}
162
163		/**
#	Line 159 | Line 166 | public class SplittableRandomTest extend
166		*/
167		public void testNextIntBounded() {
168		SplittableRandom sr = new SplittableRandom();
169	+	for (int i = 0; i < 2; i++) assertEquals(0, sr.nextInt(1));
170		// sample bound space across prime number increments
171		for (int bound = 2; bound < MAX_INT_BOUND; bound += 524959) {
172		int f = sr.nextInt(bound);
#	Line 199 | Line 207 | public class SplittableRandomTest extend
207		/**
208		* nextLong(non-positive) throws IllegalArgumentException
209		*/
210	<	public void testNextLongNonPositive() {
210	>	public void testNextLongBoundNonPositive() {
211		SplittableRandom sr = new SplittableRandom();
212	<	Runnable[] throwingActions = {
212	>	assertThrows(
213	>	IllegalArgumentException.class,
214		() -> sr.nextLong(-17L),
215		() -> sr.nextLong(0L),
216	<	() -> sr.nextLong(Long.MIN_VALUE),
208	<	};
209	<	assertThrows(IllegalArgumentException.class, throwingActions);
216	>	() -> sr.nextLong(Long.MIN_VALUE));
217		}
218
219		/**
#	Line 214 | Line 221 | public class SplittableRandomTest extend
221		*/
222		public void testNextLongBadBounds() {
223		SplittableRandom sr = new SplittableRandom();
224	<	Runnable[] throwingActions = {
224	>	assertThrows(
225	>	IllegalArgumentException.class,
226		() -> sr.nextLong(17L, 2L),
227		() -> sr.nextLong(-42L, -42L),
228	<	() -> sr.nextLong(Long.MAX_VALUE, Long.MIN_VALUE),
221	<	};
222	<	assertThrows(IllegalArgumentException.class, throwingActions);
228	>	() -> sr.nextLong(Long.MAX_VALUE, Long.MIN_VALUE));
229		}
230
231		/**
#	Line 228 | Line 234 | public class SplittableRandomTest extend
234		*/
235		public void testNextLongBounded() {
236		SplittableRandom sr = new SplittableRandom();
237	+	for (int i = 0; i < 2; i++) assertEquals(0L, sr.nextLong(1L));
238		for (long bound = 2; bound < MAX_LONG_BOUND; bound += 15485863) {
239		long f = sr.nextLong(bound);
240		assertTrue(0 <= f && f < bound);
#	Line 267 | Line 274 | public class SplittableRandomTest extend
274		/**
275		* nextDouble(non-positive) throws IllegalArgumentException
276		*/
277	<	public void testNextDoubleNonPositive() {
277	>	public void testNextDoubleBoundNonPositive() {
278		SplittableRandom sr = new SplittableRandom();
279	<	Runnable[] throwingActions = {
279	>	assertThrows(
280	>	IllegalArgumentException.class,
281		() -> sr.nextDouble(-17.0d),
282		() -> sr.nextDouble(0.0d),
283		() -> sr.nextDouble(-Double.MIN_VALUE),
284		() -> sr.nextDouble(Double.NEGATIVE_INFINITY),
285	<	() -> sr.nextDouble(Double.NaN),
278	<	};
279	<	assertThrows(IllegalArgumentException.class, throwingActions);
285	>	() -> sr.nextDouble(Double.NaN));
286		}
287
288		/**
#	Line 284 | Line 290 | public class SplittableRandomTest extend
290		*/
291		public void testNextDoubleBadBounds() {
292		SplittableRandom sr = new SplittableRandom();
293	<	Runnable[] throwingActions = {
293	>	assertThrows(
294	>	IllegalArgumentException.class,
295		() -> sr.nextDouble(17.0d, 2.0d),
296		() -> sr.nextDouble(-42.0d, -42.0d),
297		() -> sr.nextDouble(Double.MAX_VALUE, Double.MIN_VALUE),
298		() -> sr.nextDouble(Double.NaN, 0.0d),
299	<	() -> sr.nextDouble(0.0d, Double.NaN),
293	<	};
294	<	assertThrows(IllegalArgumentException.class, throwingActions);
299	>	() -> sr.nextDouble(0.0d, Double.NaN));
300		}
301
302		// TODO: Test infinite bounds!
#	Line 326 | Line 331 | public class SplittableRandomTest extend
331		*/
332		public void testBadStreamSize() {
333		SplittableRandom r = new SplittableRandom();
334	<	Runnable[] throwingActions = {
335	<	() -> { java.util.stream.IntStream x = r.ints(-1L); },
336	<	() -> { java.util.stream.IntStream x = r.ints(-1L, 2, 3); },
337	<	() -> { java.util.stream.LongStream x = r.longs(-1L); },
338	<	() -> { java.util.stream.LongStream x = r.longs(-1L, -1L, 1L); },
339	<	() -> { java.util.stream.DoubleStream x = r.doubles(-1L); },
340	<	() -> { java.util.stream.DoubleStream x = r.doubles(-1L, .5, .6); },
341	<	};
337	<	assertThrows(IllegalArgumentException.class, throwingActions);
334	>	assertThrows(
335	>	IllegalArgumentException.class,
336	>	() -> { IntStream unused = r.ints(-1L); },
337	>	() -> { IntStream unused = r.ints(-1L, 2, 3); },
338	>	() -> { LongStream unused = r.longs(-1L); },
339	>	() -> { LongStream unused = r.longs(-1L, -1L, 1L); },
340	>	() -> { DoubleStream unused = r.doubles(-1L); },
341	>	() -> { DoubleStream unused = r.doubles(-1L, .5, .6); });
342		}
343
344		/**
#	Line 343 | Line 347 | public class SplittableRandomTest extend
347		*/
348		public void testBadStreamBounds() {
349		SplittableRandom r = new SplittableRandom();
350	<	Runnable[] throwingActions = {
351	<	() -> { java.util.stream.IntStream x = r.ints(2, 1); },
352	<	() -> { java.util.stream.IntStream x = r.ints(10, 42, 42); },
353	<	() -> { java.util.stream.LongStream x = r.longs(-1L, -1L); },
354	<	() -> { java.util.stream.LongStream x = r.longs(10, 1L, -2L); },
355	<	() -> { java.util.stream.DoubleStream x = r.doubles(0.0, 0.0); },
356	<	() -> { java.util.stream.DoubleStream x = r.doubles(10, .5, .4); },
357	<	};
354	<	assertThrows(IllegalArgumentException.class, throwingActions);
350	>	assertThrows(
351	>	IllegalArgumentException.class,
352	>	() -> { IntStream unused = r.ints(2, 1); },
353	>	() -> { IntStream unused = r.ints(10, 42, 42); },
354	>	() -> { LongStream unused = r.longs(-1L, -1L); },
355	>	() -> { LongStream unused = r.longs(10, 1L, -2L); },
356	>	() -> { DoubleStream unused = r.doubles(0.0, 0.0); },
357	>	() -> { DoubleStream unused = r.doubles(10, .5, .4); });
358		}
359
360		/**
#	Line 409 | Line 412 | public class SplittableRandomTest extend
412		for (int least = -15485867; least < MAX_INT_BOUND; least += 524959) {
413		for (int bound = least + 2; bound > least && bound < MAX_INT_BOUND; bound += 67867967) {
414		final int lo = least, hi = bound;
415	<	r.ints(size, lo, hi).parallel().
416	<	forEach(x -> {if (x < lo || x >= hi)
417	<	fails.getAndIncrement(); });
415	>	r.ints(size, lo, hi).parallel().forEach(
416	>	x -> {
417	>	if (x < lo || x >= hi)
418	>	fails.getAndIncrement(); });
419		}
420		}
421		assertEquals(0, fails.get());
#	Line 427 | Line 431 | public class SplittableRandomTest extend
431		for (long least = -86028121; least < MAX_LONG_BOUND; least += 1982451653L) {
432		for (long bound = least + 2; bound > least && bound < MAX_LONG_BOUND; bound += Math.abs(bound * 7919)) {
433		final long lo = least, hi = bound;
434	<	r.longs(size, lo, hi).parallel().
435	<	forEach(x -> {if (x < lo || x >= hi)
436	<	fails.getAndIncrement(); });
434	>	r.longs(size, lo, hi).parallel().forEach(
435	>	x -> {
436	>	if (x < lo || x >= hi)
437	>	fails.getAndIncrement(); });
438		}
439		}
440		assertEquals(0, fails.get());
#	Line 445 | Line 450 | public class SplittableRandomTest extend
450		for (double least = 0.00011; least < 1.0e20; least *= 9) {
451		for (double bound = least * 1.0011; bound < 1.0e20; bound *= 17) {
452		final double lo = least, hi = bound;
453	<	r.doubles(size, lo, hi).parallel().
454	<	forEach(x -> {if (x < lo || x >= hi)
455	<	fails.getAndIncrement(); });
453	>	r.doubles(size, lo, hi).parallel().forEach(
454	>	x -> {
455	>	if (x < lo || x >= hi)
456	>	fails.getAndIncrement(); });
457		}
458		}
459		assertEquals(0, fails.get());
#	Line 519 | Line 525 | public class SplittableRandomTest extend
525		assertEquals(size, counter.sum());
526		}
527
528	+	/**
529	+	* SplittableRandom should implement most of Random's public methods
530	+	*/
531	+	public void testShouldImplementMostRandomMethods() throws Throwable {
532	+	Predicate<Method> wasForgotten = method -> {
533	+	String name = method.getName();
534	+	// some methods deliberately not implemented
535	+	if (name.equals("setSeed")) return false;
536	+	if (name.equals("nextFloat")) return false;
537	+	if (name.equals("nextGaussian")) return false;
538	+	try {
539	+	SplittableRandom.class.getMethod(
540	+	method.getName(), method.getParameterTypes());
541	+	} catch (ReflectiveOperationException ex) {
542	+	return true;
543	+	}
544	+	return false;
545	+	};
546	+	List<Method> forgotten =
547	+	Arrays.stream(java.util.Random.class.getMethods())
548	+	.filter(wasForgotten)
549	+	.collect(Collectors.toList());
550	+	if (!forgotten.isEmpty())
551	+	throw new AssertionError("Please implement: " + forgotten);
552	+	}
553	+
554	+	/**
555	+	* Repeated calls to nextBytes produce at least values of different signs for every byte
556	+	*/
557	+	public void testNextBytes() {
558	+	SplittableRandom sr = new SplittableRandom();
559	+	int n = sr.nextInt(1, 20);
560	+	byte[] bytes = new byte[n];
561	+	outer:
562	+	for (int i = 0; i < n; i++) {
563	+	for (int tries = NCALLS; tries-->0; ) {
564	+	byte before = bytes[i];
565	+	sr.nextBytes(bytes);
566	+	byte after = bytes[i];
567	+	if (after * before < 0)
568	+	continue outer;
569	+	}
570	+	fail("not enough variation in random bytes");
571	+	}
572	+	}
573	+
574	+	/**
575	+	* Filling an empty array with random bytes succeeds without effect.
576	+	*/
577	+	public void testNextBytes_emptyArray() {
578	+	new SplittableRandom().nextBytes(new byte[0]);
579	+	}
580	+
581	+	public void testNextBytes_nullArray() {
582	+	try {
583	+	new SplittableRandom().nextBytes(null);
584	+	shouldThrow();
585	+	} catch (NullPointerException success) {}
586	+	}
587	+
588		}

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines