ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/SplittableRandomTest.java
(Generate patch)

Comparing jsr166/src/test/tck/SplittableRandomTest.java (file contents):
Revision 1.1 by dl, Thu Jul 11 19:08:12 2013 UTC vs.
Revision 1.21 by jsr166, Thu Nov 17 22:09:52 2016 UTC

# Line 3 | Line 3
3   * Expert Group and released to the public domain, as explained at
4   * http://creativecommons.org/publicdomain/zero/1.0/
5   */
6 < import junit.framework.*;
7 < import java.util.*;
6 >
7   import java.util.SplittableRandom;
8   import java.util.concurrent.atomic.AtomicInteger;
10 import java.util.concurrent.atomic.AtomicLong;
9   import java.util.concurrent.atomic.LongAdder;
10  
11 + import junit.framework.Test;
12 + import junit.framework.TestSuite;
13 +
14   public class SplittableRandomTest extends JSR166TestCase {
15  
16      public static void main(String[] args) {
17 <        junit.textui.TestRunner.run(suite());
17 >        main(suite(), args);
18      }
19      public static Test suite() {
20          return new TestSuite(SplittableRandomTest.class);
# Line 22 | Line 23 | public class SplittableRandomTest extend
23      /*
24       * Testing coverage notes:
25       *
26 <     * 1. Many of the test methods are adapted from ThreadLocalRandomTest
26 >     * 1. Many of the test methods are adapted from ThreadLocalRandomTest.
27       *
28 <     * 2. This set of tests do not check for random number generator
29 <     * quality. But we check for minimal API compliance by requiring
30 <     * that repeated calls to nextX methods, up to NCALLS tries,
31 <     * produce at least one different result. (In some possible
32 <     * universe, a "correct" implementation might fail, but the odds
33 <     * are vastly less than that of encountering a hardware failure
34 <     * while running the test.) For bounded nextX methods, we sample
35 <     * various intervals across multiples of primes. In other tests,
36 <     * we repeat under REPS different values.
28 >     * 2. These tests do not check for random number generator quality.
29 >     * But we check for minimal API compliance by requiring that
30 >     * repeated calls to nextX methods, up to NCALLS tries, produce at
31 >     * least two distinct results. (In some possible universe, a
32 >     * "correct" implementation might fail, but the odds are vastly
33 >     * less than that of encountering a hardware failure while running
34 >     * the test.) For bounded nextX methods, we sample various
35 >     * intervals across multiples of primes. In other tests, we repeat
36 >     * under REPS different values.
37       */
38  
39      // max numbers of calls to detect getting stuck on one value
40      static final int NCALLS = 10000;
41  
42      // max sampled int bound
43 <    static final int MAX_INT_BOUND = (1 << 28);
43 >    static final int MAX_INT_BOUND = (1 << 26);
44  
45 <    // Max sampled long bound
46 <    static final long MAX_LONG_BOUND = (1L << 42);
45 >    // max sampled long bound
46 >    static final long MAX_LONG_BOUND = (1L << 40);
47  
48      // Number of replications for other checks
49 <    static final int REPS = 20;
49 >    static final int REPS =
50 >        Integer.getInteger("SplittableRandomTest.reps", 4);
51  
52      /**
53 <     * Repeated calls to nextInt produce at least one different result
53 >     * Repeated calls to nextInt produce at least two distinct results
54       */
55      public void testNextInt() {
56          SplittableRandom sr = new SplittableRandom();
# Line 60 | Line 62 | public class SplittableRandomTest extend
62      }
63  
64      /**
65 <     * Repeated calls to nextLong produce at least one different result
65 >     * Repeated calls to nextLong produce at least two distinct results
66       */
67      public void testNextLong() {
68          SplittableRandom sr = new SplittableRandom();
# Line 72 | Line 74 | public class SplittableRandomTest extend
74      }
75  
76      /**
77 <     * Repeated calls to nextDouble produce at least one different result
77 >     * Repeated calls to nextDouble produce at least two distinct results
78       */
79      public void testNextDouble() {
80          SplittableRandom sr = new SplittableRandom();
81          double f = sr.nextDouble();
82 <        double i = 0;
82 >        int i = 0;
83          while (i < NCALLS && sr.nextDouble() == f)
84              ++i;
85          assertTrue(i < NCALLS);
# Line 88 | Line 90 | public class SplittableRandomTest extend
90       * same values for nextLong.
91       */
92      public void testSeedConstructor() {
93 <        for (long seed = 2; seed < MAX_LONG_BOUND; seed += 15485863)  {
93 >        for (long seed = 2; seed < MAX_LONG_BOUND; seed += 15485863) {
94              SplittableRandom sr1 = new SplittableRandom(seed);
95              SplittableRandom sr2 = new SplittableRandom(seed);
96 <            for (int i = 0; i < REPS; ++i)
96 >            for (int i = 0; i < REPS; ++i)
97                  assertEquals(sr1.nextLong(), sr2.nextLong());
98          }
99      }
# Line 127 | Line 129 | public class SplittableRandomTest extend
129      }
130  
131      /**
132 <     * nextInt(negative) throws IllegalArgumentException;
132 >     * nextInt(non-positive) throws IllegalArgumentException
133       */
134 <    public void testNextIntBoundedNeg() {
134 >    public void testNextIntBoundNonPositive() {
135          SplittableRandom sr = new SplittableRandom();
136 <        try {
137 <            int f = sr.nextInt(-17);
138 <            shouldThrow();
139 <        } catch (IllegalArgumentException success) {}
136 >        Runnable[] throwingActions = {
137 >            () -> sr.nextInt(-17),
138 >            () -> sr.nextInt(0),
139 >            () -> sr.nextInt(Integer.MIN_VALUE),
140 >        };
141 >        assertThrows(IllegalArgumentException.class, throwingActions);
142      }
143  
144      /**
145 <     * nextInt(least >= bound) throws IllegalArgumentException;
145 >     * nextInt(least >= bound) throws IllegalArgumentException
146       */
147      public void testNextIntBadBounds() {
148          SplittableRandom sr = new SplittableRandom();
149 <        try {
150 <            int f = sr.nextInt(17, 2);
151 <            shouldThrow();
152 <        } catch (IllegalArgumentException success) {}
149 >        Runnable[] throwingActions = {
150 >            () -> sr.nextInt(17, 2),
151 >            () -> sr.nextInt(-42, -42),
152 >            () -> sr.nextInt(Integer.MAX_VALUE, Integer.MIN_VALUE),
153 >        };
154 >        assertThrows(IllegalArgumentException.class, throwingActions);
155      }
156  
157      /**
158       * nextInt(bound) returns 0 <= value < bound;
159 <     * repeated calls produce at least one different result
159 >     * repeated calls produce at least two distinct results
160       */
161      public void testNextIntBounded() {
162          SplittableRandom sr = new SplittableRandom();
163 +        for (int i = 0; i < 2; i++) assertEquals(0, sr.nextInt(1));
164          // sample bound space across prime number increments
165          for (int bound = 2; bound < MAX_INT_BOUND; bound += 524959) {
166              int f = sr.nextInt(bound);
# Line 171 | Line 178 | public class SplittableRandomTest extend
178  
179      /**
180       * nextInt(least, bound) returns least <= value < bound;
181 <     * repeated calls produce at least one different result
181 >     * repeated calls produce at least two distinct results
182       */
183      public void testNextIntBounded2() {
184          SplittableRandom sr = new SplittableRandom();
# Line 192 | Line 199 | public class SplittableRandomTest extend
199      }
200  
201      /**
202 <     * nextLong(negative) throws IllegalArgumentException;
202 >     * nextLong(non-positive) throws IllegalArgumentException
203       */
204 <    public void testNextLongBoundedNeg() {
204 >    public void testNextLongBoundNonPositive() {
205          SplittableRandom sr = new SplittableRandom();
206 <        try {
207 <            long f = sr.nextLong(-17);
208 <            shouldThrow();
209 <        } catch (IllegalArgumentException success) {}
206 >        Runnable[] throwingActions = {
207 >            () -> sr.nextLong(-17L),
208 >            () -> sr.nextLong(0L),
209 >            () -> sr.nextLong(Long.MIN_VALUE),
210 >        };
211 >        assertThrows(IllegalArgumentException.class, throwingActions);
212      }
213  
214      /**
215 <     * nextLong(least >= bound) throws IllegalArgumentException;
215 >     * nextLong(least >= bound) throws IllegalArgumentException
216       */
217      public void testNextLongBadBounds() {
218          SplittableRandom sr = new SplittableRandom();
219 <        try {
220 <            long f = sr.nextLong(17, 2);
221 <            shouldThrow();
222 <        } catch (IllegalArgumentException success) {}
219 >        Runnable[] throwingActions = {
220 >            () -> sr.nextLong(17L, 2L),
221 >            () -> sr.nextLong(-42L, -42L),
222 >            () -> sr.nextLong(Long.MAX_VALUE, Long.MIN_VALUE),
223 >        };
224 >        assertThrows(IllegalArgumentException.class, throwingActions);
225      }
226  
227      /**
228       * nextLong(bound) returns 0 <= value < bound;
229 <     * repeated calls produce at least one different result
229 >     * repeated calls produce at least two distinct results
230       */
231      public void testNextLongBounded() {
232          SplittableRandom sr = new SplittableRandom();
233 +        for (int i = 0; i < 2; i++) assertEquals(0L, sr.nextLong(1L));
234          for (long bound = 2; bound < MAX_LONG_BOUND; bound += 15485863) {
235              long f = sr.nextLong(bound);
236              assertTrue(0 <= f && f < bound);
# Line 235 | Line 247 | public class SplittableRandomTest extend
247  
248      /**
249       * nextLong(least, bound) returns least <= value < bound;
250 <     * repeated calls produce at least one different result
250 >     * repeated calls produce at least two distinct results
251       */
252      public void testNextLongBounded2() {
253          SplittableRandom sr = new SplittableRandom();
# Line 256 | Line 268 | public class SplittableRandomTest extend
268      }
269  
270      /**
271 +     * nextDouble(non-positive) throws IllegalArgumentException
272 +     */
273 +    public void testNextDoubleBoundNonPositive() {
274 +        SplittableRandom sr = new SplittableRandom();
275 +        Runnable[] throwingActions = {
276 +            () -> sr.nextDouble(-17.0d),
277 +            () -> sr.nextDouble(0.0d),
278 +            () -> sr.nextDouble(-Double.MIN_VALUE),
279 +            () -> sr.nextDouble(Double.NEGATIVE_INFINITY),
280 +            () -> sr.nextDouble(Double.NaN),
281 +        };
282 +        assertThrows(IllegalArgumentException.class, throwingActions);
283 +    }
284 +
285 +    /**
286 +     * nextDouble(! (least < bound)) throws IllegalArgumentException
287 +     */
288 +    public void testNextDoubleBadBounds() {
289 +        SplittableRandom sr = new SplittableRandom();
290 +        Runnable[] throwingActions = {
291 +            () -> sr.nextDouble(17.0d, 2.0d),
292 +            () -> sr.nextDouble(-42.0d, -42.0d),
293 +            () -> sr.nextDouble(Double.MAX_VALUE, Double.MIN_VALUE),
294 +            () -> sr.nextDouble(Double.NaN, 0.0d),
295 +            () -> sr.nextDouble(0.0d, Double.NaN),
296 +        };
297 +        assertThrows(IllegalArgumentException.class, throwingActions);
298 +    }
299 +
300 +    // TODO: Test infinite bounds!
301 +    //() -> sr.nextDouble(Double.NEGATIVE_INFINITY, 0.0d),
302 +    //() -> sr.nextDouble(0.0d, Double.POSITIVE_INFINITY),
303 +
304 +    /**
305       * nextDouble(least, bound) returns least <= value < bound;
306 <     * repeated calls produce at least one different result
306 >     * repeated calls produce at least two distinct results
307       */
308      public void testNextDoubleBounded2() {
309          SplittableRandom sr = new SplittableRandom();
# Line 283 | Line 329 | public class SplittableRandomTest extend
329       */
330      public void testBadStreamSize() {
331          SplittableRandom r = new SplittableRandom();
332 <        try {
333 <            java.util.stream.IntStream x = r.ints(-1L);
334 <            shouldThrow();
335 <        } catch (IllegalArgumentException ok) {
336 <        }
337 <        try {
338 <            java.util.stream.LongStream x = r.longs(-1L);
339 <            shouldThrow();
340 <        } catch (IllegalArgumentException ok) {
295 <        }
296 <        try {
297 <            java.util.stream.DoubleStream x = r.doubles(-1L);
298 <            shouldThrow();
299 <        } catch (IllegalArgumentException ok) {
300 <        }
332 >        Runnable[] throwingActions = {
333 >            () -> { java.util.stream.IntStream x = r.ints(-1L); },
334 >            () -> { java.util.stream.IntStream x = r.ints(-1L, 2, 3); },
335 >            () -> { java.util.stream.LongStream x = r.longs(-1L); },
336 >            () -> { java.util.stream.LongStream x = r.longs(-1L, -1L, 1L); },
337 >            () -> { java.util.stream.DoubleStream x = r.doubles(-1L); },
338 >            () -> { java.util.stream.DoubleStream x = r.doubles(-1L, .5, .6); },
339 >        };
340 >        assertThrows(IllegalArgumentException.class, throwingActions);
341      }
342  
343      /**
# Line 306 | Line 346 | public class SplittableRandomTest extend
346       */
347      public void testBadStreamBounds() {
348          SplittableRandom r = new SplittableRandom();
349 <        try {
350 <            java.util.stream.IntStream x = r.ints(2, 1);
351 <            shouldThrow();
352 <        } catch (IllegalArgumentException ok) {
353 <        }
354 <        try {
355 <            java.util.stream.LongStream x = r.longs(1, -2);
356 <            shouldThrow();
357 <        } catch (IllegalArgumentException ok) {
318 <        }
319 <        try {
320 <            java.util.stream.DoubleStream x = r.doubles(0, 0);
321 <            shouldThrow();
322 <        } catch (IllegalArgumentException ok) {
323 <        }
349 >        Runnable[] throwingActions = {
350 >            () -> { java.util.stream.IntStream x = r.ints(2, 1); },
351 >            () -> { java.util.stream.IntStream x = r.ints(10, 42, 42); },
352 >            () -> { java.util.stream.LongStream x = r.longs(-1L, -1L); },
353 >            () -> { java.util.stream.LongStream x = r.longs(10, 1L, -2L); },
354 >            () -> { java.util.stream.DoubleStream x = r.doubles(0.0, 0.0); },
355 >            () -> { java.util.stream.DoubleStream x = r.doubles(10, .5, .4); },
356 >        };
357 >        assertThrows(IllegalArgumentException.class, throwingActions);
358      }
359  
360      /**
# Line 332 | Line 366 | public class SplittableRandomTest extend
366          long size = 0;
367          for (int reps = 0; reps < REPS; ++reps) {
368              counter.reset();
369 <            r.ints(size).parallel().forEach(x -> {counter.increment();});
370 <            assertEquals(counter.sum(), size);
369 >            r.ints(size).parallel().forEach(x -> counter.increment());
370 >            assertEquals(size, counter.sum());
371              size += 524959;
372          }
373      }
# Line 347 | Line 381 | public class SplittableRandomTest extend
381          long size = 0;
382          for (int reps = 0; reps < REPS; ++reps) {
383              counter.reset();
384 <            r.longs(size).parallel().forEach(x -> {counter.increment();});
385 <            assertEquals(counter.sum(), size);
384 >            r.longs(size).parallel().forEach(x -> counter.increment());
385 >            assertEquals(size, counter.sum());
386              size += 524959;
387          }
388      }
# Line 362 | Line 396 | public class SplittableRandomTest extend
396          long size = 0;
397          for (int reps = 0; reps < REPS; ++reps) {
398              counter.reset();
399 <            r.doubles(size).parallel().forEach(x -> {counter.increment();});
400 <            assertEquals(counter.sum(), size);
399 >            r.doubles(size).parallel().forEach(x -> counter.increment());
400 >            assertEquals(size, counter.sum());
401              size += 524959;
402          }
403      }
# Line 378 | Line 412 | public class SplittableRandomTest extend
412          for (int least = -15485867; least < MAX_INT_BOUND; least += 524959) {
413              for (int bound = least + 2; bound > least && bound < MAX_INT_BOUND; bound += 67867967) {
414                  final int lo = least, hi = bound;
415 <                r.ints(size, lo, hi).parallel().
416 <                    forEach(x -> {if (x < lo || x >= hi)
417 <                                fails.getAndIncrement(); });
415 >                r.ints(size, lo, hi).parallel().forEach(
416 >                    x -> {
417 >                        if (x < lo || x >= hi)
418 >                            fails.getAndIncrement(); });
419              }
420          }
421 <        assertEquals(fails.get(), 0);
421 >        assertEquals(0, fails.get());
422      }
423  
424      /**
# Line 396 | Line 431 | public class SplittableRandomTest extend
431          for (long least = -86028121; least < MAX_LONG_BOUND; least += 1982451653L) {
432              for (long bound = least + 2; bound > least && bound < MAX_LONG_BOUND; bound += Math.abs(bound * 7919)) {
433                  final long lo = least, hi = bound;
434 <                r.longs(size, lo, hi).parallel().
435 <                    forEach(x -> {if (x < lo || x >= hi)
436 <                                fails.getAndIncrement(); });
434 >                r.longs(size, lo, hi).parallel().forEach(
435 >                    x -> {
436 >                        if (x < lo || x >= hi)
437 >                            fails.getAndIncrement(); });
438              }
439          }
440 <        assertEquals(fails.get(), 0);
440 >        assertEquals(0, fails.get());
441      }
442  
443      /**
# Line 414 | Line 450 | public class SplittableRandomTest extend
450          for (double least = 0.00011; least < 1.0e20; least *= 9) {
451              for (double bound = least * 1.0011; bound < 1.0e20; bound *= 17) {
452                  final double lo = least, hi = bound;
453 <                r.doubles(size, lo, hi).parallel().
454 <                    forEach(x -> {if (x < lo || x >= hi)
455 <                                fails.getAndIncrement(); });
453 >                r.doubles(size, lo, hi).parallel().forEach(
454 >                    x -> {
455 >                        if (x < lo || x >= hi)
456 >                            fails.getAndIncrement(); });
457              }
458          }
459 <        assertEquals(fails.get(), 0);
459 >        assertEquals(0, fails.get());
460 >    }
461 >
462 >    /**
463 >     * A parallel unsized stream of ints generates at least 100 values
464 >     */
465 >    public void testUnsizedIntsCount() {
466 >        LongAdder counter = new LongAdder();
467 >        SplittableRandom r = new SplittableRandom();
468 >        long size = 100;
469 >        r.ints().limit(size).parallel().forEach(x -> counter.increment());
470 >        assertEquals(size, counter.sum());
471 >    }
472 >
473 >    /**
474 >     * A parallel unsized stream of longs generates at least 100 values
475 >     */
476 >    public void testUnsizedLongsCount() {
477 >        LongAdder counter = new LongAdder();
478 >        SplittableRandom r = new SplittableRandom();
479 >        long size = 100;
480 >        r.longs().limit(size).parallel().forEach(x -> counter.increment());
481 >        assertEquals(size, counter.sum());
482 >    }
483 >
484 >    /**
485 >     * A parallel unsized stream of doubles generates at least 100 values
486 >     */
487 >    public void testUnsizedDoublesCount() {
488 >        LongAdder counter = new LongAdder();
489 >        SplittableRandom r = new SplittableRandom();
490 >        long size = 100;
491 >        r.doubles().limit(size).parallel().forEach(x -> counter.increment());
492 >        assertEquals(size, counter.sum());
493 >    }
494 >
495 >    /**
496 >     * A sequential unsized stream of ints generates at least 100 values
497 >     */
498 >    public void testUnsizedIntsCountSeq() {
499 >        LongAdder counter = new LongAdder();
500 >        SplittableRandom r = new SplittableRandom();
501 >        long size = 100;
502 >        r.ints().limit(size).forEach(x -> counter.increment());
503 >        assertEquals(size, counter.sum());
504 >    }
505 >
506 >    /**
507 >     * A sequential unsized stream of longs generates at least 100 values
508 >     */
509 >    public void testUnsizedLongsCountSeq() {
510 >        LongAdder counter = new LongAdder();
511 >        SplittableRandom r = new SplittableRandom();
512 >        long size = 100;
513 >        r.longs().limit(size).forEach(x -> counter.increment());
514 >        assertEquals(size, counter.sum());
515 >    }
516 >
517 >    /**
518 >     * A sequential unsized stream of doubles generates at least 100 values
519 >     */
520 >    public void testUnsizedDoublesCountSeq() {
521 >        LongAdder counter = new LongAdder();
522 >        SplittableRandom r = new SplittableRandom();
523 >        long size = 100;
524 >        r.doubles().limit(size).forEach(x -> counter.increment());
525 >        assertEquals(size, counter.sum());
526      }
527  
528   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines