ViewVC Help

View File | Revision Log | Show Annotations | Download File | Root Listing

root/jsr166/jsr166/src/test/tck/SplittableRandomTest.java

Comparing jsr166/src/test/tck/SplittableRandomTest.java (file contents):
Revision 1.1 by dl, Thu Jul 11 19:08:12 2013 UTC vs.
Revision 1.23 by jsr166, Fri Oct 13 02:34:59 2017 UTC

#	Line 3 | Line 3
3		* Expert Group and released to the public domain, as explained at
4		* http://creativecommons.org/publicdomain/zero/1.0/
5		*/
6	<	import junit.framework.*;
7	<	import java.util.*;
6	>
7	>	import java.util.Arrays;
8	>	import java.util.ArrayList;
9	>	import java.util.List;
10		import java.util.SplittableRandom;
11		import java.util.concurrent.atomic.AtomicInteger;
10	–	import java.util.concurrent.atomic.AtomicLong;
12		import java.util.concurrent.atomic.LongAdder;
13	+	import java.lang.reflect.Method;
14	+	import java.util.function.Predicate;
15	+	import java.util.stream.Collectors;
16	+
17	+	import junit.framework.Test;
18	+	import junit.framework.TestSuite;
19
20		public class SplittableRandomTest extends JSR166TestCase {
21
22		public static void main(String[] args) {
23	<	junit.textui.TestRunner.run(suite());
23	>	main(suite(), args);
24		}
25		public static Test suite() {
26		return new TestSuite(SplittableRandomTest.class);
#	Line 22 | Line 29 | public class SplittableRandomTest extend
29		/*
30		* Testing coverage notes:
31		*
32	<	* 1. Many of the test methods are adapted from ThreadLocalRandomTest
32	>	* 1. Many of the test methods are adapted from ThreadLocalRandomTest.
33		*
34	<	* 2. This set of tests do not check for random number generator
35	<	* quality. But we check for minimal API compliance by requiring
36	<	* that repeated calls to nextX methods, up to NCALLS tries,
37	<	* produce at least one different result. (In some possible
38	<	* universe, a "correct" implementation might fail, but the odds
39	<	* are vastly less than that of encountering a hardware failure
40	<	* while running the test.) For bounded nextX methods, we sample
41	<	* various intervals across multiples of primes. In other tests,
42	<	* we repeat under REPS different values.
34	>	* 2. These tests do not check for random number generator quality.
35	>	* But we check for minimal API compliance by requiring that
36	>	* repeated calls to nextX methods, up to NCALLS tries, produce at
37	>	* least two distinct results. (In some possible universe, a
38	>	* "correct" implementation might fail, but the odds are vastly
39	>	* less than that of encountering a hardware failure while running
40	>	* the test.) For bounded nextX methods, we sample various
41	>	* intervals across multiples of primes. In other tests, we repeat
42	>	* under REPS different values.
43		*/
44
45		// max numbers of calls to detect getting stuck on one value
46		static final int NCALLS = 10000;
47
48		// max sampled int bound
49	<	static final int MAX_INT_BOUND = (1 << 28);
49	>	static final int MAX_INT_BOUND = (1 << 26);
50
51	<	// Max sampled long bound
52	<	static final long MAX_LONG_BOUND = (1L << 42);
51	>	// max sampled long bound
52	>	static final long MAX_LONG_BOUND = (1L << 40);
53
54		// Number of replications for other checks
55	<	static final int REPS = 20;
55	>	static final int REPS =
56	>	Integer.getInteger("SplittableRandomTest.reps", 4);
57
58		/**
59	<	* Repeated calls to nextInt produce at least one different result
59	>	* Repeated calls to nextInt produce at least two distinct results
60		*/
61		public void testNextInt() {
62		SplittableRandom sr = new SplittableRandom();
#	Line 60 | Line 68 | public class SplittableRandomTest extend
68		}
69
70		/**
71	<	* Repeated calls to nextLong produce at least one different result
71	>	* Repeated calls to nextLong produce at least two distinct results
72		*/
73		public void testNextLong() {
74		SplittableRandom sr = new SplittableRandom();
#	Line 72 | Line 80 | public class SplittableRandomTest extend
80		}
81
82		/**
83	<	* Repeated calls to nextDouble produce at least one different result
83	>	* Repeated calls to nextDouble produce at least two distinct results
84		*/
85		public void testNextDouble() {
86		SplittableRandom sr = new SplittableRandom();
87		double f = sr.nextDouble();
88	<	double i = 0;
88	>	int i = 0;
89		while (i < NCALLS && sr.nextDouble() == f)
90		++i;
91		assertTrue(i < NCALLS);
#	Line 88 | Line 96 | public class SplittableRandomTest extend
96		* same values for nextLong.
97		*/
98		public void testSeedConstructor() {
99	<	for (long seed = 2; seed < MAX_LONG_BOUND; seed += 15485863)  {
99	>	for (long seed = 2; seed < MAX_LONG_BOUND; seed += 15485863) {
100		SplittableRandom sr1 = new SplittableRandom(seed);
101		SplittableRandom sr2 = new SplittableRandom(seed);
102	<	for (int i = 0; i < REPS; ++i)
102	>	for (int i = 0; i < REPS; ++i)
103		assertEquals(sr1.nextLong(), sr2.nextLong());
104		}
105		}
#	Line 127 | Line 135 | public class SplittableRandomTest extend
135		}
136
137		/**
138	<	* nextInt(negative) throws IllegalArgumentException;
138	>	* nextInt(non-positive) throws IllegalArgumentException
139		*/
140	<	public void testNextIntBoundedNeg() {
140	>	public void testNextIntBoundNonPositive() {
141		SplittableRandom sr = new SplittableRandom();
142	<	try {
143	<	int f = sr.nextInt(-17);
144	<	shouldThrow();
145	<	} catch (IllegalArgumentException success) {}
142	>	Runnable[] throwingActions = {
143	>	() -> sr.nextInt(-17),
144	>	() -> sr.nextInt(0),
145	>	() -> sr.nextInt(Integer.MIN_VALUE),
146	>	};
147	>	assertThrows(IllegalArgumentException.class, throwingActions);
148		}
149
150		/**
151	<	* nextInt(least >= bound) throws IllegalArgumentException;
151	>	* nextInt(least >= bound) throws IllegalArgumentException
152		*/
153		public void testNextIntBadBounds() {
154		SplittableRandom sr = new SplittableRandom();
155	<	try {
156	<	int f = sr.nextInt(17, 2);
157	<	shouldThrow();
158	<	} catch (IllegalArgumentException success) {}
155	>	Runnable[] throwingActions = {
156	>	() -> sr.nextInt(17, 2),
157	>	() -> sr.nextInt(-42, -42),
158	>	() -> sr.nextInt(Integer.MAX_VALUE, Integer.MIN_VALUE),
159	>	};
160	>	assertThrows(IllegalArgumentException.class, throwingActions);
161		}
162
163		/**
164		* nextInt(bound) returns 0 <= value < bound;
165	<	* repeated calls produce at least one different result
165	>	* repeated calls produce at least two distinct results
166		*/
167		public void testNextIntBounded() {
168		SplittableRandom sr = new SplittableRandom();
169	+	for (int i = 0; i < 2; i++) assertEquals(0, sr.nextInt(1));
170		// sample bound space across prime number increments
171		for (int bound = 2; bound < MAX_INT_BOUND; bound += 524959) {
172		int f = sr.nextInt(bound);
#	Line 171 | Line 184 | public class SplittableRandomTest extend
184
185		/**
186		* nextInt(least, bound) returns least <= value < bound;
187	<	* repeated calls produce at least one different result
187	>	* repeated calls produce at least two distinct results
188		*/
189		public void testNextIntBounded2() {
190		SplittableRandom sr = new SplittableRandom();
#	Line 192 | Line 205 | public class SplittableRandomTest extend
205		}
206
207		/**
208	<	* nextLong(negative) throws IllegalArgumentException;
208	>	* nextLong(non-positive) throws IllegalArgumentException
209		*/
210	<	public void testNextLongBoundedNeg() {
210	>	public void testNextLongBoundNonPositive() {
211		SplittableRandom sr = new SplittableRandom();
212	<	try {
213	<	long f = sr.nextLong(-17);
214	<	shouldThrow();
215	<	} catch (IllegalArgumentException success) {}
212	>	Runnable[] throwingActions = {
213	>	() -> sr.nextLong(-17L),
214	>	() -> sr.nextLong(0L),
215	>	() -> sr.nextLong(Long.MIN_VALUE),
216	>	};
217	>	assertThrows(IllegalArgumentException.class, throwingActions);
218		}
219
220		/**
221	<	* nextLong(least >= bound) throws IllegalArgumentException;
221	>	* nextLong(least >= bound) throws IllegalArgumentException
222		*/
223		public void testNextLongBadBounds() {
224		SplittableRandom sr = new SplittableRandom();
225	<	try {
226	<	long f = sr.nextLong(17, 2);
227	<	shouldThrow();
228	<	} catch (IllegalArgumentException success) {}
225	>	Runnable[] throwingActions = {
226	>	() -> sr.nextLong(17L, 2L),
227	>	() -> sr.nextLong(-42L, -42L),
228	>	() -> sr.nextLong(Long.MAX_VALUE, Long.MIN_VALUE),
229	>	};
230	>	assertThrows(IllegalArgumentException.class, throwingActions);
231		}
232
233		/**
234		* nextLong(bound) returns 0 <= value < bound;
235	<	* repeated calls produce at least one different result
235	>	* repeated calls produce at least two distinct results
236		*/
237		public void testNextLongBounded() {
238		SplittableRandom sr = new SplittableRandom();
239	+	for (int i = 0; i < 2; i++) assertEquals(0L, sr.nextLong(1L));
240		for (long bound = 2; bound < MAX_LONG_BOUND; bound += 15485863) {
241		long f = sr.nextLong(bound);
242		assertTrue(0 <= f && f < bound);
#	Line 235 | Line 253 | public class SplittableRandomTest extend
253
254		/**
255		* nextLong(least, bound) returns least <= value < bound;
256	<	* repeated calls produce at least one different result
256	>	* repeated calls produce at least two distinct results
257		*/
258		public void testNextLongBounded2() {
259		SplittableRandom sr = new SplittableRandom();
#	Line 256 | Line 274 | public class SplittableRandomTest extend
274		}
275
276		/**
277	+	* nextDouble(non-positive) throws IllegalArgumentException
278	+	*/
279	+	public void testNextDoubleBoundNonPositive() {
280	+	SplittableRandom sr = new SplittableRandom();
281	+	Runnable[] throwingActions = {
282	+	() -> sr.nextDouble(-17.0d),
283	+	() -> sr.nextDouble(0.0d),
284	+	() -> sr.nextDouble(-Double.MIN_VALUE),
285	+	() -> sr.nextDouble(Double.NEGATIVE_INFINITY),
286	+	() -> sr.nextDouble(Double.NaN),
287	+	};
288	+	assertThrows(IllegalArgumentException.class, throwingActions);
289	+	}
290	+
291	+	/**
292	+	* nextDouble(! (least < bound)) throws IllegalArgumentException
293	+	*/
294	+	public void testNextDoubleBadBounds() {
295	+	SplittableRandom sr = new SplittableRandom();
296	+	Runnable[] throwingActions = {
297	+	() -> sr.nextDouble(17.0d, 2.0d),
298	+	() -> sr.nextDouble(-42.0d, -42.0d),
299	+	() -> sr.nextDouble(Double.MAX_VALUE, Double.MIN_VALUE),
300	+	() -> sr.nextDouble(Double.NaN, 0.0d),
301	+	() -> sr.nextDouble(0.0d, Double.NaN),
302	+	};
303	+	assertThrows(IllegalArgumentException.class, throwingActions);
304	+	}
305	+
306	+	// TODO: Test infinite bounds!
307	+	//() -> sr.nextDouble(Double.NEGATIVE_INFINITY, 0.0d),
308	+	//() -> sr.nextDouble(0.0d, Double.POSITIVE_INFINITY),
309	+
310	+	/**
311		* nextDouble(least, bound) returns least <= value < bound;
312	<	* repeated calls produce at least one different result
312	>	* repeated calls produce at least two distinct results
313		*/
314		public void testNextDoubleBounded2() {
315		SplittableRandom sr = new SplittableRandom();
#	Line 283 | Line 335 | public class SplittableRandomTest extend
335		*/
336		public void testBadStreamSize() {
337		SplittableRandom r = new SplittableRandom();
338	<	try {
339	<	java.util.stream.IntStream x = r.ints(-1L);
340	<	shouldThrow();
341	<	} catch (IllegalArgumentException ok) {
342	<	}
343	<	try {
344	<	java.util.stream.LongStream x = r.longs(-1L);
345	<	shouldThrow();
346	<	} catch (IllegalArgumentException ok) {
295	<	}
296	<	try {
297	<	java.util.stream.DoubleStream x = r.doubles(-1L);
298	<	shouldThrow();
299	<	} catch (IllegalArgumentException ok) {
300	<	}
338	>	Runnable[] throwingActions = {
339	>	() -> { java.util.stream.IntStream x = r.ints(-1L); },
340	>	() -> { java.util.stream.IntStream x = r.ints(-1L, 2, 3); },
341	>	() -> { java.util.stream.LongStream x = r.longs(-1L); },
342	>	() -> { java.util.stream.LongStream x = r.longs(-1L, -1L, 1L); },
343	>	() -> { java.util.stream.DoubleStream x = r.doubles(-1L); },
344	>	() -> { java.util.stream.DoubleStream x = r.doubles(-1L, .5, .6); },
345	>	};
346	>	assertThrows(IllegalArgumentException.class, throwingActions);
347		}
348
349		/**
#	Line 306 | Line 352 | public class SplittableRandomTest extend
352		*/
353		public void testBadStreamBounds() {
354		SplittableRandom r = new SplittableRandom();
355	<	try {
356	<	java.util.stream.IntStream x = r.ints(2, 1);
357	<	shouldThrow();
358	<	} catch (IllegalArgumentException ok) {
359	<	}
360	<	try {
361	<	java.util.stream.LongStream x = r.longs(1, -2);
362	<	shouldThrow();
363	<	} catch (IllegalArgumentException ok) {
318	<	}
319	<	try {
320	<	java.util.stream.DoubleStream x = r.doubles(0, 0);
321	<	shouldThrow();
322	<	} catch (IllegalArgumentException ok) {
323	<	}
355	>	Runnable[] throwingActions = {
356	>	() -> { java.util.stream.IntStream x = r.ints(2, 1); },
357	>	() -> { java.util.stream.IntStream x = r.ints(10, 42, 42); },
358	>	() -> { java.util.stream.LongStream x = r.longs(-1L, -1L); },
359	>	() -> { java.util.stream.LongStream x = r.longs(10, 1L, -2L); },
360	>	() -> { java.util.stream.DoubleStream x = r.doubles(0.0, 0.0); },
361	>	() -> { java.util.stream.DoubleStream x = r.doubles(10, .5, .4); },
362	>	};
363	>	assertThrows(IllegalArgumentException.class, throwingActions);
364		}
365
366		/**
#	Line 332 | Line 372 | public class SplittableRandomTest extend
372		long size = 0;
373		for (int reps = 0; reps < REPS; ++reps) {
374		counter.reset();
375	<	r.ints(size).parallel().forEach(x -> {counter.increment();});
376	<	assertEquals(counter.sum(), size);
375	>	r.ints(size).parallel().forEach(x -> counter.increment());
376	>	assertEquals(size, counter.sum());
377		size += 524959;
378		}
379		}
#	Line 347 | Line 387 | public class SplittableRandomTest extend
387		long size = 0;
388		for (int reps = 0; reps < REPS; ++reps) {
389		counter.reset();
390	<	r.longs(size).parallel().forEach(x -> {counter.increment();});
391	<	assertEquals(counter.sum(), size);
390	>	r.longs(size).parallel().forEach(x -> counter.increment());
391	>	assertEquals(size, counter.sum());
392		size += 524959;
393		}
394		}
#	Line 362 | Line 402 | public class SplittableRandomTest extend
402		long size = 0;
403		for (int reps = 0; reps < REPS; ++reps) {
404		counter.reset();
405	<	r.doubles(size).parallel().forEach(x -> {counter.increment();});
406	<	assertEquals(counter.sum(), size);
405	>	r.doubles(size).parallel().forEach(x -> counter.increment());
406	>	assertEquals(size, counter.sum());
407		size += 524959;
408		}
409		}
#	Line 378 | Line 418 | public class SplittableRandomTest extend
418		for (int least = -15485867; least < MAX_INT_BOUND; least += 524959) {
419		for (int bound = least + 2; bound > least && bound < MAX_INT_BOUND; bound += 67867967) {
420		final int lo = least, hi = bound;
421	<	r.ints(size, lo, hi).parallel().
422	<	forEach(x -> {if (x < lo || x >= hi)
423	<	fails.getAndIncrement(); });
421	>	r.ints(size, lo, hi).parallel().forEach(
422	>	x -> {
423	>	if (x < lo || x >= hi)
424	>	fails.getAndIncrement(); });
425		}
426		}
427	<	assertEquals(fails.get(), 0);
427	>	assertEquals(0, fails.get());
428		}
429
430		/**
#	Line 396 | Line 437 | public class SplittableRandomTest extend
437		for (long least = -86028121; least < MAX_LONG_BOUND; least += 1982451653L) {
438		for (long bound = least + 2; bound > least && bound < MAX_LONG_BOUND; bound += Math.abs(bound * 7919)) {
439		final long lo = least, hi = bound;
440	<	r.longs(size, lo, hi).parallel().
441	<	forEach(x -> {if (x < lo || x >= hi)
442	<	fails.getAndIncrement(); });
440	>	r.longs(size, lo, hi).parallel().forEach(
441	>	x -> {
442	>	if (x < lo || x >= hi)
443	>	fails.getAndIncrement(); });
444		}
445		}
446	<	assertEquals(fails.get(), 0);
446	>	assertEquals(0, fails.get());
447		}
448
449		/**
#	Line 414 | Line 456 | public class SplittableRandomTest extend
456		for (double least = 0.00011; least < 1.0e20; least *= 9) {
457		for (double bound = least * 1.0011; bound < 1.0e20; bound *= 17) {
458		final double lo = least, hi = bound;
459	<	r.doubles(size, lo, hi).parallel().
460	<	forEach(x -> {if (x < lo || x >= hi)
461	<	fails.getAndIncrement(); });
459	>	r.doubles(size, lo, hi).parallel().forEach(
460	>	x -> {
461	>	if (x < lo || x >= hi)
462	>	fails.getAndIncrement(); });
463		}
464		}
465	<	assertEquals(fails.get(), 0);
465	>	assertEquals(0, fails.get());
466	>	}
467	>
468	>	/**
469	>	* A parallel unsized stream of ints generates at least 100 values
470	>	*/
471	>	public void testUnsizedIntsCount() {
472	>	LongAdder counter = new LongAdder();
473	>	SplittableRandom r = new SplittableRandom();
474	>	long size = 100;
475	>	r.ints().limit(size).parallel().forEach(x -> counter.increment());
476	>	assertEquals(size, counter.sum());
477	>	}
478	>
479	>	/**
480	>	* A parallel unsized stream of longs generates at least 100 values
481	>	*/
482	>	public void testUnsizedLongsCount() {
483	>	LongAdder counter = new LongAdder();
484	>	SplittableRandom r = new SplittableRandom();
485	>	long size = 100;
486	>	r.longs().limit(size).parallel().forEach(x -> counter.increment());
487	>	assertEquals(size, counter.sum());
488	>	}
489	>
490	>	/**
491	>	* A parallel unsized stream of doubles generates at least 100 values
492	>	*/
493	>	public void testUnsizedDoublesCount() {
494	>	LongAdder counter = new LongAdder();
495	>	SplittableRandom r = new SplittableRandom();
496	>	long size = 100;
497	>	r.doubles().limit(size).parallel().forEach(x -> counter.increment());
498	>	assertEquals(size, counter.sum());
499	>	}
500	>
501	>	/**
502	>	* A sequential unsized stream of ints generates at least 100 values
503	>	*/
504	>	public void testUnsizedIntsCountSeq() {
505	>	LongAdder counter = new LongAdder();
506	>	SplittableRandom r = new SplittableRandom();
507	>	long size = 100;
508	>	r.ints().limit(size).forEach(x -> counter.increment());
509	>	assertEquals(size, counter.sum());
510	>	}
511	>
512	>	/**
513	>	* A sequential unsized stream of longs generates at least 100 values
514	>	*/
515	>	public void testUnsizedLongsCountSeq() {
516	>	LongAdder counter = new LongAdder();
517	>	SplittableRandom r = new SplittableRandom();
518	>	long size = 100;
519	>	r.longs().limit(size).forEach(x -> counter.increment());
520	>	assertEquals(size, counter.sum());
521	>	}
522	>
523	>	/**
524	>	* A sequential unsized stream of doubles generates at least 100 values
525	>	*/
526	>	public void testUnsizedDoublesCountSeq() {
527	>	LongAdder counter = new LongAdder();
528	>	SplittableRandom r = new SplittableRandom();
529	>	long size = 100;
530	>	r.doubles().limit(size).forEach(x -> counter.increment());
531	>	assertEquals(size, counter.sum());
532	>	}
533	>
534	>	/**
535	>	* SplittableRandom should implement most of Random's public methods
536	>	*/
537	>	public void testShouldImplementMostRandomMethods() throws Throwable {
538	>	Predicate<Method> wasForgotten = method -> {
539	>	String name = method.getName();
540	>	// some methods deliberately not implemented
541	>	if (name.equals("setSeed")) return false;
542	>	if (name.equals("nextFloat")) return false;
543	>	if (name.equals("nextGaussian")) return false;
544	>	try {
545	>	SplittableRandom.class.getMethod(
546	>	method.getName(), method.getParameterTypes());
547	>	} catch (ReflectiveOperationException ex) {
548	>	return true;
549	>	}
550	>	return false;
551	>	};
552	>	List<Method> forgotten =
553	>	Arrays.stream(java.util.Random.class.getMethods())
554	>	.filter(wasForgotten)
555	>	.collect(Collectors.toList());
556	>	if (!forgotten.isEmpty())
557	>	throw new AssertionError("Please implement: " + forgotten);
558	>	}
559	>
560	>	/**
561	>	* Repeated calls to nextBytes produce at least values of different signs for every byte
562	>	*/
563	>	public void testNextBytes() {
564	>	SplittableRandom sr = new SplittableRandom();
565	>	int n = sr.nextInt(1, 20);
566	>	byte[] bytes = new byte[n];
567	>	outer:
568	>	for (int i = 0; i < n; i++) {
569	>	for (int tries = NCALLS; tries-->0; ) {
570	>	byte before = bytes[i];
571	>	sr.nextBytes(bytes);
572	>	byte after = bytes[i];
573	>	if (after * before < 0)
574	>	continue outer;
575	>	}
576	>	fail("not enough variation in random bytes");
577	>	}
578	>	}
579	>
580	>	/**
581	>	* Filling an empty array with random bytes succeeds without effect.
582	>	*/
583	>	public void testNextBytes_emptyArray() {
584	>	new SplittableRandom().nextBytes(new byte[0]);
585	>	}
586	>
587	>	public void testNextBytes_nullArray() {
588	>	try {
589	>	new SplittableRandom().nextBytes(null);
590	>	shouldThrow();
591	>	} catch (NullPointerException success) {}
592		}
593
594		}

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines