ViewVC Help

View File | Revision Log | Show Annotations | Download File | Root Listing

root/jsr166/jsr166/src/test/tck/SplittableRandomTest.java

Comparing jsr166/src/test/tck/SplittableRandomTest.java (file contents):
Revision 1.15 by jsr166, Wed Dec 31 16:44:02 2014 UTC vs.
Revision 1.25 by jsr166, Fri Feb 22 19:27:47 2019 UTC

#	Line 3 | Line 3
3		* Expert Group and released to the public domain, as explained at
4		* http://creativecommons.org/publicdomain/zero/1.0/
5		*/
6	<	import junit.framework.*;
7	<	import java.util.*;
6	>
7	>	import java.util.Arrays;
8	>	import java.util.List;
9		import java.util.SplittableRandom;
10		import java.util.concurrent.atomic.AtomicInteger;
11		import java.util.concurrent.atomic.LongAdder;
12	+	import java.lang.reflect.Method;
13	+	import java.util.function.Predicate;
14	+	import java.util.stream.Collectors;
15	+
16	+	import junit.framework.Test;
17	+	import junit.framework.TestSuite;
18
19		public class SplittableRandomTest extends JSR166TestCase {
20
21		public static void main(String[] args) {
22	<	junit.textui.TestRunner.run(suite());
22	>	main(suite(), args);
23		}
24		public static Test suite() {
25		return new TestSuite(SplittableRandomTest.class);
#	Line 131 | Line 138 | public class SplittableRandomTest extend
138		*/
139		public void testNextIntBoundNonPositive() {
140		SplittableRandom sr = new SplittableRandom();
141	<	Runnable[] throwingActions = {
141	>	assertThrows(
142	>	IllegalArgumentException.class,
143		() -> sr.nextInt(-17),
144		() -> sr.nextInt(0),
145	<	() -> sr.nextInt(Integer.MIN_VALUE),
138	<	};
139	<	assertThrows(IllegalArgumentException.class, throwingActions);
145	>	() -> sr.nextInt(Integer.MIN_VALUE));
146		}
147
148		/**
#	Line 144 | Line 150 | public class SplittableRandomTest extend
150		*/
151		public void testNextIntBadBounds() {
152		SplittableRandom sr = new SplittableRandom();
153	<	Runnable[] throwingActions = {
153	>	assertThrows(
154	>	IllegalArgumentException.class,
155		() -> sr.nextInt(17, 2),
156		() -> sr.nextInt(-42, -42),
157	<	() -> sr.nextInt(Integer.MAX_VALUE, Integer.MIN_VALUE),
151	<	};
152	<	assertThrows(IllegalArgumentException.class, throwingActions);
157	>	() -> sr.nextInt(Integer.MAX_VALUE, Integer.MIN_VALUE));
158		}
159
160		/**
#	Line 158 | Line 163 | public class SplittableRandomTest extend
163		*/
164		public void testNextIntBounded() {
165		SplittableRandom sr = new SplittableRandom();
166	+	for (int i = 0; i < 2; i++) assertEquals(0, sr.nextInt(1));
167		// sample bound space across prime number increments
168		for (int bound = 2; bound < MAX_INT_BOUND; bound += 524959) {
169		int f = sr.nextInt(bound);
#	Line 200 | Line 206 | public class SplittableRandomTest extend
206		*/
207		public void testNextLongBoundNonPositive() {
208		SplittableRandom sr = new SplittableRandom();
209	<	Runnable[] throwingActions = {
209	>	assertThrows(
210	>	IllegalArgumentException.class,
211		() -> sr.nextLong(-17L),
212		() -> sr.nextLong(0L),
213	<	() -> sr.nextLong(Long.MIN_VALUE),
207	<	};
208	<	assertThrows(IllegalArgumentException.class, throwingActions);
213	>	() -> sr.nextLong(Long.MIN_VALUE));
214		}
215
216		/**
#	Line 213 | Line 218 | public class SplittableRandomTest extend
218		*/
219		public void testNextLongBadBounds() {
220		SplittableRandom sr = new SplittableRandom();
221	<	Runnable[] throwingActions = {
221	>	assertThrows(
222	>	IllegalArgumentException.class,
223		() -> sr.nextLong(17L, 2L),
224		() -> sr.nextLong(-42L, -42L),
225	<	() -> sr.nextLong(Long.MAX_VALUE, Long.MIN_VALUE),
220	<	};
221	<	assertThrows(IllegalArgumentException.class, throwingActions);
225	>	() -> sr.nextLong(Long.MAX_VALUE, Long.MIN_VALUE));
226		}
227
228		/**
#	Line 227 | Line 231 | public class SplittableRandomTest extend
231		*/
232		public void testNextLongBounded() {
233		SplittableRandom sr = new SplittableRandom();
234	+	for (int i = 0; i < 2; i++) assertEquals(0L, sr.nextLong(1L));
235		for (long bound = 2; bound < MAX_LONG_BOUND; bound += 15485863) {
236		long f = sr.nextLong(bound);
237		assertTrue(0 <= f && f < bound);
#	Line 268 | Line 273 | public class SplittableRandomTest extend
273		*/
274		public void testNextDoubleBoundNonPositive() {
275		SplittableRandom sr = new SplittableRandom();
276	<	Runnable[] throwingActions = {
276	>	assertThrows(
277	>	IllegalArgumentException.class,
278		() -> sr.nextDouble(-17.0d),
279		() -> sr.nextDouble(0.0d),
280		() -> sr.nextDouble(-Double.MIN_VALUE),
281		() -> sr.nextDouble(Double.NEGATIVE_INFINITY),
282	<	() -> sr.nextDouble(Double.NaN),
277	<	};
278	<	assertThrows(IllegalArgumentException.class, throwingActions);
282	>	() -> sr.nextDouble(Double.NaN));
283		}
284
285		/**
#	Line 283 | Line 287 | public class SplittableRandomTest extend
287		*/
288		public void testNextDoubleBadBounds() {
289		SplittableRandom sr = new SplittableRandom();
290	<	Runnable[] throwingActions = {
290	>	assertThrows(
291	>	IllegalArgumentException.class,
292		() -> sr.nextDouble(17.0d, 2.0d),
293		() -> sr.nextDouble(-42.0d, -42.0d),
294		() -> sr.nextDouble(Double.MAX_VALUE, Double.MIN_VALUE),
295		() -> sr.nextDouble(Double.NaN, 0.0d),
296	<	() -> sr.nextDouble(0.0d, Double.NaN),
292	<	};
293	<	assertThrows(IllegalArgumentException.class, throwingActions);
296	>	() -> sr.nextDouble(0.0d, Double.NaN));
297		}
298
299		// TODO: Test infinite bounds!
#	Line 325 | Line 328 | public class SplittableRandomTest extend
328		*/
329		public void testBadStreamSize() {
330		SplittableRandom r = new SplittableRandom();
331	<	Runnable[] throwingActions = {
331	>	assertThrows(
332	>	IllegalArgumentException.class,
333		() -> { java.util.stream.IntStream x = r.ints(-1L); },
334		() -> { java.util.stream.IntStream x = r.ints(-1L, 2, 3); },
335		() -> { java.util.stream.LongStream x = r.longs(-1L); },
336		() -> { java.util.stream.LongStream x = r.longs(-1L, -1L, 1L); },
337		() -> { java.util.stream.DoubleStream x = r.doubles(-1L); },
338	<	() -> { java.util.stream.DoubleStream x = r.doubles(-1L, .5, .6); },
335	<	};
336	<	assertThrows(IllegalArgumentException.class, throwingActions);
338	>	() -> { java.util.stream.DoubleStream x = r.doubles(-1L, .5, .6); });
339		}
340
341		/**
#	Line 342 | Line 344 | public class SplittableRandomTest extend
344		*/
345		public void testBadStreamBounds() {
346		SplittableRandom r = new SplittableRandom();
347	<	Runnable[] throwingActions = {
347	>	assertThrows(
348	>	IllegalArgumentException.class,
349		() -> { java.util.stream.IntStream x = r.ints(2, 1); },
350		() -> { java.util.stream.IntStream x = r.ints(10, 42, 42); },
351		() -> { java.util.stream.LongStream x = r.longs(-1L, -1L); },
352		() -> { java.util.stream.LongStream x = r.longs(10, 1L, -2L); },
353		() -> { java.util.stream.DoubleStream x = r.doubles(0.0, 0.0); },
354	<	() -> { java.util.stream.DoubleStream x = r.doubles(10, .5, .4); },
352	<	};
353	<	assertThrows(IllegalArgumentException.class, throwingActions);
354	>	() -> { java.util.stream.DoubleStream x = r.doubles(10, .5, .4); });
355		}
356
357		/**
#	Line 408 | Line 409 | public class SplittableRandomTest extend
409		for (int least = -15485867; least < MAX_INT_BOUND; least += 524959) {
410		for (int bound = least + 2; bound > least && bound < MAX_INT_BOUND; bound += 67867967) {
411		final int lo = least, hi = bound;
412	<	r.ints(size, lo, hi).parallel().
413	<	forEach(x -> {if (x < lo || x >= hi)
414	<	fails.getAndIncrement(); });
412	>	r.ints(size, lo, hi).parallel().forEach(
413	>	x -> {
414	>	if (x < lo || x >= hi)
415	>	fails.getAndIncrement(); });
416		}
417		}
418		assertEquals(0, fails.get());
#	Line 426 | Line 428 | public class SplittableRandomTest extend
428		for (long least = -86028121; least < MAX_LONG_BOUND; least += 1982451653L) {
429		for (long bound = least + 2; bound > least && bound < MAX_LONG_BOUND; bound += Math.abs(bound * 7919)) {
430		final long lo = least, hi = bound;
431	<	r.longs(size, lo, hi).parallel().
432	<	forEach(x -> {if (x < lo || x >= hi)
433	<	fails.getAndIncrement(); });
431	>	r.longs(size, lo, hi).parallel().forEach(
432	>	x -> {
433	>	if (x < lo || x >= hi)
434	>	fails.getAndIncrement(); });
435		}
436		}
437		assertEquals(0, fails.get());
#	Line 444 | Line 447 | public class SplittableRandomTest extend
447		for (double least = 0.00011; least < 1.0e20; least *= 9) {
448		for (double bound = least * 1.0011; bound < 1.0e20; bound *= 17) {
449		final double lo = least, hi = bound;
450	<	r.doubles(size, lo, hi).parallel().
451	<	forEach(x -> {if (x < lo || x >= hi)
452	<	fails.getAndIncrement(); });
450	>	r.doubles(size, lo, hi).parallel().forEach(
451	>	x -> {
452	>	if (x < lo || x >= hi)
453	>	fails.getAndIncrement(); });
454		}
455		}
456		assertEquals(0, fails.get());
#	Line 518 | Line 522 | public class SplittableRandomTest extend
522		assertEquals(size, counter.sum());
523		}
524
525	+	/**
526	+	* SplittableRandom should implement most of Random's public methods
527	+	*/
528	+	public void testShouldImplementMostRandomMethods() throws Throwable {
529	+	Predicate<Method> wasForgotten = method -> {
530	+	String name = method.getName();
531	+	// some methods deliberately not implemented
532	+	if (name.equals("setSeed")) return false;
533	+	if (name.equals("nextFloat")) return false;
534	+	if (name.equals("nextGaussian")) return false;
535	+	try {
536	+	SplittableRandom.class.getMethod(
537	+	method.getName(), method.getParameterTypes());
538	+	} catch (ReflectiveOperationException ex) {
539	+	return true;
540	+	}
541	+	return false;
542	+	};
543	+	List<Method> forgotten =
544	+	Arrays.stream(java.util.Random.class.getMethods())
545	+	.filter(wasForgotten)
546	+	.collect(Collectors.toList());
547	+	if (!forgotten.isEmpty())
548	+	throw new AssertionError("Please implement: " + forgotten);
549	+	}
550	+
551	+	/**
552	+	* Repeated calls to nextBytes produce at least values of different signs for every byte
553	+	*/
554	+	public void testNextBytes() {
555	+	SplittableRandom sr = new SplittableRandom();
556	+	int n = sr.nextInt(1, 20);
557	+	byte[] bytes = new byte[n];
558	+	outer:
559	+	for (int i = 0; i < n; i++) {
560	+	for (int tries = NCALLS; tries-->0; ) {
561	+	byte before = bytes[i];
562	+	sr.nextBytes(bytes);
563	+	byte after = bytes[i];
564	+	if (after * before < 0)
565	+	continue outer;
566	+	}
567	+	fail("not enough variation in random bytes");
568	+	}
569	+	}
570	+
571	+	/**
572	+	* Filling an empty array with random bytes succeeds without effect.
573	+	*/
574	+	public void testNextBytes_emptyArray() {
575	+	new SplittableRandom().nextBytes(new byte[0]);
576	+	}
577	+
578	+	public void testNextBytes_nullArray() {
579	+	try {
580	+	new SplittableRandom().nextBytes(null);
581	+	shouldThrow();
582	+	} catch (NullPointerException success) {}
583	+	}
584	+
585		}

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines