ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/SynchronousQueueTest.java
(Generate patch)

Comparing jsr166/src/test/tck/SynchronousQueueTest.java (file contents):
Revision 1.15 by jsr166, Sat Nov 21 19:11:53 2009 UTC vs.
Revision 1.65 by jsr166, Tue Aug 13 23:06:39 2019 UTC

# Line 1 | Line 1
1   /*
2   * Written by Doug Lea with assistance from members of JCP JSR-166
3   * Expert Group and released to the public domain, as explained at
4 < * http://creativecommons.org/licenses/publicdomain
4 > * http://creativecommons.org/publicdomain/zero/1.0/
5   * Other contributors include Andrew Wright, Jeffrey Hayes,
6   * Pat Fisher, Mike Judd.
7   */
8  
9 import junit.framework.*;
10 import java.util.*;
11 import java.util.concurrent.*;
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 < import java.io.*;
10 >
11 > import java.util.ArrayList;
12 > import java.util.Arrays;
13 > import java.util.Collection;
14 > import java.util.Iterator;
15 > import java.util.NoSuchElementException;
16 > import java.util.concurrent.BlockingQueue;
17 > import java.util.concurrent.CountDownLatch;
18 > import java.util.concurrent.Executors;
19 > import java.util.concurrent.ExecutorService;
20 > import java.util.concurrent.SynchronousQueue;
21 >
22 > import junit.framework.Test;
23  
24   public class SynchronousQueueTest extends JSR166TestCase {
25  
26 <    public static void main(String[] args) {
27 <        junit.textui.TestRunner.run (suite());
26 >    public static class Fair extends BlockingQueueTest {
27 >        protected BlockingQueue emptyCollection() {
28 >            return new SynchronousQueue(true);
29 >        }
30      }
31  
32 <    public static Test suite() {
33 <        return new TestSuite(SynchronousQueueTest.class);
32 >    public static class NonFair extends BlockingQueueTest {
33 >        protected BlockingQueue emptyCollection() {
34 >            return new SynchronousQueue(false);
35 >        }
36      }
37  
38 <    /**
39 <     * A SynchronousQueue is both empty and full
40 <     */
41 <    public void testEmptyFull() {
42 <        SynchronousQueue q = new SynchronousQueue();
43 <        assertTrue(q.isEmpty());
44 <        assertEquals(0, q.size());
45 <        assertEquals(0, q.remainingCapacity());
33 <        assertFalse(q.offer(zero));
38 >    public static void main(String[] args) {
39 >        main(suite(), args);
40 >    }
41 >
42 >    public static Test suite() {
43 >        return newTestSuite(SynchronousQueueTest.class,
44 >                            new Fair().testSuite(),
45 >                            new NonFair().testSuite());
46      }
47  
48      /**
49 <     * A fair SynchronousQueue is both empty and full
49 >     * Any SynchronousQueue is both empty and full
50       */
51 <    public void testFairEmptyFull() {
52 <        SynchronousQueue q = new SynchronousQueue(true);
51 >    public void testEmptyFull()      { testEmptyFull(false); }
52 >    public void testEmptyFull_fair() { testEmptyFull(true); }
53 >    public void testEmptyFull(boolean fair) {
54 >        final SynchronousQueue q = new SynchronousQueue(fair);
55          assertTrue(q.isEmpty());
56          assertEquals(0, q.size());
57          assertEquals(0, q.remainingCapacity());
# Line 45 | Line 59 | public class SynchronousQueueTest extend
59      }
60  
61      /**
48     * offer(null) throws NPE
49     */
50    public void testOfferNull() {
51        try {
52            SynchronousQueue q = new SynchronousQueue();
53            q.offer(null);
54            shouldThrow();
55        } catch (NullPointerException success) {}
56    }
57
58    /**
59     * add(null) throws NPE
60     */
61    public void testAddNull() {
62        try {
63            SynchronousQueue q = new SynchronousQueue();
64            q.add(null);
65            shouldThrow();
66        } catch (NullPointerException success) {}
67    }
68
69    /**
62       * offer fails if no active taker
63       */
64 <    public void testOffer() {
65 <        SynchronousQueue q = new SynchronousQueue();
64 >    public void testOffer()      { testOffer(false); }
65 >    public void testOffer_fair() { testOffer(true); }
66 >    public void testOffer(boolean fair) {
67 >        SynchronousQueue q = new SynchronousQueue(fair);
68          assertFalse(q.offer(one));
69      }
70  
71      /**
72 <     * add throws ISE if no active taker
72 >     * add throws IllegalStateException if no active taker
73       */
74 <    public void testAdd() {
74 >    public void testAdd()      { testAdd(false); }
75 >    public void testAdd_fair() { testAdd(true); }
76 >    public void testAdd(boolean fair) {
77 >        SynchronousQueue q = new SynchronousQueue(fair);
78 >        assertEquals(0, q.remainingCapacity());
79          try {
82            SynchronousQueue q = new SynchronousQueue();
83            assertEquals(0, q.remainingCapacity());
80              q.add(one);
81              shouldThrow();
82          } catch (IllegalStateException success) {}
83      }
84  
85      /**
86 <     * addAll(null) throws NPE
86 >     * addAll(this) throws IllegalArgumentException
87       */
88 <    public void testAddAll1() {
88 >    public void testAddAll_self()      { testAddAll_self(false); }
89 >    public void testAddAll_self_fair() { testAddAll_self(true); }
90 >    public void testAddAll_self(boolean fair) {
91 >        SynchronousQueue q = new SynchronousQueue(fair);
92          try {
94            SynchronousQueue q = new SynchronousQueue();
95            q.addAll(null);
96            shouldThrow();
97        } catch (NullPointerException success) {}
98    }
99
100    /**
101     * addAll(this) throws IAE
102     */
103    public void testAddAllSelf() {
104        try {
105            SynchronousQueue q = new SynchronousQueue();
93              q.addAll(q);
94              shouldThrow();
95          } catch (IllegalArgumentException success) {}
96      }
97  
98      /**
99 <     * addAll of a collection with null elements throws NPE
113 <     */
114 <    public void testAddAll2() {
115 <        try {
116 <            SynchronousQueue q = new SynchronousQueue();
117 <            Integer[] ints = new Integer[1];
118 <            q.addAll(Arrays.asList(ints));
119 <            shouldThrow();
120 <        } catch (NullPointerException success) {}
121 <    }
122 <    /**
123 <     * addAll throws ISE if no active taker
99 >     * addAll throws IllegalStateException if no active taker
100       */
101 <    public void testAddAll4() {
101 >    public void testAddAll_ISE()      { testAddAll_ISE(false); }
102 >    public void testAddAll_ISE_fair() { testAddAll_ISE(true); }
103 >    public void testAddAll_ISE(boolean fair) {
104 >        SynchronousQueue q = new SynchronousQueue(fair);
105 >        Integer[] ints = new Integer[1];
106 >        for (int i = 0; i < ints.length; i++)
107 >            ints[i] = i;
108 >        Collection<Integer> coll = Arrays.asList(ints);
109          try {
110 <            SynchronousQueue q = new SynchronousQueue();
128 <            Integer[] ints = new Integer[1];
129 <            for (int i = 0; i < 1; ++i)
130 <                ints[i] = new Integer(i);
131 <            q.addAll(Arrays.asList(ints));
110 >            q.addAll(coll);
111              shouldThrow();
112          } catch (IllegalStateException success) {}
113      }
114  
115      /**
137     * put(null) throws NPE
138     */
139    public void testPutNull() throws InterruptedException {
140        try {
141            SynchronousQueue q = new SynchronousQueue();
142            q.put(null);
143            shouldThrow();
144        } catch (NullPointerException success) {}
145     }
146
147    /**
116       * put blocks interruptibly if no active taker
117       */
118 <    public void testBlockingPut() throws InterruptedException {
119 <        Thread t = new Thread(new CheckedInterruptedRunnable() {
120 <            public void realRun() throws InterruptedException {
121 <                SynchronousQueue q = new SynchronousQueue();
122 <                q.put(zero);
123 <            }});
156 <
157 <        t.start();
158 <        Thread.sleep(SHORT_DELAY_MS);
159 <        t.interrupt();
160 <        t.join();
161 <    }
162 <
163 <    /**
164 <     * put blocks waiting for take
165 <     */
166 <    public void testPutWithTake() throws InterruptedException {
167 <        final SynchronousQueue q = new SynchronousQueue();
168 <        Thread t = new Thread(new CheckedRunnable() {
118 >    public void testBlockingPut()      { testBlockingPut(false); }
119 >    public void testBlockingPut_fair() { testBlockingPut(true); }
120 >    public void testBlockingPut(boolean fair) {
121 >        final SynchronousQueue q = new SynchronousQueue(fair);
122 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
123 >        Thread t = newStartedThread(new CheckedRunnable() {
124              public void realRun() throws InterruptedException {
125 <                int added = 0;
125 >                Thread.currentThread().interrupt();
126                  try {
127 <                    q.put(new Object());
128 <                    ++added;
129 <                    q.put(new Object());
130 <                    ++added;
176 <                    q.put(new Object());
177 <                    ++added;
178 <                    q.put(new Object());
179 <                    ++added;
180 <                    threadShouldThrow();
181 <                } catch (InterruptedException success) {
182 <                    assertTrue(added >= 1);
183 <                }
184 <            }});
185 <
186 <        t.start();
187 <        Thread.sleep(SHORT_DELAY_MS);
188 <        q.take();
189 <        Thread.sleep(SHORT_DELAY_MS);
190 <        t.interrupt();
191 <        t.join();
192 <    }
193 <
194 <    /**
195 <     * timed offer times out if elements not taken
196 <     */
197 <    public void testTimedOffer() throws InterruptedException {
198 <        final SynchronousQueue q = new SynchronousQueue();
199 <        Thread t = new Thread(new CheckedInterruptedRunnable() {
200 <            public void realRun() throws InterruptedException {
201 <                threadAssertFalse(q.offer(new Object(), SHORT_DELAY_MS, MILLISECONDS));
202 <                q.offer(new Object(), LONG_DELAY_MS, MILLISECONDS);
203 <            }});
204 <
205 <        t.start();
206 <        Thread.sleep(SMALL_DELAY_MS);
207 <        t.interrupt();
208 <        t.join();
209 <    }
210 <
127 >                    q.put(99);
128 >                    shouldThrow();
129 >                } catch (InterruptedException success) {}
130 >                assertFalse(Thread.interrupted());
131  
132 <    /**
133 <     * take blocks interruptibly when empty
134 <     */
135 <    public void testTakeFromEmpty() throws InterruptedException {
136 <        final SynchronousQueue q = new SynchronousQueue();
137 <        Thread t = new Thread(new CheckedInterruptedRunnable() {
218 <            public void realRun() throws InterruptedException {
219 <                q.take();
132 >                pleaseInterrupt.countDown();
133 >                try {
134 >                    q.put(99);
135 >                    shouldThrow();
136 >                } catch (InterruptedException success) {}
137 >                assertFalse(Thread.interrupted());
138              }});
139  
140 <        t.start();
141 <        Thread.sleep(SHORT_DELAY_MS);
140 >        await(pleaseInterrupt);
141 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
142          t.interrupt();
143 <        t.join();
143 >        awaitTermination(t);
144 >        assertEquals(0, q.remainingCapacity());
145      }
146  
228
147      /**
148 <     * put blocks interruptibly if no active taker
148 >     * put blocks interruptibly waiting for take
149       */
150 <    public void testFairBlockingPut() throws InterruptedException {
151 <        Thread t = new Thread(new CheckedInterruptedRunnable() {
150 >    public void testPutWithTake()      { testPutWithTake(false); }
151 >    public void testPutWithTake_fair() { testPutWithTake(true); }
152 >    public void testPutWithTake(boolean fair) {
153 >        final SynchronousQueue q = new SynchronousQueue(fair);
154 >        final CountDownLatch pleaseTake = new CountDownLatch(1);
155 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
156 >        Thread t = newStartedThread(new CheckedRunnable() {
157              public void realRun() throws InterruptedException {
158 <                SynchronousQueue q = new SynchronousQueue(true);
159 <                q.put(zero);
237 <            }});
158 >                pleaseTake.countDown();
159 >                q.put(one);
160  
161 <        t.start();
162 <        Thread.sleep(SHORT_DELAY_MS);
163 <        t.interrupt();
164 <        t.join();
165 <    }
161 >                Thread.currentThread().interrupt();
162 >                try {
163 >                    q.put(99);
164 >                    shouldThrow();
165 >                } catch (InterruptedException success) {}
166 >                assertFalse(Thread.interrupted());
167  
168 <    /**
246 <     * put blocks waiting for take
247 <     */
248 <    public void testFairPutWithTake() throws InterruptedException {
249 <        final SynchronousQueue q = new SynchronousQueue(true);
250 <        Thread t = new Thread(new CheckedRunnable() {
251 <            public void realRun() throws InterruptedException {
252 <                int added = 0;
168 >                pleaseInterrupt.countDown();
169                  try {
170 <                    q.put(new Object());
171 <                    ++added;
172 <                    q.put(new Object());
173 <                    ++added;
258 <                    q.put(new Object());
259 <                    ++added;
260 <                    q.put(new Object());
261 <                    ++added;
262 <                    threadShouldThrow();
263 <                } catch (InterruptedException success) {
264 <                    assertTrue(added >= 1);
265 <                }
170 >                    q.put(99);
171 >                    shouldThrow();
172 >                } catch (InterruptedException success) {}
173 >                assertFalse(Thread.interrupted());
174              }});
175  
176 <        t.start();
177 <        Thread.sleep(SHORT_DELAY_MS);
178 <        q.take();
179 <        Thread.sleep(SHORT_DELAY_MS);
176 >        await(pleaseTake);
177 >        assertEquals(0, q.remainingCapacity());
178 >        try { assertSame(one, q.take()); }
179 >        catch (InterruptedException e) { threadUnexpectedException(e); }
180 >
181 >        await(pleaseInterrupt);
182 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.WAITING);
183          t.interrupt();
184 <        t.join();
184 >        awaitTermination(t);
185 >        assertEquals(0, q.remainingCapacity());
186      }
187  
188      /**
189       * timed offer times out if elements not taken
190       */
191 <    public void testFairTimedOffer() throws InterruptedException {
192 <        final SynchronousQueue q = new SynchronousQueue(true);
193 <        Thread t = new Thread(new CheckedInterruptedRunnable() {
191 >    public void testTimedOffer() {
192 >        final boolean fair = randomBoolean();
193 >        final SynchronousQueue q = new SynchronousQueue(fair);
194 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
195 >        Thread t = newStartedThread(new CheckedRunnable() {
196              public void realRun() throws InterruptedException {
197 <                threadAssertFalse(q.offer(new Object(), SHORT_DELAY_MS, MILLISECONDS));
284 <                q.offer(new Object(), LONG_DELAY_MS, MILLISECONDS);
285 <            }});
197 >                long startTime = System.nanoTime();
198  
199 <        t.start();
200 <        Thread.sleep(SMALL_DELAY_MS);
289 <        t.interrupt();
290 <        t.join();
291 <    }
199 >                assertFalse(q.offer(new Object(), timeoutMillis(), MILLISECONDS));
200 >                assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
201  
202 +                Thread.currentThread().interrupt();
203 +                try {
204 +                    q.offer(new Object(), randomTimeout(), randomTimeUnit());
205 +                    shouldThrow();
206 +                } catch (InterruptedException success) {}
207 +                assertFalse(Thread.interrupted());
208  
209 <    /**
210 <     * take blocks interruptibly when empty
211 <     */
212 <    public void testFairTakeFromEmpty() throws InterruptedException {
213 <        final SynchronousQueue q = new SynchronousQueue(true);
214 <        Thread t = new Thread(new CheckedInterruptedRunnable() {
215 <            public void realRun() throws InterruptedException {
216 <                q.take();
209 >                pleaseInterrupt.countDown();
210 >                try {
211 >                    q.offer(new Object(), LONG_DELAY_MS, MILLISECONDS);
212 >                    shouldThrow();
213 >                } catch (InterruptedException success) {}
214 >                assertFalse(Thread.interrupted());
215 >
216 >                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
217              }});
218  
219 <        t.start();
220 <        Thread.sleep(SHORT_DELAY_MS);
219 >        await(pleaseInterrupt);
220 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.TIMED_WAITING);
221          t.interrupt();
222 <        t.join();
222 >        awaitTermination(t);
223      }
224  
225      /**
226 <     * poll fails unless active taker
226 >     * poll return null if no active putter
227       */
228 <    public void testPoll() {
229 <        SynchronousQueue q = new SynchronousQueue();
228 >    public void testPoll()      { testPoll(false); }
229 >    public void testPoll_fair() { testPoll(true); }
230 >    public void testPoll(boolean fair) {
231 >        final SynchronousQueue q = new SynchronousQueue(fair);
232          assertNull(q.poll());
233      }
234  
235      /**
236 <     * timed pool with zero timeout times out if no active taker
236 >     * timed poll with zero timeout times out if no active putter
237       */
238 <    public void testTimedPoll0() throws InterruptedException {
239 <        SynchronousQueue q = new SynchronousQueue();
240 <        assertNull(q.poll(0, MILLISECONDS));
238 >    public void testTimedPoll0()      { testTimedPoll0(false); }
239 >    public void testTimedPoll0_fair() { testTimedPoll0(true); }
240 >    public void testTimedPoll0(boolean fair) {
241 >        final SynchronousQueue q = new SynchronousQueue(fair);
242 >        try { assertNull(q.poll(0, MILLISECONDS)); }
243 >        catch (InterruptedException e) { threadUnexpectedException(e); }
244      }
245  
246      /**
247 <     * timed pool with nonzero timeout times out if no active taker
247 >     * timed poll with nonzero timeout times out if no active putter
248       */
249 <    public void testTimedPoll() throws InterruptedException {
250 <        SynchronousQueue q = new SynchronousQueue();
251 <        assertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
249 >    public void testTimedPoll() {
250 >        final boolean fair = randomBoolean();
251 >        final SynchronousQueue q = new SynchronousQueue(fair);
252 >        final long startTime = System.nanoTime();
253 >        try { assertNull(q.poll(timeoutMillis(), MILLISECONDS)); }
254 >        catch (InterruptedException e) { threadUnexpectedException(e); }
255 >        assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
256      }
257  
258      /**
259 <     * Interrupted timed poll throws InterruptedException instead of
260 <     * returning timeout status
259 >     * timed poll before a delayed offer times out, returning null;
260 >     * after offer succeeds; on interruption throws
261       */
262 <    public void testInterruptedTimedPoll() throws InterruptedException {
263 <        final SynchronousQueue q = new SynchronousQueue();
264 <        Thread t = new Thread(new CheckedInterruptedRunnable() {
262 >    public void testTimedPollWithOffer() {
263 >        final boolean fair = randomBoolean();
264 >        final SynchronousQueue q = new SynchronousQueue(fair);
265 >        final CountDownLatch pleaseOffer = new CountDownLatch(1);
266 >        final CountDownLatch pleaseInterrupt = new CountDownLatch(1);
267 >        Thread t = newStartedThread(new CheckedRunnable() {
268              public void realRun() throws InterruptedException {
269 <                q.poll(SMALL_DELAY_MS, MILLISECONDS);
270 <            }});
271 <
345 <        t.start();
346 <        Thread.sleep(SHORT_DELAY_MS);
347 <        t.interrupt();
348 <        t.join();
349 <    }
269 >                long startTime = System.nanoTime();
270 >                assertNull(q.poll(timeoutMillis(), MILLISECONDS));
271 >                assertTrue(millisElapsedSince(startTime) >= timeoutMillis());
272  
273 <    /**
274 <     *  timed poll before a delayed offer fails; after offer succeeds;
353 <     *  on interruption throws
354 <     */
355 <    public void testTimedPollWithOffer() throws InterruptedException {
356 <        final SynchronousQueue q = new SynchronousQueue();
357 <        Thread t = new Thread(new CheckedRunnable() {
358 <            public void realRun() throws InterruptedException {
359 <                threadAssertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
273 >                pleaseOffer.countDown();
274 >                startTime = System.nanoTime();
275                  assertSame(zero, q.poll(LONG_DELAY_MS, MILLISECONDS));
276 +
277 +                Thread.currentThread().interrupt();
278                  try {
279 <                    q.poll(LONG_DELAY_MS, MILLISECONDS);
280 <                    threadShouldThrow();
279 >                    q.poll(randomTimeout(), randomTimeUnit());
280 >                    shouldThrow();
281                  } catch (InterruptedException success) {}
282 <            }});
366 <
367 <        t.start();
368 <        Thread.sleep(SMALL_DELAY_MS);
369 <        assertTrue(q.offer(zero, SHORT_DELAY_MS, MILLISECONDS));
370 <        t.interrupt();
371 <        t.join();
372 <    }
282 >                assertFalse(Thread.interrupted());
283  
284 <    /**
375 <     * Interrupted timed poll throws InterruptedException instead of
376 <     * returning timeout status
377 <     */
378 <    public void testFairInterruptedTimedPoll() throws InterruptedException {
379 <        Thread t = new Thread(new CheckedInterruptedRunnable() {
380 <            public void realRun() throws InterruptedException {
381 <                SynchronousQueue q = new SynchronousQueue(true);
382 <                q.poll(SMALL_DELAY_MS, MILLISECONDS);
383 <            }});
384 <
385 <        t.start();
386 <        Thread.sleep(SHORT_DELAY_MS);
387 <        t.interrupt();
388 <        t.join();
389 <    }
390 <
391 <    /**
392 <     *  timed poll before a delayed offer fails; after offer succeeds;
393 <     *  on interruption throws
394 <     */
395 <    public void testFairTimedPollWithOffer() throws InterruptedException {
396 <        final SynchronousQueue q = new SynchronousQueue(true);
397 <        Thread t = new Thread(new CheckedRunnable() {
398 <            public void realRun() throws InterruptedException {
399 <                threadAssertNull(q.poll(SHORT_DELAY_MS, MILLISECONDS));
400 <                assertSame(zero, q.poll(LONG_DELAY_MS, MILLISECONDS));
284 >                pleaseInterrupt.countDown();
285                  try {
286                      q.poll(LONG_DELAY_MS, MILLISECONDS);
287 <                    threadShouldThrow();
287 >                    shouldThrow();
288                  } catch (InterruptedException success) {}
289 +                assertFalse(Thread.interrupted());
290 +
291 +                assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
292              }});
293  
294 <        t.start();
295 <        Thread.sleep(SMALL_DELAY_MS);
296 <        assertTrue(q.offer(zero, SHORT_DELAY_MS, MILLISECONDS));
294 >        await(pleaseOffer);
295 >        long startTime = System.nanoTime();
296 >        try { assertTrue(q.offer(zero, LONG_DELAY_MS, MILLISECONDS)); }
297 >        catch (InterruptedException e) { threadUnexpectedException(e); }
298 >        assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
299 >
300 >        await(pleaseInterrupt);
301 >        if (randomBoolean()) assertThreadBlocks(t, Thread.State.TIMED_WAITING);
302          t.interrupt();
303 <        t.join();
303 >        awaitTermination(t);
304      }
305  
414
306      /**
307 <     * peek returns null
307 >     * peek() returns null if no active putter
308       */
309 <    public void testPeek() {
310 <        SynchronousQueue q = new SynchronousQueue();
309 >    public void testPeek()      { testPeek(false); }
310 >    public void testPeek_fair() { testPeek(true); }
311 >    public void testPeek(boolean fair) {
312 >        final SynchronousQueue q = new SynchronousQueue(fair);
313          assertNull(q.peek());
314      }
315  
316      /**
317 <     * element throws NSEE
317 >     * element() throws NoSuchElementException if no active putter
318       */
319 <    public void testElement() {
320 <        SynchronousQueue q = new SynchronousQueue();
319 >    public void testElement()      { testElement(false); }
320 >    public void testElement_fair() { testElement(true); }
321 >    public void testElement(boolean fair) {
322 >        final SynchronousQueue q = new SynchronousQueue(fair);
323          try {
324              q.element();
325              shouldThrow();
# Line 432 | Line 327 | public class SynchronousQueueTest extend
327      }
328  
329      /**
330 <     * remove throws NSEE if no active taker
330 >     * remove() throws NoSuchElementException if no active putter
331       */
332 <    public void testRemove() {
333 <        SynchronousQueue q = new SynchronousQueue();
332 >    public void testRemove()      { testRemove(false); }
333 >    public void testRemove_fair() { testRemove(true); }
334 >    public void testRemove(boolean fair) {
335 >        final SynchronousQueue q = new SynchronousQueue(fair);
336          try {
337              q.remove();
338              shouldThrow();
339 <        } catch (NoSuchElementException success) {
443 <        }
444 <    }
445 <
446 <    /**
447 <     * remove(x) returns false
448 <     */
449 <    public void testRemoveElement() {
450 <        SynchronousQueue q = new SynchronousQueue();
451 <        assertFalse(q.remove(zero));
452 <        assertTrue(q.isEmpty());
339 >        } catch (NoSuchElementException success) {}
340      }
341  
342      /**
343       * contains returns false
344       */
345 <    public void testContains() {
346 <        SynchronousQueue q = new SynchronousQueue();
345 >    public void testContains()      { testContains(false); }
346 >    public void testContains_fair() { testContains(true); }
347 >    public void testContains(boolean fair) {
348 >        final SynchronousQueue q = new SynchronousQueue(fair);
349          assertFalse(q.contains(zero));
350      }
351  
352      /**
353       * clear ensures isEmpty
354       */
355 <    public void testClear() {
356 <        SynchronousQueue q = new SynchronousQueue();
355 >    public void testClear()      { testClear(false); }
356 >    public void testClear_fair() { testClear(true); }
357 >    public void testClear(boolean fair) {
358 >        final SynchronousQueue q = new SynchronousQueue(fair);
359          q.clear();
360          assertTrue(q.isEmpty());
361      }
# Line 472 | Line 363 | public class SynchronousQueueTest extend
363      /**
364       * containsAll returns false unless empty
365       */
366 <    public void testContainsAll() {
367 <        SynchronousQueue q = new SynchronousQueue();
366 >    public void testContainsAll()      { testContainsAll(false); }
367 >    public void testContainsAll_fair() { testContainsAll(true); }
368 >    public void testContainsAll(boolean fair) {
369 >        final SynchronousQueue q = new SynchronousQueue(fair);
370          Integer[] empty = new Integer[0];
371          assertTrue(q.containsAll(Arrays.asList(empty)));
372          Integer[] ints = new Integer[1]; ints[0] = zero;
# Line 483 | Line 376 | public class SynchronousQueueTest extend
376      /**
377       * retainAll returns false
378       */
379 <    public void testRetainAll() {
380 <        SynchronousQueue q = new SynchronousQueue();
379 >    public void testRetainAll()      { testRetainAll(false); }
380 >    public void testRetainAll_fair() { testRetainAll(true); }
381 >    public void testRetainAll(boolean fair) {
382 >        final SynchronousQueue q = new SynchronousQueue(fair);
383          Integer[] empty = new Integer[0];
384          assertFalse(q.retainAll(Arrays.asList(empty)));
385          Integer[] ints = new Integer[1]; ints[0] = zero;
# Line 494 | Line 389 | public class SynchronousQueueTest extend
389      /**
390       * removeAll returns false
391       */
392 <    public void testRemoveAll() {
393 <        SynchronousQueue q = new SynchronousQueue();
392 >    public void testRemoveAll()      { testRemoveAll(false); }
393 >    public void testRemoveAll_fair() { testRemoveAll(true); }
394 >    public void testRemoveAll(boolean fair) {
395 >        final SynchronousQueue q = new SynchronousQueue(fair);
396          Integer[] empty = new Integer[0];
397          assertFalse(q.removeAll(Arrays.asList(empty)));
398          Integer[] ints = new Integer[1]; ints[0] = zero;
399          assertFalse(q.containsAll(Arrays.asList(ints)));
400      }
401  
505
402      /**
403       * toArray is empty
404       */
405 <    public void testToArray() {
406 <        SynchronousQueue q = new SynchronousQueue();
405 >    public void testToArray()      { testToArray(false); }
406 >    public void testToArray_fair() { testToArray(true); }
407 >    public void testToArray(boolean fair) {
408 >        final SynchronousQueue q = new SynchronousQueue(fair);
409          Object[] o = q.toArray();
410 <        assertEquals(o.length, 0);
410 >        assertEquals(0, o.length);
411      }
412  
413      /**
414 <     * toArray(a) is nulled at position 0
414 >     * toArray(Integer array) returns its argument with the first
415 >     * element (if present) nulled out
416       */
417 <    public void testToArray2() {
418 <        SynchronousQueue q = new SynchronousQueue();
419 <        Integer[] ints = new Integer[1];
420 <        assertNull(ints[0]);
417 >    public void testToArray2()      { testToArray2(false); }
418 >    public void testToArray2_fair() { testToArray2(true); }
419 >    public void testToArray2(boolean fair) {
420 >        final SynchronousQueue<Integer> q = new SynchronousQueue<>(fair);
421 >        Integer[] a;
422 >
423 >        a = new Integer[0];
424 >        assertSame(a, q.toArray(a));
425 >
426 >        a = new Integer[3];
427 >        Arrays.fill(a, 42);
428 >        assertSame(a, q.toArray(a));
429 >        assertNull(a[0]);
430 >        for (int i = 1; i < a.length; i++)
431 >            assertEquals(42, (int) a[i]);
432      }
433  
434      /**
435       * toArray(null) throws NPE
436       */
437 <    public void testToArray_BadArg() {
437 >    public void testToArray_null()      { testToArray_null(false); }
438 >    public void testToArray_null_fair() { testToArray_null(true); }
439 >    public void testToArray_null(boolean fair) {
440 >        final SynchronousQueue q = new SynchronousQueue(fair);
441          try {
442 <            SynchronousQueue q = new SynchronousQueue();
530 <            Object o[] = q.toArray(null);
442 >            Object[] o = q.toArray((Object[])null);
443              shouldThrow();
444          } catch (NullPointerException success) {}
445      }
446  
535
447      /**
448       * iterator does not traverse any elements
449       */
450 <    public void testIterator() {
451 <        SynchronousQueue q = new SynchronousQueue();
452 <        Iterator it = q.iterator();
453 <        assertFalse(it.hasNext());
543 <        try {
544 <            Object x = it.next();
545 <            shouldThrow();
546 <        } catch (NoSuchElementException success) {}
450 >    public void testIterator()      { testIterator(false); }
451 >    public void testIterator_fair() { testIterator(true); }
452 >    public void testIterator(boolean fair) {
453 >        assertIteratorExhausted(new SynchronousQueue(fair).iterator());
454      }
455  
456      /**
457 <     * iterator remove throws ISE
457 >     * iterator remove throws IllegalStateException
458       */
459 <    public void testIteratorRemove() {
460 <        SynchronousQueue q = new SynchronousQueue();
459 >    public void testIteratorRemove()      { testIteratorRemove(false); }
460 >    public void testIteratorRemove_fair() { testIteratorRemove(true); }
461 >    public void testIteratorRemove(boolean fair) {
462 >        final SynchronousQueue q = new SynchronousQueue(fair);
463          Iterator it = q.iterator();
464          try {
465              it.remove();
# Line 561 | Line 470 | public class SynchronousQueueTest extend
470      /**
471       * toString returns a non-null string
472       */
473 <    public void testToString() {
474 <        SynchronousQueue q = new SynchronousQueue();
473 >    public void testToString()      { testToString(false); }
474 >    public void testToString_fair() { testToString(true); }
475 >    public void testToString(boolean fair) {
476 >        final SynchronousQueue q = new SynchronousQueue(fair);
477          String s = q.toString();
478          assertNotNull(s);
479      }
480  
570
481      /**
482       * offer transfers elements across Executor tasks
483       */
484 <    public void testOfferInExecutor() {
485 <        final SynchronousQueue q = new SynchronousQueue();
486 <        ExecutorService executor = Executors.newFixedThreadPool(2);
487 <        final Integer one = new Integer(1);
488 <
489 <        executor.execute(new CheckedRunnable() {
490 <            public void realRun() throws InterruptedException {
491 <                threadAssertFalse(q.offer(one));
492 <                threadAssertTrue(q.offer(one, MEDIUM_DELAY_MS, MILLISECONDS));
493 <                threadAssertEquals(0, q.remainingCapacity());
494 <            }});
495 <
496 <        executor.execute(new CheckedRunnable() {
497 <            public void realRun() throws InterruptedException {
498 <                Thread.sleep(SMALL_DELAY_MS);
499 <                threadAssertEquals(one, q.take());
500 <            }});
501 <
502 <        joinPool(executor);
503 <
504 <    }
505 <
596 <    /**
597 <     * poll retrieves elements across Executor threads
598 <     */
599 <    public void testPollInExecutor() {
600 <        final SynchronousQueue q = new SynchronousQueue();
601 <        ExecutorService executor = Executors.newFixedThreadPool(2);
602 <        executor.execute(new CheckedRunnable() {
603 <            public void realRun() throws InterruptedException {
604 <                threadAssertNull(q.poll());
605 <                threadAssertTrue(null != q.poll(MEDIUM_DELAY_MS, MILLISECONDS));
606 <                threadAssertTrue(q.isEmpty());
607 <            }});
608 <
609 <        executor.execute(new CheckedRunnable() {
610 <            public void realRun() throws InterruptedException {
611 <                Thread.sleep(SMALL_DELAY_MS);
612 <                q.put(new Integer(1));
613 <            }});
614 <
615 <        joinPool(executor);
616 <    }
617 <
618 <    /**
619 <     * a deserialized serialized queue is usable
620 <     */
621 <    public void testSerialization() throws Exception {
622 <        SynchronousQueue q = new SynchronousQueue();
623 <        ByteArrayOutputStream bout = new ByteArrayOutputStream(10000);
624 <        ObjectOutputStream out = new ObjectOutputStream(new BufferedOutputStream(bout));
625 <        out.writeObject(q);
626 <        out.close();
627 <
628 <        ByteArrayInputStream bin = new ByteArrayInputStream(bout.toByteArray());
629 <        ObjectInputStream in = new ObjectInputStream(new BufferedInputStream(bin));
630 <        SynchronousQueue r = (SynchronousQueue)in.readObject();
631 <        assertEquals(q.size(), r.size());
632 <        while (!q.isEmpty())
633 <            assertEquals(q.remove(), r.remove());
484 >    public void testOfferInExecutor()      { testOfferInExecutor(false); }
485 >    public void testOfferInExecutor_fair() { testOfferInExecutor(true); }
486 >    public void testOfferInExecutor(boolean fair) {
487 >        final SynchronousQueue q = new SynchronousQueue(fair);
488 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
489 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
490 >        try (PoolCleaner cleaner = cleaner(executor)) {
491 >
492 >            executor.execute(new CheckedRunnable() {
493 >                public void realRun() throws InterruptedException {
494 >                    assertFalse(q.offer(one));
495 >                    threadsStarted.await();
496 >                    assertTrue(q.offer(one, LONG_DELAY_MS, MILLISECONDS));
497 >                    assertEquals(0, q.remainingCapacity());
498 >                }});
499 >
500 >            executor.execute(new CheckedRunnable() {
501 >                public void realRun() throws InterruptedException {
502 >                    threadsStarted.await();
503 >                    assertSame(one, q.take());
504 >                }});
505 >        }
506      }
507  
508      /**
509 <     * drainTo(null) throws NPE
509 >     * timed poll retrieves elements across Executor threads
510       */
511 <    public void testDrainToNull() {
512 <        SynchronousQueue q = new SynchronousQueue();
513 <        try {
514 <            q.drainTo(null);
515 <            shouldThrow();
516 <        } catch (NullPointerException success) {}
511 >    public void testPollInExecutor()      { testPollInExecutor(false); }
512 >    public void testPollInExecutor_fair() { testPollInExecutor(true); }
513 >    public void testPollInExecutor(boolean fair) {
514 >        final SynchronousQueue q = new SynchronousQueue(fair);
515 >        final CheckedBarrier threadsStarted = new CheckedBarrier(2);
516 >        final ExecutorService executor = Executors.newFixedThreadPool(2);
517 >        try (PoolCleaner cleaner = cleaner(executor)) {
518 >            executor.execute(new CheckedRunnable() {
519 >                public void realRun() throws InterruptedException {
520 >                    assertNull(q.poll());
521 >                    threadsStarted.await();
522 >                    assertSame(one, q.poll(LONG_DELAY_MS, MILLISECONDS));
523 >                    assertTrue(q.isEmpty());
524 >                }});
525 >
526 >            executor.execute(new CheckedRunnable() {
527 >                public void realRun() throws InterruptedException {
528 >                    threadsStarted.await();
529 >                    q.put(one);
530 >                }});
531 >        }
532      }
533  
534      /**
535 <     * drainTo(this) throws IAE
535 >     * a deserialized/reserialized queue is usable
536       */
537 <    public void testDrainToSelf() {
538 <        SynchronousQueue q = new SynchronousQueue();
539 <        try {
540 <            q.drainTo(q);
541 <            shouldThrow();
542 <        } catch (IllegalArgumentException success) {}
537 >    public void testSerialization() {
538 >        final SynchronousQueue x = new SynchronousQueue();
539 >        final SynchronousQueue y = new SynchronousQueue(false);
540 >        final SynchronousQueue z = new SynchronousQueue(true);
541 >        assertSerialEquals(x, y);
542 >        assertNotSerialEquals(x, z);
543 >        SynchronousQueue[] qs = { x, y, z };
544 >        for (SynchronousQueue q : qs) {
545 >            SynchronousQueue clone = serialClone(q);
546 >            assertNotSame(q, clone);
547 >            assertSerialEquals(q, clone);
548 >            assertTrue(clone.isEmpty());
549 >            assertEquals(0, clone.size());
550 >            assertEquals(0, clone.remainingCapacity());
551 >            assertFalse(clone.offer(zero));
552 >        }
553      }
554  
555      /**
556       * drainTo(c) of empty queue doesn't transfer elements
557       */
558 <    public void testDrainTo() {
559 <        SynchronousQueue q = new SynchronousQueue();
558 >    public void testDrainTo()      { testDrainTo(false); }
559 >    public void testDrainTo_fair() { testDrainTo(true); }
560 >    public void testDrainTo(boolean fair) {
561 >        final SynchronousQueue q = new SynchronousQueue(fair);
562          ArrayList l = new ArrayList();
563          q.drainTo(l);
564 <        assertEquals(q.size(), 0);
565 <        assertEquals(l.size(), 0);
564 >        assertEquals(0, q.size());
565 >        assertEquals(0, l.size());
566      }
567  
568      /**
569       * drainTo empties queue, unblocking a waiting put.
570       */
571 <    public void testDrainToWithActivePut() throws InterruptedException {
572 <        final SynchronousQueue q = new SynchronousQueue();
573 <        Thread t = new Thread(new CheckedRunnable() {
571 >    public void testDrainToWithActivePut()      { testDrainToWithActivePut(false); }
572 >    public void testDrainToWithActivePut_fair() { testDrainToWithActivePut(true); }
573 >    public void testDrainToWithActivePut(boolean fair) {
574 >        final SynchronousQueue q = new SynchronousQueue(fair);
575 >        Thread t = newStartedThread(new CheckedRunnable() {
576              public void realRun() throws InterruptedException {
577 <                q.put(new Integer(1));
577 >                q.put(one);
578              }});
579  
679        t.start();
580          ArrayList l = new ArrayList();
581 <        Thread.sleep(SHORT_DELAY_MS);
582 <        q.drainTo(l);
583 <        assertTrue(l.size() <= 1);
584 <        if (l.size() > 0)
585 <            assertEquals(l.get(0), new Integer(1));
586 <        t.join();
687 <        assertTrue(l.size() <= 1);
688 <    }
689 <
690 <    /**
691 <     * drainTo(null, n) throws NPE
692 <     */
693 <    public void testDrainToNullN() {
694 <        SynchronousQueue q = new SynchronousQueue();
695 <        try {
696 <            q.drainTo(null, 0);
697 <            shouldThrow();
698 <        } catch (NullPointerException success) {}
699 <    }
700 <
701 <    /**
702 <     * drainTo(this, n) throws IAE
703 <     */
704 <    public void testDrainToSelfN() {
705 <        SynchronousQueue q = new SynchronousQueue();
706 <        try {
707 <            q.drainTo(q, 0);
708 <            shouldThrow();
709 <        } catch (IllegalArgumentException success) {
581 >        long startTime = System.nanoTime();
582 >        while (l.isEmpty()) {
583 >            q.drainTo(l);
584 >            if (millisElapsedSince(startTime) > LONG_DELAY_MS)
585 >                fail("timed out");
586 >            Thread.yield();
587          }
588 +        assertEquals(1, l.size());
589 +        assertSame(one, l.get(0));
590 +        awaitTermination(t);
591      }
592  
593      /**
# Line 715 | Line 595 | public class SynchronousQueueTest extend
595       */
596      public void testDrainToN() throws InterruptedException {
597          final SynchronousQueue q = new SynchronousQueue();
598 <        Thread t1 = new Thread(new CheckedRunnable() {
598 >        Thread t1 = newStartedThread(new CheckedRunnable() {
599              public void realRun() throws InterruptedException {
600                  q.put(one);
601              }});
602  
603 <        Thread t2 = new Thread(new CheckedRunnable() {
603 >        Thread t2 = newStartedThread(new CheckedRunnable() {
604              public void realRun() throws InterruptedException {
605                  q.put(two);
606              }});
607  
728        t1.start();
729        t2.start();
608          ArrayList l = new ArrayList();
609 <        Thread.sleep(SHORT_DELAY_MS);
610 <        q.drainTo(l, 1);
611 <        assertTrue(l.size() == 1);
612 <        q.drainTo(l, 1);
613 <        assertTrue(l.size() == 2);
609 >        int drained;
610 >        while ((drained = q.drainTo(l, 1)) == 0) Thread.yield();
611 >        assertEquals(1, drained);
612 >        assertEquals(1, l.size());
613 >        while ((drained = q.drainTo(l, 1)) == 0) Thread.yield();
614 >        assertEquals(1, drained);
615 >        assertEquals(2, l.size());
616          assertTrue(l.contains(one));
617          assertTrue(l.contains(two));
618 <        t1.join();
619 <        t2.join();
618 >        awaitTermination(t1);
619 >        awaitTermination(t2);
620 >    }
621 >
622 >    /**
623 >     * remove(null), contains(null) always return false
624 >     */
625 >    public void testNeverContainsNull() {
626 >        Collection<?> q = new SynchronousQueue();
627 >        assertFalse(q.contains(null));
628 >        assertFalse(q.remove(null));
629      }
630  
631   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines