--- jsr166/src/test/tck/SystemTest.java 2003/09/14 20:42:41 1.2 +++ jsr166/src/test/tck/SystemTest.java 2009/11/02 20:28:32 1.7 @@ -1,23 +1,32 @@ /* - * Written by members of JCP JSR-166 Expert Group and released to the - * public domain. Use, modify, and redistribute this code in any way - * without acknowledgement. Other contributors include Andrew Wright, - * Jeffrey Hayes, Pat Fischer, Mike Judd. + * Written by Doug Lea with assistance from members of JCP JSR-166 + * Expert Group and released to the public domain, as explained at + * http://creativecommons.org/licenses/publicdomain + * Other contributors include Andrew Wright, Jeffrey Hayes, + * Pat Fisher, Mike Judd. */ import junit.framework.*; public class SystemTest extends JSR166TestCase { public static void main(String[] args) { - junit.textui.TestRunner.run(suite()); + junit.textui.TestRunner.run(suite()); } - + public static Test suite() { - return new TestSuite(SystemTest.class); + return new TestSuite(SystemTest.class); } /** - * Nanos between readings of millis is no longer than millis. + * Worst case rounding for millisecs; set for 60 cycle millis clock. + * This value might need to be changed os JVMs with coarser + * System.currentTimeMillis clocks. + */ + static final long MILLIS_ROUND = 17; + + /** + * Nanos between readings of millis is no longer than millis (plus + * possible rounding). * This shows only that nano timing not (much) worse than milli. */ public void testNanoTime1() { @@ -31,17 +40,18 @@ public class SystemTest extends JSR166Te long m2 = System.currentTimeMillis(); long millis = m2 - m1; long nanos = n2 - n1; - assertTrue(nanos >= 0); - assertTrue(nanos <= millis * 1000000); + long nanosAsMillis = nanos / 1000000; + assertTrue(nanosAsMillis <= millis + MILLIS_ROUND); } catch(InterruptedException ie) { - fail("unexpected exception"); + unexpectedException(); } } /** - * Millis between readings of nanos is no longer than nanos + * Millis between readings of nanos is less than nanos, adjusting + * for rounding. * This shows only that nano timing not (much) worse than milli. */ public void testNanoTime2() { @@ -55,14 +65,14 @@ public class SystemTest extends JSR166Te long n2 = System.nanoTime(); long millis = m2 - m1; long nanos = n2 - n1; - + assertTrue(nanos >= 0); - assertTrue(millis * 1000000 <= nanos); + long nanosAsMillis = nanos / 1000000; + assertTrue(millis <= nanosAsMillis + MILLIS_ROUND); } catch(InterruptedException ie) { - fail("unexpected exception"); + unexpectedException(); } } } -