ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ThreadLocalRandomTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ThreadLocalRandomTest.java (file contents):
Revision 1.22 by jsr166, Sun Nov 13 03:36:50 2016 UTC vs.
Revision 1.30 by jsr166, Wed Aug 12 17:39:43 2020 UTC

# Line 57 | Line 57 | public class ThreadLocalRandomTest exten
57       * possible values.
58       */
59      public void testNext() throws ReflectiveOperationException {
60 +        // Inhibit "An illegal reflective access operation has occurred"
61 +        if (!testImplementationDetails) return;
62 +
63          ThreadLocalRandom rnd = ThreadLocalRandom.current();
64 +        final java.lang.reflect.Method m;
65          try {
66 <            java.lang.reflect.Method m
63 <                = ThreadLocalRandom.class.getDeclaredMethod(
64 <                    "next", new Class[] { int.class });
66 >            m = ThreadLocalRandom.class.getDeclaredMethod("next", int.class);
67              m.setAccessible(true);
68 +        } catch (SecurityException acceptable) {
69 +            // Security manager may deny access
70 +            return;
71 +        } catch (Exception ex) {
72 +            // jdk9 module system may deny access
73 +            if (ex.getClass().getSimpleName()
74 +                .equals("InaccessibleObjectException"))
75 +                return;
76 +            throw ex;
77 +        }
78  
79 <            int i;
80 <            {
81 <                int val = new java.util.Random().nextInt(4);
82 <                for (i = 0; i < NCALLS; i++) {
83 <                    int q = (int) m.invoke(rnd, new Object[] { 2 });
84 <                    if (val == q) break;
73 <                }
74 <                assertTrue(i < NCALLS);
79 >        int i;
80 >        {
81 >            int val = new java.util.Random().nextInt(4);
82 >            for (i = 0; i < NCALLS; i++) {
83 >                int q = (int) m.invoke(rnd, new Object[] { 2 });
84 >                if (val == q) break;
85              }
86 +            assertTrue(i < NCALLS);
87 +        }
88  
89 <            {
90 <                int r = (int) m.invoke(rnd, new Object[] { 3 });
91 <                for (i = 0; i < NCALLS; i++) {
92 <                    int q = (int) m.invoke(rnd, new Object[] { 3 });
93 <                    assertTrue(q < (1<<3));
94 <                    if (r != q) break;
83 <                }
84 <                assertTrue(i < NCALLS);
89 >        {
90 >            int r = (int) m.invoke(rnd, new Object[] { 3 });
91 >            for (i = 0; i < NCALLS; i++) {
92 >                int q = (int) m.invoke(rnd, new Object[] { 3 });
93 >                assertTrue(q < (1<<3));
94 >                if (r != q) break;
95              }
96 <        } catch (SecurityException acceptable) {}
96 >            assertTrue(i < NCALLS);
97 >        }
98      }
99  
100      /**
# Line 343 | Line 354 | public class ThreadLocalRandomTest exten
354          // Don't use main thread's ThreadLocalRandom - it is likely to
355          // be polluted by previous tests.
356          final AtomicReference<ThreadLocalRandom> threadLocalRandom =
357 <            new AtomicReference<ThreadLocalRandom>();
357 >            new AtomicReference<>();
358          final AtomicLong rand = new AtomicLong();
359  
349        long firstRand = 0;
350        ThreadLocalRandom firstThreadLocalRandom = null;
351
360          Runnable getRandomState = new CheckedRunnable() {
361              public void realRun() {
362                  ThreadLocalRandom current = ThreadLocalRandom.current();
363                  assertSame(current, ThreadLocalRandom.current());
356                // test bug: the following is not guaranteed and not true in JDK8
357                //                assertNotSame(current, threadLocalRandom.get());
364                  rand.set(current.nextLong());
365                  threadLocalRandom.set(current);
366              }};
367  
368 <        Thread first = newStartedThread(getRandomState);
369 <        awaitTermination(first);
370 <        firstRand = rand.get();
371 <        firstThreadLocalRandom = threadLocalRandom.get();
368 >        awaitTermination(newStartedThread(getRandomState));
369 >        long firstRand = rand.get();
370 >        ThreadLocalRandom firstThreadLocalRandom = threadLocalRandom.get();
371 >        assertNotNull(firstThreadLocalRandom);
372  
373          for (int i = 0; i < NCALLS; i++) {
374 <            Thread t = newStartedThread(getRandomState);
375 <            awaitTermination(t);
374 >            awaitTermination(newStartedThread(getRandomState));
375 >            if (testImplementationDetails)
376 >                // ThreadLocalRandom has been a singleton since jdk8.
377 >                assertSame(firstThreadLocalRandom, threadLocalRandom.get());
378              if (firstRand != rand.get())
379                  return;
380          }
381          fail("all threads generate the same pseudo-random sequence");
382      }
383  
384 +    /**
385 +     * Repeated calls to nextBytes produce at least values of different signs for every byte
386 +     */
387 +    public void testNextBytes() {
388 +        ThreadLocalRandom rnd = ThreadLocalRandom.current();
389 +        int n = rnd.nextInt(1, 20);
390 +        byte[] bytes = new byte[n];
391 +        outer:
392 +        for (int i = 0; i < n; i++) {
393 +            for (int tries = NCALLS; tries-->0; ) {
394 +                byte before = bytes[i];
395 +                rnd.nextBytes(bytes);
396 +                byte after = bytes[i];
397 +                if (after * before < 0)
398 +                    continue outer;
399 +            }
400 +            fail("not enough variation in random bytes");
401 +        }
402 +    }
403 +
404 +    /**
405 +     * Filling an empty array with random bytes succeeds without effect.
406 +     */
407 +    public void testNextBytes_emptyArray() {
408 +        ThreadLocalRandom.current().nextBytes(new byte[0]);
409 +    }
410 +
411 +    public void testNextBytes_nullArray() {
412 +        try {
413 +            ThreadLocalRandom.current().nextBytes(null);
414 +            shouldThrow();
415 +        } catch (NullPointerException success) {}
416 +    }
417 +
418   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines