ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ThreadLocalRandomTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ThreadLocalRandomTest.java (file contents):
Revision 1.11 by jsr166, Fri Jun 3 21:36:55 2011 UTC vs.
Revision 1.29 by jsr166, Sun Jan 28 16:41:13 2018 UTC

# Line 3 | Line 3
3   * Expert Group and released to the public domain, as explained at
4   * http://creativecommons.org/publicdomain/zero/1.0/
5   */
6 < import junit.framework.*;
7 < import java.util.*;
6 >
7   import java.util.concurrent.ThreadLocalRandom;
8   import java.util.concurrent.atomic.AtomicLong;
9   import java.util.concurrent.atomic.AtomicReference;
10  
11 + import junit.framework.Test;
12 + import junit.framework.TestSuite;
13 +
14   public class ThreadLocalRandomTest extends JSR166TestCase {
15  
16      public static void main(String[] args) {
17 <        junit.textui.TestRunner.run(suite());
17 >        main(suite(), args);
18      }
19      public static Test suite() {
20          return new TestSuite(ThreadLocalRandomTest.class);
21      }
22  
23 <    /**
23 >    /*
24       * Testing coverage notes:
25       *
26       * We don't test randomness properties, but only that repeated
# Line 27 | Line 29 | public class ThreadLocalRandomTest exten
29       * across multiples of primes.
30       */
31  
32 <    //
32 >    // max numbers of calls to detect getting stuck on one value
33      static final int NCALLS = 10000;
34  
35      // max sampled int bound
36      static final int MAX_INT_BOUND = (1 << 28);
37  
38 <    // Max sampled long bound
38 >    // max sampled long bound
39      static final long MAX_LONG_BOUND = (1L << 42);
40  
41 +    // Number of replications for other checks
42 +    static final int REPS = 20;
43 +
44      /**
45       * setSeed throws UnsupportedOperationException
46       */
# Line 47 | Line 52 | public class ThreadLocalRandomTest exten
52      }
53  
54      /**
55 <     * Repeated calls to nextInt produce at least one different result
55 >     * Repeated calls to next (only accessible via reflection) produce
56 >     * at least two distinct results, and repeated calls produce all
57 >     * possible values.
58 >     */
59 >    public void testNext() throws ReflectiveOperationException {
60 >        // Inhibit "An illegal reflective access operation has occurred"
61 >        if (!testImplementationDetails) return;
62 >
63 >        ThreadLocalRandom rnd = ThreadLocalRandom.current();
64 >        final java.lang.reflect.Method m;
65 >        try {
66 >            m = ThreadLocalRandom.class.getDeclaredMethod("next", int.class);
67 >            m.setAccessible(true);
68 >        } catch (SecurityException acceptable) {
69 >            // Security manager may deny access
70 >            return;
71 >        } catch (Exception ex) {
72 >            // jdk9 module system may deny access
73 >            if (ex.getClass().getSimpleName()
74 >                .equals("InaccessibleObjectException"))
75 >                return;
76 >            throw ex;
77 >        }
78 >
79 >        int i;
80 >        {
81 >            int val = new java.util.Random().nextInt(4);
82 >            for (i = 0; i < NCALLS; i++) {
83 >                int q = (int) m.invoke(rnd, new Object[] { 2 });
84 >                if (val == q) break;
85 >            }
86 >            assertTrue(i < NCALLS);
87 >        }
88 >
89 >        {
90 >            int r = (int) m.invoke(rnd, new Object[] { 3 });
91 >            for (i = 0; i < NCALLS; i++) {
92 >                int q = (int) m.invoke(rnd, new Object[] { 3 });
93 >                assertTrue(q < (1<<3));
94 >                if (r != q) break;
95 >            }
96 >            assertTrue(i < NCALLS);
97 >        }
98 >    }
99 >
100 >    /**
101 >     * Repeated calls to nextInt produce at least two distinct results
102       */
103      public void testNextInt() {
104          int f = ThreadLocalRandom.current().nextInt();
# Line 58 | Line 109 | public class ThreadLocalRandomTest exten
109      }
110  
111      /**
112 <     * Repeated calls to nextLong produce at least one different result
112 >     * Repeated calls to nextLong produce at least two distinct results
113       */
114      public void testNextLong() {
115          long f = ThreadLocalRandom.current().nextLong();
# Line 69 | Line 120 | public class ThreadLocalRandomTest exten
120      }
121  
122      /**
123 <     * Repeated calls to nextBoolean produce at least one different result
123 >     * Repeated calls to nextBoolean produce at least two distinct results
124       */
125      public void testNextBoolean() {
126          boolean f = ThreadLocalRandom.current().nextBoolean();
# Line 80 | Line 131 | public class ThreadLocalRandomTest exten
131      }
132  
133      /**
134 <     * Repeated calls to nextFloat produce at least one different result
134 >     * Repeated calls to nextFloat produce at least two distinct results
135       */
136      public void testNextFloat() {
137          float f = ThreadLocalRandom.current().nextFloat();
# Line 91 | Line 142 | public class ThreadLocalRandomTest exten
142      }
143  
144      /**
145 <     * Repeated calls to nextDouble produce at least one different result
145 >     * Repeated calls to nextDouble produce at least two distinct results
146       */
147      public void testNextDouble() {
148          double f = ThreadLocalRandom.current().nextDouble();
149 <        double i = 0;
149 >        int i = 0;
150          while (i < NCALLS && ThreadLocalRandom.current().nextDouble() == f)
151              ++i;
152          assertTrue(i < NCALLS);
153      }
154  
155      /**
156 <     * Repeated calls to nextGaussian produce at least one different result
156 >     * Repeated calls to nextGaussian produce at least two distinct results
157       */
158      public void testNextGaussian() {
159          double f = ThreadLocalRandom.current().nextGaussian();
# Line 113 | Line 164 | public class ThreadLocalRandomTest exten
164      }
165  
166      /**
167 <     * nextInt(negative) throws IllegalArgumentException;
167 >     * nextInt(non-positive) throws IllegalArgumentException
168       */
169 <    public void testNextIntBoundedNeg() {
170 <        try {
171 <            int f = ThreadLocalRandom.current().nextInt(-17);
172 <            shouldThrow();
173 <        } catch (IllegalArgumentException success) {}
169 >    public void testNextIntBoundNonPositive() {
170 >        ThreadLocalRandom rnd = ThreadLocalRandom.current();
171 >        for (int bound : new int[] { 0, -17, Integer.MIN_VALUE }) {
172 >            try {
173 >                rnd.nextInt(bound);
174 >                shouldThrow();
175 >            } catch (IllegalArgumentException success) {}
176 >        }
177      }
178  
179      /**
180 <     * nextInt(least >= bound) throws IllegalArgumentException;
180 >     * nextInt(least >= bound) throws IllegalArgumentException
181       */
182      public void testNextIntBadBounds() {
183 <        try {
184 <            int f = ThreadLocalRandom.current().nextInt(17, 2);
185 <            shouldThrow();
186 <        } catch (IllegalArgumentException success) {}
183 >        int[][] badBoundss = {
184 >            { 17, 2 },
185 >            { -42, -42 },
186 >            { Integer.MAX_VALUE, Integer.MIN_VALUE },
187 >        };
188 >        ThreadLocalRandom rnd = ThreadLocalRandom.current();
189 >        for (int[] badBounds : badBoundss) {
190 >            try {
191 >                rnd.nextInt(badBounds[0], badBounds[1]);
192 >                shouldThrow();
193 >            } catch (IllegalArgumentException success) {}
194 >        }
195      }
196  
197      /**
198       * nextInt(bound) returns 0 <= value < bound;
199 <     * repeated calls produce at least one different result
199 >     * repeated calls produce at least two distinct results
200       */
201      public void testNextIntBounded() {
202          // sample bound space across prime number increments
# Line 154 | Line 216 | public class ThreadLocalRandomTest exten
216  
217      /**
218       * nextInt(least, bound) returns least <= value < bound;
219 <     * repeated calls produce at least one different result
219 >     * repeated calls produce at least two distinct results
220       */
221      public void testNextIntBounded2() {
222          for (int least = -15485863; least < MAX_INT_BOUND; least += 524959) {
# Line 174 | Line 236 | public class ThreadLocalRandomTest exten
236      }
237  
238      /**
239 <     * nextLong(negative) throws IllegalArgumentException;
239 >     * nextLong(non-positive) throws IllegalArgumentException
240       */
241 <    public void testNextLongBoundedNeg() {
242 <        try {
243 <            long f = ThreadLocalRandom.current().nextLong(-17);
244 <            shouldThrow();
245 <        } catch (IllegalArgumentException success) {}
241 >    public void testNextLongBoundNonPositive() {
242 >        ThreadLocalRandom rnd = ThreadLocalRandom.current();
243 >        for (long bound : new long[] { 0L, -17L, Long.MIN_VALUE }) {
244 >            try {
245 >                rnd.nextLong(bound);
246 >                shouldThrow();
247 >            } catch (IllegalArgumentException success) {}
248 >        }
249      }
250  
251      /**
252 <     * nextLong(least >= bound) throws IllegalArgumentException;
252 >     * nextLong(least >= bound) throws IllegalArgumentException
253       */
254      public void testNextLongBadBounds() {
255 <        try {
256 <            long f = ThreadLocalRandom.current().nextLong(17, 2);
257 <            shouldThrow();
258 <        } catch (IllegalArgumentException success) {}
255 >        long[][] badBoundss = {
256 >            { 17L, 2L },
257 >            { -42L, -42L },
258 >            { Long.MAX_VALUE, Long.MIN_VALUE },
259 >        };
260 >        ThreadLocalRandom rnd = ThreadLocalRandom.current();
261 >        for (long[] badBounds : badBoundss) {
262 >            try {
263 >                rnd.nextLong(badBounds[0], badBounds[1]);
264 >                shouldThrow();
265 >            } catch (IllegalArgumentException success) {}
266 >        }
267      }
268  
269      /**
270       * nextLong(bound) returns 0 <= value < bound;
271 <     * repeated calls produce at least one different result
271 >     * repeated calls produce at least two distinct results
272       */
273      public void testNextLongBounded() {
274          for (long bound = 2; bound < MAX_LONG_BOUND; bound += 15485863) {
# Line 214 | Line 287 | public class ThreadLocalRandomTest exten
287  
288      /**
289       * nextLong(least, bound) returns least <= value < bound;
290 <     * repeated calls produce at least one different result
290 >     * repeated calls produce at least two distinct results
291       */
292      public void testNextLongBounded2() {
293          for (long least = -86028121; least < MAX_LONG_BOUND; least += 982451653L) {
# Line 234 | Line 307 | public class ThreadLocalRandomTest exten
307      }
308  
309      /**
310 +     * nextDouble(non-positive) throws IllegalArgumentException
311 +     */
312 +    public void testNextDoubleBoundNonPositive() {
313 +        ThreadLocalRandom rnd = ThreadLocalRandom.current();
314 +        double[] badBounds = {
315 +            0.0d,
316 +            -17.0d,
317 +            -Double.MIN_VALUE,
318 +            Double.NEGATIVE_INFINITY,
319 +            Double.NaN,
320 +        };
321 +        for (double bound : badBounds) {
322 +            try {
323 +                rnd.nextDouble(bound);
324 +                shouldThrow();
325 +            } catch (IllegalArgumentException success) {}
326 +        }
327 +    }
328 +
329 +    /**
330       * nextDouble(least, bound) returns least <= value < bound;
331 <     * repeated calls produce at least one different result
331 >     * repeated calls produce at least two distinct results
332       */
333      public void testNextDoubleBounded2() {
334          for (double least = 0.0001; least < 1.0e20; least *= 8) {
# Line 261 | Line 354 | public class ThreadLocalRandomTest exten
354          // Don't use main thread's ThreadLocalRandom - it is likely to
355          // be polluted by previous tests.
356          final AtomicReference<ThreadLocalRandom> threadLocalRandom =
357 <            new AtomicReference<ThreadLocalRandom>();
357 >            new AtomicReference<>();
358          final AtomicLong rand = new AtomicLong();
359  
360          long firstRand = 0;
361          ThreadLocalRandom firstThreadLocalRandom = null;
362  
363 <        final CheckedRunnable getRandomState = new CheckedRunnable() {
363 >        Runnable getRandomState = new CheckedRunnable() {
364              public void realRun() {
365                  ThreadLocalRandom current = ThreadLocalRandom.current();
366                  assertSame(current, ThreadLocalRandom.current());
367 <                assertNotSame(current, threadLocalRandom.get());
367 >                // test bug: the following is not guaranteed and not true in JDK8
368 >                //                assertNotSame(current, threadLocalRandom.get());
369                  rand.set(current.nextLong());
370                  threadLocalRandom.set(current);
371              }};
# Line 290 | Line 384 | public class ThreadLocalRandomTest exten
384          fail("all threads generate the same pseudo-random sequence");
385      }
386  
387 +    /**
388 +     * Repeated calls to nextBytes produce at least values of different signs for every byte
389 +     */
390 +    public void testNextBytes() {
391 +        ThreadLocalRandom rnd = ThreadLocalRandom.current();
392 +        int n = rnd.nextInt(1, 20);
393 +        byte[] bytes = new byte[n];
394 +        outer:
395 +        for (int i = 0; i < n; i++) {
396 +            for (int tries = NCALLS; tries-->0; ) {
397 +                byte before = bytes[i];
398 +                rnd.nextBytes(bytes);
399 +                byte after = bytes[i];
400 +                if (after * before < 0)
401 +                    continue outer;
402 +            }
403 +            fail("not enough variation in random bytes");
404 +        }
405 +    }
406 +
407 +    /**
408 +     * Filling an empty array with random bytes succeeds without effect.
409 +     */
410 +    public void testNextBytes_emptyArray() {
411 +        ThreadLocalRandom.current().nextBytes(new byte[0]);
412 +    }
413 +
414 +    public void testNextBytes_nullArray() {
415 +        try {
416 +            ThreadLocalRandom.current().nextBytes(null);
417 +            shouldThrow();
418 +        } catch (NullPointerException success) {}
419 +    }
420 +
421   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines