ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ThreadLocalRandomTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ThreadLocalRandomTest.java (file contents):
Revision 1.24 by jsr166, Sat Dec 10 12:39:15 2016 UTC vs.
Revision 1.29 by jsr166, Sun Jan 28 16:41:13 2018 UTC

# Line 57 | Line 57 | public class ThreadLocalRandomTest exten
57       * possible values.
58       */
59      public void testNext() throws ReflectiveOperationException {
60 +        // Inhibit "An illegal reflective access operation has occurred"
61 +        if (!testImplementationDetails) return;
62 +
63          ThreadLocalRandom rnd = ThreadLocalRandom.current();
64          final java.lang.reflect.Method m;
65          try {
66 <            m = ThreadLocalRandom.class.getDeclaredMethod(
64 <                    "next", new Class[] { int.class });
66 >            m = ThreadLocalRandom.class.getDeclaredMethod("next", int.class);
67              m.setAccessible(true);
68          } catch (SecurityException acceptable) {
69              // Security manager may deny access
# Line 352 | Line 354 | public class ThreadLocalRandomTest exten
354          // Don't use main thread's ThreadLocalRandom - it is likely to
355          // be polluted by previous tests.
356          final AtomicReference<ThreadLocalRandom> threadLocalRandom =
357 <            new AtomicReference<ThreadLocalRandom>();
357 >            new AtomicReference<>();
358          final AtomicLong rand = new AtomicLong();
359  
360          long firstRand = 0;
# Line 382 | Line 384 | public class ThreadLocalRandomTest exten
384          fail("all threads generate the same pseudo-random sequence");
385      }
386  
387 +    /**
388 +     * Repeated calls to nextBytes produce at least values of different signs for every byte
389 +     */
390 +    public void testNextBytes() {
391 +        ThreadLocalRandom rnd = ThreadLocalRandom.current();
392 +        int n = rnd.nextInt(1, 20);
393 +        byte[] bytes = new byte[n];
394 +        outer:
395 +        for (int i = 0; i < n; i++) {
396 +            for (int tries = NCALLS; tries-->0; ) {
397 +                byte before = bytes[i];
398 +                rnd.nextBytes(bytes);
399 +                byte after = bytes[i];
400 +                if (after * before < 0)
401 +                    continue outer;
402 +            }
403 +            fail("not enough variation in random bytes");
404 +        }
405 +    }
406 +
407 +    /**
408 +     * Filling an empty array with random bytes succeeds without effect.
409 +     */
410 +    public void testNextBytes_emptyArray() {
411 +        ThreadLocalRandom.current().nextBytes(new byte[0]);
412 +    }
413 +
414 +    public void testNextBytes_nullArray() {
415 +        try {
416 +            ThreadLocalRandom.current().nextBytes(null);
417 +            shouldThrow();
418 +        } catch (NullPointerException success) {}
419 +    }
420 +
421   }

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines