ViewVC Help

View File | Revision Log | Show Annotations | Download File | Root Listing

root/jsr166/jsr166/src/test/tck/ThreadPoolExecutorSubclassTest.java

Comparing jsr166/src/test/tck/ThreadPoolExecutorSubclassTest.java (file contents):
Revision 1.97 by jsr166, Wed Jan 4 06:09:58 2017 UTC vs.
Revision 1.107 by dl, Tue Mar 22 21:29:24 2022 UTC

#	Line 10 | Line 10 | import static java.util.concurrent.TimeU
10		import static java.util.concurrent.TimeUnit.SECONDS;
11
12		import java.util.ArrayList;
13	+	import java.util.Collection;
14	+	import java.util.Collections;
15		import java.util.List;
16		import java.util.concurrent.ArrayBlockingQueue;
17		import java.util.concurrent.BlockingQueue;
#	Line 21 | Line 23 | import java.util.concurrent.ExecutorServ
23		import java.util.concurrent.Future;
24		import java.util.concurrent.FutureTask;
25		import java.util.concurrent.LinkedBlockingQueue;
24	–	import java.util.concurrent.RejectedExecutionException;
26		import java.util.concurrent.RejectedExecutionHandler;
27		import java.util.concurrent.RunnableFuture;
28		import java.util.concurrent.SynchronousQueue;
29		import java.util.concurrent.ThreadFactory;
30	+	import java.util.concurrent.ThreadLocalRandom;
31		import java.util.concurrent.ThreadPoolExecutor;
32		import java.util.concurrent.TimeoutException;
33		import java.util.concurrent.TimeUnit;
#	Line 238 | Line 240 | public class ThreadPoolExecutorSubclassT
240		final Runnable task = new CheckedRunnable() {
241		public void realRun() { done.countDown(); }};
242		p.execute(task);
243	<	assertTrue(done.await(LONG_DELAY_MS, MILLISECONDS));
243	>	await(done);
244		}
245		}
246
#	Line 332 | Line 334 | public class ThreadPoolExecutorSubclassT
334		public void realRun() throws InterruptedException {
335		threadStarted.countDown();
336		assertEquals(0, p.getCompletedTaskCount());
337	<	threadProceed.await();
337	>	await(threadProceed);
338		threadDone.countDown();
339		}});
340		await(threadStarted);
341		assertEquals(0, p.getCompletedTaskCount());
342		threadProceed.countDown();
343	<	threadDone.await();
343	>	await(threadDone);
344		long startTime = System.nanoTime();
345		while (p.getCompletedTaskCount() != 1) {
346		if (millisElapsedSince(startTime) > LONG_DELAY_MS)
#	Line 658 | Line 660 | public class ThreadPoolExecutorSubclassT
660		q);
661		try (PoolCleaner cleaner = cleaner(p, done)) {
662		final CountDownLatch threadStarted = new CountDownLatch(1);
663	<	FutureTask[] tasks = new FutureTask[5];
663	>	FutureTask[] rtasks = new FutureTask[5];
664	>	@SuppressWarnings("unchecked")
665	>	FutureTask<Boolean>[] tasks = (FutureTask<Boolean>[])rtasks;
666		for (int i = 0; i < tasks.length; i++) {
667	<	Callable<Boolean> task = new CheckedCallable<Boolean>() {
667	>	Callable<Boolean> task = new CheckedCallable<>() {
668		public Boolean realCall() throws InterruptedException {
669		threadStarted.countDown();
670		assertSame(q, p.getQueue());
671		await(done);
672		return Boolean.TRUE;
673		}};
674	<	tasks[i] = new FutureTask(task);
674	>	tasks[i] = new FutureTask<>(task);
675		p.execute(tasks[i]);
676		}
677		await(threadStarted);
#	Line 724 | Line 728 | public class ThreadPoolExecutorSubclassT
728		LONG_DELAY_MS, MILLISECONDS,
729		q);
730		try (PoolCleaner cleaner = cleaner(p, done)) {
731	<	FutureTask[] tasks = new FutureTask[5];
731	>	FutureTask[] rtasks = new FutureTask[5];
732	>	@SuppressWarnings("unchecked")
733	>	FutureTask<Boolean>[] tasks = (FutureTask<Boolean>[])rtasks;
734		for (int i = 0; i < tasks.length; i++) {
735	<	Callable<Boolean> task = new CheckedCallable<Boolean>() {
735	>	Callable<Boolean> task = new CheckedCallable<>() {
736		public Boolean realCall() throws InterruptedException {
737		threadStarted.countDown();
738		await(done);
739		return Boolean.TRUE;
740		}};
741	<	tasks[i] = new FutureTask(task);
741	>	tasks[i] = new FutureTask<>(task);
742		p.execute(tasks[i]);
743		}
744		await(threadStarted);
#	Line 767 | Line 773 | public class ThreadPoolExecutorSubclassT
773		Runnable waiter = new CheckedRunnable() { public void realRun() {
774		threadsStarted.countDown();
775		try {
776	<	MILLISECONDS.sleep(2 * LONG_DELAY_MS);
776	>	MILLISECONDS.sleep(LONGER_DELAY_MS);
777		} catch (InterruptedException success) {}
778		ran.getAndIncrement();
779		}};
#	Line 1129 | Line 1135 | public class ThreadPoolExecutorSubclassT
1135		}
1136
1137		/**
1138	<	* execute throws RejectedExecutionException if saturated.
1138	>	* Submitted tasks are rejected when saturated or shutdown
1139		*/
1140	<	public void testSaturatedExecute() {
1135	<	final CountDownLatch done = new CountDownLatch(1);
1140	>	public void testSubmittedTasksRejectedWhenSaturatedOrShutdown() throws InterruptedException {
1141		final ThreadPoolExecutor p =
1142		new CustomTPE(1, 1,
1143		LONG_DELAY_MS, MILLISECONDS,
1144		new ArrayBlockingQueue<Runnable>(1));
1145	<	try (PoolCleaner cleaner = cleaner(p, done)) {
1146	<	Runnable task = new CheckedRunnable() {
1147	<	public void realRun() throws InterruptedException {
1148	<	await(done);
1149	<	}};
1150	<	for (int i = 0; i < 2; ++i)
1151	<	p.execute(task);
1147	<	for (int i = 0; i < 2; ++i) {
1145	>	final int saturatedSize = saturatedSize(p);
1146	>	final ThreadLocalRandom rnd = ThreadLocalRandom.current();
1147	>	final CountDownLatch threadsStarted = new CountDownLatch(p.getMaximumPoolSize());
1148	>	final CountDownLatch done = new CountDownLatch(1);
1149	>	final Runnable r = () -> {
1150	>	threadsStarted.countDown();
1151	>	for (;;) {
1152		try {
1153	<	p.execute(task);
1154	<	shouldThrow();
1155	<	} catch (RejectedExecutionException success) {}
1156	<	assertTrue(p.getTaskCount() <= 2);
1157	<	}
1158	<	}
1159	<	}
1153	>	done.await();
1154	>	return;
1155	>	} catch (InterruptedException shutdownNowDeliberatelyIgnored) {}
1156	>	}};
1157	>	final Callable<Boolean> c = () -> {
1158	>	threadsStarted.countDown();
1159	>	for (;;) {
1160	>	try {
1161	>	done.await();
1162	>	return Boolean.TRUE;
1163	>	} catch (InterruptedException shutdownNowDeliberatelyIgnored) {}
1164	>	}};
1165	>	final boolean shutdownNow = rnd.nextBoolean();
1166
1157	–	/**
1158	–	* executor using CallerRunsPolicy runs task if saturated.
1159	–	*/
1160	–	public void testSaturatedExecute2() {
1161	–	final CountDownLatch done = new CountDownLatch(1);
1162	–	final ThreadPoolExecutor p =
1163	–	new CustomTPE(1, 1,
1164	–	LONG_DELAY_MS, MILLISECONDS,
1165	–	new ArrayBlockingQueue<Runnable>(1),
1166	–	new CustomTPE.CallerRunsPolicy());
1167		try (PoolCleaner cleaner = cleaner(p, done)) {
1168	<	Runnable blocker = new CheckedRunnable() {
1169	<	public void realRun() throws InterruptedException {
1170	<	await(done);
1171	<	}};
1172	<	p.execute(blocker);
1173	<	TrackedNoOpRunnable[] tasks = new TrackedNoOpRunnable[5];
1174	<	for (int i = 0; i < tasks.length; i++)
1175	<	tasks[i] = new TrackedNoOpRunnable();
1176	<	for (int i = 0; i < tasks.length; i++)
1177	<	p.execute(tasks[i]);
1178	<	for (int i = 1; i < tasks.length; i++)
1179	<	assertTrue(tasks[i].done);
1180	<	assertFalse(tasks[0].done); // waiting in queue
1181	<	}
1182	<	}
1168	>	// saturate
1169	>	for (int i = saturatedSize; i--> 0; ) {
1170	>	switch (rnd.nextInt(4)) {
1171	>	case 0: p.execute(r); break;
1172	>	case 1: assertFalse(p.submit(r).isDone()); break;
1173	>	case 2: assertFalse(p.submit(r, Boolean.TRUE).isDone()); break;
1174	>	case 3: assertFalse(p.submit(c).isDone()); break;
1175	>	}
1176	>	}
1177
1178	<	/**
1179	<	* executor using DiscardPolicy drops task if saturated.
1180	<	*/
1181	<	public void testSaturatedExecute3() {
1182	<	final TrackedNoOpRunnable[] tasks = new TrackedNoOpRunnable[5];
1183	<	for (int i = 0; i < tasks.length; ++i)
1184	<	tasks[i] = new TrackedNoOpRunnable();
1185	<	final CountDownLatch done = new CountDownLatch(1);
1186	<	final ThreadPoolExecutor p =
1187	<	new CustomTPE(1, 1,
1194	<	LONG_DELAY_MS, MILLISECONDS,
1195	<	new ArrayBlockingQueue<Runnable>(1),
1196	<	new CustomTPE.DiscardPolicy());
1197	<	try (PoolCleaner cleaner = cleaner(p, done)) {
1198	<	p.execute(awaiter(done));
1178	>	await(threadsStarted);
1179	>	assertTaskSubmissionsAreRejected(p);
1180	>
1181	>	if (shutdownNow)
1182	>	p.shutdownNow();
1183	>	else
1184	>	p.shutdown();
1185	>	// Pool is shutdown, but not yet terminated
1186	>	assertTaskSubmissionsAreRejected(p);
1187	>	assertFalse(p.isTerminated());
1188
1189	<	for (TrackedNoOpRunnable task : tasks)
1190	<	p.execute(task);
1191	<	for (int i = 1; i < tasks.length; i++)
1192	<	assertFalse(tasks[i].done);
1193	<	}
1194	<	for (int i = 1; i < tasks.length; i++)
1195	<	assertFalse(tasks[i].done);
1196	<	assertTrue(tasks[0].done); // was waiting in queue
1189	>	done.countDown();   // release blocking tasks
1190	>	assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
1191	>
1192	>	assertTaskSubmissionsAreRejected(p);
1193	>	}
1194	>	assertEquals(saturatedSize(p)
1195	>	- (shutdownNow ? p.getQueue().remainingCapacity() : 0),
1196	>	p.getCompletedTaskCount());
1197		}
1198
1199		/**
1200		* executor using DiscardOldestPolicy drops oldest task if saturated.
1201		*/
1202	<	public void testSaturatedExecute4() {
1202	>	public void testSaturatedExecute_DiscardOldestPolicy() {
1203		final CountDownLatch done = new CountDownLatch(1);
1204		LatchAwaiter r1 = awaiter(done);
1205		LatchAwaiter r2 = awaiter(done);
#	Line 1219 | Line 1208 | public class ThreadPoolExecutorSubclassT
1208		new CustomTPE(1, 1,
1209		LONG_DELAY_MS, MILLISECONDS,
1210		new ArrayBlockingQueue<Runnable>(1),
1211	<	new CustomTPE.DiscardOldestPolicy());
1211	>	new ThreadPoolExecutor.DiscardOldestPolicy());
1212		try (PoolCleaner cleaner = cleaner(p, done)) {
1213		assertEquals(LatchAwaiter.NEW, r1.state);
1214		assertEquals(LatchAwaiter.NEW, r2.state);
#	Line 1237 | Line 1226 | public class ThreadPoolExecutorSubclassT
1226		}
1227
1228		/**
1240	–	* execute throws RejectedExecutionException if shutdown
1241	–	*/
1242	–	public void testRejectedExecutionExceptionOnShutdown() {
1243	–	final ThreadPoolExecutor p =
1244	–	new CustomTPE(1, 1,
1245	–	LONG_DELAY_MS, MILLISECONDS,
1246	–	new ArrayBlockingQueue<Runnable>(1));
1247	–	try { p.shutdown(); } catch (SecurityException ok) { return; }
1248	–	try (PoolCleaner cleaner = cleaner(p)) {
1249	–	try {
1250	–	p.execute(new NoOpRunnable());
1251	–	shouldThrow();
1252	–	} catch (RejectedExecutionException success) {}
1253	–	}
1254	–	}
1255	–
1256	–	/**
1257	–	* execute using CallerRunsPolicy drops task on shutdown
1258	–	*/
1259	–	public void testCallerRunsOnShutdown() {
1260	–	final ThreadPoolExecutor p =
1261	–	new CustomTPE(1, 1,
1262	–	LONG_DELAY_MS, MILLISECONDS,
1263	–	new ArrayBlockingQueue<Runnable>(1),
1264	–	new CustomTPE.CallerRunsPolicy());
1265	–	try { p.shutdown(); } catch (SecurityException ok) { return; }
1266	–	try (PoolCleaner cleaner = cleaner(p)) {
1267	–	TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1268	–	p.execute(r);
1269	–	assertFalse(r.done);
1270	–	}
1271	–	}
1272	–
1273	–	/**
1274	–	* execute using DiscardPolicy drops task on shutdown
1275	–	*/
1276	–	public void testDiscardOnShutdown() {
1277	–	final ThreadPoolExecutor p =
1278	–	new CustomTPE(1, 1,
1279	–	LONG_DELAY_MS, MILLISECONDS,
1280	–	new ArrayBlockingQueue<Runnable>(1),
1281	–	new CustomTPE.DiscardPolicy());
1282	–	try { p.shutdown(); } catch (SecurityException ok) { return; }
1283	–	try (PoolCleaner cleaner = cleaner(p)) {
1284	–	TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1285	–	p.execute(r);
1286	–	assertFalse(r.done);
1287	–	}
1288	–	}
1289	–
1290	–	/**
1229		* execute using DiscardOldestPolicy drops task on shutdown
1230		*/
1231		public void testDiscardOldestOnShutdown() {
#	Line 1295 | Line 1233 | public class ThreadPoolExecutorSubclassT
1233		new CustomTPE(1, 1,
1234		LONG_DELAY_MS, MILLISECONDS,
1235		new ArrayBlockingQueue<Runnable>(1),
1236	<	new CustomTPE.DiscardOldestPolicy());
1236	>	new ThreadPoolExecutor.DiscardOldestPolicy());
1237
1238		try { p.shutdown(); } catch (SecurityException ok) { return; }
1239		try (PoolCleaner cleaner = cleaner(p)) {
#	Line 1306 | Line 1244 | public class ThreadPoolExecutorSubclassT
1244		}
1245
1246		/**
1247	<	* execute(null) throws NPE
1247	>	* Submitting null tasks throws NullPointerException
1248		*/
1249	<	public void testExecuteNull() {
1249	>	public void testNullTaskSubmission() {
1250		final ThreadPoolExecutor p =
1251		new CustomTPE(1, 2,
1252		1L, SECONDS,
1253		new ArrayBlockingQueue<Runnable>(10));
1254		try (PoolCleaner cleaner = cleaner(p)) {
1255	<	try {
1318	<	p.execute(null);
1319	<	shouldThrow();
1320	<	} catch (NullPointerException success) {}
1255	>	assertNullTaskSubmissionThrowsNullPointerException(p);
1256		}
1257		}
1258
#	Line 1361 | Line 1296 | public class ThreadPoolExecutorSubclassT
1296		public void testMaximumPoolSizeIllegalArgumentException2() {
1297		final ThreadPoolExecutor p =
1298		new CustomTPE(2, 3,
1299	<	LONG_DELAY_MS,
1300	<	MILLISECONDS,new ArrayBlockingQueue<Runnable>(10));
1299	>	LONG_DELAY_MS, MILLISECONDS,
1300	>	new ArrayBlockingQueue<Runnable>(10));
1301		try (PoolCleaner cleaner = cleaner(p)) {
1302		try {
1303		p.setMaximumPoolSize(-1);
#	Line 1464 | Line 1399 | public class ThreadPoolExecutorSubclassT
1399		}
1400
1401		/**
1402	<	* invokeAny(null) throws NPE
1402	>	* invokeAny(null) throws NullPointerException
1403		*/
1404		public void testInvokeAny1() throws Exception {
1405		final ExecutorService e =
#	Line 1480 | Line 1415 | public class ThreadPoolExecutorSubclassT
1415		}
1416
1417		/**
1418	<	* invokeAny(empty collection) throws IAE
1418	>	* invokeAny(empty collection) throws IllegalArgumentException
1419		*/
1420		public void testInvokeAny2() throws Exception {
1421		final ExecutorService e =
#	Line 1570 | Line 1505 | public class ThreadPoolExecutorSubclassT
1505		}
1506
1507		/**
1508	<	* invokeAll(empty collection) returns empty collection
1508	>	* invokeAll(empty collection) returns empty list
1509		*/
1510		public void testInvokeAll2() throws Exception {
1511		final ExecutorService e =
1512		new CustomTPE(2, 2,
1513		LONG_DELAY_MS, MILLISECONDS,
1514		new ArrayBlockingQueue<Runnable>(10));
1515	+	final Collection<Callable<String>> emptyCollection
1516	+	= Collections.emptyList();
1517		try (PoolCleaner cleaner = cleaner(e)) {
1518	<	List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>());
1518	>	List<Future<String>> r = e.invokeAll(emptyCollection);
1519		assertTrue(r.isEmpty());
1520		}
1521		}
#	Line 1653 | Line 1590 | public class ThreadPoolExecutorSubclassT
1590		new ArrayBlockingQueue<Runnable>(10));
1591		try (PoolCleaner cleaner = cleaner(e)) {
1592		try {
1593	<	e.invokeAny(null, MEDIUM_DELAY_MS, MILLISECONDS);
1593	>	e.invokeAny(null, randomTimeout(), randomTimeUnit());
1594		shouldThrow();
1595		} catch (NullPointerException success) {}
1596		}
#	Line 1671 | Line 1608 | public class ThreadPoolExecutorSubclassT
1608		List<Callable<String>> l = new ArrayList<>();
1609		l.add(new StringTask());
1610		try {
1611	<	e.invokeAny(l, MEDIUM_DELAY_MS, null);
1611	>	e.invokeAny(l, randomTimeout(), null);
1612		shouldThrow();
1613		} catch (NullPointerException success) {}
1614		}
1615		}
1616
1617		/**
1618	<	* timed invokeAny(empty collection) throws IAE
1618	>	* timed invokeAny(empty collection) throws IllegalArgumentException
1619		*/
1620		public void testTimedInvokeAny2() throws Exception {
1621		final ExecutorService e =
1622		new CustomTPE(2, 2,
1623		LONG_DELAY_MS, MILLISECONDS,
1624		new ArrayBlockingQueue<Runnable>(10));
1625	+	final Collection<Callable<String>> emptyCollection
1626	+	= Collections.emptyList();
1627		try (PoolCleaner cleaner = cleaner(e)) {
1628		try {
1629	<	e.invokeAny(new ArrayList<Callable<String>>(),
1691	<	MEDIUM_DELAY_MS, MILLISECONDS);
1629	>	e.invokeAny(emptyCollection, randomTimeout(), randomTimeUnit());
1630		shouldThrow();
1631		} catch (IllegalArgumentException success) {}
1632		}
#	Line 1708 | Line 1646 | public class ThreadPoolExecutorSubclassT
1646		l.add(latchAwaitingStringTask(latch));
1647		l.add(null);
1648		try {
1649	<	e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1649	>	e.invokeAny(l, randomTimeout(), randomTimeUnit());
1650		shouldThrow();
1651		} catch (NullPointerException success) {}
1652		latch.countDown();
#	Line 1766 | Line 1704 | public class ThreadPoolExecutorSubclassT
1704		new ArrayBlockingQueue<Runnable>(10));
1705		try (PoolCleaner cleaner = cleaner(e)) {
1706		try {
1707	<	e.invokeAll(null, MEDIUM_DELAY_MS, MILLISECONDS);
1707	>	e.invokeAll(null, randomTimeout(), randomTimeUnit());
1708		shouldThrow();
1709		} catch (NullPointerException success) {}
1710		}
#	Line 1784 | Line 1722 | public class ThreadPoolExecutorSubclassT
1722		List<Callable<String>> l = new ArrayList<>();
1723		l.add(new StringTask());
1724		try {
1725	<	e.invokeAll(l, MEDIUM_DELAY_MS, null);
1725	>	e.invokeAll(l, randomTimeout(), null);
1726		shouldThrow();
1727		} catch (NullPointerException success) {}
1728		}
1729		}
1730
1731		/**
1732	<	* timed invokeAll(empty collection) returns empty collection
1732	>	* timed invokeAll(empty collection) returns empty list
1733		*/
1734		public void testTimedInvokeAll2() throws Exception {
1735		final ExecutorService e =
1736		new CustomTPE(2, 2,
1737		LONG_DELAY_MS, MILLISECONDS,
1738		new ArrayBlockingQueue<Runnable>(10));
1739	+	final Collection<Callable<String>> emptyCollection
1740	+	= Collections.emptyList();
1741		try (PoolCleaner cleaner = cleaner(e)) {
1742	<	List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>(),
1743	<	MEDIUM_DELAY_MS, MILLISECONDS);
1742	>	List<Future<String>> r =
1743	>	e.invokeAll(emptyCollection, randomTimeout(), randomTimeUnit());
1744		assertTrue(r.isEmpty());
1745		}
1746		}
#	Line 1818 | Line 1758 | public class ThreadPoolExecutorSubclassT
1758		l.add(new StringTask());
1759		l.add(null);
1760		try {
1761	<	e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1761	>	e.invokeAll(l, randomTimeout(), randomTimeUnit());
1762		shouldThrow();
1763		} catch (NullPointerException success) {}
1764		}
#	Line 1873 | Line 1813 | public class ThreadPoolExecutorSubclassT
1813		public void testTimedInvokeAll6() throws Exception {
1814		for (long timeout = timeoutMillis();;) {
1815		final CountDownLatch done = new CountDownLatch(1);
1816	<	final Callable<String> waiter = new CheckedCallable<String>() {
1816	>	final Callable<String> waiter = new CheckedCallable<>() {
1817		public String realCall() {
1818		try { done.await(LONG_DELAY_MS, MILLISECONDS); }
1819		catch (InterruptedException ok) {}
#	Line 1892 | Line 1832 | public class ThreadPoolExecutorSubclassT
1832		p.invokeAll(tasks, timeout, MILLISECONDS);
1833		assertEquals(tasks.size(), futures.size());
1834		assertTrue(millisElapsedSince(startTime) >= timeout);
1835	<	for (Future future : futures)
1835	>	for (Future<?> future : futures)
1836		assertTrue(future.isDone());
1837		assertTrue(futures.get(1).isCancelled());
1838		try {
#	Line 1926 | Line 1866 | public class ThreadPoolExecutorSubclassT
1866		public void realRun() {
1867		done.countDown();
1868		}});
1869	<	assertTrue(done.await(LONG_DELAY_MS, MILLISECONDS));
1869	>	await(done);
1870		}
1871		}
1872
#	Line 2030 | Line 1970 | public class ThreadPoolExecutorSubclassT
1970		}
1971		}
1972		}
1973	+	@SuppressWarnings("removal")
1974	+	public void testFinalizeMethodCallsSuperFinalize() {
1975	+	new CustomTPE(1, 1,
1976	+	LONG_DELAY_MS, MILLISECONDS,
1977	+	new LinkedBlockingQueue<Runnable>()) {
1978	+
1979	+	/**
1980	+	* A finalize method without "throws Throwable", that
1981	+	* calls super.finalize().
1982	+	*/
1983	+	protected void finalize() {
1984	+	super.finalize();
1985	+	}
1986	+	}.shutdown();
1987	+	}
1988
1989		}

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines
>	Changed lines