ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ThreadPoolExecutorTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ThreadPoolExecutorTest.java (file contents):
Revision 1.42 by jsr166, Sat May 7 19:34:51 2011 UTC vs.
Revision 1.124 by jsr166, Mon Jul 17 22:27:31 2017 UTC

# Line 6 | Line 6
6   * Pat Fisher, Mike Judd.
7   */
8  
9 import java.util.concurrent.*;
9   import static java.util.concurrent.TimeUnit.MILLISECONDS;
10 < import java.util.concurrent.atomic.*;
11 < import junit.framework.*;
12 < import java.util.*;
10 > import static java.util.concurrent.TimeUnit.NANOSECONDS;
11 > import static java.util.concurrent.TimeUnit.SECONDS;
12 >
13 > import java.util.ArrayList;
14 > import java.util.Collection;
15 > import java.util.Collections;
16 > import java.util.List;
17 > import java.util.concurrent.ArrayBlockingQueue;
18 > import java.util.concurrent.BlockingQueue;
19 > import java.util.concurrent.Callable;
20 > import java.util.concurrent.CancellationException;
21 > import java.util.concurrent.CountDownLatch;
22 > import java.util.concurrent.ExecutionException;
23 > import java.util.concurrent.ExecutorService;
24 > import java.util.concurrent.Future;
25 > import java.util.concurrent.FutureTask;
26 > import java.util.concurrent.LinkedBlockingQueue;
27 > import java.util.concurrent.RejectedExecutionException;
28 > import java.util.concurrent.RejectedExecutionHandler;
29 > import java.util.concurrent.SynchronousQueue;
30 > import java.util.concurrent.ThreadFactory;
31 > import java.util.concurrent.ThreadLocalRandom;
32 > import java.util.concurrent.ThreadPoolExecutor;
33 > import java.util.concurrent.ThreadPoolExecutor.AbortPolicy;
34 > import java.util.concurrent.ThreadPoolExecutor.CallerRunsPolicy;
35 > import java.util.concurrent.ThreadPoolExecutor.DiscardPolicy;
36 > import java.util.concurrent.ThreadPoolExecutor.DiscardOldestPolicy;
37 > import java.util.concurrent.atomic.AtomicInteger;
38 > import java.util.concurrent.atomic.AtomicReference;
39 >
40 > import junit.framework.Test;
41 > import junit.framework.TestSuite;
42  
43   public class ThreadPoolExecutorTest extends JSR166TestCase {
44      public static void main(String[] args) {
45 <        junit.textui.TestRunner.run(suite());
45 >        main(suite(), args);
46      }
47      public static Test suite() {
48          return new TestSuite(ThreadPoolExecutorTest.class);
49      }
50  
51      static class ExtendedTPE extends ThreadPoolExecutor {
52 <        volatile boolean beforeCalled = false;
53 <        volatile boolean afterCalled = false;
54 <        volatile boolean terminatedCalled = false;
52 >        final CountDownLatch beforeCalled = new CountDownLatch(1);
53 >        final CountDownLatch afterCalled = new CountDownLatch(1);
54 >        final CountDownLatch terminatedCalled = new CountDownLatch(1);
55 >
56          public ExtendedTPE() {
57              super(1, 1, LONG_DELAY_MS, MILLISECONDS, new SynchronousQueue<Runnable>());
58          }
59          protected void beforeExecute(Thread t, Runnable r) {
60 <            beforeCalled = true;
60 >            beforeCalled.countDown();
61          }
62          protected void afterExecute(Runnable r, Throwable t) {
63 <            afterCalled = true;
63 >            afterCalled.countDown();
64          }
65          protected void terminated() {
66 <            terminatedCalled = true;
66 >            terminatedCalled.countDown();
67 >        }
68 >
69 >        public boolean beforeCalled() {
70 >            return beforeCalled.getCount() == 0;
71 >        }
72 >        public boolean afterCalled() {
73 >            return afterCalled.getCount() == 0;
74 >        }
75 >        public boolean terminatedCalled() {
76 >            return terminatedCalled.getCount() == 0;
77          }
78      }
79  
# Line 46 | Line 85 | public class ThreadPoolExecutorTest exte
85          }
86      }
87  
49
88      /**
89       * execute successfully executes a runnable
90       */
# Line 55 | Line 93 | public class ThreadPoolExecutorTest exte
93              new ThreadPoolExecutor(1, 1,
94                                     LONG_DELAY_MS, MILLISECONDS,
95                                     new ArrayBlockingQueue<Runnable>(10));
96 <        final CountDownLatch done = new CountDownLatch(1);
97 <        final Runnable task = new CheckedRunnable() {
98 <            public void realRun() {
99 <                done.countDown();
62 <            }};
63 <        try {
96 >        try (PoolCleaner cleaner = cleaner(p)) {
97 >            final CountDownLatch done = new CountDownLatch(1);
98 >            final Runnable task = new CheckedRunnable() {
99 >                public void realRun() { done.countDown(); }};
100              p.execute(task);
101 <            assertTrue(done.await(SMALL_DELAY_MS, MILLISECONDS));
66 <        } finally {
67 <            joinPool(p);
101 >            await(done);
102          }
103      }
104  
# Line 73 | Line 107 | public class ThreadPoolExecutorTest exte
107       * thread becomes active
108       */
109      public void testGetActiveCount() throws InterruptedException {
110 +        final CountDownLatch done = new CountDownLatch(1);
111          final ThreadPoolExecutor p =
112              new ThreadPoolExecutor(2, 2,
113                                     LONG_DELAY_MS, MILLISECONDS,
114                                     new ArrayBlockingQueue<Runnable>(10));
115 <        final CountDownLatch threadStarted = new CountDownLatch(1);
116 <        final CountDownLatch done = new CountDownLatch(1);
82 <        try {
115 >        try (PoolCleaner cleaner = cleaner(p, done)) {
116 >            final CountDownLatch threadStarted = new CountDownLatch(1);
117              assertEquals(0, p.getActiveCount());
118              p.execute(new CheckedRunnable() {
119                  public void realRun() throws InterruptedException {
120                      threadStarted.countDown();
121                      assertEquals(1, p.getActiveCount());
122 <                    done.await();
122 >                    await(done);
123                  }});
124 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
124 >            await(threadStarted);
125              assertEquals(1, p.getActiveCount());
92        } finally {
93            done.countDown();
94            joinPool(p);
126          }
127      }
128  
# Line 100 | Line 131 | public class ThreadPoolExecutorTest exte
131       */
132      public void testPrestartCoreThread() {
133          final ThreadPoolExecutor p =
134 <            new ThreadPoolExecutor(2, 2,
134 >            new ThreadPoolExecutor(2, 6,
135                                     LONG_DELAY_MS, MILLISECONDS,
136                                     new ArrayBlockingQueue<Runnable>(10));
137 <        assertEquals(0, p.getPoolSize());
138 <        assertTrue(p.prestartCoreThread());
139 <        assertEquals(1, p.getPoolSize());
140 <        assertTrue(p.prestartCoreThread());
141 <        assertEquals(2, p.getPoolSize());
142 <        assertFalse(p.prestartCoreThread());
143 <        assertEquals(2, p.getPoolSize());
144 <        joinPool(p);
137 >        try (PoolCleaner cleaner = cleaner(p)) {
138 >            assertEquals(0, p.getPoolSize());
139 >            assertTrue(p.prestartCoreThread());
140 >            assertEquals(1, p.getPoolSize());
141 >            assertTrue(p.prestartCoreThread());
142 >            assertEquals(2, p.getPoolSize());
143 >            assertFalse(p.prestartCoreThread());
144 >            assertEquals(2, p.getPoolSize());
145 >            p.setCorePoolSize(4);
146 >            assertTrue(p.prestartCoreThread());
147 >            assertEquals(3, p.getPoolSize());
148 >            assertTrue(p.prestartCoreThread());
149 >            assertEquals(4, p.getPoolSize());
150 >            assertFalse(p.prestartCoreThread());
151 >            assertEquals(4, p.getPoolSize());
152 >        }
153      }
154  
155      /**
# Line 118 | Line 157 | public class ThreadPoolExecutorTest exte
157       */
158      public void testPrestartAllCoreThreads() {
159          final ThreadPoolExecutor p =
160 <            new ThreadPoolExecutor(2, 2,
160 >            new ThreadPoolExecutor(2, 6,
161                                     LONG_DELAY_MS, MILLISECONDS,
162                                     new ArrayBlockingQueue<Runnable>(10));
163 <        assertEquals(0, p.getPoolSize());
164 <        p.prestartAllCoreThreads();
165 <        assertEquals(2, p.getPoolSize());
166 <        p.prestartAllCoreThreads();
167 <        assertEquals(2, p.getPoolSize());
168 <        joinPool(p);
163 >        try (PoolCleaner cleaner = cleaner(p)) {
164 >            assertEquals(0, p.getPoolSize());
165 >            p.prestartAllCoreThreads();
166 >            assertEquals(2, p.getPoolSize());
167 >            p.prestartAllCoreThreads();
168 >            assertEquals(2, p.getPoolSize());
169 >            p.setCorePoolSize(4);
170 >            p.prestartAllCoreThreads();
171 >            assertEquals(4, p.getPoolSize());
172 >            p.prestartAllCoreThreads();
173 >            assertEquals(4, p.getPoolSize());
174 >        }
175      }
176  
177      /**
# Line 138 | Line 183 | public class ThreadPoolExecutorTest exte
183              new ThreadPoolExecutor(2, 2,
184                                     LONG_DELAY_MS, MILLISECONDS,
185                                     new ArrayBlockingQueue<Runnable>(10));
186 <        final CountDownLatch threadStarted = new CountDownLatch(1);
187 <        final CountDownLatch threadProceed = new CountDownLatch(1);
188 <        final CountDownLatch threadDone = new CountDownLatch(1);
189 <        try {
186 >        try (PoolCleaner cleaner = cleaner(p)) {
187 >            final CountDownLatch threadStarted = new CountDownLatch(1);
188 >            final CountDownLatch threadProceed = new CountDownLatch(1);
189 >            final CountDownLatch threadDone = new CountDownLatch(1);
190              assertEquals(0, p.getCompletedTaskCount());
191              p.execute(new CheckedRunnable() {
192                  public void realRun() throws InterruptedException {
193                      threadStarted.countDown();
194                      assertEquals(0, p.getCompletedTaskCount());
195 <                    threadProceed.await();
195 >                    await(threadProceed);
196                      threadDone.countDown();
197                  }});
198 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
198 >            await(threadStarted);
199              assertEquals(0, p.getCompletedTaskCount());
200              threadProceed.countDown();
201 <            threadDone.await();
202 <            delay(SHORT_DELAY_MS);
203 <            assertEquals(1, p.getCompletedTaskCount());
204 <        } finally {
205 <            joinPool(p);
201 >            await(threadDone);
202 >            long startTime = System.nanoTime();
203 >            while (p.getCompletedTaskCount() != 1) {
204 >                if (millisElapsedSince(startTime) > LONG_DELAY_MS)
205 >                    fail("timed out");
206 >                Thread.yield();
207 >            }
208          }
209      }
210  
# Line 169 | Line 216 | public class ThreadPoolExecutorTest exte
216              new ThreadPoolExecutor(1, 1,
217                                     LONG_DELAY_MS, MILLISECONDS,
218                                     new ArrayBlockingQueue<Runnable>(10));
219 <        assertEquals(1, p.getCorePoolSize());
220 <        joinPool(p);
219 >        try (PoolCleaner cleaner = cleaner(p)) {
220 >            assertEquals(1, p.getCorePoolSize());
221 >        }
222      }
223  
224      /**
# Line 181 | Line 229 | public class ThreadPoolExecutorTest exte
229              new ThreadPoolExecutor(2, 2,
230                                     1000, MILLISECONDS,
231                                     new ArrayBlockingQueue<Runnable>(10));
232 <        assertEquals(1, p.getKeepAliveTime(TimeUnit.SECONDS));
233 <        joinPool(p);
232 >        try (PoolCleaner cleaner = cleaner(p)) {
233 >            assertEquals(1, p.getKeepAliveTime(SECONDS));
234 >        }
235      }
236  
188
237      /**
238       * getThreadFactory returns factory in constructor if not set
239       */
240      public void testGetThreadFactory() {
241 <        ThreadFactory tf = new SimpleThreadFactory();
241 >        ThreadFactory threadFactory = new SimpleThreadFactory();
242          final ThreadPoolExecutor p =
243              new ThreadPoolExecutor(1, 2,
244                                     LONG_DELAY_MS, MILLISECONDS,
245                                     new ArrayBlockingQueue<Runnable>(10),
246 <                                   tf,
246 >                                   threadFactory,
247                                     new NoOpREHandler());
248 <        assertSame(tf, p.getThreadFactory());
249 <        joinPool(p);
248 >        try (PoolCleaner cleaner = cleaner(p)) {
249 >            assertSame(threadFactory, p.getThreadFactory());
250 >        }
251      }
252  
253      /**
# Line 209 | Line 258 | public class ThreadPoolExecutorTest exte
258              new ThreadPoolExecutor(1, 2,
259                                     LONG_DELAY_MS, MILLISECONDS,
260                                     new ArrayBlockingQueue<Runnable>(10));
261 <        ThreadFactory tf = new SimpleThreadFactory();
262 <        p.setThreadFactory(tf);
263 <        assertSame(tf, p.getThreadFactory());
264 <        joinPool(p);
261 >        try (PoolCleaner cleaner = cleaner(p)) {
262 >            ThreadFactory threadFactory = new SimpleThreadFactory();
263 >            p.setThreadFactory(threadFactory);
264 >            assertSame(threadFactory, p.getThreadFactory());
265 >        }
266      }
267  
218
268      /**
269       * setThreadFactory(null) throws NPE
270       */
# Line 224 | Line 273 | public class ThreadPoolExecutorTest exte
273              new ThreadPoolExecutor(1, 2,
274                                     LONG_DELAY_MS, MILLISECONDS,
275                                     new ArrayBlockingQueue<Runnable>(10));
276 <        try {
277 <            p.setThreadFactory(null);
278 <            shouldThrow();
279 <        } catch (NullPointerException success) {
280 <        } finally {
281 <            joinPool(p);
276 >        try (PoolCleaner cleaner = cleaner(p)) {
277 >            try {
278 >                p.setThreadFactory(null);
279 >                shouldThrow();
280 >            } catch (NullPointerException success) {}
281 >        }
282 >    }
283 >
284 >    /**
285 >     * The default rejected execution handler is AbortPolicy.
286 >     */
287 >    public void testDefaultRejectedExecutionHandler() {
288 >        final ThreadPoolExecutor p =
289 >            new ThreadPoolExecutor(1, 2,
290 >                                   LONG_DELAY_MS, MILLISECONDS,
291 >                                   new ArrayBlockingQueue<Runnable>(10));
292 >        try (PoolCleaner cleaner = cleaner(p)) {
293 >            assertTrue(p.getRejectedExecutionHandler() instanceof AbortPolicy);
294          }
295      }
296  
# Line 237 | Line 298 | public class ThreadPoolExecutorTest exte
298       * getRejectedExecutionHandler returns handler in constructor if not set
299       */
300      public void testGetRejectedExecutionHandler() {
301 <        final RejectedExecutionHandler h = new NoOpREHandler();
301 >        final RejectedExecutionHandler handler = new NoOpREHandler();
302          final ThreadPoolExecutor p =
303              new ThreadPoolExecutor(1, 2,
304                                     LONG_DELAY_MS, MILLISECONDS,
305                                     new ArrayBlockingQueue<Runnable>(10),
306 <                                   h);
307 <        assertSame(h, p.getRejectedExecutionHandler());
308 <        joinPool(p);
306 >                                   handler);
307 >        try (PoolCleaner cleaner = cleaner(p)) {
308 >            assertSame(handler, p.getRejectedExecutionHandler());
309 >        }
310      }
311  
312      /**
# Line 256 | Line 318 | public class ThreadPoolExecutorTest exte
318              new ThreadPoolExecutor(1, 2,
319                                     LONG_DELAY_MS, MILLISECONDS,
320                                     new ArrayBlockingQueue<Runnable>(10));
321 <        RejectedExecutionHandler h = new NoOpREHandler();
322 <        p.setRejectedExecutionHandler(h);
323 <        assertSame(h, p.getRejectedExecutionHandler());
324 <        joinPool(p);
321 >        try (PoolCleaner cleaner = cleaner(p)) {
322 >            RejectedExecutionHandler handler = new NoOpREHandler();
323 >            p.setRejectedExecutionHandler(handler);
324 >            assertSame(handler, p.getRejectedExecutionHandler());
325 >        }
326      }
327  
265
328      /**
329       * setRejectedExecutionHandler(null) throws NPE
330       */
# Line 271 | Line 333 | public class ThreadPoolExecutorTest exte
333              new ThreadPoolExecutor(1, 2,
334                                     LONG_DELAY_MS, MILLISECONDS,
335                                     new ArrayBlockingQueue<Runnable>(10));
336 <        try {
337 <            p.setRejectedExecutionHandler(null);
338 <            shouldThrow();
339 <        } catch (NullPointerException success) {
340 <        } finally {
279 <            joinPool(p);
336 >        try (PoolCleaner cleaner = cleaner(p)) {
337 >            try {
338 >                p.setRejectedExecutionHandler(null);
339 >                shouldThrow();
340 >            } catch (NullPointerException success) {}
341          }
342      }
343  
283
344      /**
345       * getLargestPoolSize increases, but doesn't overestimate, when
346       * multiple threads active
347       */
348      public void testGetLargestPoolSize() throws InterruptedException {
349          final int THREADS = 3;
350 +        final CountDownLatch done = new CountDownLatch(1);
351          final ThreadPoolExecutor p =
352              new ThreadPoolExecutor(THREADS, THREADS,
353                                     LONG_DELAY_MS, MILLISECONDS,
354                                     new ArrayBlockingQueue<Runnable>(10));
355 <        final CountDownLatch threadsStarted = new CountDownLatch(THREADS);
295 <        final CountDownLatch done = new CountDownLatch(1);
296 <        try {
355 >        try (PoolCleaner cleaner = cleaner(p, done)) {
356              assertEquals(0, p.getLargestPoolSize());
357 +            final CountDownLatch threadsStarted = new CountDownLatch(THREADS);
358              for (int i = 0; i < THREADS; i++)
359                  p.execute(new CheckedRunnable() {
360                      public void realRun() throws InterruptedException {
361                          threadsStarted.countDown();
362 <                        done.await();
362 >                        await(done);
363                          assertEquals(THREADS, p.getLargestPoolSize());
364                      }});
365 <            assertTrue(threadsStarted.await(SMALL_DELAY_MS, MILLISECONDS));
306 <            assertEquals(THREADS, p.getLargestPoolSize());
307 <        } finally {
308 <            done.countDown();
309 <            joinPool(p);
365 >            await(threadsStarted);
366              assertEquals(THREADS, p.getLargestPoolSize());
367          }
368 +        assertEquals(THREADS, p.getLargestPoolSize());
369      }
370  
371      /**
# Line 320 | Line 377 | public class ThreadPoolExecutorTest exte
377              new ThreadPoolExecutor(2, 3,
378                                     LONG_DELAY_MS, MILLISECONDS,
379                                     new ArrayBlockingQueue<Runnable>(10));
380 <        assertEquals(3, p.getMaximumPoolSize());
381 <        joinPool(p);
380 >        try (PoolCleaner cleaner = cleaner(p)) {
381 >            assertEquals(3, p.getMaximumPoolSize());
382 >            p.setMaximumPoolSize(5);
383 >            assertEquals(5, p.getMaximumPoolSize());
384 >            p.setMaximumPoolSize(4);
385 >            assertEquals(4, p.getMaximumPoolSize());
386 >        }
387      }
388  
389      /**
# Line 329 | Line 391 | public class ThreadPoolExecutorTest exte
391       * become active
392       */
393      public void testGetPoolSize() throws InterruptedException {
394 +        final CountDownLatch done = new CountDownLatch(1);
395          final ThreadPoolExecutor p =
396              new ThreadPoolExecutor(1, 1,
397                                     LONG_DELAY_MS, MILLISECONDS,
398                                     new ArrayBlockingQueue<Runnable>(10));
399 <        final CountDownLatch threadStarted = new CountDownLatch(1);
337 <        final CountDownLatch done = new CountDownLatch(1);
338 <        try {
399 >        try (PoolCleaner cleaner = cleaner(p, done)) {
400              assertEquals(0, p.getPoolSize());
401 +            final CountDownLatch threadStarted = new CountDownLatch(1);
402              p.execute(new CheckedRunnable() {
403                  public void realRun() throws InterruptedException {
404                      threadStarted.countDown();
405                      assertEquals(1, p.getPoolSize());
406 <                    done.await();
406 >                    await(done);
407                  }});
408 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
408 >            await(threadStarted);
409              assertEquals(1, p.getPoolSize());
348        } finally {
349            done.countDown();
350            joinPool(p);
410          }
411      }
412  
# Line 355 | Line 414 | public class ThreadPoolExecutorTest exte
414       * getTaskCount increases, but doesn't overestimate, when tasks submitted
415       */
416      public void testGetTaskCount() throws InterruptedException {
417 +        final int TASKS = 3;
418 +        final CountDownLatch done = new CountDownLatch(1);
419          final ThreadPoolExecutor p =
420              new ThreadPoolExecutor(1, 1,
421                                     LONG_DELAY_MS, MILLISECONDS,
422                                     new ArrayBlockingQueue<Runnable>(10));
423 <        final CountDownLatch threadStarted = new CountDownLatch(1);
424 <        final CountDownLatch done = new CountDownLatch(1);
364 <        try {
423 >        try (PoolCleaner cleaner = cleaner(p, done)) {
424 >            final CountDownLatch threadStarted = new CountDownLatch(1);
425              assertEquals(0, p.getTaskCount());
426 +            assertEquals(0, p.getCompletedTaskCount());
427              p.execute(new CheckedRunnable() {
428                  public void realRun() throws InterruptedException {
429                      threadStarted.countDown();
430 <                    assertEquals(1, p.getTaskCount());
370 <                    done.await();
430 >                    await(done);
431                  }});
432 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
432 >            await(threadStarted);
433              assertEquals(1, p.getTaskCount());
434 <        } finally {
435 <            done.countDown();
436 <            joinPool(p);
434 >            assertEquals(0, p.getCompletedTaskCount());
435 >            for (int i = 0; i < TASKS; i++) {
436 >                assertEquals(1 + i, p.getTaskCount());
437 >                p.execute(new CheckedRunnable() {
438 >                    public void realRun() throws InterruptedException {
439 >                        threadStarted.countDown();
440 >                        assertEquals(1 + TASKS, p.getTaskCount());
441 >                        await(done);
442 >                    }});
443 >            }
444 >            assertEquals(1 + TASKS, p.getTaskCount());
445 >            assertEquals(0, p.getCompletedTaskCount());
446          }
447 +        assertEquals(1 + TASKS, p.getTaskCount());
448 +        assertEquals(1 + TASKS, p.getCompletedTaskCount());
449      }
450  
451      /**
452 <     * isShutDown is false before shutdown, true after
452 >     * isShutdown is false before shutdown, true after
453       */
454      public void testIsShutdown() {
455          final ThreadPoolExecutor p =
456              new ThreadPoolExecutor(1, 1,
457                                     LONG_DELAY_MS, MILLISECONDS,
458                                     new ArrayBlockingQueue<Runnable>(10));
459 <        assertFalse(p.isShutdown());
460 <        try { p.shutdown(); } catch (SecurityException ok) { return; }
461 <        assertTrue(p.isShutdown());
462 <        joinPool(p);
459 >        try (PoolCleaner cleaner = cleaner(p)) {
460 >            assertFalse(p.isShutdown());
461 >            try { p.shutdown(); } catch (SecurityException ok) { return; }
462 >            assertTrue(p.isShutdown());
463 >        }
464      }
465  
466 +    /**
467 +     * awaitTermination on a non-shutdown pool times out
468 +     */
469 +    public void testAwaitTermination_timesOut() throws InterruptedException {
470 +        final ThreadPoolExecutor p =
471 +            new ThreadPoolExecutor(1, 1,
472 +                                   LONG_DELAY_MS, MILLISECONDS,
473 +                                   new ArrayBlockingQueue<Runnable>(10));
474 +        try (PoolCleaner cleaner = cleaner(p)) {
475 +            assertFalse(p.isTerminated());
476 +            assertFalse(p.awaitTermination(Long.MIN_VALUE, NANOSECONDS));
477 +            assertFalse(p.awaitTermination(Long.MIN_VALUE, MILLISECONDS));
478 +            assertFalse(p.awaitTermination(-1L, NANOSECONDS));
479 +            assertFalse(p.awaitTermination(-1L, MILLISECONDS));
480 +            assertFalse(p.awaitTermination(randomExpiredTimeout(),
481 +                                           randomTimeUnit()));
482 +            long timeoutNanos = 999999L;
483 +            long startTime = System.nanoTime();
484 +            assertFalse(p.awaitTermination(timeoutNanos, NANOSECONDS));
485 +            assertTrue(System.nanoTime() - startTime >= timeoutNanos);
486 +            assertFalse(p.isTerminated());
487 +            startTime = System.nanoTime();
488 +            long timeoutMillis = timeoutMillis();
489 +            assertFalse(p.awaitTermination(timeoutMillis, MILLISECONDS));
490 +            assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
491 +            assertFalse(p.isTerminated());
492 +            try { p.shutdown(); } catch (SecurityException ok) { return; }
493 +            assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
494 +            assertTrue(p.isTerminated());
495 +        }
496 +    }
497  
498      /**
499       * isTerminated is false before termination, true after
# Line 400 | Line 503 | public class ThreadPoolExecutorTest exte
503              new ThreadPoolExecutor(1, 1,
504                                     LONG_DELAY_MS, MILLISECONDS,
505                                     new ArrayBlockingQueue<Runnable>(10));
506 <        final CountDownLatch threadStarted = new CountDownLatch(1);
507 <        final CountDownLatch done = new CountDownLatch(1);
508 <        assertFalse(p.isTerminated());
509 <        try {
506 >        try (PoolCleaner cleaner = cleaner(p)) {
507 >            final CountDownLatch threadStarted = new CountDownLatch(1);
508 >            final CountDownLatch done = new CountDownLatch(1);
509 >            assertFalse(p.isTerminating());
510              p.execute(new CheckedRunnable() {
511                  public void realRun() throws InterruptedException {
512 <                    assertFalse(p.isTerminated());
512 >                    assertFalse(p.isTerminating());
513                      threadStarted.countDown();
514 <                    done.await();
514 >                    await(done);
515                  }});
516 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
516 >            await(threadStarted);
517              assertFalse(p.isTerminating());
518              done.countDown();
416        } finally {
519              try { p.shutdown(); } catch (SecurityException ok) { return; }
520 +            assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
521 +            assertTrue(p.isTerminated());
522 +            assertFalse(p.isTerminating());
523          }
419        assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
420        assertTrue(p.isTerminated());
524      }
525  
526      /**
# Line 428 | Line 531 | public class ThreadPoolExecutorTest exte
531              new ThreadPoolExecutor(1, 1,
532                                     LONG_DELAY_MS, MILLISECONDS,
533                                     new ArrayBlockingQueue<Runnable>(10));
534 <        final CountDownLatch threadStarted = new CountDownLatch(1);
535 <        final CountDownLatch done = new CountDownLatch(1);
536 <        try {
534 >        try (PoolCleaner cleaner = cleaner(p)) {
535 >            final CountDownLatch threadStarted = new CountDownLatch(1);
536 >            final CountDownLatch done = new CountDownLatch(1);
537              assertFalse(p.isTerminating());
538              p.execute(new CheckedRunnable() {
539                  public void realRun() throws InterruptedException {
540                      assertFalse(p.isTerminating());
541                      threadStarted.countDown();
542 <                    done.await();
542 >                    await(done);
543                  }});
544 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
544 >            await(threadStarted);
545              assertFalse(p.isTerminating());
546              done.countDown();
444        } finally {
547              try { p.shutdown(); } catch (SecurityException ok) { return; }
548 +            assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
549 +            assertTrue(p.isTerminated());
550 +            assertFalse(p.isTerminating());
551          }
447        assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
448        assertTrue(p.isTerminated());
449        assertFalse(p.isTerminating());
552      }
553  
554      /**
555       * getQueue returns the work queue, which contains queued tasks
556       */
557      public void testGetQueue() throws InterruptedException {
558 <        final BlockingQueue<Runnable> q = new ArrayBlockingQueue<Runnable>(10);
558 >        final CountDownLatch done = new CountDownLatch(1);
559 >        final BlockingQueue<Runnable> q = new ArrayBlockingQueue<>(10);
560          final ThreadPoolExecutor p =
561              new ThreadPoolExecutor(1, 1,
562                                     LONG_DELAY_MS, MILLISECONDS,
563                                     q);
564 <        final CountDownLatch threadStarted = new CountDownLatch(1);
565 <        final CountDownLatch done = new CountDownLatch(1);
463 <        try {
564 >        try (PoolCleaner cleaner = cleaner(p, done)) {
565 >            final CountDownLatch threadStarted = new CountDownLatch(1);
566              FutureTask[] tasks = new FutureTask[5];
567              for (int i = 0; i < tasks.length; i++) {
568                  Callable task = new CheckedCallable<Boolean>() {
569                      public Boolean realCall() throws InterruptedException {
570                          threadStarted.countDown();
571                          assertSame(q, p.getQueue());
572 <                        done.await();
572 >                        await(done);
573                          return Boolean.TRUE;
574                      }};
575                  tasks[i] = new FutureTask(task);
576                  p.execute(tasks[i]);
577              }
578 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
578 >            await(threadStarted);
579              assertSame(q, p.getQueue());
580              assertFalse(q.contains(tasks[0]));
581              assertTrue(q.contains(tasks[tasks.length - 1]));
582              assertEquals(tasks.length - 1, q.size());
481        } finally {
482            done.countDown();
483            joinPool(p);
583          }
584      }
585  
# Line 488 | Line 587 | public class ThreadPoolExecutorTest exte
587       * remove(task) removes queued task, and fails to remove active task
588       */
589      public void testRemove() throws InterruptedException {
590 <        BlockingQueue<Runnable> q = new ArrayBlockingQueue<Runnable>(10);
590 >        final CountDownLatch done = new CountDownLatch(1);
591 >        BlockingQueue<Runnable> q = new ArrayBlockingQueue<>(10);
592          final ThreadPoolExecutor p =
593              new ThreadPoolExecutor(1, 1,
594                                     LONG_DELAY_MS, MILLISECONDS,
595                                     q);
596 <        Runnable[] tasks = new Runnable[5];
597 <        final CountDownLatch threadStarted = new CountDownLatch(1);
598 <        final CountDownLatch done = new CountDownLatch(1);
499 <        try {
596 >        try (PoolCleaner cleaner = cleaner(p, done)) {
597 >            Runnable[] tasks = new Runnable[6];
598 >            final CountDownLatch threadStarted = new CountDownLatch(1);
599              for (int i = 0; i < tasks.length; i++) {
600                  tasks[i] = new CheckedRunnable() {
601                      public void realRun() throws InterruptedException {
602                          threadStarted.countDown();
603 <                        done.await();
603 >                        await(done);
604                      }};
605                  p.execute(tasks[i]);
606              }
607 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
607 >            await(threadStarted);
608              assertFalse(p.remove(tasks[0]));
609              assertTrue(q.contains(tasks[4]));
610              assertTrue(q.contains(tasks[3]));
# Line 515 | Line 614 | public class ThreadPoolExecutorTest exte
614              assertTrue(q.contains(tasks[3]));
615              assertTrue(p.remove(tasks[3]));
616              assertFalse(q.contains(tasks[3]));
518        } finally {
519            done.countDown();
520            joinPool(p);
617          }
618      }
619  
# Line 527 | Line 623 | public class ThreadPoolExecutorTest exte
623      public void testPurge() throws InterruptedException {
624          final CountDownLatch threadStarted = new CountDownLatch(1);
625          final CountDownLatch done = new CountDownLatch(1);
626 <        final BlockingQueue<Runnable> q = new ArrayBlockingQueue<Runnable>(10);
626 >        final BlockingQueue<Runnable> q = new ArrayBlockingQueue<>(10);
627          final ThreadPoolExecutor p =
628              new ThreadPoolExecutor(1, 1,
629                                     LONG_DELAY_MS, MILLISECONDS,
630                                     q);
631 <        FutureTask[] tasks = new FutureTask[5];
632 <        try {
631 >        try (PoolCleaner cleaner = cleaner(p, done)) {
632 >            FutureTask[] tasks = new FutureTask[5];
633              for (int i = 0; i < tasks.length; i++) {
634                  Callable task = new CheckedCallable<Boolean>() {
635                      public Boolean realCall() throws InterruptedException {
636                          threadStarted.countDown();
637 <                        done.await();
637 >                        await(done);
638                          return Boolean.TRUE;
639                      }};
640                  tasks[i] = new FutureTask(task);
641                  p.execute(tasks[i]);
642              }
643 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
643 >            await(threadStarted);
644              assertEquals(tasks.length, p.getTaskCount());
645              assertEquals(tasks.length - 1, q.size());
646              assertEquals(1L, p.getActiveCount());
# Line 557 | Line 653 | public class ThreadPoolExecutorTest exte
653              p.purge();         // Nothing to do
654              assertEquals(tasks.length - 3, q.size());
655              assertEquals(tasks.length - 2, p.getTaskCount());
560        } finally {
561            done.countDown();
562            joinPool(p);
656          }
657      }
658  
659      /**
660 <     * shutDownNow returns a list containing tasks that were not run
660 >     * shutdownNow returns a list containing tasks that were not run,
661 >     * and those tasks are drained from the queue
662       */
663 <    public void testShutdownNow() {
663 >    public void testShutdownNow() throws InterruptedException {
664 >        final int poolSize = 2;
665 >        final int count = 5;
666 >        final AtomicInteger ran = new AtomicInteger(0);
667          final ThreadPoolExecutor p =
668 <            new ThreadPoolExecutor(1, 1,
668 >            new ThreadPoolExecutor(poolSize, poolSize,
669                                     LONG_DELAY_MS, MILLISECONDS,
670                                     new ArrayBlockingQueue<Runnable>(10));
671 <        List l;
672 <        try {
673 <            for (int i = 0; i < 5; i++)
577 <                p.execute(new MediumPossiblyInterruptedRunnable());
578 <        }
579 <        finally {
671 >        final CountDownLatch threadsStarted = new CountDownLatch(poolSize);
672 >        Runnable waiter = new CheckedRunnable() { public void realRun() {
673 >            threadsStarted.countDown();
674              try {
675 <                l = p.shutdownNow();
676 <            } catch (SecurityException ok) { return; }
675 >                MILLISECONDS.sleep(2 * LONG_DELAY_MS);
676 >            } catch (InterruptedException success) {}
677 >            ran.getAndIncrement();
678 >        }};
679 >        for (int i = 0; i < count; i++)
680 >            p.execute(waiter);
681 >        await(threadsStarted);
682 >        assertEquals(poolSize, p.getActiveCount());
683 >        assertEquals(0, p.getCompletedTaskCount());
684 >        final List<Runnable> queuedTasks;
685 >        try {
686 >            queuedTasks = p.shutdownNow();
687 >        } catch (SecurityException ok) {
688 >            return; // Allowed in case test doesn't have privs
689          }
690          assertTrue(p.isShutdown());
691 <        assertTrue(l.size() <= 4);
691 >        assertTrue(p.getQueue().isEmpty());
692 >        assertEquals(count - poolSize, queuedTasks.size());
693 >        assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
694 >        assertTrue(p.isTerminated());
695 >        assertEquals(poolSize, ran.get());
696 >        assertEquals(poolSize, p.getCompletedTaskCount());
697      }
698  
699      // Exception Tests
700  
590
701      /**
702       * Constructor throws if corePoolSize argument is less than zero
703       */
704      public void testConstructor1() {
705          try {
706 <            new ThreadPoolExecutor(-1, 1,
597 <                                   LONG_DELAY_MS, MILLISECONDS,
706 >            new ThreadPoolExecutor(-1, 1, 1L, SECONDS,
707                                     new ArrayBlockingQueue<Runnable>(10));
708              shouldThrow();
709          } catch (IllegalArgumentException success) {}
# Line 605 | Line 714 | public class ThreadPoolExecutorTest exte
714       */
715      public void testConstructor2() {
716          try {
717 <            new ThreadPoolExecutor(1, -1,
609 <                                   LONG_DELAY_MS, MILLISECONDS,
717 >            new ThreadPoolExecutor(1, -1, 1L, SECONDS,
718                                     new ArrayBlockingQueue<Runnable>(10));
719              shouldThrow();
720          } catch (IllegalArgumentException success) {}
# Line 617 | Line 725 | public class ThreadPoolExecutorTest exte
725       */
726      public void testConstructor3() {
727          try {
728 <            new ThreadPoolExecutor(1, 0,
621 <                                   LONG_DELAY_MS, MILLISECONDS,
728 >            new ThreadPoolExecutor(1, 0, 1L, SECONDS,
729                                     new ArrayBlockingQueue<Runnable>(10));
730              shouldThrow();
731          } catch (IllegalArgumentException success) {}
# Line 629 | Line 736 | public class ThreadPoolExecutorTest exte
736       */
737      public void testConstructor4() {
738          try {
739 <            new ThreadPoolExecutor(1, 2,
633 <                                   -1L, MILLISECONDS,
739 >            new ThreadPoolExecutor(1, 2, -1L, SECONDS,
740                                     new ArrayBlockingQueue<Runnable>(10));
741              shouldThrow();
742          } catch (IllegalArgumentException success) {}
# Line 641 | Line 747 | public class ThreadPoolExecutorTest exte
747       */
748      public void testConstructor5() {
749          try {
750 <            new ThreadPoolExecutor(2, 1,
645 <                                   LONG_DELAY_MS, MILLISECONDS,
750 >            new ThreadPoolExecutor(2, 1, 1L, SECONDS,
751                                     new ArrayBlockingQueue<Runnable>(10));
752              shouldThrow();
753          } catch (IllegalArgumentException success) {}
# Line 653 | Line 758 | public class ThreadPoolExecutorTest exte
758       */
759      public void testConstructorNullPointerException() {
760          try {
761 <            new ThreadPoolExecutor(1, 2,
657 <                                   LONG_DELAY_MS, MILLISECONDS,
761 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
762                                     (BlockingQueue) null);
763              shouldThrow();
764          } catch (NullPointerException success) {}
765      }
766  
663
664
767      /**
768       * Constructor throws if corePoolSize argument is less than zero
769       */
770      public void testConstructor6() {
771          try {
772 <            new ThreadPoolExecutor(-1, 1,
671 <                                   LONG_DELAY_MS, MILLISECONDS,
772 >            new ThreadPoolExecutor(-1, 1, 1L, SECONDS,
773                                     new ArrayBlockingQueue<Runnable>(10),
774                                     new SimpleThreadFactory());
775              shouldThrow();
# Line 680 | Line 781 | public class ThreadPoolExecutorTest exte
781       */
782      public void testConstructor7() {
783          try {
784 <            new ThreadPoolExecutor(1, -1,
684 <                                   LONG_DELAY_MS, MILLISECONDS,
784 >            new ThreadPoolExecutor(1, -1, 1L, SECONDS,
785                                     new ArrayBlockingQueue<Runnable>(10),
786                                     new SimpleThreadFactory());
787              shouldThrow();
# Line 693 | Line 793 | public class ThreadPoolExecutorTest exte
793       */
794      public void testConstructor8() {
795          try {
796 <            new ThreadPoolExecutor(1, 0,
697 <                                   LONG_DELAY_MS, MILLISECONDS,
796 >            new ThreadPoolExecutor(1, 0, 1L, SECONDS,
797                                     new ArrayBlockingQueue<Runnable>(10),
798                                     new SimpleThreadFactory());
799              shouldThrow();
# Line 706 | Line 805 | public class ThreadPoolExecutorTest exte
805       */
806      public void testConstructor9() {
807          try {
808 <            new ThreadPoolExecutor(1, 2,
710 <                                   -1L, MILLISECONDS,
808 >            new ThreadPoolExecutor(1, 2, -1L, SECONDS,
809                                     new ArrayBlockingQueue<Runnable>(10),
810                                     new SimpleThreadFactory());
811              shouldThrow();
# Line 719 | Line 817 | public class ThreadPoolExecutorTest exte
817       */
818      public void testConstructor10() {
819          try {
820 <            new ThreadPoolExecutor(2, 1,
723 <                                   LONG_DELAY_MS, MILLISECONDS,
820 >            new ThreadPoolExecutor(2, 1, 1L, SECONDS,
821                                     new ArrayBlockingQueue<Runnable>(10),
822                                     new SimpleThreadFactory());
823              shouldThrow();
# Line 732 | Line 829 | public class ThreadPoolExecutorTest exte
829       */
830      public void testConstructorNullPointerException2() {
831          try {
832 <            new ThreadPoolExecutor(1, 2,
736 <                                   LONG_DELAY_MS, MILLISECONDS,
832 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
833                                     (BlockingQueue) null,
834                                     new SimpleThreadFactory());
835              shouldThrow();
# Line 745 | Line 841 | public class ThreadPoolExecutorTest exte
841       */
842      public void testConstructorNullPointerException3() {
843          try {
844 <            new ThreadPoolExecutor(1, 2,
749 <                                   LONG_DELAY_MS, MILLISECONDS,
844 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
845                                     new ArrayBlockingQueue<Runnable>(10),
846                                     (ThreadFactory) null);
847              shouldThrow();
848          } catch (NullPointerException success) {}
849      }
850  
756
851      /**
852       * Constructor throws if corePoolSize argument is less than zero
853       */
854      public void testConstructor11() {
855          try {
856 <            new ThreadPoolExecutor(-1, 1,
763 <                                   LONG_DELAY_MS, MILLISECONDS,
856 >            new ThreadPoolExecutor(-1, 1, 1L, SECONDS,
857                                     new ArrayBlockingQueue<Runnable>(10),
858                                     new NoOpREHandler());
859              shouldThrow();
# Line 772 | Line 865 | public class ThreadPoolExecutorTest exte
865       */
866      public void testConstructor12() {
867          try {
868 <            new ThreadPoolExecutor(1, -1,
776 <                                   LONG_DELAY_MS, MILLISECONDS,
868 >            new ThreadPoolExecutor(1, -1, 1L, SECONDS,
869                                     new ArrayBlockingQueue<Runnable>(10),
870                                     new NoOpREHandler());
871              shouldThrow();
# Line 785 | Line 877 | public class ThreadPoolExecutorTest exte
877       */
878      public void testConstructor13() {
879          try {
880 <            new ThreadPoolExecutor(1, 0,
789 <                                   LONG_DELAY_MS, MILLISECONDS,
880 >            new ThreadPoolExecutor(1, 0, 1L, SECONDS,
881                                     new ArrayBlockingQueue<Runnable>(10),
882                                     new NoOpREHandler());
883              shouldThrow();
# Line 798 | Line 889 | public class ThreadPoolExecutorTest exte
889       */
890      public void testConstructor14() {
891          try {
892 <            new ThreadPoolExecutor(1, 2,
802 <                                   -1L, MILLISECONDS,
892 >            new ThreadPoolExecutor(1, 2, -1L, SECONDS,
893                                     new ArrayBlockingQueue<Runnable>(10),
894                                     new NoOpREHandler());
895              shouldThrow();
# Line 811 | Line 901 | public class ThreadPoolExecutorTest exte
901       */
902      public void testConstructor15() {
903          try {
904 <            new ThreadPoolExecutor(2, 1,
815 <                                   LONG_DELAY_MS, MILLISECONDS,
904 >            new ThreadPoolExecutor(2, 1, 1L, SECONDS,
905                                     new ArrayBlockingQueue<Runnable>(10),
906                                     new NoOpREHandler());
907              shouldThrow();
# Line 824 | Line 913 | public class ThreadPoolExecutorTest exte
913       */
914      public void testConstructorNullPointerException4() {
915          try {
916 <            new ThreadPoolExecutor(1, 2,
828 <                                   LONG_DELAY_MS, MILLISECONDS,
916 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
917                                     (BlockingQueue) null,
918                                     new NoOpREHandler());
919              shouldThrow();
# Line 837 | Line 925 | public class ThreadPoolExecutorTest exte
925       */
926      public void testConstructorNullPointerException5() {
927          try {
928 <            new ThreadPoolExecutor(1, 2,
841 <                                   LONG_DELAY_MS, MILLISECONDS,
928 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
929                                     new ArrayBlockingQueue<Runnable>(10),
930                                     (RejectedExecutionHandler) null);
931              shouldThrow();
932          } catch (NullPointerException success) {}
933      }
934  
848
935      /**
936       * Constructor throws if corePoolSize argument is less than zero
937       */
938      public void testConstructor16() {
939          try {
940 <            new ThreadPoolExecutor(-1, 1,
855 <                                   LONG_DELAY_MS, MILLISECONDS,
940 >            new ThreadPoolExecutor(-1, 1, 1L, SECONDS,
941                                     new ArrayBlockingQueue<Runnable>(10),
942                                     new SimpleThreadFactory(),
943                                     new NoOpREHandler());
# Line 865 | Line 950 | public class ThreadPoolExecutorTest exte
950       */
951      public void testConstructor17() {
952          try {
953 <            new ThreadPoolExecutor(1, -1,
869 <                                   LONG_DELAY_MS, MILLISECONDS,
953 >            new ThreadPoolExecutor(1, -1, 1L, SECONDS,
954                                     new ArrayBlockingQueue<Runnable>(10),
955                                     new SimpleThreadFactory(),
956                                     new NoOpREHandler());
# Line 879 | Line 963 | public class ThreadPoolExecutorTest exte
963       */
964      public void testConstructor18() {
965          try {
966 <            new ThreadPoolExecutor(1, 0,
883 <                                   LONG_DELAY_MS, MILLISECONDS,
966 >            new ThreadPoolExecutor(1, 0, 1L, SECONDS,
967                                     new ArrayBlockingQueue<Runnable>(10),
968                                     new SimpleThreadFactory(),
969                                     new NoOpREHandler());
# Line 893 | Line 976 | public class ThreadPoolExecutorTest exte
976       */
977      public void testConstructor19() {
978          try {
979 <            new ThreadPoolExecutor(1, 2,
897 <                                   -1L, MILLISECONDS,
979 >            new ThreadPoolExecutor(1, 2, -1L, SECONDS,
980                                     new ArrayBlockingQueue<Runnable>(10),
981                                     new SimpleThreadFactory(),
982                                     new NoOpREHandler());
# Line 907 | Line 989 | public class ThreadPoolExecutorTest exte
989       */
990      public void testConstructor20() {
991          try {
992 <            new ThreadPoolExecutor(2, 1,
911 <                                   LONG_DELAY_MS, MILLISECONDS,
992 >            new ThreadPoolExecutor(2, 1, 1L, SECONDS,
993                                     new ArrayBlockingQueue<Runnable>(10),
994                                     new SimpleThreadFactory(),
995                                     new NoOpREHandler());
# Line 921 | Line 1002 | public class ThreadPoolExecutorTest exte
1002       */
1003      public void testConstructorNullPointerException6() {
1004          try {
1005 <            new ThreadPoolExecutor(1, 2,
925 <                                   LONG_DELAY_MS, MILLISECONDS,
1005 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
1006                                     (BlockingQueue) null,
1007                                     new SimpleThreadFactory(),
1008                                     new NoOpREHandler());
# Line 935 | Line 1015 | public class ThreadPoolExecutorTest exte
1015       */
1016      public void testConstructorNullPointerException7() {
1017          try {
1018 <            new ThreadPoolExecutor(1, 2,
939 <                                   LONG_DELAY_MS, MILLISECONDS,
1018 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
1019                                     new ArrayBlockingQueue<Runnable>(10),
1020                                     new SimpleThreadFactory(),
1021                                     (RejectedExecutionHandler) null);
# Line 949 | Line 1028 | public class ThreadPoolExecutorTest exte
1028       */
1029      public void testConstructorNullPointerException8() {
1030          try {
1031 <            new ThreadPoolExecutor(1, 2,
953 <                                   LONG_DELAY_MS, MILLISECONDS,
1031 >            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
1032                                     new ArrayBlockingQueue<Runnable>(10),
1033                                     (ThreadFactory) null,
1034                                     new NoOpREHandler());
# Line 962 | Line 1040 | public class ThreadPoolExecutorTest exte
1040       * get of submitted callable throws InterruptedException if interrupted
1041       */
1042      public void testInterruptedSubmit() throws InterruptedException {
1043 +        final CountDownLatch done = new CountDownLatch(1);
1044          final ThreadPoolExecutor p =
1045              new ThreadPoolExecutor(1, 1,
1046 <                                   60, TimeUnit.SECONDS,
1046 >                                   60, SECONDS,
1047                                     new ArrayBlockingQueue<Runnable>(10));
1048  
1049 <        final CountDownLatch threadStarted = new CountDownLatch(1);
1050 <        final CountDownLatch done = new CountDownLatch(1);
972 <        try {
1049 >        try (PoolCleaner cleaner = cleaner(p, done)) {
1050 >            final CountDownLatch threadStarted = new CountDownLatch(1);
1051              Thread t = newStartedThread(new CheckedInterruptedRunnable() {
1052                  public void realRun() throws Exception {
1053                      Callable task = new CheckedCallable<Boolean>() {
1054                          public Boolean realCall() throws InterruptedException {
1055                              threadStarted.countDown();
1056 <                            done.await();
1056 >                            await(done);
1057                              return Boolean.TRUE;
1058                          }};
1059                      p.submit(task).get();
1060                  }});
1061  
1062 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
1062 >            await(threadStarted); // ensure quiescence
1063              t.interrupt();
1064 <            awaitTermination(t, MEDIUM_DELAY_MS);
987 <        } finally {
988 <            done.countDown();
989 <            joinPool(p);
1064 >            awaitTermination(t);
1065          }
1066      }
1067  
1068      /**
1069 <     * execute throws RejectedExecutionException if saturated.
1069 >     * Submitted tasks are rejected when saturated or shutdown
1070       */
1071 <    public void testSaturatedExecute() {
1072 <        ThreadPoolExecutor p =
1073 <            new ThreadPoolExecutor(1, 1,
1074 <                                   LONG_DELAY_MS, MILLISECONDS,
1075 <                                   new ArrayBlockingQueue<Runnable>(1));
1071 >    public void testSubmittedTasksRejectedWhenSaturatedOrShutdown() throws InterruptedException {
1072 >        final ThreadPoolExecutor p = new ThreadPoolExecutor(
1073 >            1, 1, 1, SECONDS, new ArrayBlockingQueue<Runnable>(1));
1074 >        final int saturatedSize = saturatedSize(p);
1075 >        final ThreadLocalRandom rnd = ThreadLocalRandom.current();
1076 >        final CountDownLatch threadsStarted = new CountDownLatch(p.getMaximumPoolSize());
1077          final CountDownLatch done = new CountDownLatch(1);
1078 <        try {
1079 <            Runnable task = new CheckedRunnable() {
1080 <                public void realRun() throws InterruptedException {
1005 <                    done.await();
1006 <                }};
1007 <            for (int i = 0; i < 2; ++i)
1008 <                p.execute(task);
1009 <            for (int i = 0; i < 2; ++i) {
1078 >        final Runnable r = () -> {
1079 >            threadsStarted.countDown();
1080 >            for (;;) {
1081                  try {
1011                    p.execute(task);
1012                    shouldThrow();
1013                } catch (RejectedExecutionException success) {}
1014                assertTrue(p.getTaskCount() <= 2);
1015            }
1016        } finally {
1017            done.countDown();
1018            joinPool(p);
1019        }
1020    }
1021
1022    /**
1023     * submit(runnable) throws RejectedExecutionException if saturated.
1024     */
1025    public void testSaturatedSubmitRunnable() {
1026        ThreadPoolExecutor p =
1027            new ThreadPoolExecutor(1, 1,
1028                                   LONG_DELAY_MS, MILLISECONDS,
1029                                   new ArrayBlockingQueue<Runnable>(1));
1030        final CountDownLatch done = new CountDownLatch(1);
1031        try {
1032            Runnable task = new CheckedRunnable() {
1033                public void realRun() throws InterruptedException {
1082                      done.await();
1083 <                }};
1084 <            for (int i = 0; i < 2; ++i)
1085 <                p.submit(task);
1086 <            for (int i = 0; i < 2; ++i) {
1083 >                    return;
1084 >                } catch (InterruptedException shutdownNowDeliberatelyIgnored) {}
1085 >            }};
1086 >        final Callable<Boolean> c = () -> {
1087 >            threadsStarted.countDown();
1088 >            for (;;) {
1089                  try {
1040                    p.execute(task);
1041                    shouldThrow();
1042                } catch (RejectedExecutionException success) {}
1043                assertTrue(p.getTaskCount() <= 2);
1044            }
1045        } finally {
1046            done.countDown();
1047            joinPool(p);
1048        }
1049    }
1050
1051    /**
1052     * submit(callable) throws RejectedExecutionException if saturated.
1053     */
1054    public void testSaturatedSubmitCallable() {
1055        ThreadPoolExecutor p =
1056            new ThreadPoolExecutor(1, 1,
1057                                   LONG_DELAY_MS, MILLISECONDS,
1058                                   new ArrayBlockingQueue<Runnable>(1));
1059        final CountDownLatch done = new CountDownLatch(1);
1060        try {
1061            Runnable task = new CheckedRunnable() {
1062                public void realRun() throws InterruptedException {
1090                      done.await();
1091 <                }};
1092 <            for (int i = 0; i < 2; ++i)
1093 <                p.submit(Executors.callable(task));
1094 <            for (int i = 0; i < 2; ++i) {
1095 <                try {
1096 <                    p.execute(task);
1097 <                    shouldThrow();
1098 <                } catch (RejectedExecutionException success) {}
1099 <                assertTrue(p.getTaskCount() <= 2);
1091 >                    return Boolean.TRUE;
1092 >                } catch (InterruptedException shutdownNowDeliberatelyIgnored) {}
1093 >            }};
1094 >        final boolean shutdownNow = rnd.nextBoolean();
1095 >
1096 >        try (PoolCleaner cleaner = cleaner(p, done)) {
1097 >            // saturate
1098 >            for (int i = saturatedSize; i--> 0; ) {
1099 >                switch (rnd.nextInt(4)) {
1100 >                case 0: p.execute(r); break;
1101 >                case 1: assertFalse(p.submit(r).isDone()); break;
1102 >                case 2: assertFalse(p.submit(r, Boolean.TRUE).isDone()); break;
1103 >                case 3: assertFalse(p.submit(c).isDone()); break;
1104 >                }
1105              }
1074        } finally {
1075            done.countDown();
1076            joinPool(p);
1077        }
1078    }
1106  
1107 <    /**
1108 <     * executor using CallerRunsPolicy runs task if saturated.
1082 <     */
1083 <    public void testSaturatedExecute2() {
1084 <        RejectedExecutionHandler h = new ThreadPoolExecutor.CallerRunsPolicy();
1085 <        final ThreadPoolExecutor p =
1086 <            new ThreadPoolExecutor(1, 1,
1087 <                                   LONG_DELAY_MS,
1088 <                                   MILLISECONDS,
1089 <                                   new ArrayBlockingQueue<Runnable>(1),
1090 <                                   h);
1091 <        try {
1092 <            TrackedNoOpRunnable[] tasks = new TrackedNoOpRunnable[5];
1093 <            for (int i = 0; i < tasks.length; ++i)
1094 <                tasks[i] = new TrackedNoOpRunnable();
1095 <            TrackedLongRunnable mr = new TrackedLongRunnable();
1096 <            p.execute(mr);
1097 <            for (int i = 0; i < tasks.length; ++i)
1098 <                p.execute(tasks[i]);
1099 <            for (int i = 1; i < tasks.length; ++i)
1100 <                assertTrue(tasks[i].done);
1101 <            try { p.shutdownNow(); } catch (SecurityException ok) { return; }
1102 <        } finally {
1103 <            joinPool(p);
1104 <        }
1105 <    }
1107 >            await(threadsStarted);
1108 >            assertTaskSubmissionsAreRejected(p);
1109  
1110 <    /**
1111 <     * executor using DiscardPolicy drops task if saturated.
1112 <     */
1113 <    public void testSaturatedExecute3() {
1114 <        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardPolicy();
1115 <        final ThreadPoolExecutor p =
1116 <            new ThreadPoolExecutor(1, 1,
1117 <                                   LONG_DELAY_MS, MILLISECONDS,
1118 <                                   new ArrayBlockingQueue<Runnable>(1),
1119 <                                   h);
1120 <        try {
1121 <            TrackedNoOpRunnable[] tasks = new TrackedNoOpRunnable[5];
1122 <            for (int i = 0; i < tasks.length; ++i)
1123 <                tasks[i] = new TrackedNoOpRunnable();
1124 <            p.execute(new TrackedLongRunnable());
1125 <            for (TrackedNoOpRunnable task : tasks)
1123 <                p.execute(task);
1124 <            for (TrackedNoOpRunnable task : tasks)
1125 <                assertFalse(task.done);
1126 <            try { p.shutdownNow(); } catch (SecurityException ok) { return; }
1127 <        } finally {
1128 <            joinPool(p);
1129 <        }
1110 >            if (shutdownNow)
1111 >                p.shutdownNow();
1112 >            else
1113 >                p.shutdown();
1114 >            // Pool is shutdown, but not yet terminated
1115 >            assertTaskSubmissionsAreRejected(p);
1116 >            assertFalse(p.isTerminated());
1117 >
1118 >            done.countDown();   // release blocking tasks
1119 >            assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
1120 >
1121 >            assertTaskSubmissionsAreRejected(p);
1122 >        }
1123 >        assertEquals(saturatedSize(p)
1124 >                     - (shutdownNow ? p.getQueue().remainingCapacity() : 0),
1125 >                     p.getCompletedTaskCount());
1126      }
1127  
1128      /**
1129       * executor using DiscardOldestPolicy drops oldest task if saturated.
1130       */
1131 <    public void testSaturatedExecute4() {
1132 <        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardOldestPolicy();
1131 >    public void testSaturatedExecute_DiscardOldestPolicy() {
1132 >        final CountDownLatch done = new CountDownLatch(1);
1133 >        LatchAwaiter r1 = awaiter(done);
1134 >        LatchAwaiter r2 = awaiter(done);
1135 >        LatchAwaiter r3 = awaiter(done);
1136          final ThreadPoolExecutor p =
1137              new ThreadPoolExecutor(1, 1,
1138                                     LONG_DELAY_MS, MILLISECONDS,
1139                                     new ArrayBlockingQueue<Runnable>(1),
1140 <                                   h);
1141 <        try {
1142 <            p.execute(new TrackedLongRunnable());
1143 <            TrackedLongRunnable r2 = new TrackedLongRunnable();
1140 >                                   new DiscardOldestPolicy());
1141 >        try (PoolCleaner cleaner = cleaner(p, done)) {
1142 >            assertEquals(LatchAwaiter.NEW, r1.state);
1143 >            assertEquals(LatchAwaiter.NEW, r2.state);
1144 >            assertEquals(LatchAwaiter.NEW, r3.state);
1145 >            p.execute(r1);
1146              p.execute(r2);
1147              assertTrue(p.getQueue().contains(r2));
1147            TrackedNoOpRunnable r3 = new TrackedNoOpRunnable();
1148              p.execute(r3);
1149              assertFalse(p.getQueue().contains(r2));
1150              assertTrue(p.getQueue().contains(r3));
1151            try { p.shutdownNow(); } catch (SecurityException ok) { return; }
1152        } finally {
1153            joinPool(p);
1151          }
1152 +        assertEquals(LatchAwaiter.DONE, r1.state);
1153 +        assertEquals(LatchAwaiter.NEW, r2.state);
1154 +        assertEquals(LatchAwaiter.DONE, r3.state);
1155      }
1156  
1157      /**
1158     * execute throws RejectedExecutionException if shutdown
1159     */
1160    public void testRejectedExecutionExceptionOnShutdown() {
1161        ThreadPoolExecutor p =
1162            new ThreadPoolExecutor(1, 1,
1163                                   LONG_DELAY_MS, MILLISECONDS,
1164                                   new ArrayBlockingQueue<Runnable>(1));
1165        try { p.shutdown(); } catch (SecurityException ok) { return; }
1166        try {
1167            p.execute(new NoOpRunnable());
1168            shouldThrow();
1169        } catch (RejectedExecutionException success) {}
1170
1171        joinPool(p);
1172    }
1173
1174    /**
1175     * execute using CallerRunsPolicy drops task on shutdown
1176     */
1177    public void testCallerRunsOnShutdown() {
1178        RejectedExecutionHandler h = new ThreadPoolExecutor.CallerRunsPolicy();
1179        final ThreadPoolExecutor p =
1180            new ThreadPoolExecutor(1, 1,
1181                                   LONG_DELAY_MS, MILLISECONDS,
1182                                   new ArrayBlockingQueue<Runnable>(1), h);
1183
1184        try { p.shutdown(); } catch (SecurityException ok) { return; }
1185        try {
1186            TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1187            p.execute(r);
1188            assertFalse(r.done);
1189        } finally {
1190            joinPool(p);
1191        }
1192    }
1193
1194    /**
1195     * execute using DiscardPolicy drops task on shutdown
1196     */
1197    public void testDiscardOnShutdown() {
1198        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardPolicy();
1199        ThreadPoolExecutor p =
1200            new ThreadPoolExecutor(1, 1,
1201                                   LONG_DELAY_MS, MILLISECONDS,
1202                                   new ArrayBlockingQueue<Runnable>(1),
1203                                   h);
1204
1205        try { p.shutdown(); } catch (SecurityException ok) { return; }
1206        try {
1207            TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1208            p.execute(r);
1209            assertFalse(r.done);
1210        } finally {
1211            joinPool(p);
1212        }
1213    }
1214
1215
1216    /**
1158       * execute using DiscardOldestPolicy drops task on shutdown
1159       */
1160      public void testDiscardOldestOnShutdown() {
1161 <        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardOldestPolicy();
1221 <        ThreadPoolExecutor p =
1161 >        final ThreadPoolExecutor p =
1162              new ThreadPoolExecutor(1, 1,
1163                                     LONG_DELAY_MS, MILLISECONDS,
1164                                     new ArrayBlockingQueue<Runnable>(1),
1165 <                                   h);
1165 >                                   new DiscardOldestPolicy());
1166  
1167          try { p.shutdown(); } catch (SecurityException ok) { return; }
1168 <        try {
1168 >        try (PoolCleaner cleaner = cleaner(p)) {
1169              TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1170              p.execute(r);
1171              assertFalse(r.done);
1232        } finally {
1233            joinPool(p);
1172          }
1173      }
1174  
1237
1175      /**
1176 <     * execute(null) throws NPE
1176 >     * Submitting null tasks throws NullPointerException
1177       */
1178 <    public void testExecuteNull() {
1179 <        ThreadPoolExecutor p =
1178 >    public void testNullTaskSubmission() {
1179 >        final ThreadPoolExecutor p =
1180              new ThreadPoolExecutor(1, 2,
1181 <                                   LONG_DELAY_MS, MILLISECONDS,
1181 >                                   1L, SECONDS,
1182                                     new ArrayBlockingQueue<Runnable>(10));
1183 <        try {
1184 <            p.execute(null);
1185 <            shouldThrow();
1249 <        } catch (NullPointerException success) {}
1250 <
1251 <        joinPool(p);
1183 >        try (PoolCleaner cleaner = cleaner(p)) {
1184 >            assertNullTaskSubmissionThrowsNullPointerException(p);
1185 >        }
1186      }
1187  
1188      /**
1189       * setCorePoolSize of negative value throws IllegalArgumentException
1190       */
1191      public void testCorePoolSizeIllegalArgumentException() {
1192 <        ThreadPoolExecutor p =
1192 >        final ThreadPoolExecutor p =
1193              new ThreadPoolExecutor(1, 2,
1194                                     LONG_DELAY_MS, MILLISECONDS,
1195                                     new ArrayBlockingQueue<Runnable>(10));
1196 <        try {
1197 <            p.setCorePoolSize(-1);
1198 <            shouldThrow();
1199 <        } catch (IllegalArgumentException success) {
1200 <        } finally {
1267 <            try { p.shutdown(); } catch (SecurityException ok) { return; }
1196 >        try (PoolCleaner cleaner = cleaner(p)) {
1197 >            try {
1198 >                p.setCorePoolSize(-1);
1199 >                shouldThrow();
1200 >            } catch (IllegalArgumentException success) {}
1201          }
1269        joinPool(p);
1202      }
1203  
1204      /**
# Line 1274 | Line 1206 | public class ThreadPoolExecutorTest exte
1206       * given a value less the core pool size
1207       */
1208      public void testMaximumPoolSizeIllegalArgumentException() {
1209 <        ThreadPoolExecutor p =
1209 >        final ThreadPoolExecutor p =
1210              new ThreadPoolExecutor(2, 3,
1211                                     LONG_DELAY_MS, MILLISECONDS,
1212                                     new ArrayBlockingQueue<Runnable>(10));
1213 <        try {
1214 <            p.setMaximumPoolSize(1);
1215 <            shouldThrow();
1216 <        } catch (IllegalArgumentException success) {
1217 <        } finally {
1286 <            try { p.shutdown(); } catch (SecurityException ok) { return; }
1213 >        try (PoolCleaner cleaner = cleaner(p)) {
1214 >            try {
1215 >                p.setMaximumPoolSize(1);
1216 >                shouldThrow();
1217 >            } catch (IllegalArgumentException success) {}
1218          }
1288        joinPool(p);
1219      }
1220  
1221      /**
# Line 1293 | Line 1223 | public class ThreadPoolExecutorTest exte
1223       * if given a negative value
1224       */
1225      public void testMaximumPoolSizeIllegalArgumentException2() {
1226 <        ThreadPoolExecutor p =
1226 >        final ThreadPoolExecutor p =
1227              new ThreadPoolExecutor(2, 3,
1228                                     LONG_DELAY_MS, MILLISECONDS,
1229                                     new ArrayBlockingQueue<Runnable>(10));
1230 <        try {
1231 <            p.setMaximumPoolSize(-1);
1232 <            shouldThrow();
1233 <        } catch (IllegalArgumentException success) {
1234 <        } finally {
1305 <            try { p.shutdown(); } catch (SecurityException ok) { return; }
1230 >        try (PoolCleaner cleaner = cleaner(p)) {
1231 >            try {
1232 >                p.setMaximumPoolSize(-1);
1233 >                shouldThrow();
1234 >            } catch (IllegalArgumentException success) {}
1235          }
1307        joinPool(p);
1236      }
1237  
1238 +    /**
1239 +     * Configuration changes that allow core pool size greater than
1240 +     * max pool size result in IllegalArgumentException.
1241 +     */
1242 +    public void testPoolSizeInvariants() {
1243 +        final ThreadPoolExecutor p =
1244 +            new ThreadPoolExecutor(1, 1,
1245 +                                   LONG_DELAY_MS, MILLISECONDS,
1246 +                                   new ArrayBlockingQueue<Runnable>(10));
1247 +        try (PoolCleaner cleaner = cleaner(p)) {
1248 +            for (int s = 1; s < 5; s++) {
1249 +                p.setMaximumPoolSize(s);
1250 +                p.setCorePoolSize(s);
1251 +                try {
1252 +                    p.setMaximumPoolSize(s - 1);
1253 +                    shouldThrow();
1254 +                } catch (IllegalArgumentException success) {}
1255 +                assertEquals(s, p.getCorePoolSize());
1256 +                assertEquals(s, p.getMaximumPoolSize());
1257 +                try {
1258 +                    p.setCorePoolSize(s + 1);
1259 +                    shouldThrow();
1260 +                } catch (IllegalArgumentException success) {}
1261 +                assertEquals(s, p.getCorePoolSize());
1262 +                assertEquals(s, p.getMaximumPoolSize());
1263 +            }
1264 +        }
1265 +    }
1266  
1267      /**
1268       * setKeepAliveTime throws IllegalArgumentException
1269       * when given a negative value
1270       */
1271      public void testKeepAliveTimeIllegalArgumentException() {
1272 <        ThreadPoolExecutor p =
1272 >        final ThreadPoolExecutor p =
1273              new ThreadPoolExecutor(2, 3,
1274                                     LONG_DELAY_MS, MILLISECONDS,
1275                                     new ArrayBlockingQueue<Runnable>(10));
1276 <        try {
1277 <            p.setKeepAliveTime(-1,MILLISECONDS);
1278 <            shouldThrow();
1279 <        } catch (IllegalArgumentException success) {
1280 <        } finally {
1325 <            try { p.shutdown(); } catch (SecurityException ok) { return; }
1276 >        try (PoolCleaner cleaner = cleaner(p)) {
1277 >            try {
1278 >                p.setKeepAliveTime(-1, MILLISECONDS);
1279 >                shouldThrow();
1280 >            } catch (IllegalArgumentException success) {}
1281          }
1327        joinPool(p);
1282      }
1283  
1284      /**
# Line 1332 | Line 1286 | public class ThreadPoolExecutorTest exte
1286       */
1287      public void testTerminated() {
1288          ExtendedTPE p = new ExtendedTPE();
1289 <        try { p.shutdown(); } catch (SecurityException ok) { return; }
1290 <        assertTrue(p.terminatedCalled);
1291 <        joinPool(p);
1289 >        try (PoolCleaner cleaner = cleaner(p)) {
1290 >            try { p.shutdown(); } catch (SecurityException ok) { return; }
1291 >            assertTrue(p.terminatedCalled());
1292 >            assertTrue(p.isShutdown());
1293 >        }
1294      }
1295  
1296      /**
# Line 1342 | Line 1298 | public class ThreadPoolExecutorTest exte
1298       */
1299      public void testBeforeAfter() throws InterruptedException {
1300          ExtendedTPE p = new ExtendedTPE();
1301 <        try {
1302 <            TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1303 <            p.execute(r);
1304 <            delay(SHORT_DELAY_MS);
1305 <            assertTrue(r.done);
1306 <            assertTrue(p.beforeCalled);
1307 <            assertTrue(p.afterCalled);
1308 <            try { p.shutdown(); } catch (SecurityException ok) { return; }
1309 <        } finally {
1310 <            joinPool(p);
1301 >        try (PoolCleaner cleaner = cleaner(p)) {
1302 >            final CountDownLatch done = new CountDownLatch(1);
1303 >            p.execute(new CheckedRunnable() {
1304 >                public void realRun() {
1305 >                    done.countDown();
1306 >                }});
1307 >            await(p.afterCalled);
1308 >            assertEquals(0, done.getCount());
1309 >            assertTrue(p.afterCalled());
1310 >            assertTrue(p.beforeCalled());
1311          }
1312      }
1313  
# Line 1359 | Line 1315 | public class ThreadPoolExecutorTest exte
1315       * completed submit of callable returns result
1316       */
1317      public void testSubmitCallable() throws Exception {
1318 <        ExecutorService e =
1318 >        final ExecutorService e =
1319              new ThreadPoolExecutor(2, 2,
1320                                     LONG_DELAY_MS, MILLISECONDS,
1321                                     new ArrayBlockingQueue<Runnable>(10));
1322 <        try {
1322 >        try (PoolCleaner cleaner = cleaner(e)) {
1323              Future<String> future = e.submit(new StringTask());
1324              String result = future.get();
1325              assertSame(TEST_STRING, result);
1370        } finally {
1371            joinPool(e);
1326          }
1327      }
1328  
# Line 1376 | Line 1330 | public class ThreadPoolExecutorTest exte
1330       * completed submit of runnable returns successfully
1331       */
1332      public void testSubmitRunnable() throws Exception {
1333 <        ExecutorService e =
1333 >        final ExecutorService e =
1334              new ThreadPoolExecutor(2, 2,
1335                                     LONG_DELAY_MS, MILLISECONDS,
1336                                     new ArrayBlockingQueue<Runnable>(10));
1337 <        try {
1337 >        try (PoolCleaner cleaner = cleaner(e)) {
1338              Future<?> future = e.submit(new NoOpRunnable());
1339              future.get();
1340              assertTrue(future.isDone());
1387        } finally {
1388            joinPool(e);
1341          }
1342      }
1343  
# Line 1393 | Line 1345 | public class ThreadPoolExecutorTest exte
1345       * completed submit of (runnable, result) returns result
1346       */
1347      public void testSubmitRunnable2() throws Exception {
1348 <        ExecutorService e =
1348 >        final ExecutorService e =
1349              new ThreadPoolExecutor(2, 2,
1350                                     LONG_DELAY_MS, MILLISECONDS,
1351                                     new ArrayBlockingQueue<Runnable>(10));
1352 <        try {
1352 >        try (PoolCleaner cleaner = cleaner(e)) {
1353              Future<String> future = e.submit(new NoOpRunnable(), TEST_STRING);
1354              String result = future.get();
1355              assertSame(TEST_STRING, result);
1404        } finally {
1405            joinPool(e);
1356          }
1357      }
1358  
1409
1359      /**
1360       * invokeAny(null) throws NPE
1361       */
1362      public void testInvokeAny1() throws Exception {
1363 <        ExecutorService e =
1363 >        final ExecutorService e =
1364              new ThreadPoolExecutor(2, 2,
1365                                     LONG_DELAY_MS, MILLISECONDS,
1366                                     new ArrayBlockingQueue<Runnable>(10));
1367 <        try {
1368 <            e.invokeAny(null);
1369 <            shouldThrow();
1370 <        } catch (NullPointerException success) {
1371 <        } finally {
1423 <            joinPool(e);
1367 >        try (PoolCleaner cleaner = cleaner(e)) {
1368 >            try {
1369 >                e.invokeAny(null);
1370 >                shouldThrow();
1371 >            } catch (NullPointerException success) {}
1372          }
1373      }
1374  
1375      /**
1376 <     * invokeAny(empty collection) throws IAE
1376 >     * invokeAny(empty collection) throws IllegalArgumentException
1377       */
1378      public void testInvokeAny2() throws Exception {
1379 <        ExecutorService e =
1379 >        final ExecutorService e =
1380              new ThreadPoolExecutor(2, 2,
1381                                     LONG_DELAY_MS, MILLISECONDS,
1382                                     new ArrayBlockingQueue<Runnable>(10));
1383 <        try {
1384 <            e.invokeAny(new ArrayList<Callable<String>>());
1385 <            shouldThrow();
1386 <        } catch (IllegalArgumentException success) {
1387 <        } finally {
1440 <            joinPool(e);
1383 >        try (PoolCleaner cleaner = cleaner(e)) {
1384 >            try {
1385 >                e.invokeAny(new ArrayList<Callable<String>>());
1386 >                shouldThrow();
1387 >            } catch (IllegalArgumentException success) {}
1388          }
1389      }
1390  
# Line 1450 | Line 1397 | public class ThreadPoolExecutorTest exte
1397              new ThreadPoolExecutor(2, 2,
1398                                     LONG_DELAY_MS, MILLISECONDS,
1399                                     new ArrayBlockingQueue<Runnable>(10));
1400 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1401 <        l.add(latchAwaitingStringTask(latch));
1402 <        l.add(null);
1403 <        try {
1404 <            e.invokeAny(l);
1405 <            shouldThrow();
1406 <        } catch (NullPointerException success) {
1407 <        } finally {
1400 >        try (PoolCleaner cleaner = cleaner(e)) {
1401 >            List<Callable<String>> l = new ArrayList<>();
1402 >            l.add(latchAwaitingStringTask(latch));
1403 >            l.add(null);
1404 >            try {
1405 >                e.invokeAny(l);
1406 >                shouldThrow();
1407 >            } catch (NullPointerException success) {}
1408              latch.countDown();
1462            joinPool(e);
1409          }
1410      }
1411  
# Line 1467 | Line 1413 | public class ThreadPoolExecutorTest exte
1413       * invokeAny(c) throws ExecutionException if no task completes
1414       */
1415      public void testInvokeAny4() throws Exception {
1416 <        ExecutorService e =
1416 >        final ExecutorService e =
1417              new ThreadPoolExecutor(2, 2,
1418                                     LONG_DELAY_MS, MILLISECONDS,
1419                                     new ArrayBlockingQueue<Runnable>(10));
1420 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1421 <        l.add(new NPETask());
1422 <        try {
1423 <            e.invokeAny(l);
1424 <            shouldThrow();
1425 <        } catch (ExecutionException success) {
1426 <            assertTrue(success.getCause() instanceof NullPointerException);
1427 <        } finally {
1428 <            joinPool(e);
1420 >        try (PoolCleaner cleaner = cleaner(e)) {
1421 >            List<Callable<String>> l = new ArrayList<>();
1422 >            l.add(new NPETask());
1423 >            try {
1424 >                e.invokeAny(l);
1425 >                shouldThrow();
1426 >            } catch (ExecutionException success) {
1427 >                assertTrue(success.getCause() instanceof NullPointerException);
1428 >            }
1429          }
1430      }
1431  
# Line 1487 | Line 1433 | public class ThreadPoolExecutorTest exte
1433       * invokeAny(c) returns result of some task
1434       */
1435      public void testInvokeAny5() throws Exception {
1436 <        ExecutorService e =
1436 >        final ExecutorService e =
1437              new ThreadPoolExecutor(2, 2,
1438                                     LONG_DELAY_MS, MILLISECONDS,
1439                                     new ArrayBlockingQueue<Runnable>(10));
1440 <        try {
1441 <            List<Callable<String>> l = new ArrayList<Callable<String>>();
1440 >        try (PoolCleaner cleaner = cleaner(e)) {
1441 >            List<Callable<String>> l = new ArrayList<>();
1442              l.add(new StringTask());
1443              l.add(new StringTask());
1444              String result = e.invokeAny(l);
1445              assertSame(TEST_STRING, result);
1500        } finally {
1501            joinPool(e);
1446          }
1447      }
1448  
# Line 1506 | Line 1450 | public class ThreadPoolExecutorTest exte
1450       * invokeAll(null) throws NPE
1451       */
1452      public void testInvokeAll1() throws Exception {
1453 <        ExecutorService e =
1453 >        final ExecutorService e =
1454              new ThreadPoolExecutor(2, 2,
1455                                     LONG_DELAY_MS, MILLISECONDS,
1456                                     new ArrayBlockingQueue<Runnable>(10));
1457 <        try {
1458 <            e.invokeAll(null);
1459 <            shouldThrow();
1460 <        } catch (NullPointerException success) {
1461 <        } finally {
1518 <            joinPool(e);
1457 >        try (PoolCleaner cleaner = cleaner(e)) {
1458 >            try {
1459 >                e.invokeAll(null);
1460 >                shouldThrow();
1461 >            } catch (NullPointerException success) {}
1462          }
1463      }
1464  
1465      /**
1466 <     * invokeAll(empty collection) returns empty collection
1466 >     * invokeAll(empty collection) returns empty list
1467       */
1468      public void testInvokeAll2() throws InterruptedException {
1469 <        ExecutorService e =
1469 >        final ExecutorService e =
1470              new ThreadPoolExecutor(2, 2,
1471                                     LONG_DELAY_MS, MILLISECONDS,
1472                                     new ArrayBlockingQueue<Runnable>(10));
1473 <        try {
1474 <            List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>());
1473 >        final Collection<Callable<String>> emptyCollection
1474 >            = Collections.emptyList();
1475 >        try (PoolCleaner cleaner = cleaner(e)) {
1476 >            List<Future<String>> r = e.invokeAll(emptyCollection);
1477              assertTrue(r.isEmpty());
1533        } finally {
1534            joinPool(e);
1478          }
1479      }
1480  
# Line 1539 | Line 1482 | public class ThreadPoolExecutorTest exte
1482       * invokeAll(c) throws NPE if c has null elements
1483       */
1484      public void testInvokeAll3() throws Exception {
1485 <        ExecutorService e =
1485 >        final ExecutorService e =
1486              new ThreadPoolExecutor(2, 2,
1487                                     LONG_DELAY_MS, MILLISECONDS,
1488                                     new ArrayBlockingQueue<Runnable>(10));
1489 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1490 <        l.add(new StringTask());
1491 <        l.add(null);
1492 <        try {
1493 <            e.invokeAll(l);
1494 <            shouldThrow();
1495 <        } catch (NullPointerException success) {
1496 <        } finally {
1554 <            joinPool(e);
1489 >        try (PoolCleaner cleaner = cleaner(e)) {
1490 >            List<Callable<String>> l = new ArrayList<>();
1491 >            l.add(new StringTask());
1492 >            l.add(null);
1493 >            try {
1494 >                e.invokeAll(l);
1495 >                shouldThrow();
1496 >            } catch (NullPointerException success) {}
1497          }
1498      }
1499  
# Line 1559 | Line 1501 | public class ThreadPoolExecutorTest exte
1501       * get of element of invokeAll(c) throws exception on failed task
1502       */
1503      public void testInvokeAll4() throws Exception {
1504 <        ExecutorService e =
1504 >        final ExecutorService e =
1505              new ThreadPoolExecutor(2, 2,
1506                                     LONG_DELAY_MS, MILLISECONDS,
1507                                     new ArrayBlockingQueue<Runnable>(10));
1508 <        try {
1509 <            List<Callable<String>> l = new ArrayList<Callable<String>>();
1508 >        try (PoolCleaner cleaner = cleaner(e)) {
1509 >            List<Callable<String>> l = new ArrayList<>();
1510              l.add(new NPETask());
1511              List<Future<String>> futures = e.invokeAll(l);
1512              assertEquals(1, futures.size());
# Line 1574 | Line 1516 | public class ThreadPoolExecutorTest exte
1516              } catch (ExecutionException success) {
1517                  assertTrue(success.getCause() instanceof NullPointerException);
1518              }
1577        } finally {
1578            joinPool(e);
1519          }
1520      }
1521  
# Line 1583 | Line 1523 | public class ThreadPoolExecutorTest exte
1523       * invokeAll(c) returns results of all completed tasks
1524       */
1525      public void testInvokeAll5() throws Exception {
1526 <        ExecutorService e =
1526 >        final ExecutorService e =
1527              new ThreadPoolExecutor(2, 2,
1528                                     LONG_DELAY_MS, MILLISECONDS,
1529                                     new ArrayBlockingQueue<Runnable>(10));
1530 <        try {
1531 <            List<Callable<String>> l = new ArrayList<Callable<String>>();
1530 >        try (PoolCleaner cleaner = cleaner(e)) {
1531 >            List<Callable<String>> l = new ArrayList<>();
1532              l.add(new StringTask());
1533              l.add(new StringTask());
1534              List<Future<String>> futures = e.invokeAll(l);
1535              assertEquals(2, futures.size());
1536              for (Future<String> future : futures)
1537                  assertSame(TEST_STRING, future.get());
1598        } finally {
1599            joinPool(e);
1538          }
1539      }
1540  
1603
1604
1541      /**
1542       * timed invokeAny(null) throws NPE
1543       */
1544      public void testTimedInvokeAny1() throws Exception {
1545 <        ExecutorService e =
1545 >        final ExecutorService e =
1546              new ThreadPoolExecutor(2, 2,
1547                                     LONG_DELAY_MS, MILLISECONDS,
1548                                     new ArrayBlockingQueue<Runnable>(10));
1549 <        try {
1550 <            e.invokeAny(null, MEDIUM_DELAY_MS, MILLISECONDS);
1551 <            shouldThrow();
1552 <        } catch (NullPointerException success) {
1553 <        } finally {
1618 <            joinPool(e);
1549 >        try (PoolCleaner cleaner = cleaner(e)) {
1550 >            try {
1551 >                e.invokeAny(null, randomTimeout(), randomTimeUnit());
1552 >                shouldThrow();
1553 >            } catch (NullPointerException success) {}
1554          }
1555      }
1556  
# Line 1623 | Line 1558 | public class ThreadPoolExecutorTest exte
1558       * timed invokeAny(,,null) throws NPE
1559       */
1560      public void testTimedInvokeAnyNullTimeUnit() throws Exception {
1561 <        ExecutorService e =
1561 >        final ExecutorService e =
1562              new ThreadPoolExecutor(2, 2,
1563                                     LONG_DELAY_MS, MILLISECONDS,
1564                                     new ArrayBlockingQueue<Runnable>(10));
1565 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1566 <        l.add(new StringTask());
1567 <        try {
1568 <            e.invokeAny(l, MEDIUM_DELAY_MS, null);
1569 <            shouldThrow();
1570 <        } catch (NullPointerException success) {
1571 <        } finally {
1637 <            joinPool(e);
1565 >        try (PoolCleaner cleaner = cleaner(e)) {
1566 >            List<Callable<String>> l = new ArrayList<>();
1567 >            l.add(new StringTask());
1568 >            try {
1569 >                e.invokeAny(l, randomTimeout(), null);
1570 >                shouldThrow();
1571 >            } catch (NullPointerException success) {}
1572          }
1573      }
1574  
1575      /**
1576 <     * timed invokeAny(empty collection) throws IAE
1576 >     * timed invokeAny(empty collection) throws IllegalArgumentException
1577       */
1578      public void testTimedInvokeAny2() throws Exception {
1579 <        ExecutorService e =
1579 >        final ExecutorService e =
1580              new ThreadPoolExecutor(2, 2,
1581                                     LONG_DELAY_MS, MILLISECONDS,
1582                                     new ArrayBlockingQueue<Runnable>(10));
1583 <        try {
1584 <            e.invokeAny(new ArrayList<Callable<String>>(), MEDIUM_DELAY_MS, MILLISECONDS);
1585 <            shouldThrow();
1586 <        } catch (IllegalArgumentException success) {
1587 <        } finally {
1588 <            joinPool(e);
1583 >        try (PoolCleaner cleaner = cleaner(e)) {
1584 >            try {
1585 >                e.invokeAny(new ArrayList<Callable<String>>(),
1586 >                            randomTimeout(), randomTimeUnit());
1587 >                shouldThrow();
1588 >            } catch (IllegalArgumentException success) {}
1589          }
1590      }
1591  
1592      /**
1593 <     * timed invokeAny(c) throws NPE if c has null elements
1593 >     * timed invokeAny(c) throws NullPointerException if c has null elements
1594       */
1595      public void testTimedInvokeAny3() throws Exception {
1596          final CountDownLatch latch = new CountDownLatch(1);
# Line 1664 | Line 1598 | public class ThreadPoolExecutorTest exte
1598              new ThreadPoolExecutor(2, 2,
1599                                     LONG_DELAY_MS, MILLISECONDS,
1600                                     new ArrayBlockingQueue<Runnable>(10));
1601 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1602 <        l.add(latchAwaitingStringTask(latch));
1603 <        l.add(null);
1604 <        try {
1605 <            e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1606 <            shouldThrow();
1607 <        } catch (NullPointerException success) {
1608 <        } finally {
1601 >        try (PoolCleaner cleaner = cleaner(e)) {
1602 >            List<Callable<String>> l = new ArrayList<>();
1603 >            l.add(latchAwaitingStringTask(latch));
1604 >            l.add(null);
1605 >            try {
1606 >                e.invokeAny(l, randomTimeout(), randomTimeUnit());
1607 >                shouldThrow();
1608 >            } catch (NullPointerException success) {}
1609              latch.countDown();
1676            joinPool(e);
1610          }
1611      }
1612  
# Line 1681 | Line 1614 | public class ThreadPoolExecutorTest exte
1614       * timed invokeAny(c) throws ExecutionException if no task completes
1615       */
1616      public void testTimedInvokeAny4() throws Exception {
1617 <        ExecutorService e =
1617 >        final ExecutorService e =
1618              new ThreadPoolExecutor(2, 2,
1619                                     LONG_DELAY_MS, MILLISECONDS,
1620                                     new ArrayBlockingQueue<Runnable>(10));
1621 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1622 <        l.add(new NPETask());
1623 <        try {
1624 <            e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1625 <            shouldThrow();
1626 <        } catch (ExecutionException success) {
1627 <            assertTrue(success.getCause() instanceof NullPointerException);
1628 <        } finally {
1629 <            joinPool(e);
1621 >        try (PoolCleaner cleaner = cleaner(e)) {
1622 >            long startTime = System.nanoTime();
1623 >            List<Callable<String>> l = new ArrayList<>();
1624 >            l.add(new NPETask());
1625 >            try {
1626 >                e.invokeAny(l, LONG_DELAY_MS, MILLISECONDS);
1627 >                shouldThrow();
1628 >            } catch (ExecutionException success) {
1629 >                assertTrue(success.getCause() instanceof NullPointerException);
1630 >            }
1631 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
1632          }
1633      }
1634  
# Line 1701 | Line 1636 | public class ThreadPoolExecutorTest exte
1636       * timed invokeAny(c) returns result of some task
1637       */
1638      public void testTimedInvokeAny5() throws Exception {
1639 <        ExecutorService e =
1639 >        final ExecutorService e =
1640              new ThreadPoolExecutor(2, 2,
1641                                     LONG_DELAY_MS, MILLISECONDS,
1642                                     new ArrayBlockingQueue<Runnable>(10));
1643 <        try {
1644 <            List<Callable<String>> l = new ArrayList<Callable<String>>();
1643 >        try (PoolCleaner cleaner = cleaner(e)) {
1644 >            long startTime = System.nanoTime();
1645 >            List<Callable<String>> l = new ArrayList<>();
1646              l.add(new StringTask());
1647              l.add(new StringTask());
1648 <            String result = e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1648 >            String result = e.invokeAny(l, LONG_DELAY_MS, MILLISECONDS);
1649              assertSame(TEST_STRING, result);
1650 <        } finally {
1715 <            joinPool(e);
1650 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
1651          }
1652      }
1653  
# Line 1720 | Line 1655 | public class ThreadPoolExecutorTest exte
1655       * timed invokeAll(null) throws NPE
1656       */
1657      public void testTimedInvokeAll1() throws Exception {
1658 <        ExecutorService e =
1658 >        final ExecutorService e =
1659              new ThreadPoolExecutor(2, 2,
1660                                     LONG_DELAY_MS, MILLISECONDS,
1661                                     new ArrayBlockingQueue<Runnable>(10));
1662 <        try {
1663 <            e.invokeAll(null, MEDIUM_DELAY_MS, MILLISECONDS);
1664 <            shouldThrow();
1665 <        } catch (NullPointerException success) {
1666 <        } finally {
1732 <            joinPool(e);
1662 >        try (PoolCleaner cleaner = cleaner(e)) {
1663 >            try {
1664 >                e.invokeAll(null, randomTimeout(), randomTimeUnit());
1665 >                shouldThrow();
1666 >            } catch (NullPointerException success) {}
1667          }
1668      }
1669  
# Line 1737 | Line 1671 | public class ThreadPoolExecutorTest exte
1671       * timed invokeAll(,,null) throws NPE
1672       */
1673      public void testTimedInvokeAllNullTimeUnit() throws Exception {
1674 <        ExecutorService e =
1674 >        final ExecutorService e =
1675              new ThreadPoolExecutor(2, 2,
1676                                     LONG_DELAY_MS, MILLISECONDS,
1677                                     new ArrayBlockingQueue<Runnable>(10));
1678 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1679 <        l.add(new StringTask());
1680 <        try {
1681 <            e.invokeAll(l, MEDIUM_DELAY_MS, null);
1682 <            shouldThrow();
1683 <        } catch (NullPointerException success) {
1684 <        } finally {
1751 <            joinPool(e);
1678 >        try (PoolCleaner cleaner = cleaner(e)) {
1679 >            List<Callable<String>> l = new ArrayList<>();
1680 >            l.add(new StringTask());
1681 >            try {
1682 >                e.invokeAll(l, randomTimeout(), null);
1683 >                shouldThrow();
1684 >            } catch (NullPointerException success) {}
1685          }
1686      }
1687  
1688      /**
1689 <     * timed invokeAll(empty collection) returns empty collection
1689 >     * timed invokeAll(empty collection) returns empty list
1690       */
1691      public void testTimedInvokeAll2() throws InterruptedException {
1692 <        ExecutorService e =
1692 >        final ExecutorService e =
1693              new ThreadPoolExecutor(2, 2,
1694                                     LONG_DELAY_MS, MILLISECONDS,
1695                                     new ArrayBlockingQueue<Runnable>(10));
1696 <        try {
1697 <            List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>(), MEDIUM_DELAY_MS, MILLISECONDS);
1696 >        final Collection<Callable<String>> emptyCollection
1697 >            = Collections.emptyList();
1698 >        try (PoolCleaner cleaner = cleaner(e)) {
1699 >            List<Future<String>> r =
1700 >                e.invokeAll(emptyCollection, randomTimeout(), randomTimeUnit());
1701              assertTrue(r.isEmpty());
1766        } finally {
1767            joinPool(e);
1702          }
1703      }
1704  
# Line 1772 | Line 1706 | public class ThreadPoolExecutorTest exte
1706       * timed invokeAll(c) throws NPE if c has null elements
1707       */
1708      public void testTimedInvokeAll3() throws Exception {
1709 <        ExecutorService e =
1709 >        final ExecutorService e =
1710              new ThreadPoolExecutor(2, 2,
1711                                     LONG_DELAY_MS, MILLISECONDS,
1712                                     new ArrayBlockingQueue<Runnable>(10));
1713 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1714 <        l.add(new StringTask());
1715 <        l.add(null);
1716 <        try {
1717 <            e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1718 <            shouldThrow();
1719 <        } catch (NullPointerException success) {
1720 <        } finally {
1787 <            joinPool(e);
1713 >        try (PoolCleaner cleaner = cleaner(e)) {
1714 >            List<Callable<String>> l = new ArrayList<>();
1715 >            l.add(new StringTask());
1716 >            l.add(null);
1717 >            try {
1718 >                e.invokeAll(l, randomTimeout(), randomTimeUnit());
1719 >                shouldThrow();
1720 >            } catch (NullPointerException success) {}
1721          }
1722      }
1723  
# Line 1792 | Line 1725 | public class ThreadPoolExecutorTest exte
1725       * get of element of invokeAll(c) throws exception on failed task
1726       */
1727      public void testTimedInvokeAll4() throws Exception {
1728 <        ExecutorService e =
1728 >        final ExecutorService e =
1729              new ThreadPoolExecutor(2, 2,
1730                                     LONG_DELAY_MS, MILLISECONDS,
1731                                     new ArrayBlockingQueue<Runnable>(10));
1732 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1733 <        l.add(new NPETask());
1734 <        List<Future<String>> futures =
1735 <            e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1736 <        assertEquals(1, futures.size());
1737 <        try {
1738 <            futures.get(0).get();
1739 <            shouldThrow();
1740 <        } catch (ExecutionException success) {
1741 <            assertTrue(success.getCause() instanceof NullPointerException);
1742 <        } finally {
1743 <            joinPool(e);
1732 >        try (PoolCleaner cleaner = cleaner(e)) {
1733 >            List<Callable<String>> l = new ArrayList<>();
1734 >            l.add(new NPETask());
1735 >            List<Future<String>> futures =
1736 >                e.invokeAll(l, LONG_DELAY_MS, MILLISECONDS);
1737 >            assertEquals(1, futures.size());
1738 >            try {
1739 >                futures.get(0).get();
1740 >                shouldThrow();
1741 >            } catch (ExecutionException success) {
1742 >                assertTrue(success.getCause() instanceof NullPointerException);
1743 >            }
1744          }
1745      }
1746  
# Line 1815 | Line 1748 | public class ThreadPoolExecutorTest exte
1748       * timed invokeAll(c) returns results of all completed tasks
1749       */
1750      public void testTimedInvokeAll5() throws Exception {
1751 <        ExecutorService e =
1751 >        final ExecutorService e =
1752              new ThreadPoolExecutor(2, 2,
1753                                     LONG_DELAY_MS, MILLISECONDS,
1754                                     new ArrayBlockingQueue<Runnable>(10));
1755 <        try {
1756 <            List<Callable<String>> l = new ArrayList<Callable<String>>();
1755 >        try (PoolCleaner cleaner = cleaner(e)) {
1756 >            List<Callable<String>> l = new ArrayList<>();
1757              l.add(new StringTask());
1758              l.add(new StringTask());
1759              List<Future<String>> futures =
1760 <                e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1760 >                e.invokeAll(l, LONG_DELAY_MS, MILLISECONDS);
1761              assertEquals(2, futures.size());
1762              for (Future<String> future : futures)
1763                  assertSame(TEST_STRING, future.get());
1831        } finally {
1832            joinPool(e);
1764          }
1765      }
1766  
# Line 1837 | Line 1768 | public class ThreadPoolExecutorTest exte
1768       * timed invokeAll(c) cancels tasks not completed by timeout
1769       */
1770      public void testTimedInvokeAll6() throws Exception {
1771 <        ExecutorService e =
1772 <            new ThreadPoolExecutor(2, 2,
1773 <                                   LONG_DELAY_MS, MILLISECONDS,
1774 <                                   new ArrayBlockingQueue<Runnable>(10));
1775 <        try {
1776 <            List<Callable<String>> l = new ArrayList<Callable<String>>();
1777 <            l.add(new StringTask());
1778 <            l.add(Executors.callable(new MediumPossiblyInterruptedRunnable(), TEST_STRING));
1779 <            l.add(new StringTask());
1780 <            List<Future<String>> futures =
1781 <                e.invokeAll(l, SHORT_DELAY_MS, MILLISECONDS);
1782 <            assertEquals(3, futures.size());
1783 <            Iterator<Future<String>> it = futures.iterator();
1784 <            Future<String> f1 = it.next();
1785 <            Future<String> f2 = it.next();
1786 <            Future<String> f3 = it.next();
1787 <            assertTrue(f1.isDone());
1788 <            assertTrue(f2.isDone());
1789 <            assertTrue(f3.isDone());
1790 <            assertFalse(f1.isCancelled());
1791 <            assertTrue(f2.isCancelled());
1792 <        } finally {
1793 <            joinPool(e);
1771 >        for (long timeout = timeoutMillis();;) {
1772 >            final CountDownLatch done = new CountDownLatch(1);
1773 >            final Callable<String> waiter = new CheckedCallable<String>() {
1774 >                public String realCall() {
1775 >                    try { done.await(LONG_DELAY_MS, MILLISECONDS); }
1776 >                    catch (InterruptedException ok) {}
1777 >                    return "1"; }};
1778 >            final ExecutorService p =
1779 >                new ThreadPoolExecutor(2, 2,
1780 >                                       LONG_DELAY_MS, MILLISECONDS,
1781 >                                       new ArrayBlockingQueue<Runnable>(10));
1782 >            try (PoolCleaner cleaner = cleaner(p, done)) {
1783 >                List<Callable<String>> tasks = new ArrayList<>();
1784 >                tasks.add(new StringTask("0"));
1785 >                tasks.add(waiter);
1786 >                tasks.add(new StringTask("2"));
1787 >                long startTime = System.nanoTime();
1788 >                List<Future<String>> futures =
1789 >                    p.invokeAll(tasks, timeout, MILLISECONDS);
1790 >                assertEquals(tasks.size(), futures.size());
1791 >                assertTrue(millisElapsedSince(startTime) >= timeout);
1792 >                for (Future future : futures)
1793 >                    assertTrue(future.isDone());
1794 >                assertTrue(futures.get(1).isCancelled());
1795 >                try {
1796 >                    assertEquals("0", futures.get(0).get());
1797 >                    assertEquals("2", futures.get(2).get());
1798 >                    break;
1799 >                } catch (CancellationException retryWithLongerTimeout) {
1800 >                    timeout *= 2;
1801 >                    if (timeout >= LONG_DELAY_MS / 2)
1802 >                        fail("expected exactly one task to be cancelled");
1803 >                }
1804 >            }
1805          }
1806      }
1807  
# Line 1873 | Line 1815 | public class ThreadPoolExecutorTest exte
1815                                     LONG_DELAY_MS, MILLISECONDS,
1816                                     new LinkedBlockingQueue<Runnable>(),
1817                                     new FailingThreadFactory());
1818 <        try {
1818 >        try (PoolCleaner cleaner = cleaner(e)) {
1819              final int TASKS = 100;
1820              final CountDownLatch done = new CountDownLatch(TASKS);
1821              for (int k = 0; k < TASKS; ++k)
# Line 1881 | Line 1823 | public class ThreadPoolExecutorTest exte
1823                      public void realRun() {
1824                          done.countDown();
1825                      }});
1826 <            assertTrue(done.await(LONG_DELAY_MS, MILLISECONDS));
1885 <        } finally {
1886 <            joinPool(e);
1826 >            await(done);
1827          }
1828      }
1829  
# Line 1895 | Line 1835 | public class ThreadPoolExecutorTest exte
1835              new ThreadPoolExecutor(2, 2,
1836                                     1000, MILLISECONDS,
1837                                     new ArrayBlockingQueue<Runnable>(10));
1838 <        assertFalse(p.allowsCoreThreadTimeOut());
1839 <        joinPool(p);
1838 >        try (PoolCleaner cleaner = cleaner(p)) {
1839 >            assertFalse(p.allowsCoreThreadTimeOut());
1840 >        }
1841      }
1842  
1843      /**
1844       * allowCoreThreadTimeOut(true) causes idle threads to time out
1845       */
1846      public void testAllowCoreThreadTimeOut_true() throws Exception {
1847 +        long keepAliveTime = timeoutMillis();
1848          final ThreadPoolExecutor p =
1849              new ThreadPoolExecutor(2, 10,
1850 <                                   SHORT_DELAY_MS, MILLISECONDS,
1850 >                                   keepAliveTime, MILLISECONDS,
1851                                     new ArrayBlockingQueue<Runnable>(10));
1852 <        final CountDownLatch threadStarted = new CountDownLatch(1);
1853 <        try {
1852 >        try (PoolCleaner cleaner = cleaner(p)) {
1853 >            final CountDownLatch threadStarted = new CountDownLatch(1);
1854              p.allowCoreThreadTimeOut(true);
1855              p.execute(new CheckedRunnable() {
1856 <                public void realRun() throws InterruptedException {
1856 >                public void realRun() {
1857                      threadStarted.countDown();
1858                      assertEquals(1, p.getPoolSize());
1859                  }});
1860 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
1861 <            for (int i = 0; i < (MEDIUM_DELAY_MS/10); i++) {
1862 <                if (p.getPoolSize() == 0)
1863 <                    break;
1864 <                delay(10);
1865 <            }
1860 >            await(threadStarted);
1861 >            delay(keepAliveTime);
1862 >            long startTime = System.nanoTime();
1863 >            while (p.getPoolSize() > 0
1864 >                   && millisElapsedSince(startTime) < LONG_DELAY_MS)
1865 >                Thread.yield();
1866 >            assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
1867              assertEquals(0, p.getPoolSize());
1925        } finally {
1926            joinPool(p);
1868          }
1869      }
1870  
# Line 1931 | Line 1872 | public class ThreadPoolExecutorTest exte
1872       * allowCoreThreadTimeOut(false) causes idle threads not to time out
1873       */
1874      public void testAllowCoreThreadTimeOut_false() throws Exception {
1875 +        long keepAliveTime = timeoutMillis();
1876          final ThreadPoolExecutor p =
1877              new ThreadPoolExecutor(2, 10,
1878 <                                   SHORT_DELAY_MS, MILLISECONDS,
1878 >                                   keepAliveTime, MILLISECONDS,
1879                                     new ArrayBlockingQueue<Runnable>(10));
1880 <        final CountDownLatch threadStarted = new CountDownLatch(1);
1881 <        try {
1880 >        try (PoolCleaner cleaner = cleaner(p)) {
1881 >            final CountDownLatch threadStarted = new CountDownLatch(1);
1882              p.allowCoreThreadTimeOut(false);
1883              p.execute(new CheckedRunnable() {
1884                  public void realRun() throws InterruptedException {
1885                      threadStarted.countDown();
1886                      assertTrue(p.getPoolSize() >= 1);
1887                  }});
1888 <            delay(SMALL_DELAY_MS);
1888 >            delay(2 * keepAliveTime);
1889              assertTrue(p.getPoolSize() >= 1);
1948        } finally {
1949            joinPool(p);
1890          }
1891      }
1892  
# Line 1962 | Line 1902 | public class ThreadPoolExecutorTest exte
1902                  done.countDown();
1903              }};
1904          final ThreadPoolExecutor p =
1905 <            new ThreadPoolExecutor(1, 30, 60, TimeUnit.SECONDS,
1905 >            new ThreadPoolExecutor(1, 30,
1906 >                                   60, SECONDS,
1907                                     new ArrayBlockingQueue(30));
1908 <        try {
1908 >        try (PoolCleaner cleaner = cleaner(p)) {
1909              for (int i = 0; i < nTasks; ++i) {
1910                  for (;;) {
1911                      try {
# Line 1975 | Line 1916 | public class ThreadPoolExecutorTest exte
1916                  }
1917              }
1918              // enough time to run all tasks
1919 <            assertTrue(done.await(nTasks * SHORT_DELAY_MS, MILLISECONDS));
1979 <        } finally {
1980 <            p.shutdown();
1919 >            await(done, nTasks * SHORT_DELAY_MS);
1920          }
1921      }
1922  
1923 +    /**
1924 +     * get(cancelled task) throws CancellationException
1925 +     */
1926 +    public void testGet_cancelled() throws Exception {
1927 +        final CountDownLatch done = new CountDownLatch(1);
1928 +        final ExecutorService e =
1929 +            new ThreadPoolExecutor(1, 1,
1930 +                                   LONG_DELAY_MS, MILLISECONDS,
1931 +                                   new LinkedBlockingQueue<Runnable>());
1932 +        try (PoolCleaner cleaner = cleaner(e, done)) {
1933 +            final CountDownLatch blockerStarted = new CountDownLatch(1);
1934 +            final List<Future<?>> futures = new ArrayList<>();
1935 +            for (int i = 0; i < 2; i++) {
1936 +                Runnable r = new CheckedRunnable() { public void realRun()
1937 +                                                         throws Throwable {
1938 +                    blockerStarted.countDown();
1939 +                    assertTrue(done.await(2 * LONG_DELAY_MS, MILLISECONDS));
1940 +                }};
1941 +                futures.add(e.submit(r));
1942 +            }
1943 +            await(blockerStarted);
1944 +            for (Future<?> future : futures) future.cancel(false);
1945 +            for (Future<?> future : futures) {
1946 +                try {
1947 +                    future.get();
1948 +                    shouldThrow();
1949 +                } catch (CancellationException success) {}
1950 +                try {
1951 +                    future.get(LONG_DELAY_MS, MILLISECONDS);
1952 +                    shouldThrow();
1953 +                } catch (CancellationException success) {}
1954 +                assertTrue(future.isCancelled());
1955 +                assertTrue(future.isDone());
1956 +            }
1957 +        }
1958 +    }
1959 +
1960 +    /** Directly test simple ThreadPoolExecutor RejectedExecutionHandlers. */
1961 +    public void testStandardRejectedExecutionHandlers() {
1962 +        final ThreadPoolExecutor p =
1963 +            new ThreadPoolExecutor(1, 1, 1, SECONDS,
1964 +                                   new ArrayBlockingQueue<Runnable>(1));
1965 +        final AtomicReference<Thread> thread = new AtomicReference<>();
1966 +        final Runnable r = new Runnable() { public void run() {
1967 +            thread.set(Thread.currentThread()); }};
1968 +
1969 +        try {
1970 +            new AbortPolicy().rejectedExecution(r, p);
1971 +            shouldThrow();
1972 +        } catch (RejectedExecutionException success) {}
1973 +        assertNull(thread.get());
1974 +
1975 +        new DiscardPolicy().rejectedExecution(r, p);
1976 +        assertNull(thread.get());
1977 +
1978 +        new CallerRunsPolicy().rejectedExecution(r, p);
1979 +        assertSame(Thread.currentThread(), thread.get());
1980 +
1981 +        // check that pool was not perturbed by handlers
1982 +        assertTrue(p.getRejectedExecutionHandler() instanceof AbortPolicy);
1983 +        assertEquals(0, p.getTaskCount());
1984 +        assertTrue(p.getQueue().isEmpty());
1985 +    }
1986 +
1987   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines