ViewVC Help
View File | Revision Log | Show Annotations | Download File | Root Listing
root/jsr166/jsr166/src/test/tck/ThreadPoolExecutorTest.java
(Generate patch)

Comparing jsr166/src/test/tck/ThreadPoolExecutorTest.java (file contents):
Revision 1.58 by jsr166, Mon Sep 14 00:53:37 2015 UTC vs.
Revision 1.104 by jsr166, Mon Oct 5 22:54:45 2015 UTC

# Line 29 | Line 29 | import java.util.concurrent.SynchronousQ
29   import java.util.concurrent.ThreadFactory;
30   import java.util.concurrent.ThreadPoolExecutor;
31   import java.util.concurrent.TimeUnit;
32 + import java.util.concurrent.atomic.AtomicInteger;
33  
34   import junit.framework.Test;
35   import junit.framework.TestSuite;
# Line 86 | Line 87 | public class ThreadPoolExecutorTest exte
87              new ThreadPoolExecutor(1, 1,
88                                     LONG_DELAY_MS, MILLISECONDS,
89                                     new ArrayBlockingQueue<Runnable>(10));
90 <        final CountDownLatch done = new CountDownLatch(1);
91 <        final Runnable task = new CheckedRunnable() {
92 <            public void realRun() {
93 <                done.countDown();
93 <            }};
94 <        try {
90 >        try (PoolCleaner cleaner = cleaner(p)) {
91 >            final CountDownLatch done = new CountDownLatch(1);
92 >            final Runnable task = new CheckedRunnable() {
93 >                public void realRun() { done.countDown(); }};
94              p.execute(task);
95 <            assertTrue(done.await(SMALL_DELAY_MS, MILLISECONDS));
97 <        } finally {
98 <            joinPool(p);
95 >            assertTrue(done.await(LONG_DELAY_MS, MILLISECONDS));
96          }
97      }
98  
# Line 108 | Line 105 | public class ThreadPoolExecutorTest exte
105              new ThreadPoolExecutor(2, 2,
106                                     LONG_DELAY_MS, MILLISECONDS,
107                                     new ArrayBlockingQueue<Runnable>(10));
108 <        final CountDownLatch threadStarted = new CountDownLatch(1);
109 <        final CountDownLatch done = new CountDownLatch(1);
110 <        try {
108 >        try (PoolCleaner cleaner = cleaner(p)) {
109 >            final CountDownLatch threadStarted = new CountDownLatch(1);
110 >            final CountDownLatch done = new CountDownLatch(1);
111              assertEquals(0, p.getActiveCount());
112              p.execute(new CheckedRunnable() {
113                  public void realRun() throws InterruptedException {
# Line 118 | Line 115 | public class ThreadPoolExecutorTest exte
115                      assertEquals(1, p.getActiveCount());
116                      done.await();
117                  }});
118 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
118 >            assertTrue(threadStarted.await(LONG_DELAY_MS, MILLISECONDS));
119              assertEquals(1, p.getActiveCount());
123        } finally {
120              done.countDown();
125            joinPool(p);
121          }
122      }
123  
# Line 131 | Line 126 | public class ThreadPoolExecutorTest exte
126       */
127      public void testPrestartCoreThread() {
128          final ThreadPoolExecutor p =
129 <            new ThreadPoolExecutor(2, 2,
129 >            new ThreadPoolExecutor(2, 6,
130                                     LONG_DELAY_MS, MILLISECONDS,
131                                     new ArrayBlockingQueue<Runnable>(10));
132 <        assertEquals(0, p.getPoolSize());
133 <        assertTrue(p.prestartCoreThread());
134 <        assertEquals(1, p.getPoolSize());
135 <        assertTrue(p.prestartCoreThread());
136 <        assertEquals(2, p.getPoolSize());
137 <        assertFalse(p.prestartCoreThread());
138 <        assertEquals(2, p.getPoolSize());
139 <        joinPool(p);
132 >        try (PoolCleaner cleaner = cleaner(p)) {
133 >            assertEquals(0, p.getPoolSize());
134 >            assertTrue(p.prestartCoreThread());
135 >            assertEquals(1, p.getPoolSize());
136 >            assertTrue(p.prestartCoreThread());
137 >            assertEquals(2, p.getPoolSize());
138 >            assertFalse(p.prestartCoreThread());
139 >            assertEquals(2, p.getPoolSize());
140 >            p.setCorePoolSize(4);
141 >            assertTrue(p.prestartCoreThread());
142 >            assertEquals(3, p.getPoolSize());
143 >            assertTrue(p.prestartCoreThread());
144 >            assertEquals(4, p.getPoolSize());
145 >            assertFalse(p.prestartCoreThread());
146 >            assertEquals(4, p.getPoolSize());
147 >        }
148      }
149  
150      /**
# Line 149 | Line 152 | public class ThreadPoolExecutorTest exte
152       */
153      public void testPrestartAllCoreThreads() {
154          final ThreadPoolExecutor p =
155 <            new ThreadPoolExecutor(2, 2,
155 >            new ThreadPoolExecutor(2, 6,
156                                     LONG_DELAY_MS, MILLISECONDS,
157                                     new ArrayBlockingQueue<Runnable>(10));
158 <        assertEquals(0, p.getPoolSize());
159 <        p.prestartAllCoreThreads();
160 <        assertEquals(2, p.getPoolSize());
161 <        p.prestartAllCoreThreads();
162 <        assertEquals(2, p.getPoolSize());
163 <        joinPool(p);
158 >        try (PoolCleaner cleaner = cleaner(p)) {
159 >            assertEquals(0, p.getPoolSize());
160 >            p.prestartAllCoreThreads();
161 >            assertEquals(2, p.getPoolSize());
162 >            p.prestartAllCoreThreads();
163 >            assertEquals(2, p.getPoolSize());
164 >            p.setCorePoolSize(4);
165 >            p.prestartAllCoreThreads();
166 >            assertEquals(4, p.getPoolSize());
167 >            p.prestartAllCoreThreads();
168 >            assertEquals(4, p.getPoolSize());
169 >        }
170      }
171  
172      /**
# Line 169 | Line 178 | public class ThreadPoolExecutorTest exte
178              new ThreadPoolExecutor(2, 2,
179                                     LONG_DELAY_MS, MILLISECONDS,
180                                     new ArrayBlockingQueue<Runnable>(10));
181 <        final CountDownLatch threadStarted = new CountDownLatch(1);
182 <        final CountDownLatch threadProceed = new CountDownLatch(1);
183 <        final CountDownLatch threadDone = new CountDownLatch(1);
184 <        try {
181 >        try (PoolCleaner cleaner = cleaner(p)) {
182 >            final CountDownLatch threadStarted = new CountDownLatch(1);
183 >            final CountDownLatch threadProceed = new CountDownLatch(1);
184 >            final CountDownLatch threadDone = new CountDownLatch(1);
185              assertEquals(0, p.getCompletedTaskCount());
186              p.execute(new CheckedRunnable() {
187                  public void realRun() throws InterruptedException {
# Line 191 | Line 200 | public class ThreadPoolExecutorTest exte
200                      fail("timed out");
201                  Thread.yield();
202              }
194        } finally {
195            joinPool(p);
203          }
204      }
205  
# Line 204 | Line 211 | public class ThreadPoolExecutorTest exte
211              new ThreadPoolExecutor(1, 1,
212                                     LONG_DELAY_MS, MILLISECONDS,
213                                     new ArrayBlockingQueue<Runnable>(10));
214 <        assertEquals(1, p.getCorePoolSize());
215 <        joinPool(p);
214 >        try (PoolCleaner cleaner = cleaner(p)) {
215 >            assertEquals(1, p.getCorePoolSize());
216 >        }
217      }
218  
219      /**
# Line 216 | Line 224 | public class ThreadPoolExecutorTest exte
224              new ThreadPoolExecutor(2, 2,
225                                     1000, MILLISECONDS,
226                                     new ArrayBlockingQueue<Runnable>(10));
227 <        assertEquals(1, p.getKeepAliveTime(SECONDS));
228 <        joinPool(p);
227 >        try (PoolCleaner cleaner = cleaner(p)) {
228 >            assertEquals(1, p.getKeepAliveTime(SECONDS));
229 >        }
230      }
231  
232      /**
233       * getThreadFactory returns factory in constructor if not set
234       */
235      public void testGetThreadFactory() {
236 <        ThreadFactory tf = new SimpleThreadFactory();
236 >        ThreadFactory threadFactory = new SimpleThreadFactory();
237          final ThreadPoolExecutor p =
238              new ThreadPoolExecutor(1, 2,
239                                     LONG_DELAY_MS, MILLISECONDS,
240                                     new ArrayBlockingQueue<Runnable>(10),
241 <                                   tf,
241 >                                   threadFactory,
242                                     new NoOpREHandler());
243 <        assertSame(tf, p.getThreadFactory());
244 <        joinPool(p);
243 >        try (PoolCleaner cleaner = cleaner(p)) {
244 >            assertSame(threadFactory, p.getThreadFactory());
245 >        }
246      }
247  
248      /**
# Line 243 | Line 253 | public class ThreadPoolExecutorTest exte
253              new ThreadPoolExecutor(1, 2,
254                                     LONG_DELAY_MS, MILLISECONDS,
255                                     new ArrayBlockingQueue<Runnable>(10));
256 <        ThreadFactory tf = new SimpleThreadFactory();
257 <        p.setThreadFactory(tf);
258 <        assertSame(tf, p.getThreadFactory());
259 <        joinPool(p);
256 >        try (PoolCleaner cleaner = cleaner(p)) {
257 >            ThreadFactory threadFactory = new SimpleThreadFactory();
258 >            p.setThreadFactory(threadFactory);
259 >            assertSame(threadFactory, p.getThreadFactory());
260 >        }
261      }
262  
263      /**
# Line 257 | Line 268 | public class ThreadPoolExecutorTest exte
268              new ThreadPoolExecutor(1, 2,
269                                     LONG_DELAY_MS, MILLISECONDS,
270                                     new ArrayBlockingQueue<Runnable>(10));
271 <        try {
272 <            p.setThreadFactory(null);
273 <            shouldThrow();
274 <        } catch (NullPointerException success) {
275 <        } finally {
265 <            joinPool(p);
271 >        try (PoolCleaner cleaner = cleaner(p)) {
272 >            try {
273 >                p.setThreadFactory(null);
274 >                shouldThrow();
275 >            } catch (NullPointerException success) {}
276          }
277      }
278  
# Line 270 | Line 280 | public class ThreadPoolExecutorTest exte
280       * getRejectedExecutionHandler returns handler in constructor if not set
281       */
282      public void testGetRejectedExecutionHandler() {
283 <        final RejectedExecutionHandler h = new NoOpREHandler();
283 >        final RejectedExecutionHandler handler = new NoOpREHandler();
284          final ThreadPoolExecutor p =
285              new ThreadPoolExecutor(1, 2,
286                                     LONG_DELAY_MS, MILLISECONDS,
287                                     new ArrayBlockingQueue<Runnable>(10),
288 <                                   h);
289 <        assertSame(h, p.getRejectedExecutionHandler());
290 <        joinPool(p);
288 >                                   handler);
289 >        try (PoolCleaner cleaner = cleaner(p)) {
290 >            assertSame(handler, p.getRejectedExecutionHandler());
291 >        }
292      }
293  
294      /**
# Line 289 | Line 300 | public class ThreadPoolExecutorTest exte
300              new ThreadPoolExecutor(1, 2,
301                                     LONG_DELAY_MS, MILLISECONDS,
302                                     new ArrayBlockingQueue<Runnable>(10));
303 <        RejectedExecutionHandler h = new NoOpREHandler();
304 <        p.setRejectedExecutionHandler(h);
305 <        assertSame(h, p.getRejectedExecutionHandler());
306 <        joinPool(p);
303 >        try (PoolCleaner cleaner = cleaner(p)) {
304 >            RejectedExecutionHandler handler = new NoOpREHandler();
305 >            p.setRejectedExecutionHandler(handler);
306 >            assertSame(handler, p.getRejectedExecutionHandler());
307 >        }
308      }
309  
310      /**
# Line 303 | Line 315 | public class ThreadPoolExecutorTest exte
315              new ThreadPoolExecutor(1, 2,
316                                     LONG_DELAY_MS, MILLISECONDS,
317                                     new ArrayBlockingQueue<Runnable>(10));
318 <        try {
319 <            p.setRejectedExecutionHandler(null);
320 <            shouldThrow();
321 <        } catch (NullPointerException success) {
322 <        } finally {
311 <            joinPool(p);
318 >        try (PoolCleaner cleaner = cleaner(p)) {
319 >            try {
320 >                p.setRejectedExecutionHandler(null);
321 >                shouldThrow();
322 >            } catch (NullPointerException success) {}
323          }
324      }
325  
# Line 318 | Line 329 | public class ThreadPoolExecutorTest exte
329       */
330      public void testGetLargestPoolSize() throws InterruptedException {
331          final int THREADS = 3;
332 +        final CountDownLatch done = new CountDownLatch(1);
333          final ThreadPoolExecutor p =
334              new ThreadPoolExecutor(THREADS, THREADS,
335                                     LONG_DELAY_MS, MILLISECONDS,
336                                     new ArrayBlockingQueue<Runnable>(10));
337 <        final CountDownLatch threadsStarted = new CountDownLatch(THREADS);
326 <        final CountDownLatch done = new CountDownLatch(1);
327 <        try {
337 >        try (PoolCleaner cleaner = cleaner(p, done)) {
338              assertEquals(0, p.getLargestPoolSize());
339 +            final CountDownLatch threadsStarted = new CountDownLatch(THREADS);
340              for (int i = 0; i < THREADS; i++)
341                  p.execute(new CheckedRunnable() {
342                      public void realRun() throws InterruptedException {
# Line 333 | Line 344 | public class ThreadPoolExecutorTest exte
344                          done.await();
345                          assertEquals(THREADS, p.getLargestPoolSize());
346                      }});
347 <            assertTrue(threadsStarted.await(SMALL_DELAY_MS, MILLISECONDS));
337 <            assertEquals(THREADS, p.getLargestPoolSize());
338 <        } finally {
339 <            done.countDown();
340 <            joinPool(p);
347 >            assertTrue(threadsStarted.await(LONG_DELAY_MS, MILLISECONDS));
348              assertEquals(THREADS, p.getLargestPoolSize());
349          }
350 +        assertEquals(THREADS, p.getLargestPoolSize());
351      }
352  
353      /**
# Line 351 | Line 359 | public class ThreadPoolExecutorTest exte
359              new ThreadPoolExecutor(2, 3,
360                                     LONG_DELAY_MS, MILLISECONDS,
361                                     new ArrayBlockingQueue<Runnable>(10));
362 <        assertEquals(3, p.getMaximumPoolSize());
363 <        joinPool(p);
362 >        try (PoolCleaner cleaner = cleaner(p)) {
363 >            assertEquals(3, p.getMaximumPoolSize());
364 >            p.setMaximumPoolSize(5);
365 >            assertEquals(5, p.getMaximumPoolSize());
366 >            p.setMaximumPoolSize(4);
367 >            assertEquals(4, p.getMaximumPoolSize());
368 >        }
369      }
370  
371      /**
# Line 360 | Line 373 | public class ThreadPoolExecutorTest exte
373       * become active
374       */
375      public void testGetPoolSize() throws InterruptedException {
376 +        final CountDownLatch done = new CountDownLatch(1);
377          final ThreadPoolExecutor p =
378              new ThreadPoolExecutor(1, 1,
379                                     LONG_DELAY_MS, MILLISECONDS,
380                                     new ArrayBlockingQueue<Runnable>(10));
381 <        final CountDownLatch threadStarted = new CountDownLatch(1);
368 <        final CountDownLatch done = new CountDownLatch(1);
369 <        try {
381 >        try (PoolCleaner cleaner = cleaner(p, done)) {
382              assertEquals(0, p.getPoolSize());
383 +            final CountDownLatch threadStarted = new CountDownLatch(1);
384              p.execute(new CheckedRunnable() {
385                  public void realRun() throws InterruptedException {
386                      threadStarted.countDown();
387                      assertEquals(1, p.getPoolSize());
388                      done.await();
389                  }});
390 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
390 >            assertTrue(threadStarted.await(LONG_DELAY_MS, MILLISECONDS));
391              assertEquals(1, p.getPoolSize());
379        } finally {
380            done.countDown();
381            joinPool(p);
392          }
393      }
394  
# Line 386 | Line 396 | public class ThreadPoolExecutorTest exte
396       * getTaskCount increases, but doesn't overestimate, when tasks submitted
397       */
398      public void testGetTaskCount() throws InterruptedException {
399 +        final int TASKS = 3;
400 +        final CountDownLatch done = new CountDownLatch(1);
401          final ThreadPoolExecutor p =
402              new ThreadPoolExecutor(1, 1,
403                                     LONG_DELAY_MS, MILLISECONDS,
404                                     new ArrayBlockingQueue<Runnable>(10));
405 <        final CountDownLatch threadStarted = new CountDownLatch(1);
406 <        final CountDownLatch done = new CountDownLatch(1);
395 <        try {
405 >        try (PoolCleaner cleaner = cleaner(p, done)) {
406 >            final CountDownLatch threadStarted = new CountDownLatch(1);
407              assertEquals(0, p.getTaskCount());
408 +            assertEquals(0, p.getCompletedTaskCount());
409              p.execute(new CheckedRunnable() {
410                  public void realRun() throws InterruptedException {
411                      threadStarted.countDown();
400                    assertEquals(1, p.getTaskCount());
412                      done.await();
413                  }});
414 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
414 >            assertTrue(threadStarted.await(LONG_DELAY_MS, MILLISECONDS));
415              assertEquals(1, p.getTaskCount());
416 <        } finally {
417 <            done.countDown();
418 <            joinPool(p);
416 >            assertEquals(0, p.getCompletedTaskCount());
417 >            for (int i = 0; i < TASKS; i++) {
418 >                assertEquals(1 + i, p.getTaskCount());
419 >                p.execute(new CheckedRunnable() {
420 >                    public void realRun() throws InterruptedException {
421 >                        threadStarted.countDown();
422 >                        assertEquals(1 + TASKS, p.getTaskCount());
423 >                        done.await();
424 >                    }});
425 >            }
426 >            assertEquals(1 + TASKS, p.getTaskCount());
427 >            assertEquals(0, p.getCompletedTaskCount());
428          }
429 +        assertEquals(1 + TASKS, p.getTaskCount());
430 +        assertEquals(1 + TASKS, p.getCompletedTaskCount());
431      }
432  
433      /**
# Line 416 | Line 438 | public class ThreadPoolExecutorTest exte
438              new ThreadPoolExecutor(1, 1,
439                                     LONG_DELAY_MS, MILLISECONDS,
440                                     new ArrayBlockingQueue<Runnable>(10));
441 <        assertFalse(p.isShutdown());
442 <        try { p.shutdown(); } catch (SecurityException ok) { return; }
443 <        assertTrue(p.isShutdown());
444 <        joinPool(p);
441 >        try (PoolCleaner cleaner = cleaner(p)) {
442 >            assertFalse(p.isShutdown());
443 >            try { p.shutdown(); } catch (SecurityException ok) { return; }
444 >            assertTrue(p.isShutdown());
445 >        }
446      }
447  
448      /**
# Line 430 | Line 453 | public class ThreadPoolExecutorTest exte
453              new ThreadPoolExecutor(1, 1,
454                                     LONG_DELAY_MS, MILLISECONDS,
455                                     new ArrayBlockingQueue<Runnable>(10));
456 <        assertFalse(p.isTerminated());
457 <        assertFalse(p.awaitTermination(Long.MIN_VALUE, NANOSECONDS));
458 <        assertFalse(p.awaitTermination(Long.MIN_VALUE, MILLISECONDS));
459 <        assertFalse(p.awaitTermination(-1L, NANOSECONDS));
460 <        assertFalse(p.awaitTermination(-1L, MILLISECONDS));
461 <        assertFalse(p.awaitTermination(0L, NANOSECONDS));
462 <        assertFalse(p.awaitTermination(0L, MILLISECONDS));
463 <        long timeoutNanos = 999999L;
464 <        long startTime = System.nanoTime();
465 <        assertFalse(p.awaitTermination(timeoutNanos, NANOSECONDS));
466 <        assertTrue(System.nanoTime() - startTime >= timeoutNanos);
467 <        assertFalse(p.isTerminated());
468 <        startTime = System.nanoTime();
469 <        long timeoutMillis = timeoutMillis();
470 <        assertFalse(p.awaitTermination(timeoutMillis, MILLISECONDS));
471 <        assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
472 <        assertFalse(p.isTerminated());
473 <        p.shutdown();
474 <        assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
475 <        assertTrue(p.isTerminated());
456 >        try (PoolCleaner cleaner = cleaner(p)) {
457 >            assertFalse(p.isTerminated());
458 >            assertFalse(p.awaitTermination(Long.MIN_VALUE, NANOSECONDS));
459 >            assertFalse(p.awaitTermination(Long.MIN_VALUE, MILLISECONDS));
460 >            assertFalse(p.awaitTermination(-1L, NANOSECONDS));
461 >            assertFalse(p.awaitTermination(-1L, MILLISECONDS));
462 >            assertFalse(p.awaitTermination(0L, NANOSECONDS));
463 >            assertFalse(p.awaitTermination(0L, MILLISECONDS));
464 >            long timeoutNanos = 999999L;
465 >            long startTime = System.nanoTime();
466 >            assertFalse(p.awaitTermination(timeoutNanos, NANOSECONDS));
467 >            assertTrue(System.nanoTime() - startTime >= timeoutNanos);
468 >            assertFalse(p.isTerminated());
469 >            startTime = System.nanoTime();
470 >            long timeoutMillis = timeoutMillis();
471 >            assertFalse(p.awaitTermination(timeoutMillis, MILLISECONDS));
472 >            assertTrue(millisElapsedSince(startTime) >= timeoutMillis);
473 >            assertFalse(p.isTerminated());
474 >            try { p.shutdown(); } catch (SecurityException ok) { return; }
475 >            assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
476 >            assertTrue(p.isTerminated());
477 >        }
478      }
479  
480      /**
# Line 460 | Line 485 | public class ThreadPoolExecutorTest exte
485              new ThreadPoolExecutor(1, 1,
486                                     LONG_DELAY_MS, MILLISECONDS,
487                                     new ArrayBlockingQueue<Runnable>(10));
488 <        final CountDownLatch threadStarted = new CountDownLatch(1);
489 <        final CountDownLatch done = new CountDownLatch(1);
490 <        assertFalse(p.isTerminated());
491 <        try {
488 >        try (PoolCleaner cleaner = cleaner(p)) {
489 >            final CountDownLatch threadStarted = new CountDownLatch(1);
490 >            final CountDownLatch done = new CountDownLatch(1);
491 >            assertFalse(p.isTerminating());
492              p.execute(new CheckedRunnable() {
493                  public void realRun() throws InterruptedException {
494 <                    assertFalse(p.isTerminated());
494 >                    assertFalse(p.isTerminating());
495                      threadStarted.countDown();
496                      done.await();
497                  }});
498 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
498 >            assertTrue(threadStarted.await(LONG_DELAY_MS, MILLISECONDS));
499              assertFalse(p.isTerminating());
500              done.countDown();
476        } finally {
501              try { p.shutdown(); } catch (SecurityException ok) { return; }
502 +            assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
503 +            assertTrue(p.isTerminated());
504 +            assertFalse(p.isTerminating());
505          }
479        assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
480        assertTrue(p.isTerminated());
506      }
507  
508      /**
# Line 488 | Line 513 | public class ThreadPoolExecutorTest exte
513              new ThreadPoolExecutor(1, 1,
514                                     LONG_DELAY_MS, MILLISECONDS,
515                                     new ArrayBlockingQueue<Runnable>(10));
516 <        final CountDownLatch threadStarted = new CountDownLatch(1);
517 <        final CountDownLatch done = new CountDownLatch(1);
518 <        try {
516 >        try (PoolCleaner cleaner = cleaner(p)) {
517 >            final CountDownLatch threadStarted = new CountDownLatch(1);
518 >            final CountDownLatch done = new CountDownLatch(1);
519              assertFalse(p.isTerminating());
520              p.execute(new CheckedRunnable() {
521                  public void realRun() throws InterruptedException {
# Line 498 | Line 523 | public class ThreadPoolExecutorTest exte
523                      threadStarted.countDown();
524                      done.await();
525                  }});
526 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
526 >            assertTrue(threadStarted.await(LONG_DELAY_MS, MILLISECONDS));
527              assertFalse(p.isTerminating());
528              done.countDown();
504        } finally {
529              try { p.shutdown(); } catch (SecurityException ok) { return; }
530 +            assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
531 +            assertTrue(p.isTerminated());
532 +            assertFalse(p.isTerminating());
533          }
507        assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
508        assertTrue(p.isTerminated());
509        assertFalse(p.isTerminating());
534      }
535  
536      /**
# Line 518 | Line 542 | public class ThreadPoolExecutorTest exte
542              new ThreadPoolExecutor(1, 1,
543                                     LONG_DELAY_MS, MILLISECONDS,
544                                     q);
545 <        final CountDownLatch threadStarted = new CountDownLatch(1);
546 <        final CountDownLatch done = new CountDownLatch(1);
547 <        try {
545 >        try (PoolCleaner cleaner = cleaner(p)) {
546 >            final CountDownLatch threadStarted = new CountDownLatch(1);
547 >            final CountDownLatch done = new CountDownLatch(1);
548              FutureTask[] tasks = new FutureTask[5];
549              for (int i = 0; i < tasks.length; i++) {
550                  Callable task = new CheckedCallable<Boolean>() {
# Line 533 | Line 557 | public class ThreadPoolExecutorTest exte
557                  tasks[i] = new FutureTask(task);
558                  p.execute(tasks[i]);
559              }
560 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
560 >            assertTrue(threadStarted.await(LONG_DELAY_MS, MILLISECONDS));
561              assertSame(q, p.getQueue());
562              assertFalse(q.contains(tasks[0]));
563              assertTrue(q.contains(tasks[tasks.length - 1]));
564              assertEquals(tasks.length - 1, q.size());
541        } finally {
565              done.countDown();
543            joinPool(p);
566          }
567      }
568  
# Line 553 | Line 575 | public class ThreadPoolExecutorTest exte
575              new ThreadPoolExecutor(1, 1,
576                                     LONG_DELAY_MS, MILLISECONDS,
577                                     q);
578 <        Runnable[] tasks = new Runnable[5];
579 <        final CountDownLatch threadStarted = new CountDownLatch(1);
580 <        final CountDownLatch done = new CountDownLatch(1);
581 <        try {
578 >        try (PoolCleaner cleaner = cleaner(p)) {
579 >            Runnable[] tasks = new Runnable[6];
580 >            final CountDownLatch threadStarted = new CountDownLatch(1);
581 >            final CountDownLatch done = new CountDownLatch(1);
582              for (int i = 0; i < tasks.length; i++) {
583                  tasks[i] = new CheckedRunnable() {
584                      public void realRun() throws InterruptedException {
# Line 565 | Line 587 | public class ThreadPoolExecutorTest exte
587                      }};
588                  p.execute(tasks[i]);
589              }
590 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
590 >            assertTrue(threadStarted.await(LONG_DELAY_MS, MILLISECONDS));
591              assertFalse(p.remove(tasks[0]));
592              assertTrue(q.contains(tasks[4]));
593              assertTrue(q.contains(tasks[3]));
# Line 575 | Line 597 | public class ThreadPoolExecutorTest exte
597              assertTrue(q.contains(tasks[3]));
598              assertTrue(p.remove(tasks[3]));
599              assertFalse(q.contains(tasks[3]));
578        } finally {
600              done.countDown();
580            joinPool(p);
601          }
602      }
603  
# Line 592 | Line 612 | public class ThreadPoolExecutorTest exte
612              new ThreadPoolExecutor(1, 1,
613                                     LONG_DELAY_MS, MILLISECONDS,
614                                     q);
615 <        FutureTask[] tasks = new FutureTask[5];
616 <        try {
615 >        try (PoolCleaner cleaner = cleaner(p, done)) {
616 >            FutureTask[] tasks = new FutureTask[5];
617              for (int i = 0; i < tasks.length; i++) {
618                  Callable task = new CheckedCallable<Boolean>() {
619                      public Boolean realCall() throws InterruptedException {
# Line 604 | Line 624 | public class ThreadPoolExecutorTest exte
624                  tasks[i] = new FutureTask(task);
625                  p.execute(tasks[i]);
626              }
627 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
627 >            assertTrue(threadStarted.await(LONG_DELAY_MS, MILLISECONDS));
628              assertEquals(tasks.length, p.getTaskCount());
629              assertEquals(tasks.length - 1, q.size());
630              assertEquals(1L, p.getActiveCount());
# Line 617 | Line 637 | public class ThreadPoolExecutorTest exte
637              p.purge();         // Nothing to do
638              assertEquals(tasks.length - 3, q.size());
639              assertEquals(tasks.length - 2, p.getTaskCount());
620        } finally {
621            done.countDown();
622            joinPool(p);
640          }
641      }
642  
643      /**
644 <     * shutdownNow returns a list containing tasks that were not run
644 >     * shutdownNow returns a list containing tasks that were not run,
645 >     * and those tasks are drained from the queue
646       */
647 <    public void testShutdownNow() {
647 >    public void testShutdownNow() throws InterruptedException {
648 >        final int poolSize = 2;
649 >        final int count = 5;
650 >        final AtomicInteger ran = new AtomicInteger(0);
651          final ThreadPoolExecutor p =
652 <            new ThreadPoolExecutor(1, 1,
652 >            new ThreadPoolExecutor(poolSize, poolSize,
653                                     LONG_DELAY_MS, MILLISECONDS,
654                                     new ArrayBlockingQueue<Runnable>(10));
655 <        List l;
656 <        try {
657 <            for (int i = 0; i < 5; i++)
637 <                p.execute(new MediumPossiblyInterruptedRunnable());
638 <        }
639 <        finally {
655 >        final CountDownLatch threadsStarted = new CountDownLatch(poolSize);
656 >        Runnable waiter = new CheckedRunnable() { public void realRun() {
657 >            threadsStarted.countDown();
658              try {
659 <                l = p.shutdownNow();
660 <            } catch (SecurityException ok) { return; }
659 >                MILLISECONDS.sleep(2 * LONG_DELAY_MS);
660 >            } catch (InterruptedException success) {}
661 >            ran.getAndIncrement();
662 >        }};
663 >        for (int i = 0; i < count; i++)
664 >            p.execute(waiter);
665 >        assertTrue(threadsStarted.await(LONG_DELAY_MS, MILLISECONDS));
666 >        assertEquals(poolSize, p.getActiveCount());
667 >        assertEquals(0, p.getCompletedTaskCount());
668 >        final List<Runnable> queuedTasks;
669 >        try {
670 >            queuedTasks = p.shutdownNow();
671 >        } catch (SecurityException ok) {
672 >            return; // Allowed in case test doesn't have privs
673          }
674          assertTrue(p.isShutdown());
675 <        assertTrue(l.size() <= 4);
675 >        assertTrue(p.getQueue().isEmpty());
676 >        assertEquals(count - poolSize, queuedTasks.size());
677 >        assertTrue(p.awaitTermination(LONG_DELAY_MS, MILLISECONDS));
678 >        assertTrue(p.isTerminated());
679 >        assertEquals(poolSize, ran.get());
680 >        assertEquals(poolSize, p.getCompletedTaskCount());
681      }
682  
683      // Exception Tests
# Line 989 | Line 1024 | public class ThreadPoolExecutorTest exte
1024       * get of submitted callable throws InterruptedException if interrupted
1025       */
1026      public void testInterruptedSubmit() throws InterruptedException {
1027 +        final CountDownLatch done = new CountDownLatch(1);
1028          final ThreadPoolExecutor p =
1029              new ThreadPoolExecutor(1, 1,
1030                                     60, SECONDS,
1031                                     new ArrayBlockingQueue<Runnable>(10));
1032  
1033 <        final CountDownLatch threadStarted = new CountDownLatch(1);
1034 <        final CountDownLatch done = new CountDownLatch(1);
999 <        try {
1033 >        try (PoolCleaner cleaner = cleaner(p, done)) {
1034 >            final CountDownLatch threadStarted = new CountDownLatch(1);
1035              Thread t = newStartedThread(new CheckedInterruptedRunnable() {
1036                  public void realRun() throws Exception {
1037                      Callable task = new CheckedCallable<Boolean>() {
# Line 1008 | Line 1043 | public class ThreadPoolExecutorTest exte
1043                      p.submit(task).get();
1044                  }});
1045  
1046 <            assertTrue(threadStarted.await(SMALL_DELAY_MS, MILLISECONDS));
1046 >            await(threadStarted);
1047              t.interrupt();
1048 <            awaitTermination(t, MEDIUM_DELAY_MS);
1014 <        } finally {
1015 <            done.countDown();
1016 <            joinPool(p);
1048 >            awaitTermination(t);
1049          }
1050      }
1051  
# Line 1021 | Line 1053 | public class ThreadPoolExecutorTest exte
1053       * execute throws RejectedExecutionException if saturated.
1054       */
1055      public void testSaturatedExecute() {
1056 <        ThreadPoolExecutor p =
1056 >        final ThreadPoolExecutor p =
1057              new ThreadPoolExecutor(1, 1,
1058                                     LONG_DELAY_MS, MILLISECONDS,
1059                                     new ArrayBlockingQueue<Runnable>(1));
1060 <        final CountDownLatch done = new CountDownLatch(1);
1061 <        try {
1060 >        try (PoolCleaner cleaner = cleaner(p)) {
1061 >            final CountDownLatch done = new CountDownLatch(1);
1062              Runnable task = new CheckedRunnable() {
1063                  public void realRun() throws InterruptedException {
1064                      done.await();
# Line 1040 | Line 1072 | public class ThreadPoolExecutorTest exte
1072                  } catch (RejectedExecutionException success) {}
1073                  assertTrue(p.getTaskCount() <= 2);
1074              }
1043        } finally {
1075              done.countDown();
1045            joinPool(p);
1076          }
1077      }
1078  
# Line 1050 | Line 1080 | public class ThreadPoolExecutorTest exte
1080       * submit(runnable) throws RejectedExecutionException if saturated.
1081       */
1082      public void testSaturatedSubmitRunnable() {
1083 <        ThreadPoolExecutor p =
1083 >        final ThreadPoolExecutor p =
1084              new ThreadPoolExecutor(1, 1,
1085                                     LONG_DELAY_MS, MILLISECONDS,
1086                                     new ArrayBlockingQueue<Runnable>(1));
1087 <        final CountDownLatch done = new CountDownLatch(1);
1088 <        try {
1087 >        try (PoolCleaner cleaner = cleaner(p)) {
1088 >            final CountDownLatch done = new CountDownLatch(1);
1089              Runnable task = new CheckedRunnable() {
1090                  public void realRun() throws InterruptedException {
1091                      done.await();
# Line 1069 | Line 1099 | public class ThreadPoolExecutorTest exte
1099                  } catch (RejectedExecutionException success) {}
1100                  assertTrue(p.getTaskCount() <= 2);
1101              }
1072        } finally {
1102              done.countDown();
1074            joinPool(p);
1103          }
1104      }
1105  
# Line 1079 | Line 1107 | public class ThreadPoolExecutorTest exte
1107       * submit(callable) throws RejectedExecutionException if saturated.
1108       */
1109      public void testSaturatedSubmitCallable() {
1110 <        ThreadPoolExecutor p =
1110 >        final ThreadPoolExecutor p =
1111              new ThreadPoolExecutor(1, 1,
1112                                     LONG_DELAY_MS, MILLISECONDS,
1113                                     new ArrayBlockingQueue<Runnable>(1));
1114 <        final CountDownLatch done = new CountDownLatch(1);
1115 <        try {
1114 >        try (PoolCleaner cleaner = cleaner(p)) {
1115 >            final CountDownLatch done = new CountDownLatch(1);
1116              Runnable task = new CheckedRunnable() {
1117                  public void realRun() throws InterruptedException {
1118                      done.await();
# Line 1098 | Line 1126 | public class ThreadPoolExecutorTest exte
1126                  } catch (RejectedExecutionException success) {}
1127                  assertTrue(p.getTaskCount() <= 2);
1128              }
1101        } finally {
1129              done.countDown();
1103            joinPool(p);
1130          }
1131      }
1132  
# Line 1108 | Line 1134 | public class ThreadPoolExecutorTest exte
1134       * executor using CallerRunsPolicy runs task if saturated.
1135       */
1136      public void testSaturatedExecute2() {
1111        RejectedExecutionHandler h = new ThreadPoolExecutor.CallerRunsPolicy();
1137          final ThreadPoolExecutor p =
1138              new ThreadPoolExecutor(1, 1,
1139                                     LONG_DELAY_MS,
1140                                     MILLISECONDS,
1141                                     new ArrayBlockingQueue<Runnable>(1),
1142 <                                   h);
1143 <        try {
1142 >                                   new ThreadPoolExecutor.CallerRunsPolicy());
1143 >        try (PoolCleaner cleaner = cleaner(p)) {
1144 >            final CountDownLatch done = new CountDownLatch(1);
1145 >            Runnable blocker = new CheckedRunnable() {
1146 >                public void realRun() throws InterruptedException {
1147 >                    done.await();
1148 >                }};
1149 >            p.execute(blocker);
1150              TrackedNoOpRunnable[] tasks = new TrackedNoOpRunnable[5];
1151 <            for (int i = 0; i < tasks.length; ++i)
1151 >            for (int i = 0; i < tasks.length; i++)
1152                  tasks[i] = new TrackedNoOpRunnable();
1153 <            TrackedLongRunnable mr = new TrackedLongRunnable();
1123 <            p.execute(mr);
1124 <            for (int i = 0; i < tasks.length; ++i)
1153 >            for (int i = 0; i < tasks.length; i++)
1154                  p.execute(tasks[i]);
1155 <            for (int i = 1; i < tasks.length; ++i)
1155 >            for (int i = 1; i < tasks.length; i++)
1156                  assertTrue(tasks[i].done);
1157 <            try { p.shutdownNow(); } catch (SecurityException ok) { return; }
1158 <        } finally {
1130 <            joinPool(p);
1157 >            assertFalse(tasks[0].done); // waiting in queue
1158 >            done.countDown();
1159          }
1160      }
1161  
# Line 1135 | Line 1163 | public class ThreadPoolExecutorTest exte
1163       * executor using DiscardPolicy drops task if saturated.
1164       */
1165      public void testSaturatedExecute3() {
1166 <        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardPolicy();
1166 >        final TrackedNoOpRunnable[] tasks = new TrackedNoOpRunnable[5];
1167 >        for (int i = 0; i < tasks.length; ++i)
1168 >            tasks[i] = new TrackedNoOpRunnable();
1169          final ThreadPoolExecutor p =
1170              new ThreadPoolExecutor(1, 1,
1171 <                                   LONG_DELAY_MS, MILLISECONDS,
1172 <                                   new ArrayBlockingQueue<Runnable>(1),
1173 <                                   h);
1174 <        try {
1175 <            TrackedNoOpRunnable[] tasks = new TrackedNoOpRunnable[5];
1176 <            for (int i = 0; i < tasks.length; ++i)
1177 <                tasks[i] = new TrackedNoOpRunnable();
1148 <            p.execute(new TrackedLongRunnable());
1171 >                          LONG_DELAY_MS, MILLISECONDS,
1172 >                          new ArrayBlockingQueue<Runnable>(1),
1173 >                          new ThreadPoolExecutor.DiscardPolicy());
1174 >        try (PoolCleaner cleaner = cleaner(p)) {
1175 >            final CountDownLatch done = new CountDownLatch(1);
1176 >            p.execute(awaiter(done));
1177 >
1178              for (TrackedNoOpRunnable task : tasks)
1179                  p.execute(task);
1180 <            for (TrackedNoOpRunnable task : tasks)
1181 <                assertFalse(task.done);
1182 <            try { p.shutdownNow(); } catch (SecurityException ok) { return; }
1154 <        } finally {
1155 <            joinPool(p);
1180 >            for (int i = 1; i < tasks.length; i++)
1181 >                assertFalse(tasks[i].done);
1182 >            done.countDown();
1183          }
1184 +        for (int i = 1; i < tasks.length; i++)
1185 +            assertFalse(tasks[i].done);
1186 +        assertTrue(tasks[0].done); // was waiting in queue
1187      }
1188  
1189      /**
1190       * executor using DiscardOldestPolicy drops oldest task if saturated.
1191       */
1192      public void testSaturatedExecute4() {
1193 <        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardOldestPolicy();
1193 >        final CountDownLatch done = new CountDownLatch(1);
1194 >        LatchAwaiter r1 = awaiter(done);
1195 >        LatchAwaiter r2 = awaiter(done);
1196 >        LatchAwaiter r3 = awaiter(done);
1197          final ThreadPoolExecutor p =
1198              new ThreadPoolExecutor(1, 1,
1199                                     LONG_DELAY_MS, MILLISECONDS,
1200                                     new ArrayBlockingQueue<Runnable>(1),
1201 <                                   h);
1202 <        try {
1203 <            p.execute(new TrackedLongRunnable());
1204 <            TrackedLongRunnable r2 = new TrackedLongRunnable();
1201 >                                   new ThreadPoolExecutor.DiscardOldestPolicy());
1202 >        try (PoolCleaner cleaner = cleaner(p)) {
1203 >            assertEquals(LatchAwaiter.NEW, r1.state);
1204 >            assertEquals(LatchAwaiter.NEW, r2.state);
1205 >            assertEquals(LatchAwaiter.NEW, r3.state);
1206 >            p.execute(r1);
1207              p.execute(r2);
1208              assertTrue(p.getQueue().contains(r2));
1174            TrackedNoOpRunnable r3 = new TrackedNoOpRunnable();
1209              p.execute(r3);
1210              assertFalse(p.getQueue().contains(r2));
1211              assertTrue(p.getQueue().contains(r3));
1212 <            try { p.shutdownNow(); } catch (SecurityException ok) { return; }
1179 <        } finally {
1180 <            joinPool(p);
1212 >            done.countDown();
1213          }
1214 +        assertEquals(LatchAwaiter.DONE, r1.state);
1215 +        assertEquals(LatchAwaiter.NEW, r2.state);
1216 +        assertEquals(LatchAwaiter.DONE, r3.state);
1217      }
1218  
1219      /**
1220       * execute throws RejectedExecutionException if shutdown
1221       */
1222      public void testRejectedExecutionExceptionOnShutdown() {
1223 <        ThreadPoolExecutor p =
1223 >        final ThreadPoolExecutor p =
1224              new ThreadPoolExecutor(1, 1,
1225                                     LONG_DELAY_MS, MILLISECONDS,
1226                                     new ArrayBlockingQueue<Runnable>(1));
1227          try { p.shutdown(); } catch (SecurityException ok) { return; }
1228 <        try {
1229 <            p.execute(new NoOpRunnable());
1230 <            shouldThrow();
1231 <        } catch (RejectedExecutionException success) {}
1232 <
1233 <        joinPool(p);
1228 >        try (PoolCleaner cleaner = cleaner(p)) {
1229 >            try {
1230 >                p.execute(new NoOpRunnable());
1231 >                shouldThrow();
1232 >            } catch (RejectedExecutionException success) {}
1233 >        }
1234      }
1235  
1236      /**
# Line 1209 | Line 1244 | public class ThreadPoolExecutorTest exte
1244                                     new ArrayBlockingQueue<Runnable>(1), h);
1245  
1246          try { p.shutdown(); } catch (SecurityException ok) { return; }
1247 <        try {
1247 >        try (PoolCleaner cleaner = cleaner(p)) {
1248              TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1249              p.execute(r);
1250              assertFalse(r.done);
1216        } finally {
1217            joinPool(p);
1251          }
1252      }
1253  
# Line 1222 | Line 1255 | public class ThreadPoolExecutorTest exte
1255       * execute using DiscardPolicy drops task on shutdown
1256       */
1257      public void testDiscardOnShutdown() {
1258 <        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardPolicy();
1226 <        ThreadPoolExecutor p =
1258 >        final ThreadPoolExecutor p =
1259              new ThreadPoolExecutor(1, 1,
1260                                     LONG_DELAY_MS, MILLISECONDS,
1261                                     new ArrayBlockingQueue<Runnable>(1),
1262 <                                   h);
1262 >                                   new ThreadPoolExecutor.DiscardPolicy());
1263  
1264          try { p.shutdown(); } catch (SecurityException ok) { return; }
1265 <        try {
1265 >        try (PoolCleaner cleaner = cleaner(p)) {
1266              TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1267              p.execute(r);
1268              assertFalse(r.done);
1237        } finally {
1238            joinPool(p);
1269          }
1270      }
1271  
# Line 1243 | Line 1273 | public class ThreadPoolExecutorTest exte
1273       * execute using DiscardOldestPolicy drops task on shutdown
1274       */
1275      public void testDiscardOldestOnShutdown() {
1276 <        RejectedExecutionHandler h = new ThreadPoolExecutor.DiscardOldestPolicy();
1247 <        ThreadPoolExecutor p =
1276 >        final ThreadPoolExecutor p =
1277              new ThreadPoolExecutor(1, 1,
1278                                     LONG_DELAY_MS, MILLISECONDS,
1279                                     new ArrayBlockingQueue<Runnable>(1),
1280 <                                   h);
1280 >                                   new ThreadPoolExecutor.DiscardOldestPolicy());
1281  
1282          try { p.shutdown(); } catch (SecurityException ok) { return; }
1283 <        try {
1283 >        try (PoolCleaner cleaner = cleaner(p)) {
1284              TrackedNoOpRunnable r = new TrackedNoOpRunnable();
1285              p.execute(r);
1286              assertFalse(r.done);
1258        } finally {
1259            joinPool(p);
1287          }
1288      }
1289  
# Line 1264 | Line 1291 | public class ThreadPoolExecutorTest exte
1291       * execute(null) throws NPE
1292       */
1293      public void testExecuteNull() {
1294 <        ThreadPoolExecutor p =
1295 <            new ThreadPoolExecutor(1, 2, 1L, SECONDS,
1294 >        final ThreadPoolExecutor p =
1295 >            new ThreadPoolExecutor(1, 2,
1296 >                                   1L, SECONDS,
1297                                     new ArrayBlockingQueue<Runnable>(10));
1298 <        try {
1299 <            p.execute(null);
1300 <            shouldThrow();
1301 <        } catch (NullPointerException success) {}
1302 <
1303 <        joinPool(p);
1298 >        try (PoolCleaner cleaner = cleaner(p)) {
1299 >            try {
1300 >                p.execute(null);
1301 >                shouldThrow();
1302 >            } catch (NullPointerException success) {}
1303 >        }
1304      }
1305  
1306      /**
1307       * setCorePoolSize of negative value throws IllegalArgumentException
1308       */
1309      public void testCorePoolSizeIllegalArgumentException() {
1310 <        ThreadPoolExecutor p =
1310 >        final ThreadPoolExecutor p =
1311              new ThreadPoolExecutor(1, 2,
1312                                     LONG_DELAY_MS, MILLISECONDS,
1313                                     new ArrayBlockingQueue<Runnable>(10));
1314 <        try {
1315 <            p.setCorePoolSize(-1);
1316 <            shouldThrow();
1317 <        } catch (IllegalArgumentException success) {
1318 <        } finally {
1291 <            try { p.shutdown(); } catch (SecurityException ok) { return; }
1314 >        try (PoolCleaner cleaner = cleaner(p)) {
1315 >            try {
1316 >                p.setCorePoolSize(-1);
1317 >                shouldThrow();
1318 >            } catch (IllegalArgumentException success) {}
1319          }
1293        joinPool(p);
1320      }
1321  
1322      /**
# Line 1298 | Line 1324 | public class ThreadPoolExecutorTest exte
1324       * given a value less the core pool size
1325       */
1326      public void testMaximumPoolSizeIllegalArgumentException() {
1327 <        ThreadPoolExecutor p =
1327 >        final ThreadPoolExecutor p =
1328              new ThreadPoolExecutor(2, 3,
1329                                     LONG_DELAY_MS, MILLISECONDS,
1330                                     new ArrayBlockingQueue<Runnable>(10));
1331 <        try {
1332 <            p.setMaximumPoolSize(1);
1333 <            shouldThrow();
1334 <        } catch (IllegalArgumentException success) {
1335 <        } finally {
1310 <            try { p.shutdown(); } catch (SecurityException ok) { return; }
1331 >        try (PoolCleaner cleaner = cleaner(p)) {
1332 >            try {
1333 >                p.setMaximumPoolSize(1);
1334 >                shouldThrow();
1335 >            } catch (IllegalArgumentException success) {}
1336          }
1312        joinPool(p);
1337      }
1338  
1339      /**
# Line 1317 | Line 1341 | public class ThreadPoolExecutorTest exte
1341       * if given a negative value
1342       */
1343      public void testMaximumPoolSizeIllegalArgumentException2() {
1344 <        ThreadPoolExecutor p =
1344 >        final ThreadPoolExecutor p =
1345              new ThreadPoolExecutor(2, 3,
1346                                     LONG_DELAY_MS, MILLISECONDS,
1347                                     new ArrayBlockingQueue<Runnable>(10));
1348 <        try {
1349 <            p.setMaximumPoolSize(-1);
1350 <            shouldThrow();
1351 <        } catch (IllegalArgumentException success) {
1352 <        } finally {
1329 <            try { p.shutdown(); } catch (SecurityException ok) { return; }
1348 >        try (PoolCleaner cleaner = cleaner(p)) {
1349 >            try {
1350 >                p.setMaximumPoolSize(-1);
1351 >                shouldThrow();
1352 >            } catch (IllegalArgumentException success) {}
1353          }
1331        joinPool(p);
1354      }
1355  
1356      /**
# Line 1336 | Line 1358 | public class ThreadPoolExecutorTest exte
1358       * max pool size result in IllegalArgumentException.
1359       */
1360      public void testPoolSizeInvariants() {
1361 <        ThreadPoolExecutor p =
1361 >        final ThreadPoolExecutor p =
1362              new ThreadPoolExecutor(1, 1,
1363                                     LONG_DELAY_MS, MILLISECONDS,
1364                                     new ArrayBlockingQueue<Runnable>(10));
1365 <        for (int s = 1; s < 5; s++) {
1366 <            p.setMaximumPoolSize(s);
1367 <            p.setCorePoolSize(s);
1368 <            try {
1369 <                p.setMaximumPoolSize(s - 1);
1370 <                shouldThrow();
1371 <            } catch (IllegalArgumentException success) {}
1372 <            assertEquals(s, p.getCorePoolSize());
1373 <            assertEquals(s, p.getMaximumPoolSize());
1374 <            try {
1375 <                p.setCorePoolSize(s + 1);
1376 <                shouldThrow();
1377 <            } catch (IllegalArgumentException success) {}
1378 <            assertEquals(s, p.getCorePoolSize());
1379 <            assertEquals(s, p.getMaximumPoolSize());
1365 >        try (PoolCleaner cleaner = cleaner(p)) {
1366 >            for (int s = 1; s < 5; s++) {
1367 >                p.setMaximumPoolSize(s);
1368 >                p.setCorePoolSize(s);
1369 >                try {
1370 >                    p.setMaximumPoolSize(s - 1);
1371 >                    shouldThrow();
1372 >                } catch (IllegalArgumentException success) {}
1373 >                assertEquals(s, p.getCorePoolSize());
1374 >                assertEquals(s, p.getMaximumPoolSize());
1375 >                try {
1376 >                    p.setCorePoolSize(s + 1);
1377 >                    shouldThrow();
1378 >                } catch (IllegalArgumentException success) {}
1379 >                assertEquals(s, p.getCorePoolSize());
1380 >                assertEquals(s, p.getMaximumPoolSize());
1381 >            }
1382          }
1359        joinPool(p);
1383      }
1384  
1385      /**
# Line 1364 | Line 1387 | public class ThreadPoolExecutorTest exte
1387       * when given a negative value
1388       */
1389      public void testKeepAliveTimeIllegalArgumentException() {
1390 <        ThreadPoolExecutor p =
1390 >        final ThreadPoolExecutor p =
1391              new ThreadPoolExecutor(2, 3,
1392                                     LONG_DELAY_MS, MILLISECONDS,
1393                                     new ArrayBlockingQueue<Runnable>(10));
1394 <        try {
1395 <            p.setKeepAliveTime(-1,MILLISECONDS);
1396 <            shouldThrow();
1397 <        } catch (IllegalArgumentException success) {
1398 <        } finally {
1376 <            try { p.shutdown(); } catch (SecurityException ok) { return; }
1394 >        try (PoolCleaner cleaner = cleaner(p)) {
1395 >            try {
1396 >                p.setKeepAliveTime(-1, MILLISECONDS);
1397 >                shouldThrow();
1398 >            } catch (IllegalArgumentException success) {}
1399          }
1378        joinPool(p);
1400      }
1401  
1402      /**
# Line 1383 | Line 1404 | public class ThreadPoolExecutorTest exte
1404       */
1405      public void testTerminated() {
1406          ExtendedTPE p = new ExtendedTPE();
1407 <        try { p.shutdown(); } catch (SecurityException ok) { return; }
1408 <        assertTrue(p.terminatedCalled());
1409 <        joinPool(p);
1407 >        try (PoolCleaner cleaner = cleaner(p)) {
1408 >            try { p.shutdown(); } catch (SecurityException ok) { return; }
1409 >            assertTrue(p.terminatedCalled());
1410 >            assertTrue(p.isShutdown());
1411 >        }
1412      }
1413  
1414      /**
# Line 1393 | Line 1416 | public class ThreadPoolExecutorTest exte
1416       */
1417      public void testBeforeAfter() throws InterruptedException {
1418          ExtendedTPE p = new ExtendedTPE();
1419 <        try {
1419 >        try (PoolCleaner cleaner = cleaner(p)) {
1420              final CountDownLatch done = new CountDownLatch(1);
1421              p.execute(new CheckedRunnable() {
1422                  public void realRun() {
# Line 1403 | Line 1426 | public class ThreadPoolExecutorTest exte
1426              assertEquals(0, done.getCount());
1427              assertTrue(p.afterCalled());
1428              assertTrue(p.beforeCalled());
1406            try { p.shutdown(); } catch (SecurityException ok) { return; }
1407        } finally {
1408            joinPool(p);
1429          }
1430      }
1431  
# Line 1413 | Line 1433 | public class ThreadPoolExecutorTest exte
1433       * completed submit of callable returns result
1434       */
1435      public void testSubmitCallable() throws Exception {
1436 <        ExecutorService e =
1436 >        final ExecutorService e =
1437              new ThreadPoolExecutor(2, 2,
1438                                     LONG_DELAY_MS, MILLISECONDS,
1439                                     new ArrayBlockingQueue<Runnable>(10));
1440 <        try {
1440 >        try (PoolCleaner cleaner = cleaner(e)) {
1441              Future<String> future = e.submit(new StringTask());
1442              String result = future.get();
1443              assertSame(TEST_STRING, result);
1424        } finally {
1425            joinPool(e);
1444          }
1445      }
1446  
# Line 1430 | Line 1448 | public class ThreadPoolExecutorTest exte
1448       * completed submit of runnable returns successfully
1449       */
1450      public void testSubmitRunnable() throws Exception {
1451 <        ExecutorService e =
1451 >        final ExecutorService e =
1452              new ThreadPoolExecutor(2, 2,
1453                                     LONG_DELAY_MS, MILLISECONDS,
1454                                     new ArrayBlockingQueue<Runnable>(10));
1455 <        try {
1455 >        try (PoolCleaner cleaner = cleaner(e)) {
1456              Future<?> future = e.submit(new NoOpRunnable());
1457              future.get();
1458              assertTrue(future.isDone());
1441        } finally {
1442            joinPool(e);
1459          }
1460      }
1461  
# Line 1447 | Line 1463 | public class ThreadPoolExecutorTest exte
1463       * completed submit of (runnable, result) returns result
1464       */
1465      public void testSubmitRunnable2() throws Exception {
1466 <        ExecutorService e =
1466 >        final ExecutorService e =
1467              new ThreadPoolExecutor(2, 2,
1468                                     LONG_DELAY_MS, MILLISECONDS,
1469                                     new ArrayBlockingQueue<Runnable>(10));
1470 <        try {
1470 >        try (PoolCleaner cleaner = cleaner(e)) {
1471              Future<String> future = e.submit(new NoOpRunnable(), TEST_STRING);
1472              String result = future.get();
1473              assertSame(TEST_STRING, result);
1458        } finally {
1459            joinPool(e);
1474          }
1475      }
1476  
# Line 1464 | Line 1478 | public class ThreadPoolExecutorTest exte
1478       * invokeAny(null) throws NPE
1479       */
1480      public void testInvokeAny1() throws Exception {
1481 <        ExecutorService e =
1481 >        final ExecutorService e =
1482              new ThreadPoolExecutor(2, 2,
1483                                     LONG_DELAY_MS, MILLISECONDS,
1484                                     new ArrayBlockingQueue<Runnable>(10));
1485 <        try {
1486 <            e.invokeAny(null);
1487 <            shouldThrow();
1488 <        } catch (NullPointerException success) {
1489 <        } finally {
1476 <            joinPool(e);
1485 >        try (PoolCleaner cleaner = cleaner(e)) {
1486 >            try {
1487 >                e.invokeAny(null);
1488 >                shouldThrow();
1489 >            } catch (NullPointerException success) {}
1490          }
1491      }
1492  
# Line 1481 | Line 1494 | public class ThreadPoolExecutorTest exte
1494       * invokeAny(empty collection) throws IAE
1495       */
1496      public void testInvokeAny2() throws Exception {
1497 <        ExecutorService e =
1497 >        final ExecutorService e =
1498              new ThreadPoolExecutor(2, 2,
1499                                     LONG_DELAY_MS, MILLISECONDS,
1500                                     new ArrayBlockingQueue<Runnable>(10));
1501 <        try {
1502 <            e.invokeAny(new ArrayList<Callable<String>>());
1503 <            shouldThrow();
1504 <        } catch (IllegalArgumentException success) {
1505 <        } finally {
1493 <            joinPool(e);
1501 >        try (PoolCleaner cleaner = cleaner(e)) {
1502 >            try {
1503 >                e.invokeAny(new ArrayList<Callable<String>>());
1504 >                shouldThrow();
1505 >            } catch (IllegalArgumentException success) {}
1506          }
1507      }
1508  
# Line 1503 | Line 1515 | public class ThreadPoolExecutorTest exte
1515              new ThreadPoolExecutor(2, 2,
1516                                     LONG_DELAY_MS, MILLISECONDS,
1517                                     new ArrayBlockingQueue<Runnable>(10));
1518 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1519 <        l.add(latchAwaitingStringTask(latch));
1520 <        l.add(null);
1521 <        try {
1522 <            e.invokeAny(l);
1523 <            shouldThrow();
1524 <        } catch (NullPointerException success) {
1525 <        } finally {
1518 >        try (PoolCleaner cleaner = cleaner(e)) {
1519 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1520 >            l.add(latchAwaitingStringTask(latch));
1521 >            l.add(null);
1522 >            try {
1523 >                e.invokeAny(l);
1524 >                shouldThrow();
1525 >            } catch (NullPointerException success) {}
1526              latch.countDown();
1515            joinPool(e);
1527          }
1528      }
1529  
# Line 1520 | Line 1531 | public class ThreadPoolExecutorTest exte
1531       * invokeAny(c) throws ExecutionException if no task completes
1532       */
1533      public void testInvokeAny4() throws Exception {
1534 <        ExecutorService e =
1534 >        final ExecutorService e =
1535              new ThreadPoolExecutor(2, 2,
1536                                     LONG_DELAY_MS, MILLISECONDS,
1537                                     new ArrayBlockingQueue<Runnable>(10));
1538 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1539 <        l.add(new NPETask());
1540 <        try {
1541 <            e.invokeAny(l);
1542 <            shouldThrow();
1543 <        } catch (ExecutionException success) {
1544 <            assertTrue(success.getCause() instanceof NullPointerException);
1545 <        } finally {
1546 <            joinPool(e);
1538 >        try (PoolCleaner cleaner = cleaner(e)) {
1539 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1540 >            l.add(new NPETask());
1541 >            try {
1542 >                e.invokeAny(l);
1543 >                shouldThrow();
1544 >            } catch (ExecutionException success) {
1545 >                assertTrue(success.getCause() instanceof NullPointerException);
1546 >            }
1547          }
1548      }
1549  
# Line 1540 | Line 1551 | public class ThreadPoolExecutorTest exte
1551       * invokeAny(c) returns result of some task
1552       */
1553      public void testInvokeAny5() throws Exception {
1554 <        ExecutorService e =
1554 >        final ExecutorService e =
1555              new ThreadPoolExecutor(2, 2,
1556                                     LONG_DELAY_MS, MILLISECONDS,
1557                                     new ArrayBlockingQueue<Runnable>(10));
1558 <        try {
1558 >        try (PoolCleaner cleaner = cleaner(e)) {
1559              List<Callable<String>> l = new ArrayList<Callable<String>>();
1560              l.add(new StringTask());
1561              l.add(new StringTask());
1562              String result = e.invokeAny(l);
1563              assertSame(TEST_STRING, result);
1553        } finally {
1554            joinPool(e);
1564          }
1565      }
1566  
# Line 1559 | Line 1568 | public class ThreadPoolExecutorTest exte
1568       * invokeAll(null) throws NPE
1569       */
1570      public void testInvokeAll1() throws Exception {
1571 <        ExecutorService e =
1571 >        final ExecutorService e =
1572              new ThreadPoolExecutor(2, 2,
1573                                     LONG_DELAY_MS, MILLISECONDS,
1574                                     new ArrayBlockingQueue<Runnable>(10));
1575 <        try {
1576 <            e.invokeAll(null);
1577 <            shouldThrow();
1578 <        } catch (NullPointerException success) {
1579 <        } finally {
1571 <            joinPool(e);
1575 >        try (PoolCleaner cleaner = cleaner(e)) {
1576 >            try {
1577 >                e.invokeAll(null);
1578 >                shouldThrow();
1579 >            } catch (NullPointerException success) {}
1580          }
1581      }
1582  
# Line 1576 | Line 1584 | public class ThreadPoolExecutorTest exte
1584       * invokeAll(empty collection) returns empty collection
1585       */
1586      public void testInvokeAll2() throws InterruptedException {
1587 <        ExecutorService e =
1587 >        final ExecutorService e =
1588              new ThreadPoolExecutor(2, 2,
1589                                     LONG_DELAY_MS, MILLISECONDS,
1590                                     new ArrayBlockingQueue<Runnable>(10));
1591 <        try {
1591 >        try (PoolCleaner cleaner = cleaner(e)) {
1592              List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>());
1593              assertTrue(r.isEmpty());
1586        } finally {
1587            joinPool(e);
1594          }
1595      }
1596  
# Line 1592 | Line 1598 | public class ThreadPoolExecutorTest exte
1598       * invokeAll(c) throws NPE if c has null elements
1599       */
1600      public void testInvokeAll3() throws Exception {
1601 <        ExecutorService e =
1601 >        final ExecutorService e =
1602              new ThreadPoolExecutor(2, 2,
1603                                     LONG_DELAY_MS, MILLISECONDS,
1604                                     new ArrayBlockingQueue<Runnable>(10));
1605 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1606 <        l.add(new StringTask());
1607 <        l.add(null);
1608 <        try {
1609 <            e.invokeAll(l);
1610 <            shouldThrow();
1611 <        } catch (NullPointerException success) {
1612 <        } finally {
1607 <            joinPool(e);
1605 >        try (PoolCleaner cleaner = cleaner(e)) {
1606 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1607 >            l.add(new StringTask());
1608 >            l.add(null);
1609 >            try {
1610 >                e.invokeAll(l);
1611 >                shouldThrow();
1612 >            } catch (NullPointerException success) {}
1613          }
1614      }
1615  
# Line 1612 | Line 1617 | public class ThreadPoolExecutorTest exte
1617       * get of element of invokeAll(c) throws exception on failed task
1618       */
1619      public void testInvokeAll4() throws Exception {
1620 <        ExecutorService e =
1620 >        final ExecutorService e =
1621              new ThreadPoolExecutor(2, 2,
1622                                     LONG_DELAY_MS, MILLISECONDS,
1623                                     new ArrayBlockingQueue<Runnable>(10));
1624 <        try {
1624 >        try (PoolCleaner cleaner = cleaner(e)) {
1625              List<Callable<String>> l = new ArrayList<Callable<String>>();
1626              l.add(new NPETask());
1627              List<Future<String>> futures = e.invokeAll(l);
# Line 1627 | Line 1632 | public class ThreadPoolExecutorTest exte
1632              } catch (ExecutionException success) {
1633                  assertTrue(success.getCause() instanceof NullPointerException);
1634              }
1630        } finally {
1631            joinPool(e);
1635          }
1636      }
1637  
# Line 1636 | Line 1639 | public class ThreadPoolExecutorTest exte
1639       * invokeAll(c) returns results of all completed tasks
1640       */
1641      public void testInvokeAll5() throws Exception {
1642 <        ExecutorService e =
1642 >        final ExecutorService e =
1643              new ThreadPoolExecutor(2, 2,
1644                                     LONG_DELAY_MS, MILLISECONDS,
1645                                     new ArrayBlockingQueue<Runnable>(10));
1646 <        try {
1646 >        try (PoolCleaner cleaner = cleaner(e)) {
1647              List<Callable<String>> l = new ArrayList<Callable<String>>();
1648              l.add(new StringTask());
1649              l.add(new StringTask());
# Line 1648 | Line 1651 | public class ThreadPoolExecutorTest exte
1651              assertEquals(2, futures.size());
1652              for (Future<String> future : futures)
1653                  assertSame(TEST_STRING, future.get());
1651        } finally {
1652            joinPool(e);
1654          }
1655      }
1656  
# Line 1657 | Line 1658 | public class ThreadPoolExecutorTest exte
1658       * timed invokeAny(null) throws NPE
1659       */
1660      public void testTimedInvokeAny1() throws Exception {
1661 <        ExecutorService e =
1661 >        final ExecutorService e =
1662              new ThreadPoolExecutor(2, 2,
1663                                     LONG_DELAY_MS, MILLISECONDS,
1664                                     new ArrayBlockingQueue<Runnable>(10));
1665 <        try {
1666 <            e.invokeAny(null, MEDIUM_DELAY_MS, MILLISECONDS);
1667 <            shouldThrow();
1668 <        } catch (NullPointerException success) {
1669 <        } finally {
1669 <            joinPool(e);
1665 >        try (PoolCleaner cleaner = cleaner(e)) {
1666 >            try {
1667 >                e.invokeAny(null, MEDIUM_DELAY_MS, MILLISECONDS);
1668 >                shouldThrow();
1669 >            } catch (NullPointerException success) {}
1670          }
1671      }
1672  
# Line 1674 | Line 1674 | public class ThreadPoolExecutorTest exte
1674       * timed invokeAny(,,null) throws NPE
1675       */
1676      public void testTimedInvokeAnyNullTimeUnit() throws Exception {
1677 <        ExecutorService e =
1677 >        final ExecutorService e =
1678              new ThreadPoolExecutor(2, 2,
1679                                     LONG_DELAY_MS, MILLISECONDS,
1680                                     new ArrayBlockingQueue<Runnable>(10));
1681 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1682 <        l.add(new StringTask());
1683 <        try {
1684 <            e.invokeAny(l, MEDIUM_DELAY_MS, null);
1685 <            shouldThrow();
1686 <        } catch (NullPointerException success) {
1687 <        } finally {
1688 <            joinPool(e);
1681 >        try (PoolCleaner cleaner = cleaner(e)) {
1682 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1683 >            l.add(new StringTask());
1684 >            try {
1685 >                e.invokeAny(l, MEDIUM_DELAY_MS, null);
1686 >                shouldThrow();
1687 >            } catch (NullPointerException success) {}
1688          }
1689      }
1690  
# Line 1693 | Line 1692 | public class ThreadPoolExecutorTest exte
1692       * timed invokeAny(empty collection) throws IAE
1693       */
1694      public void testTimedInvokeAny2() throws Exception {
1695 <        ExecutorService e =
1695 >        final ExecutorService e =
1696              new ThreadPoolExecutor(2, 2,
1697                                     LONG_DELAY_MS, MILLISECONDS,
1698                                     new ArrayBlockingQueue<Runnable>(10));
1699 <        try {
1700 <            e.invokeAny(new ArrayList<Callable<String>>(), MEDIUM_DELAY_MS, MILLISECONDS);
1701 <            shouldThrow();
1702 <        } catch (IllegalArgumentException success) {
1703 <        } finally {
1704 <            joinPool(e);
1699 >        try (PoolCleaner cleaner = cleaner(e)) {
1700 >            try {
1701 >                e.invokeAny(new ArrayList<Callable<String>>(),
1702 >                            MEDIUM_DELAY_MS, MILLISECONDS);
1703 >                shouldThrow();
1704 >            } catch (IllegalArgumentException success) {}
1705          }
1706      }
1707  
# Line 1715 | Line 1714 | public class ThreadPoolExecutorTest exte
1714              new ThreadPoolExecutor(2, 2,
1715                                     LONG_DELAY_MS, MILLISECONDS,
1716                                     new ArrayBlockingQueue<Runnable>(10));
1717 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1718 <        l.add(latchAwaitingStringTask(latch));
1719 <        l.add(null);
1720 <        try {
1721 <            e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1722 <            shouldThrow();
1723 <        } catch (NullPointerException success) {
1724 <        } finally {
1717 >        try (PoolCleaner cleaner = cleaner(e)) {
1718 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1719 >            l.add(latchAwaitingStringTask(latch));
1720 >            l.add(null);
1721 >            try {
1722 >                e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1723 >                shouldThrow();
1724 >            } catch (NullPointerException success) {}
1725              latch.countDown();
1727            joinPool(e);
1726          }
1727      }
1728  
# Line 1732 | Line 1730 | public class ThreadPoolExecutorTest exte
1730       * timed invokeAny(c) throws ExecutionException if no task completes
1731       */
1732      public void testTimedInvokeAny4() throws Exception {
1733 <        ExecutorService e =
1733 >        final ExecutorService e =
1734              new ThreadPoolExecutor(2, 2,
1735                                     LONG_DELAY_MS, MILLISECONDS,
1736                                     new ArrayBlockingQueue<Runnable>(10));
1737 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1738 <        l.add(new NPETask());
1739 <        try {
1740 <            e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1741 <            shouldThrow();
1742 <        } catch (ExecutionException success) {
1743 <            assertTrue(success.getCause() instanceof NullPointerException);
1744 <        } finally {
1745 <            joinPool(e);
1737 >        try (PoolCleaner cleaner = cleaner(e)) {
1738 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1739 >            l.add(new NPETask());
1740 >            try {
1741 >                e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1742 >                shouldThrow();
1743 >            } catch (ExecutionException success) {
1744 >                assertTrue(success.getCause() instanceof NullPointerException);
1745 >            }
1746          }
1747      }
1748  
# Line 1752 | Line 1750 | public class ThreadPoolExecutorTest exte
1750       * timed invokeAny(c) returns result of some task
1751       */
1752      public void testTimedInvokeAny5() throws Exception {
1753 <        ExecutorService e =
1753 >        final ExecutorService e =
1754              new ThreadPoolExecutor(2, 2,
1755                                     LONG_DELAY_MS, MILLISECONDS,
1756                                     new ArrayBlockingQueue<Runnable>(10));
1757 <        try {
1757 >        try (PoolCleaner cleaner = cleaner(e)) {
1758              List<Callable<String>> l = new ArrayList<Callable<String>>();
1759              l.add(new StringTask());
1760              l.add(new StringTask());
1761              String result = e.invokeAny(l, MEDIUM_DELAY_MS, MILLISECONDS);
1762              assertSame(TEST_STRING, result);
1765        } finally {
1766            joinPool(e);
1763          }
1764      }
1765  
# Line 1771 | Line 1767 | public class ThreadPoolExecutorTest exte
1767       * timed invokeAll(null) throws NPE
1768       */
1769      public void testTimedInvokeAll1() throws Exception {
1770 <        ExecutorService e =
1770 >        final ExecutorService e =
1771              new ThreadPoolExecutor(2, 2,
1772                                     LONG_DELAY_MS, MILLISECONDS,
1773                                     new ArrayBlockingQueue<Runnable>(10));
1774 <        try {
1775 <            e.invokeAll(null, MEDIUM_DELAY_MS, MILLISECONDS);
1776 <            shouldThrow();
1777 <        } catch (NullPointerException success) {
1778 <        } finally {
1783 <            joinPool(e);
1774 >        try (PoolCleaner cleaner = cleaner(e)) {
1775 >            try {
1776 >                e.invokeAll(null, MEDIUM_DELAY_MS, MILLISECONDS);
1777 >                shouldThrow();
1778 >            } catch (NullPointerException success) {}
1779          }
1780      }
1781  
# Line 1788 | Line 1783 | public class ThreadPoolExecutorTest exte
1783       * timed invokeAll(,,null) throws NPE
1784       */
1785      public void testTimedInvokeAllNullTimeUnit() throws Exception {
1786 <        ExecutorService e =
1786 >        final ExecutorService e =
1787              new ThreadPoolExecutor(2, 2,
1788                                     LONG_DELAY_MS, MILLISECONDS,
1789                                     new ArrayBlockingQueue<Runnable>(10));
1790 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1791 <        l.add(new StringTask());
1792 <        try {
1793 <            e.invokeAll(l, MEDIUM_DELAY_MS, null);
1794 <            shouldThrow();
1795 <        } catch (NullPointerException success) {
1796 <        } finally {
1802 <            joinPool(e);
1790 >        try (PoolCleaner cleaner = cleaner(e)) {
1791 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1792 >            l.add(new StringTask());
1793 >            try {
1794 >                e.invokeAll(l, MEDIUM_DELAY_MS, null);
1795 >                shouldThrow();
1796 >            } catch (NullPointerException success) {}
1797          }
1798      }
1799  
# Line 1807 | Line 1801 | public class ThreadPoolExecutorTest exte
1801       * timed invokeAll(empty collection) returns empty collection
1802       */
1803      public void testTimedInvokeAll2() throws InterruptedException {
1804 <        ExecutorService e =
1804 >        final ExecutorService e =
1805              new ThreadPoolExecutor(2, 2,
1806                                     LONG_DELAY_MS, MILLISECONDS,
1807                                     new ArrayBlockingQueue<Runnable>(10));
1808 <        try {
1809 <            List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>(), MEDIUM_DELAY_MS, MILLISECONDS);
1808 >        try (PoolCleaner cleaner = cleaner(e)) {
1809 >            List<Future<String>> r = e.invokeAll(new ArrayList<Callable<String>>(),
1810 >                                                 MEDIUM_DELAY_MS, MILLISECONDS);
1811              assertTrue(r.isEmpty());
1817        } finally {
1818            joinPool(e);
1812          }
1813      }
1814  
# Line 1823 | Line 1816 | public class ThreadPoolExecutorTest exte
1816       * timed invokeAll(c) throws NPE if c has null elements
1817       */
1818      public void testTimedInvokeAll3() throws Exception {
1819 <        ExecutorService e =
1819 >        final ExecutorService e =
1820              new ThreadPoolExecutor(2, 2,
1821                                     LONG_DELAY_MS, MILLISECONDS,
1822                                     new ArrayBlockingQueue<Runnable>(10));
1823 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1824 <        l.add(new StringTask());
1825 <        l.add(null);
1826 <        try {
1827 <            e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1828 <            shouldThrow();
1829 <        } catch (NullPointerException success) {
1830 <        } finally {
1838 <            joinPool(e);
1823 >        try (PoolCleaner cleaner = cleaner(e)) {
1824 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1825 >            l.add(new StringTask());
1826 >            l.add(null);
1827 >            try {
1828 >                e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1829 >                shouldThrow();
1830 >            } catch (NullPointerException success) {}
1831          }
1832      }
1833  
# Line 1843 | Line 1835 | public class ThreadPoolExecutorTest exte
1835       * get of element of invokeAll(c) throws exception on failed task
1836       */
1837      public void testTimedInvokeAll4() throws Exception {
1838 <        ExecutorService e =
1838 >        final ExecutorService e =
1839              new ThreadPoolExecutor(2, 2,
1840                                     LONG_DELAY_MS, MILLISECONDS,
1841                                     new ArrayBlockingQueue<Runnable>(10));
1842 <        List<Callable<String>> l = new ArrayList<Callable<String>>();
1843 <        l.add(new NPETask());
1844 <        List<Future<String>> futures =
1845 <            e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1846 <        assertEquals(1, futures.size());
1847 <        try {
1848 <            futures.get(0).get();
1849 <            shouldThrow();
1850 <        } catch (ExecutionException success) {
1851 <            assertTrue(success.getCause() instanceof NullPointerException);
1852 <        } finally {
1853 <            joinPool(e);
1842 >        try (PoolCleaner cleaner = cleaner(e)) {
1843 >            List<Callable<String>> l = new ArrayList<Callable<String>>();
1844 >            l.add(new NPETask());
1845 >            List<Future<String>> futures =
1846 >                e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1847 >            assertEquals(1, futures.size());
1848 >            try {
1849 >                futures.get(0).get();
1850 >                shouldThrow();
1851 >            } catch (ExecutionException success) {
1852 >                assertTrue(success.getCause() instanceof NullPointerException);
1853 >            }
1854          }
1855      }
1856  
# Line 1866 | Line 1858 | public class ThreadPoolExecutorTest exte
1858       * timed invokeAll(c) returns results of all completed tasks
1859       */
1860      public void testTimedInvokeAll5() throws Exception {
1861 <        ExecutorService e =
1861 >        final ExecutorService e =
1862              new ThreadPoolExecutor(2, 2,
1863                                     LONG_DELAY_MS, MILLISECONDS,
1864                                     new ArrayBlockingQueue<Runnable>(10));
1865 <        try {
1865 >        try (PoolCleaner cleaner = cleaner(e)) {
1866              List<Callable<String>> l = new ArrayList<Callable<String>>();
1867              l.add(new StringTask());
1868              l.add(new StringTask());
1869              List<Future<String>> futures =
1870 <                e.invokeAll(l, MEDIUM_DELAY_MS, MILLISECONDS);
1870 >                e.invokeAll(l, LONG_DELAY_MS, MILLISECONDS);
1871              assertEquals(2, futures.size());
1872              for (Future<String> future : futures)
1873                  assertSame(TEST_STRING, future.get());
1882        } finally {
1883            joinPool(e);
1874          }
1875      }
1876  
# Line 1888 | Line 1878 | public class ThreadPoolExecutorTest exte
1878       * timed invokeAll(c) cancels tasks not completed by timeout
1879       */
1880      public void testTimedInvokeAll6() throws Exception {
1881 <        ExecutorService e =
1881 >        final ExecutorService e =
1882              new ThreadPoolExecutor(2, 2,
1883                                     LONG_DELAY_MS, MILLISECONDS,
1884                                     new ArrayBlockingQueue<Runnable>(10));
1885 <        try {
1885 >        try (PoolCleaner cleaner = cleaner(e)) {
1886              for (long timeout = timeoutMillis();;) {
1887                  List<Callable<String>> tasks = new ArrayList<>();
1888 <                tasks.add(new StringTask());
1888 >                tasks.add(new StringTask("0"));
1889                  tasks.add(Executors.callable(new LongPossiblyInterruptedRunnable(), TEST_STRING));
1890 <                tasks.add(new StringTask());
1890 >                tasks.add(new StringTask("2"));
1891                  long startTime = System.nanoTime();
1892                  List<Future<String>> futures =
1893                      e.invokeAll(tasks, timeout, MILLISECONDS);
# Line 1907 | Line 1897 | public class ThreadPoolExecutorTest exte
1897                      assertTrue(future.isDone());
1898                  assertTrue(futures.get(1).isCancelled());
1899                  try {
1900 <                    assertEquals(TEST_STRING, futures.get(0).get());
1901 <                    assertEquals(TEST_STRING, futures.get(2).get());
1900 >                    assertEquals("0", futures.get(0).get());
1901 >                    assertEquals("2", futures.get(2).get());
1902                      break;
1903                  } catch (CancellationException retryWithLongerTimeout) {
1904                      timeout *= 2;
# Line 1916 | Line 1906 | public class ThreadPoolExecutorTest exte
1906                          fail("expected exactly one task to be cancelled");
1907                  }
1908              }
1919        } finally {
1920            joinPool(e);
1909          }
1910      }
1911  
# Line 1931 | Line 1919 | public class ThreadPoolExecutorTest exte
1919                                     LONG_DELAY_MS, MILLISECONDS,
1920                                     new LinkedBlockingQueue<Runnable>(),
1921                                     new FailingThreadFactory());
1922 <        try {
1922 >        try (PoolCleaner cleaner = cleaner(e)) {
1923              final int TASKS = 100;
1924              final CountDownLatch done = new CountDownLatch(TASKS);
1925              for (int k = 0; k < TASKS; ++k)
# Line 1940 | Line 1928 | public class ThreadPoolExecutorTest exte
1928                          done.countDown();
1929                      }});
1930              assertTrue(done.await(LONG_DELAY_MS, MILLISECONDS));
1943        } finally {
1944            joinPool(e);
1931          }
1932      }
1933  
# Line 1953 | Line 1939 | public class ThreadPoolExecutorTest exte
1939              new ThreadPoolExecutor(2, 2,
1940                                     1000, MILLISECONDS,
1941                                     new ArrayBlockingQueue<Runnable>(10));
1942 <        assertFalse(p.allowsCoreThreadTimeOut());
1943 <        joinPool(p);
1942 >        try (PoolCleaner cleaner = cleaner(p)) {
1943 >            assertFalse(p.allowsCoreThreadTimeOut());
1944 >        }
1945      }
1946  
1947      /**
# Line 1966 | Line 1953 | public class ThreadPoolExecutorTest exte
1953              new ThreadPoolExecutor(2, 10,
1954                                     keepAliveTime, MILLISECONDS,
1955                                     new ArrayBlockingQueue<Runnable>(10));
1956 <        final CountDownLatch threadStarted = new CountDownLatch(1);
1957 <        try {
1956 >        try (PoolCleaner cleaner = cleaner(p)) {
1957 >            final CountDownLatch threadStarted = new CountDownLatch(1);
1958              p.allowCoreThreadTimeOut(true);
1959              p.execute(new CheckedRunnable() {
1960                  public void realRun() {
# Line 1982 | Line 1969 | public class ThreadPoolExecutorTest exte
1969                  Thread.yield();
1970              assertTrue(millisElapsedSince(startTime) < LONG_DELAY_MS);
1971              assertEquals(0, p.getPoolSize());
1985        } finally {
1986            joinPool(p);
1972          }
1973      }
1974  
# Line 1996 | Line 1981 | public class ThreadPoolExecutorTest exte
1981              new ThreadPoolExecutor(2, 10,
1982                                     keepAliveTime, MILLISECONDS,
1983                                     new ArrayBlockingQueue<Runnable>(10));
1984 <        final CountDownLatch threadStarted = new CountDownLatch(1);
1985 <        try {
1984 >        try (PoolCleaner cleaner = cleaner(p)) {
1985 >            final CountDownLatch threadStarted = new CountDownLatch(1);
1986              p.allowCoreThreadTimeOut(false);
1987              p.execute(new CheckedRunnable() {
1988                  public void realRun() throws InterruptedException {
# Line 2006 | Line 1991 | public class ThreadPoolExecutorTest exte
1991                  }});
1992              delay(2 * keepAliveTime);
1993              assertTrue(p.getPoolSize() >= 1);
2009        } finally {
2010            joinPool(p);
1994          }
1995      }
1996  
# Line 2026 | Line 2009 | public class ThreadPoolExecutorTest exte
2009              new ThreadPoolExecutor(1, 30,
2010                                     60, SECONDS,
2011                                     new ArrayBlockingQueue(30));
2012 <        try {
2012 >        try (PoolCleaner cleaner = cleaner(p)) {
2013              for (int i = 0; i < nTasks; ++i) {
2014                  for (;;) {
2015                      try {
# Line 2038 | Line 2021 | public class ThreadPoolExecutorTest exte
2021              }
2022              // enough time to run all tasks
2023              assertTrue(done.await(nTasks * SHORT_DELAY_MS, MILLISECONDS));
2024 <        } finally {
2025 <            joinPool(p);
2024 >        }
2025 >    }
2026 >
2027 >    /**
2028 >     * get(cancelled task) throws CancellationException
2029 >     */
2030 >    public void testGet_cancelled() throws Exception {
2031 >        final ExecutorService e =
2032 >            new ThreadPoolExecutor(1, 1,
2033 >                                   LONG_DELAY_MS, MILLISECONDS,
2034 >                                   new LinkedBlockingQueue<Runnable>());
2035 >        try (PoolCleaner cleaner = cleaner(e)) {
2036 >            final CountDownLatch blockerStarted = new CountDownLatch(1);
2037 >            final CountDownLatch done = new CountDownLatch(1);
2038 >            final List<Future<?>> futures = new ArrayList<>();
2039 >            for (int i = 0; i < 2; i++) {
2040 >                Runnable r = new CheckedRunnable() { public void realRun()
2041 >                                                         throws Throwable {
2042 >                    blockerStarted.countDown();
2043 >                    assertTrue(done.await(2 * LONG_DELAY_MS, MILLISECONDS));
2044 >                }};
2045 >                futures.add(e.submit(r));
2046 >            }
2047 >            assertTrue(blockerStarted.await(LONG_DELAY_MS, MILLISECONDS));
2048 >            for (Future<?> future : futures) future.cancel(false);
2049 >            for (Future<?> future : futures) {
2050 >                try {
2051 >                    future.get();
2052 >                    shouldThrow();
2053 >                } catch (CancellationException success) {}
2054 >                try {
2055 >                    future.get(LONG_DELAY_MS, MILLISECONDS);
2056 >                    shouldThrow();
2057 >                } catch (CancellationException success) {}
2058 >                assertTrue(future.isCancelled());
2059 >                assertTrue(future.isDone());
2060 >            }
2061 >            done.countDown();
2062          }
2063      }
2064  

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines