--- jsr166/src/test/tck/TreeSetTest.java 2015/02/28 20:13:46 1.37 +++ jsr166/src/test/tck/TreeSetTest.java 2016/09/15 16:43:56 1.43 @@ -21,7 +21,7 @@ import junit.framework.TestSuite; public class TreeSetTest extends JSR166TestCase { public static void main(String[] args) { - junit.textui.TestRunner.run(suite()); + main(suite(), args); } public static Test suite() { return new TestSuite(TreeSetTest.class); @@ -45,7 +45,7 @@ public class TreeSetTest extends JSR166T private TreeSet populatedSet(int n) { TreeSet q = new TreeSet(); assertTrue(q.isEmpty()); - for (int i = n-1; i >= 0; i -= 2) + for (int i = n - 1; i >= 0; i -= 2) assertTrue(q.add(new Integer(i))); for (int i = (n & 1); i < n; i += 2) assertTrue(q.add(new Integer(i))); @@ -91,8 +91,7 @@ public class TreeSetTest extends JSR166T */ public void testConstructor4() { try { - Integer[] ints = new Integer[SIZE]; - new TreeSet(Arrays.asList(ints)); + new TreeSet(Arrays.asList(new Integer[SIZE])); shouldThrow(); } catch (NullPointerException success) {} } @@ -101,10 +100,10 @@ public class TreeSetTest extends JSR166T * Initializing from Collection with some null elements throws NPE */ public void testConstructor5() { + Integer[] ints = new Integer[SIZE]; + for (int i = 0; i < SIZE - 1; ++i) + ints[i] = new Integer(i); try { - Integer[] ints = new Integer[SIZE]; - for (int i = 0; i < SIZE-1; ++i) - ints[i] = new Integer(i); new TreeSet(Arrays.asList(ints)); shouldThrow(); } catch (NullPointerException success) {} @@ -133,7 +132,7 @@ public class TreeSetTest extends JSR166T for (int i = 0; i < SIZE; ++i) ints[i] = new Integer(i); q.addAll(Arrays.asList(ints)); - for (int i = SIZE-1; i >= 0; --i) + for (int i = SIZE - 1; i >= 0; --i) assertEquals(ints[i], q.pollFirst()); } @@ -157,7 +156,7 @@ public class TreeSetTest extends JSR166T public void testSize() { TreeSet q = populatedSet(SIZE); for (int i = 0; i < SIZE; ++i) { - assertEquals(SIZE-i, q.size()); + assertEquals(SIZE - i, q.size()); q.pollFirst(); } for (int i = 0; i < SIZE; ++i) { @@ -237,7 +236,7 @@ public class TreeSetTest extends JSR166T public void testAddAll3() { TreeSet q = new TreeSet(); Integer[] ints = new Integer[SIZE]; - for (int i = 0; i < SIZE-1; ++i) + for (int i = 0; i < SIZE - 1; ++i) ints[i] = new Integer(i); try { q.addAll(Arrays.asList(ints)); @@ -252,7 +251,7 @@ public class TreeSetTest extends JSR166T Integer[] empty = new Integer[0]; Integer[] ints = new Integer[SIZE]; for (int i = 0; i < SIZE; ++i) - ints[i] = new Integer(SIZE-1-i); + ints[i] = new Integer(SIZE - 1 - i); TreeSet q = new TreeSet(); assertFalse(q.addAll(Arrays.asList(empty))); assertTrue(q.addAll(Arrays.asList(ints))); @@ -276,7 +275,7 @@ public class TreeSetTest extends JSR166T */ public void testPollLast() { TreeSet q = populatedSet(SIZE); - for (int i = SIZE-1; i >= 0; --i) { + for (int i = SIZE - 1; i >= 0; --i) { assertEquals(i, q.pollLast()); } assertNull(q.pollFirst()); @@ -291,14 +290,14 @@ public class TreeSetTest extends JSR166T assertTrue(q.contains(i)); assertTrue(q.remove(i)); assertFalse(q.contains(i)); - assertTrue(q.contains(i-1)); + assertTrue(q.contains(i - 1)); } for (int i = 0; i < SIZE; i += 2) { assertTrue(q.contains(i)); assertTrue(q.remove(i)); assertFalse(q.contains(i)); - assertFalse(q.remove(i+1)); - assertFalse(q.contains(i+1)); + assertFalse(q.remove(i + 1)); + assertFalse(q.contains(i + 1)); } assertTrue(q.isEmpty()); } @@ -357,7 +356,7 @@ public class TreeSetTest extends JSR166T assertTrue(changed); assertTrue(q.containsAll(p)); - assertEquals(SIZE-i, q.size()); + assertEquals(SIZE - i, q.size()); p.pollFirst(); } } @@ -370,7 +369,7 @@ public class TreeSetTest extends JSR166T TreeSet q = populatedSet(SIZE); TreeSet p = populatedSet(i); assertTrue(q.removeAll(p)); - assertEquals(SIZE-i, q.size()); + assertEquals(SIZE - i, q.size()); for (int j = 0; j < i; ++j) { Integer x = (Integer)(p.pollFirst()); assertFalse(q.contains(x)); @@ -696,7 +695,8 @@ public class TreeSetTest extends JSR166T } static NavigableSet newSet(Class cl) throws Exception { - NavigableSet result = (NavigableSet) cl.newInstance(); + NavigableSet result = + (NavigableSet) cl.getConstructor().newInstance(); assertEquals(0, result.size()); assertFalse(result.iterator().hasNext()); return result; @@ -904,18 +904,18 @@ public class TreeSetTest extends JSR166T else if (element > max) return -1; int result = bs.nextSetBit(element); - return result > max ? -1 : result; + return (result > max) ? -1 : result; } int higherAscending(int element) { return ceilingAscending(element + 1); } private int firstAscending() { int result = ceilingAscending(min); - return result > max ? -1 : result; + return (result > max) ? -1 : result; } private int lastAscending() { int result = floorAscending(max); - return result < min ? -1 : result; + return (result < min) ? -1 : result; } } ReferenceSet rs = new ReferenceSet(); @@ -976,7 +976,7 @@ public class TreeSetTest extends JSR166T } static boolean eq(Integer i, int j) { - return i == null ? j == -1 : i == j; + return (i == null) ? j == -1 : i == j; } }