util/Collections/ReverseOrder.java

/*
 * Copyright (c) 2002, 2013, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 only, as
 * published by the Free Software Foundation.
 *
 * This code is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 * version 2 for more details (a copy is included in the LICENSE file that
 * accompanied this code).
 *
 * You should have received a copy of the GNU General Public License version
 * 2 along with this work; if not, write to the Free Software Foundation,
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
 *
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
 * or visit www.oracle.com if you need additional information or have any
 * questions.
 */

/*
 * @test
 * @bug 4593209 8001667
 * @summary Reverse comparator was subtly broken
 * @author Josh Bloch
 */

import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;
import java.util.Arrays;
import java.util.Collections;
import java.util.Comparator;
import java.util.List;

public class ReverseOrder {
    static byte[] serialBytes(Object o) {
        try {
            ByteArrayOutputStream bos = new ByteArrayOutputStream();
            ObjectOutputStream oos = new ObjectOutputStream(bos);
            oos.writeObject(o);
            oos.flush();
            oos.close();
            return bos.toByteArray();
        } catch (Throwable t) {
            throw new Error(t);
        }
    }

    @SuppressWarnings("unchecked")
    static <T> T serialClone(T o) {
        try {
            ObjectInputStream ois = new ObjectInputStream
                (new ByteArrayInputStream(serialBytes(o)));
            T clone = (T) ois.readObject();
            return clone;
        } catch (Throwable t) {
            throw new Error(t);
        }
    }

    public static void main(String[] args) throws Exception {
        Foo[] a = { new Foo(2), new Foo(3), new Foo(1) };
        List list = Arrays.asList(a);
        Comparator cmp = Collections.reverseOrder();
        Collections.sort(list, cmp);

        Foo[] golden = { new Foo(3), new Foo(2), new Foo(1) };
        List goldenList = Arrays.asList(golden);
        if (!list.equals(goldenList))
            throw new Exception(list.toString());

        Comparator clone = serialClone(cmp);
        List list2 = Arrays.asList(a);
        Collections.sort(list2, clone);
        if (!list2.equals(goldenList))
            throw new Exception(list.toString());
    }
}

class Foo implements Comparable {
    int val;
    Foo(int i) { val = i; }

    public int compareTo(Object o) {
        Foo f = (Foo)o;
        return (val < f.val ? Integer.MIN_VALUE : (val == f.val ? 0 : 1));
    }

    public boolean equals(Object o) {
        return o instanceof Foo && ((Foo)o).val == val;
    }

    public int hashCode()    { return val; }

    public String toString() { return Integer.toString(val); }
}
Revision:	1.5
Committed:	Mon Jan 8 03:12:03 2018 UTC (6 years, 4 months ago) by jsr166
Branch:	MAIN
CVS Tags:	HEAD
Changes since 1.4:	+8 -2 lines
Log Message:	organize imports
#	User	Rev	Content
1	jsr166	1.1	/*
2	jsr166	1.4	* Copyright (c) 2002, 2013, Oracle and/or its affiliates. All rights reserved.
3	jsr166	1.1	* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4			*
5			* This code is free software; you can redistribute it and/or modify it
6			* under the terms of the GNU General Public License version 2 only, as
7			* published by the Free Software Foundation.
8			*
9			* This code is distributed in the hope that it will be useful, but WITHOUT
10			* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11			* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12			* version 2 for more details (a copy is included in the LICENSE file that
13			* accompanied this code).
14			*
15			* You should have received a copy of the GNU General Public License version
16			* 2 along with this work; if not, write to the Free Software Foundation,
17			* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18			*
19	jsr166	1.2	* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20			* or visit www.oracle.com if you need additional information or have any
21			* questions.
22	jsr166	1.1	*/
23
24			/*
25			* @test
26	jsr166	1.4	* @bug 4593209 8001667
27	jsr166	1.1	* @summary Reverse comparator was subtly broken
28	jsr166	1.3	* @author Josh Bloch
29	jsr166	1.1	*/
30
31	jsr166	1.5	import java.io.ByteArrayInputStream;
32			import java.io.ByteArrayOutputStream;
33			import java.io.ObjectInputStream;
34			import java.io.ObjectOutputStream;
35			import java.util.Arrays;
36			import java.util.Collections;
37			import java.util.Comparator;
38			import java.util.List;
39	jsr166	1.1
40			public class ReverseOrder {
41	jsr166	1.4	static byte[] serialBytes(Object o) {
42			try {
43			ByteArrayOutputStream bos = new ByteArrayOutputStream();
44			ObjectOutputStream oos = new ObjectOutputStream(bos);
45			oos.writeObject(o);
46			oos.flush();
47			oos.close();
48			return bos.toByteArray();
49			} catch (Throwable t) {
50			throw new Error(t);
51			}
52			}
53
54			@SuppressWarnings("unchecked")
55			static <T> T serialClone(T o) {
56			try {
57			ObjectInputStream ois = new ObjectInputStream
58			(new ByteArrayInputStream(serialBytes(o)));
59			T clone = (T) ois.readObject();
60			return clone;
61			} catch (Throwable t) {
62			throw new Error(t);
63			}
64			}
65
66	jsr166	1.1	public static void main(String[] args) throws Exception {
67			Foo[] a = { new Foo(2), new Foo(3), new Foo(1) };
68			List list = Arrays.asList(a);
69	jsr166	1.4	Comparator cmp = Collections.reverseOrder();
70			Collections.sort(list, cmp);
71	jsr166	1.1
72			Foo[] golden = { new Foo(3), new Foo(2), new Foo(1) };
73			List goldenList = Arrays.asList(golden);
74			if (!list.equals(goldenList))
75			throw new Exception(list.toString());
76	jsr166	1.4
77			Comparator clone = serialClone(cmp);
78			List list2 = Arrays.asList(a);
79			Collections.sort(list2, clone);
80			if (!list2.equals(goldenList))
81			throw new Exception(list.toString());
82	jsr166	1.1	}
83			}
84
85			class Foo implements Comparable {
86			int val;
87			Foo(int i) { val = i; }
88
89			public int compareTo(Object o) {
90			Foo f = (Foo)o;
91			return (val < f.val ? Integer.MIN_VALUE : (val == f.val ? 0 : 1));
92			}
93
94			public boolean equals(Object o) {
95			return o instanceof Foo && ((Foo)o).val == val;
96			}
97
98			public int hashCode() { return val; }
99
100			public String toString() { return Integer.toString(val); }
101			}